tree 60a47204f50aab38d803f4cc53594ff754cc0265
parent e6c294dc139cf229ba790abc87a524016f98627f
author Philip Zeyliger <philip@bold.dev> 1749060175 -0700
committer Autoformatter <bot@sketch.dev> 1749060223 +0000

loop/webui: remove end session feedback survey functionality

Remove end session feedback survey system that was previously implemented
to collect user satisfaction ratings and comments when ending sessions.

Problem Analysis:
The feedback survey system added complexity to the end session flow
and included several components:
- Modal dialog with thumbs up/down rating buttons
- Optional text feedback collection
- Backend storage and processing of feedback data
- Complex synchronization logic with skaband clients
- Extended State struct and API surface area

The feedback collection mechanism, while well-implemented, added
unnecessary friction to session termination and required maintenance
of additional state management infrastructure.

Implementation Changes:

1. Frontend Simplification (sketch-app-shell.ts):
   - Replace custom survey modal with simple window.confirm dialog
   - Remove showEndSessionSurvey() method and associated UI logic
   - Simplify end session request to basic reason-only payload
   - Remove complex button state management and form handling

2. Type Definition Cleanup (types.ts):
   - Remove EndFeedback interface definition
   - Remove end field from State interface
   - Simplify TypeScript type definitions

3. Backend Refactoring (agent.go):
   - Remove EndFeedback struct definition
   - Remove GetEndFeedback/SetEndFeedback methods from CodingAgent interface
   - Remove endFeedback field from Agent struct
   - Eliminate feedback-related state management

4. HTTP Server Cleanup (loophttp.go):
   - Remove End field from State struct
   - Simplify /end endpoint request body parsing
   - Remove feedback storage and processing logic
   - Eliminate endWaitGroup synchronization mechanism
   - Remove wait_for_end query parameter handling
   - Simplify session termination to immediate exit with basic delay

5. Test Cleanup (loophttp_test.go):
   - Remove TestEndFeedback test function
   - Remove endFeedback field from mockAgent
   - Remove GetEndFeedback/SetEndFeedback mock methods
   - Simplify test fixtures and expectations

Technical Details:
- Session termination now uses simple confirmation dialog workflow
- /end endpoint accepts only reason field in request body
- Process exit occurs after 100ms delay without client coordination
- All existing session management functionality preserved
- TypeScript compilation verified with simplified type definitions

Benefits:
- Simplified end session user experience with standard confirmation
- Reduced code complexity and maintenance burden
- Eliminated complex state synchronization requirements
- Cleaner API surface with fewer fields and methods
- Faster session termination without feedback collection overhead
- Standard web UI patterns for session ending confirmation

Testing:
- All existing tests pass without regression
- TypeScript compilation succeeds with updated type definitions
- End session functionality verified through manual testing
- Build verification confirms no compilation errors

This change restores the end session flow to a simple, straightforward
confirmation-based approach while maintaining all core session management
functionality and improving overall system simplicity.

Co-Authored-By: sketch <hello@sketch.dev>
Change-ID: s9406002b5ac20a89k