tree e5096166ffe7ed487def369ac9f2981e745d2edf
parent c898abf9973147658cb90862c071759b0a82259e
author Philip Zeyliger <philip@bold.dev> 1749055378 +0000
committer Philip Zeyliger <philip@bold.dev> 1749055600 +0000

loop: replace sketch-host remote with origin remote in agent.Init()

Change git remote handling in agent initialization to replace any existing
origin remote with the provided git remote URL instead of creating a
sketch-host remote.

Problem Analysis:
Previously, when a git remote URL was provided to the agent, it would:
1. Add a new remote called 'sketch-host' pointing to the provided URL
2. Configure additional fetch refs for feature branches
3. Use 'sketch-host' for all fetch operations

This created confusion and inconsistency since most git workflows expect
to interact with 'origin' as the primary remote, not a custom 'sketch-host'
remote.

Implementation Changes:

1. Git Remote Setup Logic:
   - Remove existing 'origin' remote if it exists (ignoring errors if not present)
   - Add the provided remote URL as the new 'origin' remote
   - Update fetch operations to use 'origin' instead of 'sketch-host'

2. Branch Detection Logic:
   - Updated branchExists() function to remove 'refs/remotes/sketch-host/' reference
   - Now only checks 'refs/heads/' and 'refs/remotes/origin/' for branch existence

3. Comment Updates:
   - Updated git debugging comment in dockerimg/githttp.go to reference 'origin' instead of 'sketch-host'

Technical Details:
- The 'git remote remove origin' command gracefully handles the case where
  origin doesn't exist by logging and continuing
- All existing git operations (fetch, checkout, commit tracking) continue
  to work seamlessly with the origin remote
- branchExists() function correctly identifies branches in origin remotes

Benefits:
- Consistent with standard git workflows that use 'origin' as primary remote
- Eliminates confusion about which remote to use for git operations
- Maintains all existing functionality while using standard git conventions
- Simplifies git operations by using the expected 'origin' remote name
- Better integration with external git tools and workflows

Testing:
- All existing loop package tests continue to pass
- Verified git fetch, config, and branch detection work correctly
- Integration testing confirms seamless operation with origin remote

This change provides a more intuitive and standard git remote configuration
while preserving all agent functionality and improving compatibility with
standard git workflows.

Co-Authored-By: sketch <hello@sketch.dev>
Change-ID: s9edcdfe5bae3ef4ek