tree d52cec3d8a26fe8f6f0883008aaef86b425e55cb
parent 289525bcecca82247e0908c5ff1f213213d9c9a4
author Josh Bleecher Snyder <josharian@gmail.com> 1751947948 +0000
committer Josh Bleecher Snyder <josharian@gmail.com> 1751948074 -0700

sketch/loop: remove flaky TestPortMonitor_IntegrationDemo test

Delete the integration test that was still flaky despite previous fixes.

Root Cause:
- Test suffered from inherent race condition with system-wide port resources
- After closing test ports, other processes could immediately bind to same port numbers
- Race condition window existed between port closure and PortMonitor detection
- Cannot be made truly hermetic because port numbers are OS-managed system resources

Test Coverage Analysis:
- Integration test added minimal unique value over existing unit tests
- Agent.pushToOutbox already tested in agent_test.go
- Port detection logic thoroughly tested in port_monitor_test.go
- TCP filtering, sorting, added/removed detection all covered by unit tests
- Core functionality has excellent test coverage without the integration test

The Fix:
- Remove the flaky integration test entirely
- Preserve all existing unit tests which provide reliable coverage
- Eliminate CI/CD reliability issues caused by environmental dependencies
- Remove maintenance burden of debugging false test failures

This removes the flaky test while maintaining comprehensive test coverage
through the existing unit test suite.

Co-Authored-By: sketch <hello@sketch.dev>
Change-ID: s8bd05f43558fc5c4k