tree 0fa126370bdc31193834bd00b2d0ed36b952b82b
parent 7fe76973f6cba7c7a51f4b896444c2ce3c1ce0d5
author banksean <banksean@gmail.com> 1753325094 +0000
committer banksean <banksean@gmail.com> 1753325494 +0000

webui: fix IDLE/DISCONNECTED oscillation by replacing initialLoadComplete misuse

Fix DataManager session_ended handler that caused rapid status switching
between IDLE and DISCONNECTED when sessions ended.

Issue Description:
When a session ended, the UI's sketch-call-status component would rapidly
oscillate between IDLE and DISCONNECTED states, suggesting continued
connection attempts despite the session being over.

Root Cause Analysis:
The primary issue was session_ended handler improperly firing initialLoadComplete
event, confusing timeline component state management. The initialLoadComplete event
was added for newsessions functionality but broke assumptions in regular sketch
sessions. The timeline component expects initialLoadComplete to signal new page
loads, not ended sessions.

When fired for ended sessions, this caused UI re-render cycles and state confusion
that interfered with connection status display, creating the oscillation effect.

Implementation Changes:
- Added sessionDataReady event type for ended session data readiness
- Modified session_ended handler to emit sessionDataReady instead of
  initialLoadComplete for ended sessions
- Preserved initialLoadComplete semantics for active session data loading
- Added clarifying comment to existing isSessionEnded guard in connect()

Security & Compatibility:
- No security implications, purely UI state management fix
- Newsessions component unaffected (doesn't use initialLoadComplete)
- Timeline component behavior restored to expected state
- All existing event handling preserved

This fix eliminates the connection status oscillation while maintaining
proper separation of concerns between live session loading and ended
session display states.

Co-Authored-By: sketch <hello@sketch.dev>
Change-ID: scd1b437c8ae7c381k