commit 7de3bdd597e962ab2533f67018545c6fd2a33d16
author Josh Bleecher Snyder <josharian@gmail.com> Fri Jul 18 01:51:53 2025 +0000
committer Josh Bleecher Snyder <josharian@gmail.com> Thu Jul 17 19:13:58 2025 -0700
tree 5c3116b9e2fc88f47f820014a1ce071d104b1773
parent ebe74cdcc911d70afd804b6218bab25744513578

webui: hide GitHub link in push dialog for non-GitHub remotes

Only show "Open on GitHub" button when pushing to GitHub remotes.
The dialog now checks the remote's is_github property before generating
a branch URL, returning empty string for non-GitHub remotes.

Changes:
- Modified _computeBranchURL() to check selectedRemote.is_github
- Added test coverage for GitHub, GitLab, and self-hosted remotes
- Updated demo mock to include non-GitHub remotes for testing

This prevents the confusing "Open on GitHub" button from appearing
when pushing to GitLab, self-hosted Git servers, or other non-GitHub
remote repositories.

Co-Authored-By: sketch <hello@sketch.dev>
Change-ID: sb441bfcebf8fea07k

webui/src/web-components/demo/mock-git-data-service.ts

diff --git a/webui/src/web-components/demo/mock-git-data-service.ts b/webui/src/web-components/demo/mock-git-data-service.ts
index 92fae9e..b643e50 100644
--- a/webui/src/web-components/demo/mock-git-data-service.ts
+++ b/webui/src/web-components/demo/mock-git-data-service.ts
@@ -600,10 +600,16 @@
               is_github: true,
             },
             {
-              name: "upstream",
-              url: "https://github.com/anotheruser/bold.git",
-              display_name: "anotheruser/bold",
-              is_github: true,
+              name: "gitlab",
+              url: "https://gitlab.com/testuser/bold.git",
+              display_name: "gitlab.com/testuser/bold",
+              is_github: false,
+            },
+            {
+              name: "selfhosted",
+              url: "https://git.company.com/team/bold.git",
+              display_name: "git.company.com/team/bold",
+              is_github: false,
             },
           ],
         }),