tree 9ced21ca57a202fc44456c7cbd53a8a113435c51
parent c7a98d8360cf03f977625a65e8dd637d6b2ab18b
author Josh Bleecher Snyder <josharian@gmail.com> 1751946279 +0000
committer Josh Bleecher Snyder <josharian@gmail.com> 1751947598 -0700

sketch/loop: fix flaky TestPortMonitor_IntegrationDemo test

Remove assumptions about system-wide port state that made the test flaky.

Root Cause:
- Test assumed it was the only process creating/destroying ports
- Made brittle assertions about total port counts before/after test servers
- Failed when other processes (tests, services, containers) modified ports

The Fix:
- Focus only on the specific test ports created by the test
- Use polling with timeout to detect port creation/removal
- Remove assertions about total port counts
- Test only verifies its own test ports are detected and removed

Changes:
- Replace fixed sleeps with polling loops with timeouts
- Remove port count comparisons that depended on system state
- Keep track of test ports separately from system port scanning
- Add proper timeout handling to prevent hanging tests

Test Results:
- Before: Flaky failures when other processes modified ports
- After: 5 consecutive runs all passed, focusing only on test-specific behavior

This preserves the test's usefulness as an integration test while making it
deterministic and isolated from system-wide port changes.

Co-Authored-By: sketch <hello@sketch.dev>
Change-ID: s58312d8275959960k