Using GH actions provided Chrome for test speedup (#149)
OMG. This had wild behavior. Sometimes you'd log into tmate, and it
would work. Something about running Chrome manually would tickle some
dbus thing into working. The error would sometimes show up, but most
often it would be swallowed.
The punchline? We had a context timeout of 5 or 10 seconds in the tests
that would trigger silently, and we'd see nothing. Everything else
(including maybe the dbus stuff) was a red herring: the test executor
machine is swamped, and shit's slow, and the various timeouts needed
tweaking. I bet there are a few more timeouts to loosen eventually, but
it seems to be passing now.
Error message:
failed to start browser (please apt get chromium or equivalent): chrome failed to start:
diff --git a/.github/workflows/go_test.yml b/.github/workflows/go_test.yml
index e10dbb3..95049cd 100644
--- a/.github/workflows/go_test.yml
+++ b/.github/workflows/go_test.yml
@@ -44,9 +44,20 @@
go install mvdan.cc/gofumpt@latest
go install golang.org/x/tools/cmd/goimports@latest
# Empirically (by logging into runners with tmate), there are versions of Chromium/Chrome in /opt/google/chrome
- # and /usr/local/share/chromium/chrome-linux. However, adding them to the PATH
- # hasn't worked yet. I don't know why.
- sudo apt-get update && sudo apt-get -y install chromium
+ # and /usr/local/share/chromium/chrome-linux, and /usr/bin/chromium links to the former. Therefore, we
+ # don't need to apt-get it separately.
+
+ # If you wish to do some interactive debugging, the following is handy. It will print
+ # an SSH command that you can use to connect to the runner instance.
+ - name: tmate debugging (disabled)
+ if: false
+ run: |
+ sudo apt-get update && sudo apt-get install -y tmate
+ set -x
+ tmate -S /tmp/tmate.sock.${GITHUB_RUN_ID} new-session -d
+ tmate -S /tmp/tmate.sock.${GITHUB_RUN_ID} wait tmate-ready
+ tmate -S /tmp/tmate.sock.${GITHUB_RUN_ID} display -p '#{tmate_ssh}'
+ sleep 1800
- name: Go generate
run: |