tree df1b7548a47fa1e4f219bcd8a27e5fadaa0acc3c
parent 83c5be6f73607c6add6d5c389f7894e1d7b5e06a
author Sean McCullough <banksean@gmail.com> 1749784878 +0000
committer Autoformatter <bot@sketch.dev> 1749786498 +0000

webui: fix repository name parsing for names containing dots

Fix GitHub repository URL parsing in sketch-container-status component to
properly handle repository names containing dots, resolving broken GitHub
links in the ongoing session log banner.

Problem Analysis:
The formatGitHubRepo function used regex patterns with [^/\s.]+ character
classes that excluded dots from repository names. This caused repository names
like 'boldsoftware/sketch.git' to be truncated to 'boldsoftware/sketch' when
parsed, breaking GitHub links and repository display in the session banner.

The issue occurred in three regex patterns for different GitHub URL formats:
- HTTPS URLs: /https:\/\/github\.com\/([^/]+)\/([^/\s.]+)(?:\.git)?/
- SSH URLs: /git@github\.com:([^/]+)\/([^/\s.]+)(?:\.git)?/
- Git protocol: /git:\/\/github\.com\/([^/]+)\/([^/\s.]+)(?:\.git)?/

The [^/\s.]+ pattern specifically excluded dots (.) from matching, which was
problematic for legitimate repository names containing dots.

Implementation Changes:

1. Regex Pattern Updates:
   - Changed [^/\s.]+ to [^/\s]+? in all three URL patterns
   - Removed dot exclusion while maintaining whitespace and slash exclusion
   - Added non-greedy quantifier (?) to prevent over-matching
   - Added end-of-string anchor ($) for precise matching

2. Updated patterns:
   - HTTPS: /https:\/\/github\.com\/([^/]+)\/([^/\s]+?)(?:\.git)?$/
   - SSH: /git@github\.com:([^/]+)\/([^/\s]+?)(?:\.git)?$/
   - Git: /git:\/\/github\.com\/([^/]+)\/([^/\s]+?)(?:\.git)?$/

Technical Details:
- Non-greedy matching (+?) ensures proper handling of .git suffix
- End anchors ($) prevent partial matches and improve precision
- Dots now allowed in repository names while preserving .git detection
- Existing functionality preserved for repositories without dots

Testing:
Verified fix with comprehensive test cases:
- git@github.com:boldsoftware/sketch.git → boldsoftware/sketch ✓
- https://github.com/user/repo.with.dots.git → user/repo.with.dots ✓
- git@github.com:org/project.name.git → org/project.name ✓
- https://github.com/test/normal-repo → test/normal-repo ✓

Benefits:
- GitHub links now work correctly for repositories with dots in names
- Session banner displays proper repository information
- Maintains backward compatibility with existing repository names
- Improves user experience for repository navigation

This fix resolves the specific issue where repository names containing dots
would have their GitHub links truncated, breaking navigation to the actual
repository on GitHub.

Co-Authored-By: sketch <hello@sketch.dev>
Change-ID: sda0a251af3d756b6k

webui: improve GitHub repo parsing tests

Replace internal method testing with component behavior testing for better
integration coverage and maintainability.

- Test actual GitHub link rendering in DOM instead of calling private methods
- Add separate test cases for repository names with dots
- Verify href attributes, text content, and title attributes are correct
- Cover both general dot-containing names and the specific boldsoftware/sketch case

Co-Authored-By: sketch <hello@sketch.dev>
Change-ID: s216977b6be91a2bak