tree 8d245ab695e991337b7c11cdef23d280d10df466
parent 5c654f6e66db881f17e202ec60cf7c997f7c0bad
author Jon Friesen <jon@jonfriesen.ca> 1749129356 +0000
committer Josh Bleecher Snyder <josharian@gmail.com> 1749176987 -0700

dockerimg: prioritize Dockerfile.sketch over Dockerfile

Implement prioritization system for Dockerfile discovery that prefers
Dockerfile.sketch when available, falling back to standard Dockerfile
behavior when not present.

Problem Analysis:
The existing code had a TODO comment requesting preference for
'Dockerfile.sketch' to allow users to tailor environments specifically
for Sketch usage. The current logic only handled single Dockerfile
scenarios or fell back to generated dockerfiles, missing the
opportunity to prioritize sketch-specific configurations.

Implementation Changes:

1. Prioritization Function:
   - Added prioritizeDockerfiles() function with clear priority order
   - Priority: Dockerfile.sketch > Dockerfile > other Dockerfile.*
   - Case-insensitive matching for broader compatibility
   - Returns first candidate when no priority matches

2. Discovery Logic Update:
   - Modified findOrBuildDockerImage() to use prioritization
   - Removed single-dockerfile restriction for better flexibility
   - Uses prioritizeDockerfiles() for any number of candidates
   - Maintains existing behavior for generated dockerfile fallback

3. User Experience Enhancement:
   - Clear console output showing which dockerfile is being used
   - Consistent behavior regardless of dockerfile count
   - Preserves all existing functionality and error handling

Technical Details:
- Maintains backward compatibility with existing Dockerfile usage
- No changes to function signatures or public interfaces
- Efficient O(n) prioritization with early returns
- Proper filepath handling for cross-platform compatibility

Benefits:
- Users can create Dockerfile.sketch for sketch-specific environments
- Automatic preference without requiring configuration changes
- Maintains existing Dockerfile support as fallback
- Clear, predictable behavior for dockerfile selection

Testing:
- Added comprehensive unit tests for prioritizeDockerfiles()
- Integration tests verify findDirDockerfiles() compatibility
- End-to-end tests confirm findRepoDockerfiles() behavior
- All existing tests continue to pass without modification

This enhancement enables users to create sketch-optimized Docker
environments while preserving full backward compatibility with
existing Dockerfile workflows.

Co-Authored-By: sketch <hello@sketch.dev>
Change-ID: s1d7f47401929e175k