commit dbfd36a4149c03a501be12aacfecdbe237c7b7bf
author Josh Bleecher Snyder <josharian@gmail.com> Fri May 23 20:57:50 2025 +0000
committer Josh Bleecher Snyder <josharian@gmail.com> Fri May 23 14:25:55 2025 -0700
tree c8928ebe5568b7c5330f9211538ab8139832652f
parent afeafea91f20db4e5b99620df98baa1628bfeaf1

claudetool/bashkit: add validation to reject blind git add commands

Implements new validation function to prevent bash commands that blindly
add all files to git commits, requiring agents to specify files explicitly.

Changes include:

1. New noBlindGitAdd validation function that rejects:
   - git add -A (add all)
   - git add --all (add all)
   - git add . (add current directory)
   - git add * (add all files via glob)

2. Enhanced hasBlindGitAdd helper function:
   - Parses git command structure using existing AST approach
   - Finds 'add' subcommand and checks subsequent arguments
   - Handles git flags before 'add' subcommand correctly
   - Allows legitimate specific file additions like 'git add main.go'

3. Comprehensive test coverage for all blind add patterns:
   - Tests rejection of all blind patterns including flags combinations
   - Tests acceptance of specific file additions and valid use cases
   - Tests multiline scripts and edge cases like filenames that look
     like flags (e.g., 'file.A')

4. Integration with existing validation framework:
   - Added noBlindGitAdd to the checks slice alongside existing
     noGitConfigUsernameEmailChanges validation
   - Uses same error reporting pattern and AST parsing infrastructure

This prevents agents from accidentally committing unintended files or
build artifacts by forcing explicit file specification in git add
commands. The validation maintains the existing pattern of being
mistake-prevention rather than security-focused.

Error message provides clear guidance: 'blind git add commands (git add -A,
git add ., git add --all, git add *) are not allowed, specify files explicitly'

Co-Authored-By: sketch <hello@sketch.dev>
Change-ID: s4d8fe71ef5816b36k