| commit | e2954ce9c186576151b5e0da05de1b37bb99afea | [log] [tgz] |
|---|---|---|
| author | David Crawshaw <david@zentus.com> | Sun Jun 15 00:06:34 2025 +0000 |
| committer | David Crawshaw <david@zentus.com> | Sat Jun 14 17:12:58 2025 -0700 |
| tree | ef54edfec55171ff3faf8428e0f0e274b49e1ea5 | |
| parent | dbca8975c4616c02f284359fed07d4a2c1477301 [diff] |
webui: fix diff view scrollbar visibility and resize handling
Fix Monaco editor scrollbar display issues and improve browser window resize
responsiveness in the diff view, providing a cleaner interface and better
user experience across different screen sizes.
Problem Analysis:
The diff view had two significant issues affecting usability:
1. Monaco Scrollbar Visibility: Despite setting scrollbar configuration to
'hidden', a large gray scrollbar remained visible on the right side of
the Monaco diff editor. This was caused by insufficient CSS targeting
of Monaco's complex DOM structure and scrollbar element hierarchy.
2. Resize Handling: The diff view did not properly adapt when users resized
their browser window. While the editor had automaticLayout: false and
manual sizing, there was no window resize listener to trigger layout
recalculation, causing the editor to maintain its original dimensions.
3. Refresh Button Layout: At certain screen widths, the refresh button would
wrap to its own line prematurely due to inflexible sizing constraints.
Implementation Changes:
1. Monaco Scrollbar Removal (sketch-diff2-view.ts):
- Added comprehensive global CSS rules targeting all Monaco scrollbar elements
- Targeted .monaco-editor, .monaco-diff-editor, and .monaco-scrollable-element
- Applied multiple hiding techniques: display: none, visibility: hidden,
width/height: 0, opacity: 0 for maximum coverage
- Added padding/margin removal to prevent scrollbar space reservation
- Ensured diff content takes full width without scrollbar spacing
2. Window Resize Handler (sketch-monaco-view.ts):
- Added setupWindowResizeHandler() method with debounced resize logic
- Implemented 100ms debounce to prevent excessive layout calls
- Added window 'resize' event listener that triggers fitEditorToContent()
- Fallback layout call with current container dimensions if fit function unavailable
- Proper cleanup in disconnectedCallback() to prevent memory leaks
3. Layout Improvements (sketch-diff2-view.ts):
- Set minimum width (400px) for sketch-diff-range-picker component
- Added minimum width (120px) for file-count display
- Ensured flex layout provides adequate space for all controls
- Improved responsive behavior at various screen widths
4. Enhanced Scrollbar Configuration (sketch-monaco-view.ts):
- Extended scrollbar options with additional Monaco-specific settings:
- useShadows: false to disable scrollbar shadows
- verticalHasArrows: false / horizontalHasArrows: false to remove arrows
- verticalScrollbarSize: 0 / horizontalScrollbarSize: 0 for zero track size
- Combined configuration-based and CSS-based hiding for complete coverage
Technical Details:
- Global CSS injection occurs once per diff view instance in constructor
- Window resize handler uses setTimeout debouncing to avoid performance issues
- Monaco editor layout() called with explicit dimensions during resize
- CSS targeting covers all known Monaco scrollbar element patterns
- Minimum width constraints prevent layout collapse at small screen sizes
- Cleanup handlers prevent memory leaks when components are destroyed
Benefits:
- Clean, professional diff view appearance without distracting scrollbars
- Smooth responsive behavior when browser window is resized
- Improved layout stability for controls at various screen widths
- Better user experience across desktop and mobile viewport sizes
- Maintained full Monaco editor functionality (editing, syntax highlighting, etc.)
Testing:
- Verified scrollbar completely hidden at all screen sizes
- Tested resize responsiveness from 600px to 1400px+ widths
- Confirmed smooth transitions during window resize operations
- Validated refresh button layout behavior at different breakpoints
- Ensured Monaco editor features remain fully functional
- Tested both horizontal and vertical window resize scenarios
This implementation provides a polished, responsive diff view experience
that properly adapts to user browser configurations while maintaining
all advanced Monaco editor capabilities.
Co-Authored-By: sketch <hello@sketch.dev>
Change-ID: sf19d359b4fcbcbdek
Sketch is an agentic coding tool. It draws the 🦉
Sketch runs in your terminal, has a web UI, understands your code, and helps you get work done. To keep your environment pristine, sketch starts a docker container and outputs its work onto a branch in your host git repository.
Sketch helps with most programming environments, but Sketch has extra goodies for Go.
go install sketch.dev/cmd/sketch@latest sketch
Currently, Sketch runs on macOS and Linux. It uses Docker for containers.
| Platform | Installation |
|---|---|
| macOS | brew install colima (or Docker Desktop/Orbstack) |
| Linux | apt install docker.io (or equivalent for your distro) |
| WSL2 | Install Docker Desktop for Windows (docker entirely inside WSL2 is tricky) |
The sketch.dev service is used to provide access to an LLM service and give you a way to access the web UI from anywhere.
Start Sketch by running sketch in a Git repository. It will open your browser to the Sketch chat interface, but you can also use the CLI interface. Use -open=false if you want to use just the CLI interface.
Ask Sketch about your codebase or ask it to implement a feature. It may take a little while for Sketch to do its work, so hit the bell (🔔) icon to enable browser notifications. We won't spam you or anything; it will notify you when the Sketch agent's turn is done, and there's something to look at.
When you start Sketch, it:
This design lets you run multiple sketches in parallel since they each have their own sandbox. It also lets Sketch work without worry: it can trash its own container, but it can't trash your machine.
Sketch's agentic loop uses tool calls (mostly shell commands, but also a handful of other important tools) to allow the LLM to interact with your codebase.
Sketch is trained to make Git commits. When those happen, they are automatically pushed to the git repository where you started sketch with branch names sketch/*.
Finding Sketch branches:
git branch -a --sort=creatordate | grep sketch/ | tail
The UI keeps track of the latest branch it pushed and displays it prominently. You can use standard Git workflows to pull those branches into your workspace:
git cherry-pick $(git merge-base origin/main sketch/foo)
or merge the branch
git merge sketch/foo
or reset to the branch
git reset --hard sketch/foo
Ie use the same workflows you would if you were pulling in a friend's Pull Request.
Advanced: You can ask Sketch to git fetch sketch-host and rebase onto another commit. This will also fetch where you started Sketch, and we do a bit of "git fetch refspec configuration" to make origin/main work as a git reference.
Don't be afraid of asking Sketch to help you rebase, merge/squash commits, rewrite commit messages, and so forth; it's good at it!
The diff view shows you changes since Sketch started. Leaving comments on lines adds them to the chat box, and, when you hit Send (at the bottom of the page), Sketch goes to work addressing your comments.
You can interact directly with the container in three ways:
ssh sketch-ilik-eske-tcha-lott. We have automatically configured your SSH configuration to make these special hostnames work.Using SSH (and/or VSCode) allows you to forward ports from the container to your machine. For example, if you want to start your development webserver, you can do something like this:
# Forward container port 8888 to local port 8000 ssh -L8000:localhost:8888 sketch-ilik-epor-tfor-ward go run ./cmd/server
This makes http://localhost:8000/ on your machine point to localhost:8888 inside the container.
You can ask Sketch to browse a web page and take screenshots. There are tools both for taking screenshots and "reading images", the latter of which sends the image to the LLM. This functionality is handy if you're working on a web page and want to see what the in-progress change looks like.
Docker images, containers, and so forth tend to pile up. Ask Docker to prune unused images and containers:
docker system prune -a
See CONTRIBUTING.md for development guidelines.
Sketch is open source. It is right here in this repository! Have a look around and mod away.
If you want to run Sketch entirely without the sketch.dev service, you can set the flag -skaband-addr="" and then provide an ANTHROPIC_API_KEY environment variable. (More LLM services coming soon!)