claudetool/codereview: stop checking string iteration patterns
Even frontier LLMs get confused by these recent language improvements.
I'm sick of fighting them (i.e. watching them fight themselves).
We'll just have to wait for them to either get more capable,
or to learn the new idioms. Sigh.
diff --git a/claudetool/codereview/llm_codereview_prompt.txt b/claudetool/codereview/llm_codereview_prompt.txt
index 920fc9f..321b812 100644
--- a/claudetool/codereview/llm_codereview_prompt.txt
+++ b/claudetool/codereview/llm_codereview_prompt.txt
@@ -69,108 +69,6 @@
</examples>
</issue>
-<issue>
-<name>String Iteration Patterns (Go 1.24+)</name>
-<description>
-Newly added code that iterates over lines in a string using traditional patterns like strings.Split or bufio.Scanner when strings.Lines could be used instead. Also covers other string splitting patterns where strings.SplitSeq would be more efficient.
-</description>
-
-<identification_criteria>
-For newline iteration patterns:
-- strings.Split with newline separator followed by iteration
-- bufio.Scanner with ScanLines split (explicit or implicit)
-- Any other pattern that processes lines one by one
-
-For general string splitting patterns:
-- strings.Split with non-newline separators
-</identification_criteria>
-<scope>ONLY newly added code in the diff. Do not flag existing code.</scope>
-<examples>
-<example_input flag="true">
-+ lines := strings.Split(s, "\n")
-+ for _, line := range lines {
-+ // process line
-+ }
-</example_input>
-<example_output>
-Line iteration pattern using strings.Split with iteration can be improved.
-
-Use strings.Lines instead:
-```go
-for line := range strings.Lines(s) {
- // process line
-}
-```
-
-Important: strings.Lines preserves terminating newlines and handles empty strings correctly. The yielded lines include their terminating newlines unless the input doesn't end with one.
-
-File: filepath/filename.ext
-Line: + lines := strings.Split(s, "\n")
- + for _, line := range lines {
- + // process line
- + }
-</example_output>
-<example_input flag="true">
-+ scanner := bufio.NewScanner(strings.NewReader(text))
-+ for scanner.Scan() {
-+ line := scanner.Text()
-+ // process line
-+ }
-</example_input>
-<example_output>
-Line iteration using bufio.Scanner with ScanLines can be simplified.
-
-Use strings.Lines instead:
-```go
-for line := range strings.Lines(text) {
- // process line
-}
-```
-
-Important: strings.Lines preserves terminating newlines and handles empty strings correctly. The yielded lines include their terminating newlines unless the input doesn't end with one.
-
-File: filepath/filename.ext
-Line: + scanner := bufio.NewScanner(strings.NewReader(text))
- + scanner.Split(bufio.ScanLines)
- + for scanner.Scan() {
- + line := scanner.Text()
- + // process line
- + }
-</example_output>
-<example_input flag="true">
-+ parts := strings.Split(data, ",")
-+ for _, part := range parts {
-+ // process part
-+ }
-</example_input>
-<example_output>
-String splitting with iteration can be more efficient.
-
-Use strings.SplitSeq instead:
-```go
-for part := range strings.SplitSeq(data, ",") {
- // process part
-}
-```
-
-Important: strings.SplitSeq creates an iterator without constructing the full slice, improving memory efficiency for large strings.
-
-File: filepath/filename.ext
-Line: + parts := strings.Split(data, ",")
- + for _, part := range parts {
- + // process part
- + }
-</example_output>
-<example_input flag="false">
-- lines := strings.Split(s, "\n")
-- for _, line := range lines {
-- // process line
-- }
-</example_input>
-<example_output>
-</example_output>
-</examples>
-</issue>
</issues>
Output format: