)]}' { "log": [ { "commit": "4201bde20034516105d17deca502c6e76e7db603", "tree": "7c39dbc55cfc88e3aa2f6866f5400c7790fd7fb6", "parents": [ "cad67b0ac0e374dd687ca4ef8abddbc9c4323fd5" ], "author": { "name": "Philip Zeyliger", "email": "philip@bold.dev", "time": "Fri Jun 27 17:22:43 2025 -0700" }, "committer": { "name": "Philip Zeyliger", "email": "philip@bold.dev", "time": "Fri Jun 27 17:22:43 2025 -0700" }, "message": "Replace skaband tools with a sketch.dev MCP client\n\nsketch.dev provides seeing recent sessions and reading a past\nsession as tool.\n" }, { "commit": "cad67b0ac0e374dd687ca4ef8abddbc9c4323fd5", "tree": "44b66d28b1be62eb47b3cc26fd228c7031704922", "parents": [ "cebb03c0513e98e1861efe787ac1577c614e2e52" ], "author": { "name": "banksean", "email": "banksean@gmail.com", "time": "Fri Jun 27 21:57:05 2025 +0000" }, "committer": { "name": "Autoformatter", "email": "bot@sketch.dev", "time": "Fri Jun 27 22:21:38 2025 +0000" }, "message": "sketch: add git username attribution for user messages in timeline\n\nImplement comprehensive user attribution system displaying git username below user message bubbles in both active sketch sessions and archived skaband message views, with full test coverage.\n\nProblems Solved:\n\nMissing User Attribution:\n- User messages in timeline lacked visible attribution for identification\n- No way to distinguish which user sent messages in shared or review contexts\n- Timeline display provided no user context beyond message type differentiation\n- Archived messages on skaband /messages/\u003csession-id\u003e page had no user attribution\n\nInconsistent Attribution Between Views:\n- Active sketch sessions and archived skaband views used different component systems\n- Messages-viewer component wasn\u0027t setting state property for timeline attribution\n- Git username information wasn\u0027t being extracted from session data in skaband\n- Version skew between sketch and skaband frontend components\n\nSolution Implementation:\n\nBackend State Management:\n- Added GitUsername() method to Agent struct returning config.GitUsername\n- Extended CodingAgent interface to include GitUsername() method\n- Added git_username field to State struct in loophttp.go\n- Populated git_username in getState() method from agent.GitUsername()\n- Enhanced skaband SessionWithData with UserName field for git username storage\n- Updated session JSON parsing to extract git_username into UserName field\n\nFrontend Timeline Component:\n- Added user attribution display outside and below user message bubbles\n- Right-edge alignment of username with message bubble edge\n- Clean visual separation between message content and attribution metadata\n- Conditional rendering only for user message types with available git_username\n- Responsive design handling both normal and compact display modes\n\nSkaband Integration:\n- Modified messages-viewer.ts to create proper State object for timeline component\n- Added git_username population with fallback hierarchy for backward compatibility\n- Enhanced session JSON parsing to extract git_username into UserName field\n- Updated all session data retrieval functions in skaband database layer\n- Ensured consistent attribution across active and archived message views\n\nVisual Design:\n- Username displays in 11px italic font below message content\n- Right-aligned to match user message bubble alignment\n- Color: #666 for clear contrast and subtle attribution appearance\n- 4px top margin for appropriate spacing from message bubble\n- CSS classes: .user-name-container and .user-name for styling\n\nImplementation Details:\n\nState Management Architecture:\n- Active sessions: Agent config → State object → timeline component\n- Archived sessions: Session JSON → SessionWithData.UserName → State object → timeline component\n- Consistent data flow ensuring attribution works in both contexts\n- Three-tier fallback: session_state.git_username → user_name → undefined\n\nData Extraction Pipeline:\n- Session JSON parsing extracts git_username using same pattern as user_email\n- Database layer updates in GetAllSessionStateData, SearchSessionsByMessageContentPaginated, GetSessionStateDataWithFilters\n- Graceful degradation for older sessions without git username data\n- No breaking changes to existing data structures or APIs\n\nComponent Integration:\n- Timeline component state property receives comprehensive git-related fields\n- Messages-viewer creates state object matching active session behavior\n- No breaking changes to existing component interfaces or data structures\n- Clean separation between message content and user attribution\n\nBackward Compatibility:\n- Older sessions without git_username gracefully show no attribution\n- New sessions have complete attribution data in both views\n- No impact on existing message display or functionality\n- Optional field design maintains compatibility with existing code\n\nTesting and Validation:\n\nComprehensive Test Coverage:\n- Created messages-viewer.test.ts with 8 test scenarios covering state creation logic\n- Added git username attribution tests to sketch-timeline-message.test.ts\n- Tested fallback hierarchy: session_state.git_username → user_name → undefined\n- Verified message filtering, data handling, and edge cases\n- All messages-viewer tests passing (8/8)\n\nTest Environment Compatibility:\n- Resolved TypeScript decorator configuration issues in test environment\n- Implemented workarounds for Lit component testing constraints\n- Fixed mock data factory functions to properly handle undefined values\n- Maintained comprehensive test coverage despite environment limitations\n\nFunctional Validation:\n- Created visual mockups confirming correct alignment and positioning\n- Verified state object creation with proper git_username extraction\n- Confirmed visual positioning and alignment requirements\n- Validated TypeScript compilation and Go build compatibility\n- Manual testing confirms runtime functionality works correctly\n\nFiles Modified:\n- sketch/loop/agent.go: Added GitUsername() method to interface and implementation\n- sketch/loop/server/loophttp.go: Added git_username to State struct and population\n- sketch/webui/src/types.ts: Added git_username field to State interface\n- sketch/webui/src/web-components/sketch-timeline-message.ts: User attribution display and positioning\n- sketch/webui/src/messages-viewer.ts: State object creation for timeline component\n- skaband/skadb/skadb.go: UserName field and git username extraction from session JSON\n- sketch/webui/src/messages-viewer.test.ts: Comprehensive test coverage for state creation\n- sketch/webui/src/web-components/sketch-timeline-message.test.ts: Timeline component tests\n\nThe implementation provides consistent user attribution across all message viewing contexts while maintaining clean visual design, full backward compatibility, and comprehensive test coverage.\n\nCo-Authored-By: sketch \u003chello@sketch.dev\u003e\nChange-ID: seb68c9ba94cdcc5bk\n" }, { "commit": "cebb03c0513e98e1861efe787ac1577c614e2e52", "tree": "a219d281aa31e06be6a99849f05a8a84dcc19ea0", "parents": [ "297327174d1d13cf185cf781c19813f2a05ca809" ], "author": { "name": "philip.zeyliger", "email": "philip.zeyliger@gmail.com", "time": "Fri Jun 27 13:24:38 2025 -0700" }, "committer": { "name": "Philip Zeyliger", "email": "philip@bold.dev", "time": "Fri Jun 27 13:24:38 2025 -0700" }, "message": "Add cmd/mcp-tool command for testing MCP servers\n\nCreates sketch/cmd/mcp-tool with discover and call subcommands to manually\ntest MCP servers using the same mcp-go library as Sketch.\n\nExample calls tested with Context7 MCP servers:\n\nmcp-tool discover -mcp \u0027{\"name\": \"context7\", \"type\": \"http\", \"url\": \"https://mcp.context7.com/mcp\"}\u0027\n\nmcp-tool discover -mcp \u0027{\"name\": \"context7-stdio\", \"type\": \"stdio\", \"command\": \"npx\", \"args\": [\"-y\", \"@upstash/context7-mcp\"]}\u0027\n\nmcp-tool call -mcp \u0027{\"name\": \"context7-sse\", \"type\": \"sse\", \"url\": \"https://mcp.context7.com/sse\"}\u0027 resolve-library-id \u0027{\"libraryName\": \"react\"}\u0027\n\nmcp-tool call -mcp \u0027{\"name\": \"context7\", \"type\": \"http\", \"url\": \"https://mcp.context7.com/mcp\"}\u0027 get-library-docs \u0027{\"context7CompatibleLibraryID\": \"/reactjs/react.dev\", \"tokens\": 1000, \"topic\": \"hooks\"}\u0027\n\nCo-Authored-By: sketch \u003chello@sketch.dev\u003e\nChange-ID: s3c5c4cca2cf302d5k\n" }, { "commit": "297327174d1d13cf185cf781c19813f2a05ca809", "tree": "17e91a7f31ea3bb23ebb9282e6f682813278ed46", "parents": [ "4ce9dca335692e6aeff59c57f9a91b6ee19756ed" ], "author": { "name": "Philip Zeyliger", "email": "philip@bold.dev", "time": "Fri Jun 27 09:57:12 2025 -0700" }, "committer": { "name": "Philip Zeyliger", "email": "philip@bold.dev", "time": "Fri Jun 27 09:57:41 2025 -0700" }, "message": "Pin \u0027npx prettier\u0027 version\n\nIf you don\u0027t do this, you get cruft from various autofixers competing.\n" }, { "commit": "4ce9dca335692e6aeff59c57f9a91b6ee19756ed", "tree": "31c96d7356304b3739b2225422cb1a4c1b66ee53", "parents": [ "9aa141a4bdde68a1ad57d56ba3cb0023109c6b7b" ], "author": { "name": "Philip Zeyliger", "email": "philip@bold.dev", "time": "Fri Jun 27 09:46:42 2025 -0700" }, "committer": { "name": "Philip Zeyliger", "email": "philip@bold.dev", "time": "Fri Jun 27 09:46:42 2025 -0700" }, "message": "Bump down to 8-core github runners\n" }, { "commit": "9aa141a4bdde68a1ad57d56ba3cb0023109c6b7b", "tree": "343ad7ce6404ceeee210a1f43d4b3c0f86e70756", "parents": [ "b01b150abe7bf3066a08dcaafe1e443aa101c5c1" ], "author": { "name": "banksean", "email": "banksean@gmail.com", "time": "Fri Jun 27 05:02:24 2025 +0000" }, "committer": { "name": "Autoformatter", "email": "bot@sketch.dev", "time": "Fri Jun 27 05:07:21 2025 +0000" }, "message": "skaband: remove all manual input switching functionality from sessions page\n\nfix for #430\n\nCompletely remove auto-switch and manual switch functionality to simplify\nthe repository selection interface and eliminate user confusion.\n\nProblems Solved:\n\nComplex Dual-Mode Interface:\n- Auto-switch feature automatically changed UI state without user consent\n- Manual switch buttons created confusing dual-mode interface\n- Users unclear when to use dropdown vs manual input vs auto-switching\n- Multiple code paths for repository input handling created maintenance overhead\n\nInconsistent User Experience:\n- Repository loading failures triggered unexpected auto-switch behavior\n- Manual buttons overlaid on repository selection interface\n- Console error logging without clear user benefit\n- No clear guidance on which input method to use\n\nJavaScript Complexity:\n- switchToManualInput() and enhancedSwitchToManualInput() functions\n- Complex validation setup and event handlers for switching\n- setTimeout scripts for auto-switch timeouts and console logging\n- Event listeners and DOM manipulation for button interactions\n\nSolution Implementation:\n\nComplete Feature Removal:\n- Removed all auto-switch timeout scripts and console error logging\n- Eliminated switchToManualInput() and enhancedSwitchToManualInput() functions\n- Removed all manual switch buttons from repository selection interface\n- Simplified JavaScript by removing switching-related event handlers\n\nSimplified Repository Selection:\n- Repository selection now uses standard HTML select dropdown only\n- Hidden text input remains for loading state (standard form behavior)\n- No manual override buttons or automatic switching functionality\n- Clean, predictable interface focused on dropdown selection\n\nTemplate Structure Cleanup:\n- Removed button elements with switch-to-manual IDs from HTML\n- Eliminated complex validation setup code tied to manual switching\n- Simplified repository selection container structure\n- Preserved core form functionality and submission workflow\n\nImplementation Details:\n\nRemoved JavaScript Functions:\n- switchToManualInput(): DOM manipulation for switching input modes\n- enhancedSwitchToManualInput(): Validation setup and enhanced switching\n- Auto-switch timeout script: 10-second timeout with console logging\n- Manual button event handlers: onclick setup and event listeners\n\nRemoved HTML Elements:\n- Manual switch button in dropdown mode\n- Manual switch button in loading state\n- All switch-to-manual ID references\n- Button overlay positioning and styling\n\nPreserved Core Functionality:\n- Repository select dropdown when GitHubRepos available\n- Hidden text input for loading states\n- Form submission and validation workflow\n- Repository selection and session creation process\n\nTesting Updates:\n- Updated TestRepositoryUIFeatures to reflect simplified interface\n- Removed tests checking for presence of removed switching functionality\n- Tests now focus on core dropdown and loading state functionality\n- Verified repository selection continues to work with standard form behavior\n\nUser Experience Impact:\n- Single, predictable way to select repositories via dropdown\n- No unexpected UI changes or automatic state transitions\n- Standard HTML form behavior users expect\n- Reduced cognitive load with simpler interface\n\nFiles Modified:\n- skaband/sessions.gohtml: Removed switching functions, buttons, and timeout scripts\n- skaband/skaband_test.go: Updated tests for simplified interface\n\nThe simplified interface eliminates confusion by providing a single,\nstandard way to select repositories through HTML dropdown selection.\n\nCo-Authored-By: sketch \u003chello@sketch.dev\u003e\nChange-ID: sdc7975f0ace4b511k\n" }, { "commit": "b01b150abe7bf3066a08dcaafe1e443aa101c5c1", "tree": "3488103cc3b3f9a124d04f7cd6f0619406e74f7a", "parents": [ "b379592340a40c4c22ac1a52be4d2e612a9aa4f4" ], "author": { "name": "Philip Zeyliger", "email": "philip@bold.dev", "time": "Thu Jun 26 21:20:12 2025 -0700" }, "committer": { "name": "Autoformatter", "email": "bot@sketch.dev", "time": "Fri Jun 27 04:21:19 2025 +0000" }, "message": "Fix nil pointer dereference #432\n" }, { "commit": "b379592340a40c4c22ac1a52be4d2e612a9aa4f4", "tree": "37d9ce08602651cc11b0b1bc2f46ebdd6907fc6a", "parents": [ "659b98361783ad139412ea2a0bc62c8ed25c292e" ], "author": { "name": "Sean McCullough", "email": "banksean@gmail.com", "time": "Fri Jun 27 01:59:41 2025 +0000" }, "committer": { "name": "Autoformatter", "email": "bot@sketch.dev", "time": "Fri Jun 27 02:04:42 2025 +0000" }, "message": "webui: convert sketch-call-status and sketch-chat-input to SketchTailwindElement with comprehensive demo support\n\nConvert both sketch-call-status and sketch-chat-input components from shadow DOM CSS to Tailwind classes while maintaining test compatibility and adding comprehensive demo infrastructure.\n\nProblems Solved:\n\nShadow DOM Styling Limitations:\n- Both components used CSS-in-JS with shadow DOM preventing Tailwind integration\n- Large static styles blocks with custom CSS duplicated Tailwind functionality\n- Components couldn\u0027t benefit from design system consistency\n- Difficult to maintain custom CSS alongside Tailwind-based components\n\nMissing Demo Infrastructure:\n- sketch-call-status had no demo fixtures for testing component states\n- sketch-chat-input needed dedicated demo fixture following naming convention\n- Components not properly integrated into demo runner system\n\nTest Compatibility Issues:\n- Conversion to Tailwind required updating shadow DOM selectors\n- renderRoot.querySelector calls needed conversion to direct querySelector\n- Component tests needed updating for non-shadow DOM structure\n\nSolution Implementation:\n\nTailwind CSS Conversion - sketch-call-status:\n- Changed sketch-call-status to inherit from SketchTailwindElement\n- Replaced CSS-in-JS styles with Tailwind utility classes and inline animations\n- Converted animations using @keyframes in inline \u003cstyle\u003e tag\n- Maintained exact visual appearance while using Tailwind classes\n\nTailwind CSS Conversion - sketch-chat-input:\n- Changed sketch-chat-input to inherit from SketchTailwindElement\n- Replaced extensive static styles CSS block with Tailwind utility classes\n- Converted complex chat container, input wrapper, and button styling\n- Added custom fade-in animation to tailwind.config.js with keyframes\n\nKey Tailwind Class Mappings:\n- Call status indicators: bg-yellow-100 text-amber-500 (active), text-gray-400 (idle)\n- Status banners: bg-green-50 text-green-700 (idle), bg-orange-50 text-orange-600 (working)\n- Chat container: w-full bg-gray-100 p-4 min-h-[40px] relative\n- Chat input: flex-1 p-3 border border-gray-300 rounded resize-y font-mono\n- Send button: bg-blue-500 hover:bg-blue-600 disabled:bg-gray-400\n\nShadow DOM to Light DOM Conversion:\n- Removed static styles properties completely\n- Updated all renderRoot.querySelector calls to direct querySelector calls\n- Changed shadow DOM event handler setup to work with light DOM\n- Maintained all drag-and-drop and event handling functionality\n\nTest Compatibility Maintenance:\n- Added semantic CSS classes back to elements for test selectors\n- Updated sketch-chat-input.test.ts to use querySelector instead of renderRoot.querySelector\n- Fixed drag event simulation to work with light DOM structure\n- All existing tests continue to pass with updated selectors\n\nDemo Infrastructure Implementation:\n- Created call-status.ts demo fixtures with CallStatusState interface\n- Added comprehensive sketch-call-status.demo.ts with interactive controls\n- Created chat-input.ts demo fixture with message display and controls\n- Added both components to demo-runner.ts knownComponents list\n\nInteractive Demo Features:\n- Call status: Status variations, interactive LLM/tool call controls, connection toggle\n- Chat input: Message display with user/bot styling, multiple preset buttons\n- Both demos include real-time state updates and comprehensive examples\n\nDependencies:\n- Added @tailwindcss/vite package for Tailwind integration\n- Updated package.json and package-lock.json with new dependency\n\nFiles Modified:\n- sketch/webui/src/web-components/sketch-call-status.ts: Converted to SketchTailwindElement\n- sketch/webui/src/web-components/sketch-chat-input.ts: Converted to SketchTailwindElement\n- sketch/webui/src/web-components/sketch-chat-input.test.ts: Updated selectors for light DOM\n- sketch/webui/src/web-components/demo/demo-fixtures/call-status.ts: Added call status fixtures\n- sketch/webui/src/web-components/demo/demo-fixtures/index.ts: Export call status fixtures\n- sketch/webui/src/web-components/demo/sketch-call-status.demo.ts: Complete interactive demo\n- sketch/webui/src/web-components/demo/chat-input.ts: New chat input demo fixture\n- sketch/webui/src/web-components/demo/demo-framework/demo-runner.ts: Added both components\n- sketch/webui/tailwind.config.js: Added custom fade-in animation\n- sketch/webui/package.json: Added @tailwindcss/vite dependency\n\nTesting and Validation:\n- All component tests pass with updated selectors\n- Components render correctly with Tailwind classes\n- All functionality preserved including animations and interactions\n- Interactive demos load and function properly\n- Components appear in demo runner list\n\nThe conversion maintains all functionality while enabling better integration\nwith the Tailwind-based design system and providing comprehensive demo\ninfrastructure for development and testing.\n\nCo-Authored-By: sketch \u003chello@sketch.dev\u003e\nChange-ID: s97f4190763cfe17ak\n" }, { "commit": "659b98361783ad139412ea2a0bc62c8ed25c292e", "tree": "ee1ce34629a13101b0cb1a492f0457c1e83a9eaa", "parents": [ "49577498f65808da9faaa1745e66a590e0ad3583" ], "author": { "name": "banksean", "email": "banksean@gmail.com", "time": "Fri Jun 27 00:50:41 2025 +0000" }, "committer": { "name": "Autoformatter", "email": "bot@sketch.dev", "time": "Fri Jun 27 00:53:48 2025 +0000" }, "message": "webui: convert SketchCallStatus to Tailwind CSS with comprehensive demo support\n\nConvert SketchCallStatus component from shadow DOM CSS to Tailwind classes\nwhile maintaining test compatibility and adding complete demo infrastructure.\n\nProblems Solved:\n\nShadow DOM Styling Limitations:\n- SketchCallStatus used CSS-in-JS with shadow DOM preventing Tailwind integration\n- Custom CSS animations and styling duplicated Tailwind functionality\n- Component couldn\u0027t benefit from design system consistency\n- Difficult to maintain custom CSS alongside Tailwind-based components\n\nMissing Demo Infrastructure:\n- No demo fixtures for testing SketchCallStatus component states\n- Component not included in demo runner for development testing\n- Manual testing required for visual verification of component behavior\n\nTest Compatibility Issues:\n- Conversion to Tailwind removed semantic class names expected by tests\n- Need to maintain backward compatibility with existing test suite\n\nSolution Implementation:\n\nTailwind CSS Conversion:\n- Changed SketchCallStatus to inherit from SketchTailwindElement\n- Replaced CSS-in-JS styles with Tailwind utility classes\n- Converted animations using @keyframes in inline \u003cstyle\u003e tag\n- Maintained exact visual appearance while using Tailwind classes\n\nComponent State Styling:\n- LLM indicator: bg-yellow-100 text-amber-500 when active, text-gray-400 when idle\n- Tool indicator: bg-blue-100 text-blue-500 when active, text-gray-400 when idle\n- Status banner: bg-green-50 text-green-700 (idle), bg-orange-50 text-orange-600 (working), bg-red-50 text-red-600 (disconnected)\n- Gentle pulse animation preserved with animate-gentle-pulse class\n\nTest Compatibility Maintenance:\n- Added semantic CSS classes back to elements (.llm-indicator, .tool-indicator, .status-banner)\n- Added .active class when indicators are in active state\n- Added status state classes (status-idle, status-working, status-disconnected)\n- Maintains backward compatibility with existing Playwright tests\n\nDemo Fixtures Implementation:\n- Added call-status.ts with CallStatusState interface and sample states\n- Created demo fixtures: idleCallStatus, workingCallStatus, heavyWorkingCallStatus, disconnectedCallStatus, workingDisconnectedCallStatus\n- Fixed TypeScript module export issues using \u0027export type\u0027 syntax\n- Comprehensive sketch-call-status.demo.ts with interactive controls\n- Added component to demo-runner.ts knownComponents list\n\nInteractive Demo Features:\n- Status variations section showing all possible states\n- Interactive demo with buttons to add/remove LLM calls and tool calls\n- Toggle connection state and change agent state functionality\n- Reset button to return to idle state\n- Real-time simulation of activity changes\n\nFiles Modified:\n- sketch/webui/src/web-components/sketch-call-status.ts: Converted to SketchTailwindElement with Tailwind classes and semantic class names\n- sketch/webui/src/web-components/demo/demo-fixtures/call-status.ts: Added call status demo data\n- sketch/webui/src/web-components/demo/demo-fixtures/index.ts: Export call status fixtures with proper TypeScript module exports\n- sketch/webui/src/web-components/demo/sketch-call-status.demo.ts: Complete demo implementation with interactive controls\n- sketch/webui/src/web-components/demo/demo-framework/demo-runner.ts: Added sketch-call-status to knownComponents\n\nTesting and Validation:\n- Verified component renders correctly with Tailwind classes\n- Confirmed all state variations display proper colors and animations\n- Tested interactive demo controls function correctly\n- Validated component appears in demo runner list\n- Ensured test compatibility with semantic class preservation\n\nThe conversion maintains visual fidelity and test compatibility while enabling\nbetter integration with the Tailwind-based design system and providing\ncomprehensive demo infrastructure for development and testing.\n\nCo-Authored-By: sketch \u003chello@sketch.dev\u003e\nChange-ID: s3437e5020555164dk\n" }, { "commit": "49577498f65808da9faaa1745e66a590e0ad3583", "tree": "aed3194233b9f8ceec24cb930f066abace25b477", "parents": [ "d5c849d0923c6b254047ebb07589adf10bc18548" ], "author": { "name": "Sean McCullough", "email": "banksean@gmail.com", "time": "Thu Jun 26 17:13:28 2025 -0700" }, "committer": { "name": "Autoformatter", "email": "bot@sketch.dev", "time": "Fri Jun 27 00:16:07 2025 +0000" }, "message": "sketch-container-status: fix long branch names\n" }, { "commit": "d5c849d0923c6b254047ebb07589adf10bc18548", "tree": "4c3daefe24c0c618b1499452ca1dc974311f880b", "parents": [ "4b64468e6dd5d4283c90d85a483351af11933c2f" ], "author": { "name": "banksean", "email": "banksean@gmail.com", "time": "Thu Jun 26 15:48:31 2025 +0000" }, "committer": { "name": "Autoformatter", "email": "bot@sketch.dev", "time": "Thu Jun 26 19:25:55 2025 +0000" }, "message": "webui: convert SketchViewModeSelect to use SketchTailwindElement with Tailwind CSS\n\nReplace LitElement shadow DOM component with SketchTailwindElement base class\nto use Tailwind CSS utility classes instead of component-scoped CSS styles.\n\nAlso adds tailwind support for CSS container queries in addition to media\nqueries.\n\nCo-Authored-By: sketch \u003chello@sketch.dev\u003e\nChange-ID: s0eeb80dd54594375k\n" }, { "commit": "4b64468e6dd5d4283c90d85a483351af11933c2f", "tree": "3c3721c5714d88bba7c04f292e705da339dfdbfc", "parents": [ "07b7400182aefc4153eb6617ab89a5f05f577349" ], "author": { "name": "David Crawshaw", "email": "david@zentus.com", "time": "Thu Jun 26 17:15:10 2025 +0000" }, "committer": { "name": "Autoformatter", "email": "bot@sketch.dev", "time": "Thu Jun 26 18:32:41 2025 +0000" }, "message": "webui: add compactPadding parameter to reduce message padding\n\nCo-Authored-By: sketch \u003chello@sketch.dev\u003e\nChange-ID: s33c29800305d4dd2k\n" }, { "commit": "07b7400182aefc4153eb6617ab89a5f05f577349", "tree": "c94fccc6dea3ca946c2c9039f062d3814d61477f", "parents": [ "9aa7828cbff8e8d66e63909db5a222d1b90fa986" ], "author": { "name": "banksean", "email": "banksean@gmail.com", "time": "Thu Jun 26 16:05:25 2025 +0000" }, "committer": { "name": "Sean McCullough", "email": "banksean@gmail.com", "time": "Thu Jun 26 09:07:17 2025 -0700" }, "message": "fix: prevent nil pointer panic in codereview compareTestResults\n\nFix for https://github.com/boldsoftware/sketch/issues/175\n\nFix nil pointer dereference when comparing test results between commits\nwhere a package exists in the after state but not the before state.\n\nThe panic occurred at line 867 when accessing beforeResult.TestStatus[test]\nwithout checking if beforeResult was nil. This happens when testing new\npackages that didn\u0027t exist in the base commit.\n\nNow properly check for nil beforeResult and default to testStatusUnknown\nfor tests in packages that didn\u0027t exist in the before state.\n\nAdd comprehensive unit tests covering:\n- New package with passing tests (the panic scenario)\n- New package with failing tests (regression detection)\n- Existing package regressions (ensure normal flow still works)\n- End-to-end integration test for new package scenario\n\nCo-Authored-By: sketch \u003chello@sketch.dev\u003e\nChange-ID: sab802d91eff08039k\n" }, { "commit": "9aa7828cbff8e8d66e63909db5a222d1b90fa986", "tree": "f1e66dc2b5db0a7a391a7c516b9ec32a2bdf35ce", "parents": [ "261c9116af76218e9d0c4c7c426f7829b911421c" ], "author": { "name": "david", "email": "david@zentus.com", "time": "Thu Jun 26 04:15:54 2025 +0000" }, "committer": { "name": "David Crawshaw", "email": "david@zentus.com", "time": "Wed Jun 25 21:33:31 2025 -0700" }, "message": "sketch: add -ignoresig flag to ignore SIGINT and SIGTERM\n\nInside the container, do not let the agent kill PID 1.\n\nCo-Authored-By: sketch \u003chello@sketch.dev\u003e\nChange-ID: s5197e5ad119cd474k\n" }, { "commit": "261c9116af76218e9d0c4c7c426f7829b911421c", "tree": "5ad8adb42cad1357bd49a92bb64caa0b5e3e716a", "parents": [ "a70dcc45ebdf79aba2a49f445caa96f40ce5a603" ], "author": { "name": "Sean McCullough", "email": "banksean@gmail.com", "time": "Wed Jun 25 16:36:20 2025 -0700" }, "committer": { "name": "Autoformatter", "email": "bot@sketch.dev", "time": "Wed Jun 25 23:45:45 2025 +0000" }, "message": "rm shadowRoot references from SketchAppShellBase\n\nit no longer has a shadowRoot since it\u0027s using tailwind now.\n" }, { "commit": "a70dcc45ebdf79aba2a49f445caa96f40ce5a603", "tree": "0412fce470e83de280e3e8ff5836418d2a0d54b0", "parents": [ "618bfb28892561a8ef2e3d6163de4fd6c990beda" ], "author": { "name": "banksean", "email": "banksean@gmail.com", "time": "Wed Jun 25 20:54:11 2025 +0000" }, "committer": { "name": "Sean McCullough", "email": "banksean@gmail.com", "time": "Wed Jun 25 15:57:55 2025 -0700" }, "message": "fix visibility and css breakpoits on todo panel\n\nCo-Authored-By: sketch \u003chello@sketch.dev\u003e\nChange-ID: sbb5ba87b117a38c1k\n" }, { "commit": "618bfb28892561a8ef2e3d6163de4fd6c990beda", "tree": "c1ef367f8a4ecea00f237bc084f1ecbd15773764", "parents": [ "8b2bc8eacb6ca23c1dbfda31eb9f3651eb756820" ], "author": { "name": "Sean McCullough", "email": "banksean@gmail.com", "time": "Wed Jun 25 20:52:30 2025 +0000" }, "committer": { "name": "Autoformatter", "email": "bot@sketch.dev", "time": "Wed Jun 25 22:24:00 2025 +0000" }, "message": "webui: implement modular demo system with TypeScript and shared fixtures\n\nReplace hand-written HTML demo pages with TypeScript demo modules and\nautomated infrastructure to reduce maintenance overhead and improve\ndeveloper experience with type safety and shared code.\n\nProblems Solved:\n\nDemo Maintenance Overhead:\n- Hand-written HTML demo pages contained extensive boilerplate duplication\n- No type checking for demo setup code or component data\n- Manual maintenance of demo/index.html with available demos\n- Difficult to share common fake data between demo pages\n- No hot module replacement for demo development\n\nCode Quality and Consistency:\n- Demo setup code written in plain JavaScript without type safety\n- No validation that demo data matches component interfaces\n- Inconsistent styling and structure across demo pages\n- Duplicated fake data declarations in each demo file\n\nSolution Architecture:\n\nTypeScript Demo Module System:\n- Created DemoModule interface for standardized demo structure\n- Demo modules export title, description, imports, and setup functions\n- Full TypeScript compilation with type checking for demo code\n- Dynamic import system for on-demand demo loading with Vite integration\n\nShared Demo Infrastructure:\n- demo-framework/ with types.ts and demo-runner.ts for core functionality\n- DemoRunner class handles dynamic loading, cleanup, and error handling\n- Single demo-runner.html page loads any demo module dynamically\n- Supports URL hash routing for direct demo links\n\nCentralized Fake Data:\n- demo-fixtures/ directory with shared TypeScript data files\n- sampleToolCalls, sampleTimelineMessages, and sampleContainerState\n- Type-safe imports ensure demo data matches component interfaces\n- demoUtils with helper functions for consistent demo UI creation\n\nAuto-generated Index Page:\n- generate-index.ts scans for *.demo.ts files and extracts metadata\n- Creates index-generated.html with links to all available demos\n- Automatically includes demo titles and descriptions\n- Eliminates manual maintenance of demo listing\n\nImplementation Details:\n\nDemo Framework:\n- DemoRunner.loadDemo() uses dynamic imports with Vite ignore comments\n- Automatic component import based on demo module configuration\n- Support for demo-specific CSS and cleanup functions\n- Error handling with detailed error display for debugging\n\nDemo Module Structure:\n- sketch-chat-input.demo.ts: Interactive chat with message history\n- sketch-container-status.demo.ts: Status variations with real-time updates\n- sketch-tool-calls.demo.ts: Multiple tool call examples with progressive loading\n- All use shared fixtures and utilities for consistent experience\n\nVite Integration:\n- Hot Module Replacement works for demo modules and shared fixtures\n- TypeScript compilation on-the-fly for immediate feedback\n- Dynamic imports work seamlessly with Vite\u0027s module system\n- @vite-ignore comments prevent import analysis warnings\n\nTesting and Validation:\n- Tested demo runner loads and displays available components\n- Verified component discovery and dynamic import functionality\n- Confirmed shared fixture imports work correctly\n- Validated auto-generated index creation and content\n\nFiles Modified:\n- demo-framework/types.ts: TypeScript interfaces for demo system\n- demo-framework/demo-runner.ts: Core demo loading and execution logic\n- demo-fixtures/: Shared fake data (tool-calls.ts, timeline-messages.ts, container-status.ts, index.ts)\n- demo-runner.html: Interactive demo browser with sidebar navigation\n- generate-index.ts: Auto-generation script for demo index\n- sketch-chat-input.demo.ts: Converted chat input demo to TypeScript\n- sketch-container-status.demo.ts: Container status demo with variations\n- sketch-tool-calls.demo.ts: Tool calls demo with interactive examples\n- readme.md: Comprehensive documentation for new demo system\n\nBenefits:\n- Developers get full TypeScript type checking for demo code\n- Shared fake data ensures consistency and reduces duplication\n- Hot module replacement provides instant feedback during development\n- Auto-generated index eliminates manual maintenance\n- Modular architecture makes it easy to add new demos\n- Vite integration provides fast development iteration\n\nThe new system reduces demo maintenance overhead while providing\nbetter developer experience through TypeScript, shared code, and\nautomated infrastructure.\n\nCo-Authored-By: sketch \u003chello@sketch.dev\u003e\nChange-ID: s3d91894eb7c4a79fk\n" }, { "commit": "8b2bc8eacb6ca23c1dbfda31eb9f3651eb756820", "tree": "3ddde7e060d63b7acde22f770f3769b819608cc8", "parents": [ "3999593021336893670576875c130c1b171e797d" ], "author": { "name": "Sean McCullough", "email": "banksean@gmail.com", "time": "Wed Jun 25 12:52:16 2025 -0700" }, "committer": { "name": "Sean McCullough", "email": "banksean@gmail.com", "time": "Wed Jun 25 13:08:24 2025 -0700" }, "message": "fix stop/end button css breakpoints\n" }, { "commit": "3999593021336893670576875c130c1b171e797d", "tree": "9568daa2fefa7cdef0ec5416fc734b640822ecc3", "parents": [ "0635c776054d5ced92328a2c8cd4014ef5f4a86f" ], "author": { "name": "Sean McCullough", "email": "banksean@gmail.com", "time": "Wed Jun 25 19:32:08 2025 +0000" }, "committer": { "name": "Autoformatter", "email": "bot@sketch.dev", "time": "Wed Jun 25 19:42:32 2025 +0000" }, "message": "webui: generate tailwind.css in esbuild.go, output to dist/\n\nMove Tailwind CSS generation from npm script to esbuild.go build process\nand output generated file to dist/tailwind.css instead of src/tailwind.css\nto prevent tracking generated files in git.\n\nProblems Solved:\n- Generated CSS file was tracked in git causing unnecessary diffs\n- Build process relied on manual npm script execution\n- Generated CSS mixed with source files\n\nSolution Architecture:\n- Integrated Tailwind CSS generation into Go build process\n- Moved output location to dist/ directory (already gitignored)\n- Added automatic CSS generation during webui.Build()\n- Moved @tailwindcss/cli from devDependencies to regular dependencies\n\nImplementation Details:\n- Added generateTailwindCSS() function to run tailwindcss CLI during build\n- Modified Build() to call generateTailwindCSS() after npm ci\n- Updated file copying logic to skip src/tailwind.css (no longer needed)\n- Moved @tailwindcss/cli to regular dependencies to work with --omit dev\n- Updated npm tailwind script to output to dist/tailwind.css\n- Added src/tailwind.css to .gitignore to prevent accidental tracking\n\nFiles Modified:\n- sketch/webui/esbuild.go: Added CSS generation and updated build process\n- sketch/webui/.gitignore: Added src/tailwind.css exclusion\n- sketch/webui/package.json: Moved @tailwindcss/cli to dependencies, updated script\n- sketch/webui/src/tailwind.css: Removed from git tracking\n\nThe generated CSS is now properly separated from source files and\nautomatically created during the build process.\n\nCo-Authored-By: sketch \u003chello@sketch.dev\u003e\nChange-ID: s3464450fc2c7851fk\n" }, { "commit": "0635c776054d5ced92328a2c8cd4014ef5f4a86f", "tree": "cccaae48def4d6592cda8f75f32441f565e48553", "parents": [ "cff0ff8f582a970fa8bd688448964bef8d2b84ab" ], "author": { "name": "Philip Zeyliger", "email": "philip@bold.dev", "time": "Wed Jun 25 12:01:16 2025 -0700" }, "committer": { "name": "Autoformatter", "email": "bot@sketch.dev", "time": "Wed Jun 25 19:02:30 2025 +0000" }, "message": "webui: fix monaco diff editor jumping behavior\n\nThis is Sketch\u0027s attempt to fix the jumping. It seems to\nbe better for me.\n" }, { "commit": "cff0ff8f582a970fa8bd688448964bef8d2b84ab", "tree": "be78da943008f817a8af3ba40c34f633ce855344", "parents": [ "7e36a04e5b9eb206faad20f0a37fa111285ffdce" ], "author": { "name": "banksean", "email": "banksean@gmail.com", "time": "Wed Jun 25 16:43:47 2025 +0000" }, "committer": { "name": "Autoformatter", "email": "bot@sketch.dev", "time": "Wed Jun 25 18:39:06 2025 +0000" }, "message": "sketch: add /proc filesystem fallback for port monitoring when ss command unavailable\n\nImplements /proc/net/tcp* parsing as fallback when ss command fails to eliminate\ndependency on ss being installed in container environments.\n\nProblems Solved:\n\nss Command Dependency:\n- PortMonitor.updatePortState() relied on \u0027ss -lntu\u0027 command for port detection\n- Failed on systems where ss (iproute2 package) is not installed\n- No fallback mechanism when ss command execution failed\n- Port monitoring became non-functional in minimal container environments\n\nLimited Container Support:\n- Many minimal container images don\u0027t include ss command\n- Port monitoring silently failed without providing any functionality\n- No way to detect listening ports without external command dependencies\n\nSolution Architecture:\n\n/proc Filesystem Parsing:\n- Added getListeningPortsFromProc() method to read /proc/net/tcp* files\n- Parses /proc/net/tcp, /proc/net/tcp6, /proc/net/udp, /proc/net/udp6\n- Hex address decoding for both IPv4 and IPv6 addresses\n- Socket state filtering to identify listening sockets (state 0x0A for TCP, 0x07 for UDP)\n\nFallback Implementation:\n- updatePortState() tries ss command first, falls back to /proc on failure\n- parseAddress() handles little-endian hex encoding from /proc files\n- Generated output format matches ss command output for compatibility\n- Maintains existing parseSSPorts() functionality for ss output\n\nImplementation Details:\n\nAddress Parsing:\n- IPv4: 8-character hex string representing little-endian 32-bit address\n- IPv6: 32-character hex string with little-endian 32-bit chunks\n- Port numbers stored as big-endian hex values\n- Special address handling: 0.0.0.0 and :: converted to \u0027*\u0027\n\nSocket State Detection:\n- TCP listening sockets: state 0x0A (TCP_LISTEN)\n- UDP bound sockets: state 0x07 (TCP_CLOSE for UDP)\n- Filters out non-listening connections and states\n\nError Handling:\n- Graceful fallback when ss command fails\n- Logs debug messages for command failures\n- Continues with /proc parsing if available\n- Handles missing /proc files gracefully\n\nTesting:\n\nComprehensive Test Coverage:\n- TestParseAddress() verifies hex address decoding for IPv4/IPv6\n- TestParseProcData() validates /proc file parsing with mock data\n- TestGetListeningPortsFromProcFallback() tests complete fallback functionality\n- TestUpdatePortStateWithFallback() validates end-to-end behavior\n\nAddress Parsing Validation:\n- IPv4 localhost (0100007F:0050 -\u003e 127.0.0.1:80)\n- IPv4 wildcard (00000000:0016 -\u003e *:22)\n- IPv6 wildcard and specific addresses\n- Error handling for invalid formats and hex values\n\nFiles Modified:\n- sketch/loop/port_monitor.go: Added /proc parsing methods and fallback logic\n- sketch/loop/port_monitor_test.go: Added comprehensive tests for new functionality\n\nThe implementation ensures port monitoring works reliably in any Linux environment\nregardless of whether ss command is available, using native /proc filesystem access.\n\nCo-Authored-By: sketch \u003chello@sketch.dev\u003e\nChange-ID: s72dd58a0b3f4304bk\n" }, { "commit": "7e36a04e5b9eb206faad20f0a37fa111285ffdce", "tree": "1711a78624b0e56fa6b43a29ee407e34cbc83763", "parents": [ "cb48b67edc89182fbde0827fd25f7c4c1640d2c8" ], "author": { "name": "Sean McCullough", "email": "banksean@gmail.com", "time": "Wed Jun 25 08:45:18 2025 +0000" }, "committer": { "name": "Autoformatter", "email": "bot@sketch.dev", "time": "Wed Jun 25 18:16:03 2025 +0000" }, "message": "webui: convert sketch-container-status to use tailwind\n\nConvert sketch-container-status component from shadowDOM CSS to Tailwind classes\nwhile preserving the original visual styling and functionality.\n\n- Inherit from SketchTailwindElement instead of LitElement to disable shadowDOM\n- Replace static styles CSS with equivalent Tailwind utility classes\n- Update pulse animation to use document-level CSS since Tailwind doesn\u0027t support custom keyframes inline\n- Convert all layout, typography, color, and spacing properties to Tailwind equivalents\n- Update DOM queries from shadowRoot to direct element queries due to disabled shadowDOM\n- Preserve all interactive functionality including info panel expansion and commit copying\n- Maintain visual consistency with original design including hover states and transitions\n\nCo-Authored-By: sketch \u003chello@sketch.dev\u003e\nChange-ID: s7f97a079a6dd14c1k\n" }, { "commit": "cb48b67edc89182fbde0827fd25f7c4c1640d2c8", "tree": "dd01329422b22139d42390c311b914cbdf0a54e9", "parents": [ "7735844caf9fa4e2d7bbe3bf64d20e86b9bf469e" ], "author": { "name": "Sean McCullough", "email": "banksean@gmail.com", "time": "Wed Jun 25 10:11:16 2025 -0700" }, "committer": { "name": "Sean McCullough", "email": "banksean@gmail.com", "time": "Wed Jun 25 10:11:34 2025 -0700" }, "message": "sketch-app-shell: add tailwind css to demo html\n" }, { "commit": "7735844caf9fa4e2d7bbe3bf64d20e86b9bf469e", "tree": "e5c73e24642f2dab2ac95ba3db4c04e1ac0ac82e", "parents": [ "bf66a2f9313894d63f204816ba90e412e02363c0" ], "author": { "name": "David Crawshaw", "email": "david@zentus.com", "time": "Wed Jun 25 00:26:08 2025 +0000" }, "committer": { "name": "Autoformatter", "email": "bot@sketch.dev", "time": "Wed Jun 25 03:12:26 2025 +0000" }, "message": "skaband: create forked app shell for /newsessions with shared base\n\nFactor out shared components from sketch/webui app shell and create\nnewsessions-specific version under skaband with pinned topbar/textarea layout.\n\nCo-Authored-By: sketch \u003chello@sketch.dev\u003e\nChange-ID: s9fcdda62becc98f9k\n" }, { "commit": "bf66a2f9313894d63f204816ba90e412e02363c0", "tree": "22acc34aa404c3ac5add1e2de7f4df1aadce8251", "parents": [ "194bfa8cc3970d28f2d072dc82142e24b7e56c9f" ], "author": { "name": "Sean McCullough", "email": "banksean@gmail.com", "time": "Mon Jun 23 21:53:55 2025 -0700" }, "committer": { "name": "Autoformatter", "email": "bot@sketch.dev", "time": "Tue Jun 24 16:43:42 2025 +0000" }, "message": "webui: convert sketch-app-shell to use tailwind\n\nDoing the conversion from shadowDOM to tailwind starting with the\noutermost elements in the page because shadowDOM hides dom nodes from\nancestor styles, which means tailwind styles don\u0027t apply to an element\nif its ancestors use shadowDOM.\n\n- add new SketchTailwindElement that disables shadowDOM for tailwind\n- convert sketch-app-shell to inherit from SketchTailwindElement\n- convert sketch-app-shell\u0027s CSS from shadowDOM to tailwind classes\n" }, { "commit": "194bfa8cc3970d28f2d072dc82142e24b7e56c9f", "tree": "8cf0872d8d1d6b1ab5eec4ef1f20ab7b201a7de9", "parents": [ "ba351be3a9e50c67baef59af5ee35e3b654727e1" ], "author": { "name": "Philip Zeyliger", "email": "philip@bold.dev", "time": "Tue Jun 24 06:03:06 2025 -0700" }, "committer": { "name": "Philip Zeyliger", "email": "philip@bold.dev", "time": "Tue Jun 24 06:03:06 2025 -0700" }, "message": "sketch: add MCP support\n\nLets you initialize extra tools via MCP. This is additive, so it\u0027s\nharmless enough.\n\nHere are some examples of the kind of things you can pass to the -mcp\nflag.\n\n {\"name\": \"context7\", \"type\": \"http\", \"url\": \"https://mcp.context7.com/mcp\"}\n {\"name\": \"context7-http\", \"type\": \"http\", \"url\": \"https://mcp.context7.com/mcp\"}\n {\"name\": \"context7-stdio\", \"type\": \"stdio\", \"command\": \"npx\", \"args\": [\"-y\", \"@upstash/context7-mcp\"]}\n {\"name\": \"context7-sse\", \"type\": \"sse\", \"url\": \"https://mcp.context7.com/sse\"}\n {\"name\": \"local-tool\", \"type\": \"stdio\", \"command\": \"my_tool\", \"args\": [\"--option\", \"value\"], \"env\": {\"TOKEN\": \"secret\"}}\n { \"name\": \"playwright\", \"command\": \"npx\", \"args\": [ \"@playwright/mcp@latest\" ]}\n\nCo-Authored-By: sketch \u003chello@sketch.dev\u003e\nChange-ID: s259a35d11e7bd660k\n" }, { "commit": "ba351be3a9e50c67baef59af5ee35e3b654727e1", "tree": "b6d654a743e058ad357effd56287b40f469cce65", "parents": [ "5a85ffe8c6a3f6916fd3d7951af5486a784e87f0" ], "author": { "name": "Autoformatter", "email": "bot@sketch.dev", "time": "Mon Jun 23 21:59:08 2025 +0000" }, "committer": { "name": "Autoformatter", "email": "bot@sketch.dev", "time": "Mon Jun 23 21:59:08 2025 +0000" }, "message": "all: fix formatting\n" }, { "commit": "5a85ffe8c6a3f6916fd3d7951af5486a784e87f0", "tree": "0efa325e62b99fc366516f6575ce6d7bff95ccde", "parents": [ "d158f9d2954c8ad8b803aa257eba3084651b43e8" ], "author": { "name": "Philip Zeyliger", "email": "philip@bold.dev", "time": "Sat Jun 21 21:27:44 2025 -0700" }, "committer": { "name": "Philip Zeyliger", "email": "philip@bold.dev", "time": "Mon Jun 23 14:58:22 2025 -0700" }, "message": "webui: fix IDLE/WORKING indicator to ignore system messages\n\nFix bug where IDLE/WORKING status indicator in top-right incorrectly used\nsystem messages (like commit detection) to determine agent state instead\nof only considering user and agent messages.\n\nCo-Authored-By: sketch \u003chello@sketch.dev\u003e\nChange-ID: s7aecd377d88b46f8k\n" }, { "commit": "d158f9d2954c8ad8b803aa257eba3084651b43e8", "tree": "1f47cbb236bcd968f97edc921cb94ca400b4458e", "parents": [ "29d689f174f0a414ee818961118c2e9ec33a809c" ], "author": { "name": "Philip Zeyliger", "email": "philip@bold.dev", "time": "Mon Jun 23 14:08:18 2025 -0700" }, "committer": { "name": "Philip Zeyliger", "email": "philip@bold.dev", "time": "Mon Jun 23 14:09:16 2025 -0700" }, "message": "Remove noisy log line\n" }, { "commit": "29d689f174f0a414ee818961118c2e9ec33a809c", "tree": "17ae059d3085a7905b9fe1d59ead9cb066511f49", "parents": [ "ebbdee49d9b9e7d5144a878135b7e222385a565b" ], "author": { "name": "banksean", "email": "banksean@gmail.com", "time": "Mon Jun 23 15:41:26 2025 +0000" }, "committer": { "name": "Autoformatter", "email": "bot@sketch.dev", "time": "Mon Jun 23 16:06:50 2025 +0000" }, "message": "dockerimg: rename ssh_theater to local_sshimmer\n\nCo-Authored-By: sketch \u003chello@sketch.dev\u003e\nChange-ID: s650e5e56560011fak\n" }, { "commit": "ebbdee49d9b9e7d5144a878135b7e222385a565b", "tree": "9c88a791806c9239b4e040a36348e8ff3de3d9e7", "parents": [ "8105fe6bfa914c17c0f474bacdbe9d4c62b6b2b3" ], "author": { "name": "cbro", "email": "cbro@gm.report", "time": "Fri Jun 20 09:57:44 2025 +0000" }, "committer": { "name": "David Crawshaw", "email": "david@zentus.com", "time": "Sun Jun 22 10:17:08 2025 -0700" }, "message": "webui: fix copy button functionality for new branch creation\n\nAdd click handler to copy icon in commit branch containers to enable copying\nbranch names by clicking the icon, not just the branch name text.\n\nCo-Authored-By: sketch \u003chello@sketch.dev\u003e\nChange-ID: saee9afbb466904efk\n" }, { "commit": "8105fe6bfa914c17c0f474bacdbe9d4c62b6b2b3", "tree": "3ba587467d33c5f9ef78ab20fc80a3b64967733b", "parents": [ "dd6352a74f1214035785025df127ed6a0dc73ac6" ], "author": { "name": "Philip Zeyliger", "email": "philip@bold.dev", "time": "Sat Jun 21 21:22:34 2025 -0700" }, "committer": { "name": "Philip Zeyliger", "email": "philip@bold.dev", "time": "Sat Jun 21 21:23:06 2025 -0700" }, "message": "Removing noisy log line.\n" }, { "commit": "dd6352a74f1214035785025df127ed6a0dc73ac6", "tree": "19be1f1d366eeef09ba0eb203163d9de6a7404c8", "parents": [ "23772f43d80fdc3a8f8f1364d7e4aef6fde86a26" ], "author": { "name": "Kilian Lackhove", "email": "kilian@lackhove.de", "time": "Tue Jun 17 22:01:05 2025 +0200" }, "committer": { "name": "David Crawshaw", "email": "david@zentus.com", "time": "Sat Jun 21 18:42:19 2025 -0700" }, "message": "fix docker inspect for podman docker alias\n\n" }, { "commit": "23772f43d80fdc3a8f8f1364d7e4aef6fde86a26", "tree": "7d6bd884e60e5330e2368a42e18c95d32245c0c4", "parents": [ "9ee498c6a621ff7cf5f85429a5f3f25d704f43d9" ], "author": { "name": "Kilian Lackhove", "email": "kilian@lackhove.de", "time": "Wed Jun 18 20:28:58 2025 +0200" }, "committer": { "name": "David Crawshaw", "email": "david@zentus.com", "time": "Sat Jun 21 18:34:01 2025 -0700" }, "message": "support building docker image with gemini\n" }, { "commit": "9ee498c6a621ff7cf5f85429a5f3f25d704f43d9", "tree": "ef4f0fd7d25d5a026a2a3f799bf89ecde8791de5", "parents": [ "afbade271d75493d95faf94609368c891f973829" ], "author": { "name": "David Crawshaw", "email": "david@zentus.com", "time": "Sat Jun 21 18:10:15 2025 -0700" }, "committer": { "name": "David Crawshaw", "email": "david@zentus.com", "time": "Sat Jun 21 18:10:17 2025 -0700" }, "message": ".clabot: add d2orbc\n\nCLA signed.\n" }, { "commit": "afbade271d75493d95faf94609368c891f973829", "tree": "0474ab629a9199d49b242e987b8d6806db1e7cc8", "parents": [ "364b35a411afadef2531d600ca5b0da5d1b25d7f" ], "author": { "name": "David Crawshaw", "email": "david@zentus.com", "time": "Sat Jun 21 17:44:58 2025 -0700" }, "committer": { "name": "David Crawshaw", "email": "david@zentus.com", "time": "Sat Jun 21 17:48:20 2025 -0700" }, "message": ".clabot: add lackhove\n\nCLA signed.\n" }, { "commit": "364b35a411afadef2531d600ca5b0da5d1b25d7f", "tree": "6feb28f2bee414abc51e62ef2ad67ddf94bee44e", "parents": [ "61a0f6758240d318e8d0ae778e2a93ef45a867cf" ], "author": { "name": "Philip Zeyliger", "email": "philip@bold.dev", "time": "Sat Jun 21 16:39:04 2025 -0700" }, "committer": { "name": "Autoformatter", "email": "bot@sketch.dev", "time": "Sat Jun 21 23:39:39 2025 +0000" }, "message": "webui: improve/simplify commit selector in Monaco diff view\n\nThe HTML select\u0027s cant be formatted to show tags nicely, so\ndid a \"custom\" select thing.\n\nFurthermore, I never use the \"to\" thing, so let\u0027s just get rid of\nit, and we\u0027re always going from someplace to someplace.\n\nI don\u0027t love the overflow behavior, but we\u0027ll see how it goes.\n\nCo-Authored-By: sketch \u003chello@sketch.dev\u003e\nChange-ID: s9f70e9aef1fb08c4k\n" }, { "commit": "61a0f6758240d318e8d0ae778e2a93ef45a867cf", "tree": "8b18ef5a7b1b4cb6312136ce25bb3a0f86f84ad7", "parents": [ "3cde282e7b12d14ec27400a2c0f9b167001ed60e" ], "author": { "name": "Philip Zeyliger", "email": "philip@bold.dev", "time": "Sat Jun 21 15:33:18 2025 -0700" }, "committer": { "name": "Autoformatter", "email": "bot@sketch.dev", "time": "Sat Jun 21 22:34:05 2025 +0000" }, "message": "webui: add Jump to Bottom button for mobile and desktop chat views\n\nAdd a floating Jump to Bottom button that appears when users scroll up\nfrom the bottom of chat interfaces, positioned at the boundary between\nchat content and input areas.\n\nCo-Authored-By: sketch \u003chello@sketch.dev\u003e\nChange-ID: sba26f10bfcccf392k\n" }, { "commit": "3cde282e7b12d14ec27400a2c0f9b167001ed60e", "tree": "ae7df9f0552e87ae7aa1c06ceb3210bf7343efcc", "parents": [ "d1832847e9d6566971088d7b1a255487b0ed0e0b" ], "author": { "name": "Philip Zeyliger", "email": "philip@bold.dev", "time": "Sat Jun 21 09:32:38 2025 -0700" }, "committer": { "name": "Autoformatter", "email": "bot@sketch.dev", "time": "Sat Jun 21 16:35:56 2025 +0000" }, "message": "webui: improve comment functionality for Monaco diff editor by using gutter\n\nThis was a bit of a journey. To me, the correct functionality is like\nthe breakpoint setting in VSCode. I had o3 find the relevant code and\ntried to feed it back into Sketch, but it turned out I had to break it\ndown into pieces. (Asking it for the whole thing failed several times.)\nIn the end, I asked Sketch first to add a comment icon in the gutters.\nThis required just the right \"glyphMargin\" settings and finally worked.\nIn the next session, it worked on showing/hiding them depending on where\nyou were hovering. In the one after that, it deleted the old comment box\nfunctionality, and then in the one after that, added that functionality\nback in. And now we\u0027re here, and it seems to work.\n\nCo-Authored-By: sketch \u003chello@sketch.dev\u003e\nChange-ID: sd81ff0507f3398a8k\n" }, { "commit": "d1832847e9d6566971088d7b1a255487b0ed0e0b", "tree": "554760d15b2c1cb04b85eb950641fcebb392e6c7", "parents": [ "cfd0fe64e379f066b117effe84100a38c48e493f" ], "author": { "name": "Sean McCullough", "email": "banksean@gmail.com", "time": "Fri Jun 20 22:42:06 2025 -0400" }, "committer": { "name": "Autoformatter", "email": "bot@sketch.dev", "time": "Sat Jun 21 02:48:15 2025 +0000" }, "message": "fix messages-viewer\n" }, { "commit": "cfd0fe64e379f066b117effe84100a38c48e493f", "tree": "fed8d755bb3a8fffd61f6cd5da706c9267a7c5f3", "parents": [ "c540e8ea6a8dd2a5297345b6f9b885988338f237" ], "author": { "name": "Philip Zeyliger", "email": "philip@bold.dev", "time": "Sat Jun 21 02:17:41 2025 +0000" }, "committer": { "name": "Philip Zeyliger", "email": "philip@bold.dev", "time": "Fri Jun 20 19:21:43 2025 -0700" }, "message": "cleanup: remove unused functions and fix tests\n\nRemove unused Go code identified through systematic analysis:\n\nRemoved Functions:\n- BashRun() in claudetool/bash.go - legacy testing function\n- ContentToString() in claudetool/util.go - unused utility function\n- GetActiveTunnels() in dockerimg/tunnel_manager.go - unused getter method\n\nRemoved Types:\n- baseResponse struct in claudetool/browse/browse.go - unused response type\n\nTest Updates:\n- Replaced BashRun tests with direct Bash.Run calls in bash_test.go\n- Removed ContentToString test from agent_test.go (testing unused function)\n- Updated tunnel manager tests to access internal activeTunnels map directly\n- Fixed all compilation errors caused by removed functions\n\nAll tests now pass and the codebase is cleaner with reduced maintenance burden.\nThe removed functions had no references in production code and were only\nused in tests, which have been updated or removed as appropriate.\n\nCo-Authored-By: sketch \u003chello@sketch.dev\u003e\nChange-ID: s2cac4b024f877682k\n" }, { "commit": "c540e8ea6a8dd2a5297345b6f9b885988338f237", "tree": "fcae305b543bfc26cbee0480d57d0ecd8f628a92", "parents": [ "037f3160b72f05979c02787274b570a92da5a764" ], "author": { "name": "philip.zeyliger", "email": "philip.zeyliger@gmail.com", "time": "Wed Jun 18 21:05:46 2025 +0000" }, "committer": { "name": "Philip Zeyliger", "email": "philip@bold.dev", "time": "Fri Jun 20 19:15:24 2025 -0700" }, "message": "webui: add missing codicon font reference to mobile app shell\n\nThe mobile diff view uses sketch-monaco-view component which requires\nthe codicon font for Monaco editor icons. Added the same @font-face\ndeclaration that exists in sketch-app-shell.css to mobile-app-shell.css.\n\nThis ensures Monaco editor icons display properly in the mobile interface\nwhen viewing diffs, fixing missing codicon glyphs that would otherwise\nappear as empty squares or missing characters.\n\nThe font-face declaration must be in global CSS rather than component-\nscoped styles due to Chrome\u0027s shadow DOM font loading limitations.\n\nCo-Authored-By: sketch \u003chello@sketch.dev\u003e\nChange-ID: secee77cd7912efd9k\n" }, { "commit": "037f3160b72f05979c02787274b570a92da5a764", "tree": "32c824d8bfc2611465acd4b6d5fcf6709becbab4", "parents": [ "be0da4410fc3f9b434ec1fb487bda486278bf524" ], "author": { "name": "Philip Zeyliger", "email": "philip@bold.dev", "time": "Fri Jun 20 22:26:31 2025 +0000" }, "committer": { "name": "Philip Zeyliger", "email": "philip@bold.dev", "time": "Fri Jun 20 18:11:34 2025 -0700" }, "message": "github workflows: add working-directory input parameter\n\nAdd optional working-directory input parameter to both go_test.yml and\nwebui_test.yml workflows with default value of \u0027.\u0027, allowing workflows\nto be run from different subdirectories when needed.\n\nChanges made:\n- go_test.yml: Added working-directory input, updated go.mod path reference,\n added working-directory to Go generate and test steps\n- webui_test.yml: Added working-directory input, updated package-lock.json path,\n updated all webui-related step working directories and artifact path\n\nBoth workflows maintain backward compatibility with default \u0027.\u0027 value while\nenabling flexible directory targeting for workflow reuse.\n\nCo-Authored-By: sketch \u003chello@sketch.dev\u003e\nChange-ID: sbece0e025c355895k\n" }, { "commit": "be0da4410fc3f9b434ec1fb487bda486278bf524", "tree": "eebec953b04474c57c7a5370ce13753ec7de9282", "parents": [ "f0f9af07c40798f6424d428685338fd6fed2ae4c" ], "author": { "name": "Philip Zeyliger", "email": "philip@bold.dev", "time": "Fri Jun 20 15:14:24 2025 -0700" }, "committer": { "name": "Philip Zeyliger", "email": "philip@bold.dev", "time": "Fri Jun 20 18:11:34 2025 -0700" }, "message": "Minor docs change.\n" }, { "commit": "f0f9af07c40798f6424d428685338fd6fed2ae4c", "tree": "ebe89739754a049aa7446ae23d7bb07765ab7e87", "parents": [ "882e7ea7097129ff75e3595b049df585976e12a1" ], "author": { "name": "philip.zeyliger", "email": "philip.zeyliger@gmail.com", "time": "Fri Jun 20 15:29:14 2025 +0000" }, "committer": { "name": "Autoformatter", "email": "bot@sketch.dev", "time": "Fri Jun 20 18:08:22 2025 +0000" }, "message": "webui: remove unused sketch-diff-file-picker component\n\nRemove sketch-diff-file-picker component and all related imports/styles\nas it is no longer needed for multi-file diff view functionality.\n\nRemoved Files:\n- webui/src/web-components/sketch-diff-file-picker.ts (390 lines)\n\nUpdated Files:\n- Remove commented import from sketch-diff2-view.ts\n- Remove unused CSS styles for sketch-diff-file-picker\n- Clean up all references to SketchDiffFilePicker component\n\nThe multi-file diff view now uses a built-in file selector dropdown\ninstead of the separate picker component, simplifying the codebase\nand eliminating unused code.\n\nCo-Authored-By: sketch \u003chello@sketch.dev\u003e\nChange-ID: se8747dd5f2bfc50ak\n" }, { "commit": "882e7ea7097129ff75e3595b049df585976e12a1", "tree": "bdf436800495b973f3b8d808dc4ec9fdc83d4b31", "parents": [ "1f8fe9c0531de311dc3847f766f748da28fc3368" ], "author": { "name": "philip.zeyliger", "email": "philip.zeyliger@gmail.com", "time": "Fri Jun 20 14:31:16 2025 +0000" }, "committer": { "name": "Philip Zeyliger", "email": "philip@bold.dev", "time": "Fri Jun 20 08:21:42 2025 -0700" }, "message": "loop: preserve cumulative usage across conversation compaction\n\nconversation: add optional CumulativeUsage parameter to New function\n\nUpdate CompactConversation to preserve cumulative usage statistics when\nresetting the conversation, preventing usage numbers from being lost during\ncompaction.\n\nCo-Authored-By: sketch \u003chello@sketch.dev\u003e\nChange-ID: s11dcb84790847494k\n" }, { "commit": "1f8fe9c0531de311dc3847f766f748da28fc3368", "tree": "7301725c9d9270c286371790ef399edb0c670d16", "parents": [ "ffa94c65f4b7b3aabb0ecb50dbd9d8c2bfd40da3" ], "author": { "name": "Philip Zeyliger", "email": "philip@bold.dev", "time": "Fri Jun 20 02:56:28 2025 +0000" }, "committer": { "name": "Autoformatter", "email": "bot@sketch.dev", "time": "Fri Jun 20 03:04:47 2025 +0000" }, "message": "webui: fix Monaco editor initialization parentNode errors in diff view\n\nAdd proper Lit component lifecycle validation to ensure Monaco editor container\nis connected to the document before initialization, preventing \u0027undefined parentNode\u0027\nerrors during diff view loading.\n\nThe fix uses await this.updateComplete and validates both component and container\nconnection state, eliminating race conditions between component rendering and\nMonaco API calls without using timeouts or retries.\n\nCo-Authored-By: sketch \u003chello@sketch.dev\u003e\nChange-ID: s85d1738b85a64745k\n" }, { "commit": "ffa94c65f4b7b3aabb0ecb50dbd9d8c2bfd40da3", "tree": "5f677bbf845f2b00777c2b7babe7a7dbacb49b93", "parents": [ "5477736d9678803a245764439df767bf0e7c561d" ], "author": { "name": "philip.zeyliger", "email": "philip.zeyliger@gmail.com", "time": "Thu Jun 19 18:43:37 2025 -0700" }, "committer": { "name": "Autoformatter", "email": "bot@sketch.dev", "time": "Fri Jun 20 01:44:11 2025 +0000" }, "message": "webui: add print styles for full chat printing\n\nImplement CSS print media queries across key webui components to ensure\ncomplete chat conversations can be printed without content truncation.\n\nThey\u0027re not perfect but better than nothing.\n\nCo-Authored-By: sketch \u003chello@sketch.dev\u003e\nChange-ID: s3815b4291912c721k\n" }, { "commit": "5477736d9678803a245764439df767bf0e7c561d", "tree": "887290d2e601739a4bfeae0b4e6638feb8bb393e", "parents": [ "65ff909493e8f27bcdc507ed27253e28c98eb5ec" ], "author": { "name": "banksean", "email": "banksean@gmail.com", "time": "Thu Jun 19 16:38:30 2025 +0000" }, "committer": { "name": "Autoformatter", "email": "bot@sketch.dev", "time": "Thu Jun 19 23:08:56 2025 +0000" }, "message": "webui: implement explicit initial render detection using State.message_count\n\nAdd explicit initial load completion detection to SketchTimeline component using\nState.message_count to determine when all existing messages have been loaded\nand the timeline is ready for initial render.\n\nImplementation Changes:\n\n1. DataManager Enhancement (data.ts):\n - Add expectedMessageCount and isInitialLoadComplete state tracking\n - Add \u0027initialLoadComplete\u0027 event type to DataManagerEventType union\n - Add checkInitialLoadComplete() method to validate completion state\n - Add handleInitialLoadComplete() event emission with message counts\n - Handle empty conversation edge case (message_count: 0) with immediate completion\n - Reset initial load state on connection establishment to handle reconnection\n - Add getIsInitialLoadComplete() and getExpectedMessageCount() getters\n\n2. Timeline Component Enhancement (sketch-timeline.ts):\n - Add isInitialLoadComplete state property for render control\n - Add dataManager property reference for event listener setup\n - Add handleInitialLoadComplete() event handler with console logging\n - Update render logic to show loading indicator until initial load complete\n - Apply \u0027view-initialized\u0027 CSS class when initial load completes\n - Only render messages and thinking indicator after initial load completion\n - Set up DataManager event listeners in updated() lifecycle hook\n - Clean up event listeners in disconnectedCallback() lifecycle hook\n\n3. App Shell Integration (sketch-app-shell.ts):\n - Pass dataManager reference to sketch-timeline component property\n - Enable timeline component to receive initial load completion events\n - Maintain existing data flow while adding explicit completion detection\n\n4. Demo Mock Enhancement (handlers.ts):\n - Initialize currentState with correct message_count based on initial messages\n - Ensure proper message_count synchronization in SSE stream simulation\n - Handle empty conversation demo scenario with accurate state\n\n5. Enhanced CSS Styling (sketch-timeline.ts):\n - Add opacity-based transitions for message appearance\n - Show loading indicator before initial completion\n - Hide message content until view-initialized class is applied\n - Smooth transition from loading to content display\n\nTechnical Benefits:\n- Eliminates reliance on implicit \u0027first message means streaming started\u0027 detection\n- Provides explicit completion signal when all existing messages are loaded\n- Handles edge cases like empty conversations (0 messages) immediately\n- Prevents flash of incomplete content during initial load\n- Enables proper loading states and smooth transitions\n- Supports reconnection scenarios with state reset\n\nUser Experience Improvements:\n- Clear loading indicator until conversation is fully loaded\n- Smooth transition from loading to content display\n- No flash of partial message lists during initial load\n- Consistent behavior across different conversation sizes\n- Better feedback during network delays or large conversation loads\n\nEdge Case Handling:\n- Empty conversations (message_count: 0) marked complete immediately\n- Messages arriving before state handled gracefully\n- Reconnection scenarios reset initial load detection\n- Race conditions between state and message delivery resolved\n\nThis replaces the implicit initial load detection with explicit State.message_count\nbased completion detection, providing more reliable initial render timing and\nbetter user experience during conversation loading.\n\nCo-Authored-By: sketch \u003chello@sketch.dev\u003e\nChange-ID: s5126c2705d6ad6bak\n" }, { "commit": "65ff909493e8f27bcdc507ed27253e28c98eb5ec", "tree": "c5c8eb1dc785f62fa5b3843fcc3ff653200cce59", "parents": [ "b774437ff57fb95b14d326cc6be2c9937bdb6a78" ], "author": { "name": "banksean", "email": "banksean@gmail.com", "time": "Thu Jun 19 00:36:25 2025 +0000" }, "committer": { "name": "Sean McCullough", "email": "banksean@gmail.com", "time": "Wed Jun 18 21:22:21 2025 -0400" }, "message": "webui: preserve chat scroll position when switching tabs\n\nFix scroll position preservation in SketchAppShell to maintain chat timeline\nscroll position when navigating between tabs, preventing automatic scroll\nto top when returning to the chat view.\n\nImplementation Changes:\n\n1. Scroll Position Storage:\n - Add _chatScrollPosition state property to track chat scroll position\n - Store scroll position when leaving chat view in toggleViewMode()\n - Only store position if content is scrollable and user has actually scrolled\n - Validate scrollHeight \u003e clientHeight and scrollTop \u003e 0 before storing\n\n2. Scroll Position Restoration:\n - Restore scroll position when returning to chat view\n - Use requestAnimationFrame to ensure DOM is ready before restoration\n - Add safety checks to verify view mode and container connection\n - Validate container is still connected before applying scroll position\n\n3. Smart Reset Logic:\n - Reset stored scroll position when new messages arrive and user is near bottom\n - Check if user is within 50px of bottom (isNearBottom) before resetting\n - Allow timeline auto-scroll behavior for new messages when user is following\n - Preserve position when user has scrolled up to read older messages\n\n4. Defensive Programming:\n - Add comprehensive validation for scroll container existence\n - Check scrollHeight, clientHeight, and scrollTop before calculations\n - Validate viewMode matches expected state during restoration\n - Ensure container.isConnected before DOM manipulation\n\nTechnical Details:\n- Uses existing scrollContainerRef for scroll container access\n- Maintains compatibility with existing scroll behavior in sketch-timeline\n- Preserves timeline auto-scroll for new messages when user is at bottom\n- Only stores meaningful scroll positions (not zero or invalid values)\n- Handles edge cases like rapid tab switching or container changes\n\nUser Experience:\n- Chat tab now remembers scroll position when switching to diff/terminal tabs\n- Reading older messages no longer interrupted by tab navigation\n- New messages still auto-scroll when user is following conversation\n- Smooth restoration without visible jumps or layout shifts\n\nThis resolves the issue where the chat timeline would always scroll to the\noldest message when navigating back from other tabs, significantly improving\nthe user experience when reviewing conversation history.\n\nCo-Authored-By: sketch \u003chello@sketch.dev\u003e\nChange-ID: s3a52c0413098ade3k\n" }, { "commit": "b774437ff57fb95b14d326cc6be2c9937bdb6a78", "tree": "43fde963077252de8c57e3bcf4957aae70431e25", "parents": [ "e68613d5105c86652d5287102e1bd4ad0859b781" ], "author": { "name": "Sean McCullough", "email": "banksean@gmail.com", "time": "Thu Jun 19 00:01:07 2025 +0000" }, "committer": { "name": "Autoformatter", "email": "bot@sketch.dev", "time": "Thu Jun 19 00:32:20 2025 +0000" }, "message": "webui: add comprehensive unit tests for sketch-timeline incremental rendering\n\nCreate sketch-timeline.test.ts with comprehensive unit tests covering all major\nincremental rendering features and viewport management functionality.\n\nTest Categories:\n\n1. Basic Rendering Tests:\n - Empty state rendering with welcome box\n - Message rendering with timeline-message components\n - Thinking indicator display during agent activity\n - Message filtering (hide_output flag handling)\n\n2. Viewport Management Tests:\n - Initial message count limiting (initialMessageCount property)\n - Viewport expansion with loadChunkSize increments\n - resetViewport method functionality\n - Most recent message display prioritization\n\n3. Scroll State Management Tests:\n - Jump-to-latest button visibility based on scroll state\n - Button click triggering scroll-to-bottom functionality\n - Scroll state transitions (pinToLatest vs floating)\n\n4. Loading State Tests:\n - Loading indicator display during older message fetching\n - Loading indicator hiding when not in loading state\n - Loading spinner and text rendering\n\n5. Memory Management Tests:\n - Scroll container change handling with proper cleanup\n - Event listener management across container transitions\n - Loading operation cancellation on viewport reset\n\n6. Message Handling Tests:\n - Message ordering (chronological display)\n - Previous message context passing\n - Message array updates and re-rendering\n - Edge cases with empty filtered messages\n\n7. Event Handling Tests:\n - show-commit-diff event bubbling from message components\n - Custom event dispatching and detail handling\n\n8. Utility Function Tests:\n - messageKey method for unique message identification\n - Key generation with tool_calls consideration\n\nTechnical Implementation:\n- Uses @sand4rt/experimental-ct-web testing framework\n- Implements proper TypeScript types and component mounting\n- Creates comprehensive mock message factory functions\n- Uses component.evaluate() for internal state access and method calls\n- Includes proper cleanup and error handling patterns\n- Declares global window interface extensions for test utilities\n\nTest Coverage:\n- 25+ test cases covering all major incremental rendering features\n- Skips complex async operations that require integration testing\n- Focuses on state management, rendering logic, and event handling\n- Validates viewport calculation mathematics and edge cases\n\nThis provides thorough test coverage for the incremental rendering functionality\nwhile maintaining compatibility with the existing test infrastructure and\nensuring reliable behavior across all viewport management scenarios.\n\nCo-Authored-By: sketch \u003chello@sketch.dev\u003e\nChange-ID: s2da61be85adaca75k\n\nwebui: remove empty placeholder tests from sketch-timeline.test.ts\n\nRemove two skipped test placeholders that contained only comments:\n- \u0027handles scroll events correctly\u0027\n- \u0027performs loading operations with proper race condition prevention\u0027\n\nThese placeholder tests provided no value and the functionality they referenced\nis already covered by the interactive demo and other existing tests.\n\nCo-Authored-By: sketch \u003chello@sketch.dev\u003e\nChange-ID: s0119049ed970c057k\n\nwebui: fix TypeScript error in sketch-timeline test tool_calls structure\n\nFix ToolCall interface mismatch in messageKey test by using correct properties:\n- Replace incorrect \u0027type\u0027 and \u0027function\u0027 properties with \u0027name\u0027 and \u0027input\u0027\n- Add proper \u0027result_message\u0027 as AgentMessage instead of string\n- Ensure tool_calls array matches actual ToolCall interface from types.ts\n\nThis resolves the TypeScript compilation error:\n\u0027Type string is not assignable to type AgentMessage\u0027\n\nCo-Authored-By: sketch \u003chello@sketch.dev\u003e\nChange-ID: s8570c39653681f17k\n\nwebui: fix test failures in sketch-timeline.test.ts\n\nFix 4 failing test cases with proper Playwright test patterns:\n\n1. filters out messages with hide_output flag:\n - Replace problematic not.toContainText() on multiple elements\n - Use individual textContent() checks to verify hidden message exclusion\n - Check each visible message individually instead of using strict mode violation\n\n2. jump-to-latest button calls scroll method:\n - Fix window object type casting with (window as any)\n - Ensure scrollCalled property is properly set and retrieved\n\n3. handles scroll container changes properly:\n - Move mock container creation inside evaluate() to avoid serialization issues\n - Use window object to track addEventListener/removeEventListener calls\n - Initialize counters properly and retrieve them after operations\n\n4. handles empty filteredMessages gracefully:\n - Expect .timeline-container instead of .welcome-box for hidden messages\n - Welcome box only shows when messages array is completely empty\n - Hidden messages still render timeline container, just with no message elements\n\nThese fixes address Playwright\u0027s strict mode requirements and proper async\noperation handling in component tests.\n\nCo-Authored-By: sketch \u003chello@sketch.dev\u003e\nChange-ID: s30192a1528e84a61k\n\nwebui: fix remaining test failures in sketch-timeline.test.ts\n\nFix the last 2 failing test cases:\n\n1. jump-to-latest button calls scroll method:\n - Initialize scrollCalled flag to false before mocking\n - Combine all setup operations in single evaluate() call\n - Add verification that button is visible before clicking\n - Ensure proper order of mock setup and button interaction\n\n2. handles empty filteredMessages gracefully:\n - Correct test expectations to match actual component behavior\n - Component only shows welcome box when messages.length \u003d\u003d\u003d 0\n - Hidden messages (hide_output: true) still render timeline structure\n - Use toBeAttached() instead of toBeVisible() for timeline container\n - Timeline container may be CSS hidden but still attached to DOM\n\nThese fixes address the remaining Playwright test failures by properly\nunderstanding the component\u0027s conditional rendering logic and ensuring\nproper test setup order for async operations.\n\nCo-Authored-By: sketch \u003chello@sketch.dev\u003e\nChange-ID: s7fecd7e2c7824913k\n" }, { "commit": "e68613d5105c86652d5287102e1bd4ad0859b781", "tree": "ed2b409f2c3649ae0afc14cc3df31c89382106eb", "parents": [ "e0a9f7252a39c66ffa409daa9fd0ac5c6b08a100" ], "author": { "name": "Sean McCullough", "email": "banksean@gmail.com", "time": "Wed Jun 18 14:48:53 2025 +0000" }, "committer": { "name": "Autoformatter", "email": "bot@sketch.dev", "time": "Wed Jun 18 23:44:00 2025 +0000" }, "message": "webui: implement viewport-based message rendering in sketch-timeline\n\nAdd viewport-based rendering to SketchTimeline component to optimize performance\nwith large conversation histories by only rendering messages in current viewport.\n\nImplementation Changes:\n\n1. Viewport Management:\n - Add initialMessageCount property (default: 30) to control initial render\n - Add loadChunkSize property (default: 20) for batch loading older messages\n - Add visibleMessageStartIndex state to track current viewport window\n - Add isLoadingOlderMessages state to prevent concurrent load operations\n\n2. Message Filtering and Windowing:\n - Create filteredMessages getter to exclude hidden messages\n - Create visibleMessages getter to return current viewport slice\n - Implement loadOlderMessages() to expand viewport window on scroll\n - Preserve scroll position when prepending older messages\n\n3. Scroll-Based Loading:\n - Add loadMoreThreshold property (100px from top) for trigger distance\n - Enhance _handleScroll() to detect near-top scroll and trigger loading\n - Add loading indicator with spinner for older message loading states\n - Maintain existing \u0027pinToLatest\u0027 and \u0027floating\u0027 scroll behaviors\n\n4. Updated Rendering Logic:\n - Replace direct messages.filter() with visibleMessages getter\n - Add loading indicator rendering above message list\n - Preserve message key generation for efficient re-rendering\n - Maintain proper previousMessage calculation for filtered messages\n\n5. Lifecycle Management:\n - Reset viewport window on significant message changes\n - Preserve scroll-to-bottom behavior for new messages\n - Handle edge cases for empty messages and initial load states\n\nTechnical Details:\n- Uses slice-based windowing instead of full virtual scrolling for simplicity\n- Implements scroll position preservation using scrollHeight differences\n- Maintains efficient message key generation for Lit\u0027s repeat directive\n- Preserves all existing timeline functionality and styling\n- Loading indicator appears only during older message fetching operations\n\nBenefits:\n- Significant performance improvement for large conversation histories\n- Reduced initial render time by limiting message count\n- Progressive loading maintains responsive UI during scroll\n- Maintains existing scroll behaviors and user experience\n- Memory usage scales with viewport size rather than total messages\n\nThis implements the requested viewport-based rendering while preserving all\nexisting SketchTimeline functionality and user experience patterns.\n\nCo-Authored-By: sketch \u003chello@sketch.dev\u003e\nChange-ID: sbe64498bdb5fd1cck\n\nwebui: fix viewport rendering to always show most recent messages initially\n\nFix viewport calculation logic in SketchTimeline to ensure the most recent\nmessages are always displayed on initial load, addressing issue where first\nmessages were shown instead of latest ones.\n\nRoot Cause:\nThe original viewport calculation used subtraction logic that was prone to\nshowing older messages when the viewport state wasn\u0027t properly initialized\nor when messages loaded incrementally.\n\nImplementation Changes:\n\n1. Simplified Viewport Logic:\n - Replace complex subtraction-based calculation with direct slice approach\n - Use \u0027totalVisible \u003d initialMessageCount + visibleMessageStartIndex\u0027\n - Calculate startIndex as \u0027max(0, filteredMessages.length - totalVisible)\u0027\n - Always slice from startIndex to end to show most recent messages\n\n2. Enhanced Viewport Reset Logic:\n - Trigger viewport reset for large message count changes (\u003e20 difference)\n - Reset viewport on initial load (oldMessages.length \u003d\u003d\u003d 0)\n - Reset viewport when message count decreases (session change)\n\n3. Added Public Reset Method:\n - Add resetViewport() public method for external viewport reset\n - Useful for app shell to call when loading new sessions\n - Updated demo to demonstrate manual viewport reset\n\n4. Improved Demo:\n - Add expected message range display in demo info\n - Add viewport reset button for testing\n - Call resetViewport() on message generation for consistent behavior\n\nTechnical Details:\n- Viewport now correctly shows messages [N-30, N] initially for N total messages\n- Scroll-up loading expands to show [N-30-X, N] where X is loaded chunk size\n- Eliminates race conditions between message loading and viewport calculation\n- Maintains all existing scroll behaviors and performance optimizations\n\nThis ensures users always see the most recent conversation content when\nloading sessions with large message histories, matching expected chat UX.\n\nCo-Authored-By: sketch \u003chello@sketch.dev\u003e\nChange-ID: s56dda43278ce4d5bk\n\nwebui: fix scroll container height and demo setup for viewport rendering\n\nFix scroll container CSS and demo JavaScript to enable proper scrolling and\nviewport testing in the sketch-timeline component.\n\nCSS Fix:\n- Add \u0027height: 100%\u0027 to #scroll-container to properly constrain container height\n- Enables overflow scrolling when content exceeds available space\n- Fixes issue where scrollHeight \u003d\u003d\u003d clientHeight prevented scrolling\n\nDemo Setup Fix:\n- Correct scrollContainer property setup using shadow DOM reference\n- Wait for component render before setting scroll container reference\n- Use proper Lit Ref pattern: { value: scrollContainerElement }\n- Add console logging for debugging scroll container setup\n\nTesting Results:\n- Viewport rendering now works correctly with 500+ messages\n- Initial load shows most recent 20 messages (e.g., 481-500 for 500 total)\n- Scroll-up loading successfully expands viewport (20 → 30 → 40 messages)\n- Proper scroll position preservation when loading older messages\n- Jump-to-latest button appears when not pinned to bottom\n\nThis fixes the demo functionality and confirms viewport rendering works as\ndesigned for performance optimization with large conversation histories.\n\nCo-Authored-By: sketch \u003chello@sketch.dev\u003e\nChange-ID: s998bb29cf9f06291k\n\nwebui: eliminate setTimeout in viewport demo for reliable initialization\n\nReplace setTimeout-based initialization with proper event-driven setup using\nMutationObserver and Lit\u0027s updateComplete promise for robust demo functionality.\n\nProblems with setTimeout Approach:\n- Race conditions between component rendering and scroll setup\n- Arbitrary delays cause flakiness in different environments\n- No guarantee that shadow DOM or scroll container exists after timeout\n- Unreliable for automated testing or slower systems\n\nImproved Event-Driven Approach:\n\n1. MutationObserver Pattern:\n - Watch for shadow DOM creation using MutationObserver\n - Disconnect observer once shadow DOM is detected\n - Eliminates timing-based guesswork\n\n2. Lit updateComplete Promise:\n - Use timeline.updateComplete to ensure full component render\n - Promise-based approach guarantees completion before setup\n - Handles both initial render and re-renders reliably\n\n3. Robust Fallback Strategy:\n - Try immediate setup first (component may already be ready)\n - Use MutationObserver for shadow DOM detection\n - Apply updateComplete promise for render completion\n - Multiple strategies ensure setup works in all scenarios\n\n4. Promise-Based Message Generation:\n - Use updateComplete in generateMessages() for reliable info updates\n - Ensure scroll container setup after each message array change\n - Eliminates race between message updates and UI state\n\nTesting Results:\n- Reliable setup across page reloads and component re-initialization\n- Consistent scroll container configuration without timing issues\n- Proper viewport loading functionality (20→30 messages on scroll up)\n- No console errors or failed setup attempts\n\nThis eliminates demo flakiness and provides a robust example of proper\nLit component initialization patterns for complex shadow DOM interactions.\n\nCo-Authored-By: sketch \u003chello@sketch.dev\u003e\nChange-ID: s6b897544f3af8454k\n\nwebui: fix memory leaks and race conditions in sketch-timeline scroll handling\n\nImplement proper event listener cleanup and debounced scroll handling to prevent\nmemory leaks and race conditions in SketchTimeline incremental rendering.\n\nMemory Leak Fixes:\n\n1. Scroll Container Tracking:\n - Add currentScrollContainer property to track active scroll listener\n - Implement addScrollListener() with automatic cleanup of previous listeners\n - Implement removeScrollListener() with guaranteed cleanup\n - Replace fragile scrollContainer.value?.removeEventListener with tracked cleanup\n\n2. Event Listener Lifecycle:\n - Ensure proper cleanup in disconnectedCallback() using removeScrollListener()\n - Handle scrollContainer property changes with proper cleanup sequence\n - Add scroll timeout cleanup to prevent lingering timers\n - Track and clean up scroll container references to prevent stale listeners\n\nRace Condition Prevention:\n\n3. Debounced Scroll Handling:\n - Add scrollTimeout property to debounce scroll events\n - Implement 100ms debounce for loadOlderMessages() calls\n - Maintain immediate scroll state updates for responsive UI\n - Clear pending timeouts during cleanup to prevent memory leaks\n\n4. Loading State Protection:\n - Add comprehensive error handling in loadOlderMessages()\n - Implement 5-second timeout fallback to prevent stuck loading state\n - Add bounds checking for visibleMessageStartIndex calculation\n - Use try-catch blocks for scroll position restoration\n\n5. Robust Error Recovery:\n - Check container.isConnected before DOM manipulation\n - Add fallback timeout to reset loading state if updateComplete fails\n - Log warnings for debugging without breaking functionality\n - Ensure isLoadingOlderMessages always gets reset\n\nTechnical Implementation:\n- Uses proper TypeScript typing with HTMLElement | null for container tracking\n- Implements window.setTimeout for proper timeout management\n- Maintains all existing scroll behavior while preventing memory leaks\n- Preserves scroll position restoration with error recovery\n- Compatible with existing viewport rendering functionality\n\nTesting:\n- Add testMemoryLeakFix() function to viewport demo for validation\n- Verify cleanup happens correctly during scroll container changes\n- Confirm no lingering event listeners after component disconnection\n- Test loading state timeout recovery mechanisms\n\nThis resolves the critical memory leak issues identified in the timeline\ncomponent while maintaining all existing functionality and user experience.\n\nCo-Authored-By: sketch \u003chello@sketch.dev\u003e\nChange-ID: seb56a936de452cefk\n\nwebui: enhance memory leak test in timeline viewport demo\n\nAdd comprehensive test for scroll event listener cleanup validation with\nimproved logging and multiple cleanup scenarios for testing memory leak fixes.\n\nCo-Authored-By: sketch \u003chello@sketch.dev\u003e\nChange-ID: sd1928398dca67ad9k\n\nwebui: eliminate race conditions in sketch-timeline scroll handling and loading operations\n\nImplement comprehensive race condition prevention in SketchTimeline incremental\nrendering with async loading operations and proper state management.\n\nRace Condition Fixes:\n\n1. Async Loading Operations:\n - Convert loadOlderMessages() to async/await pattern for proper sequencing\n - Add currentLoadingOperation tracking to prevent concurrent loads\n - Implement executeScrollPositionRestoration() with proper error handling\n - Use Promise-based DOM update waiting instead of fire-and-forget callbacks\n\n2. Loading State Management:\n - Add cancelCurrentLoadingOperation() method for safe operation cancellation\n - Implement clearAllPendingOperations() to clean up all timeouts and operations\n - Add loadingTimeoutId tracking for proper timeout cleanup\n - Add pendingScrollRestoration tracking for cancellable scroll operations\n\n3. Scroll Container Validation:\n - Add isStableForLoading() method to validate component state before operations\n - Verify scroll container hasn\u0027t changed during async operations\n - Check container.isConnected before DOM manipulation\n - Validate container matches currentScrollContainer throughout operation lifecycle\n\n4. Property Change Coordination:\n - Cancel loading operations when scrollContainer property changes\n - Cancel operations during significant message array changes\n - Handle viewport resets during loading with proper state cleanup\n - Prevent scroll-to-bottom during loading operations to avoid conflicts\n\n5. Enhanced Scroll Position Restoration:\n - Add comprehensive validation for scroll calculations before applying\n - Implement bounds checking for scroll position values\n - Add debug logging for invalid restoration attempts\n - Ensure restoration only happens if calculations are mathematically valid\n\n6. Component Lifecycle Protection:\n - Cancel loading operations in disconnectedCallback() before cleanup\n - Handle rapid property changes without state corruption\n - Prevent operations on disconnected or invalid containers\n - Ensure all timeouts and promises are cleaned up during disconnection\n\nTechnical Implementation:\n- Uses async/await throughout loading pipeline for proper sequencing\n- Implements operation cancellation with proper cleanup guarantees\n- Added container stability checks before all DOM operations\n- Uses typed Promise returns for better error handling\n- Maintains backward compatibility with existing scroll behavior\n\nTesting Enhancements:\n- Add testRaceConditions() function to demo for validation\n- Test rapid viewport resets, container changes, and message updates\n- Verify graceful handling of component state changes during loading\n- Validate proper cleanup during simulated disconnection scenarios\n\nBenefits:\n- Eliminates concurrent loading operations that could corrupt state\n- Prevents scroll position restoration conflicts and invalid calculations\n- Ensures consistent component state during rapid user interactions\n- Provides robust error recovery for all async operations\n- Maintains responsive UI while preventing race-related bugs\n\nThis resolves all identified race conditions while preserving existing\nfunctionality and improving overall component reliability and performance.\n\nCo-Authored-By: sketch \u003chello@sketch.dev\u003e\nChange-ID: sc0c567cfff13ae3fk\n\nwebui: replace setTimeout with event-driven patterns in sketch-timeline\n\nEliminate setTimeout dependencies in favor of proper event-driven and async/await\npatterns for more reliable and performant timeline operations.\n\nEvent-Driven Replacements:\n\n1. Scroll Debouncing:\n - Replace setTimeout-based debouncing with requestAnimationFrame\n - Use scrollDebounceFrame with cancelAnimationFrame for smooth performance\n - Eliminate arbitrary 100ms delays in favor of browser-optimized frame timing\n - Maintain responsive UI updates while preventing excessive loading calls\n\n2. Loading Operation Management:\n - Replace setTimeout fallback with AbortController for proper cancellation\n - Add loadingAbortController for clean operation abortion\n - Implement signal-based cancellation throughout loading pipeline\n - Remove 5-second timeout fallback in favor of proper Promise rejection handling\n\n3. Scroll Position Restoration:\n - Replace setTimeout retry logic with ResizeObserver-based content detection\n - Add waitForContentReady() using ResizeObserver to detect when DOM is ready\n - Use requestAnimationFrame for frame-perfect scroll position updates\n - Eliminate arbitrary delays and retry intervals\n\n4. Auto-Scroll to Bottom:\n - Replace setTimeout-based retry with MutationObserver approach\n - Use scrollToBottomWithRetry() with event-driven content change detection\n - Implement requestAnimationFrame for smooth scroll operations\n - Remove hardcoded retry intervals and attempt limits\n\n5. Component Lifecycle:\n - Add disconnectObservers() for proper cleanup of ResizeObserver and MutationObserver\n - Replace clearTimeout calls with cancelAnimationFrame and AbortController.abort()\n - Ensure all async operations can be properly cancelled during component lifecycle\n\nTechnical Benefits:\n- Uses browser-native APIs (ResizeObserver, MutationObserver, AbortController)\n- Eliminates race conditions from setTimeout timing assumptions\n- Provides frame-perfect animations with requestAnimationFrame\n- Enables proper cancellation of async operations with AbortController\n- Reduces arbitrary delays and improves perceived performance\n\nImplementation Details:\n- AbortController provides clean cancellation semantics for loading operations\n- ResizeObserver detects content changes without polling or timeouts\n- MutationObserver monitors DOM changes for scroll position adjustments\n- requestAnimationFrame ensures operations happen at optimal frame timing\n- All observers are created on-demand and properly cleaned up\n\nTesting Enhancements:\n- Add testEventDriven() function to validate no setTimeout usage\n- Test AbortController availability and proper operation cancellation\n- Verify ResizeObserver, MutationObserver, and requestAnimationFrame support\n- Monitor setTimeout calls during operations to ensure elimination\n\nThis modernizes the timeline component to use proper browser APIs instead of\nsetTimeout workarounds, improving reliability and performance while eliminating\ntiming-based race conditions.\n\nCo-Authored-By: sketch \u003chello@sketch.dev\u003e\nChange-ID: se869d73b455454a5k\n" }, { "commit": "e0a9f7252a39c66ffa409daa9fd0ac5c6b08a100", "tree": "163959dfbb33e0341b40750bff5a738ad569089c", "parents": [ "a7e7fb62140c4af5ef8b194d8c84f1e791dea2ca" ], "author": { "name": "Philip Zeyliger", "email": "philip@bold.dev", "time": "Wed Jun 18 13:11:24 2025 -0700" }, "committer": { "name": "Philip Zeyliger", "email": "philip@bold.dev", "time": "Wed Jun 18 13:11:24 2025 -0700" }, "message": "test_recipes: add Docker and gvisor installation guide\n\nAdd comprehensive installation instructions for Docker and gvisor on SSH hosts\nto enable self-testing of Sketch.\n\nCo-Authored-By: sketch \u003chello@sketch.dev\u003e\nChange-ID: scf7cbfd6f14c6445k\n" }, { "commit": "a7e7fb62140c4af5ef8b194d8c84f1e791dea2ca", "tree": "07bfaeb6dfbdea294f5f1f30590e334e718e9249", "parents": [ "e08609352271d61acb57774cdbfa91f1d35b1931" ], "author": { "name": "Philip Zeyliger", "email": "philip@bold.dev", "time": "Tue Jun 17 19:28:12 2025 -0700" }, "committer": { "name": "Philip Zeyliger", "email": "philip@bold.dev", "time": "Wed Jun 18 13:08:36 2025 -0700" }, "message": "Sketch: test thyself\n" }, { "commit": "e08609352271d61acb57774cdbfa91f1d35b1931", "tree": "d2d0609057422a33579552a8a191c179158a0050", "parents": [ "963ae4b514ed20fc84c63c4cc6de028a99964448" ], "author": { "name": "Philip Zeyliger", "email": "philip@bold.dev", "time": "Wed Jun 18 13:01:17 2025 -0700" }, "committer": { "name": "Philip Zeyliger", "email": "philip@bold.dev", "time": "Wed Jun 18 13:01:17 2025 -0700" }, "message": "Re-enable monaco horizontal scroll bars.\n\nLike all things LLM and Monaco, the key here is to delete things\nthat aren\u0027t default until things get better. The scrollbars don\u0027t\nshow up because they aren\u0027t necessary, and, when the horizontal\nones are necessary, they now show up.\n\nI\u0027m still seeing two bugs:\n\n1. If you click into the diff the first time on some line, especially\nif it\u0027s the second diff block, Monaco jumps to a different area. This\nis kind of terrible and annoying.\n\n2. My touchpad should let me scroll right/left as well as vertical, but\nI\u0027m only getting vertical scrolling in this mode.\n" }, { "commit": "963ae4b514ed20fc84c63c4cc6de028a99964448", "tree": "efae6465ae384ab5f26f01fafcac5e3ed7986504", "parents": [ "2e3337d7127d24e2d22fde945de32c9a35fbb3f0" ], "author": { "name": "Philip Zeyliger", "email": "philip@bold.dev", "time": "Wed Jun 18 12:08:25 2025 -0700" }, "committer": { "name": "Philip Zeyliger", "email": "philip@bold.dev", "time": "Wed Jun 18 12:08:25 2025 -0700" }, "message": "scripts: disable man-db auto-update in apt optimization script\n\nCo-Authored-By: sketch \u003chello@sketch.dev\u003e\nChange-ID: s5c0fd4b08cea2be8k\n" }, { "commit": "2e3337d7127d24e2d22fde945de32c9a35fbb3f0", "tree": "03feb48b8ee8d00d259420db70745ce9108f923e", "parents": [ "0258add1c3e5858635a4286f3e308e32132f828a" ], "author": { "name": "David Crawshaw", "email": "david@zentus.com", "time": "Wed Jun 18 10:33:41 2025 -0700" }, "committer": { "name": "David Crawshaw", "email": "david@zentus.com", "time": "Wed Jun 18 10:38:16 2025 -0700" }, "message": "loop: add docker to the system prompt\n" }, { "commit": "0258add1c3e5858635a4286f3e308e32132f828a", "tree": "26e92d1a0e01e469aebcc4b7f1957ff6e71227af", "parents": [ "57162e0bd03c33b5201822a7038c71aafe3a12c8" ], "author": { "name": "David Crawshaw", "email": "david@zentus.com", "time": "Wed Jun 18 09:26:09 2025 -0700" }, "committer": { "name": "David Crawshaw", "email": "david@zentus.com", "time": "Wed Jun 18 10:37:26 2025 -0700" }, "message": "dockerimg: add docker to the sketch image\n" }, { "commit": "57162e0bd03c33b5201822a7038c71aafe3a12c8", "tree": "161c11f9782e3a0ab64e3e2b74ff6de9a41eea7c", "parents": [ "92dcbf56f0de92f99391f560b67a75d4a654e6fe" ], "author": { "name": "philip.zeyliger", "email": "philip.zeyliger@gmail.com", "time": "Wed Jun 18 09:59:48 2025 -0700" }, "committer": { "name": "Philip Zeyliger", "email": "philip@bold.dev", "time": "Wed Jun 18 09:59:48 2025 -0700" }, "message": "codereview: add 1-minute timeout parameter with context propagation\n\nUsers and I have seen codereview hanging. I think giving it one\nminute is better than nothing.\n\nCo-Authored-By: sketch \u003chello@sketch.dev\u003e\nChange-ID: s32c0166e97ef0effk\n" }, { "commit": "92dcbf56f0de92f99391f560b67a75d4a654e6fe", "tree": "ae0622fee50825a89147dc5c4efd6ab232d315db", "parents": [ "d5c8d71adfec8b8cb5aa15c7ce74da19c697191f" ], "author": { "name": "philip.zeyliger", "email": "philip.zeyliger@gmail.com", "time": "Tue Jun 17 16:10:57 2025 -0700" }, "committer": { "name": "Philip Zeyliger", "email": "philip@bold.dev", "time": "Tue Jun 17 16:10:57 2025 -0700" }, "message": "cmd: add -ska-band-addr as alias for -skaband-addr flag\n\nAdd -ska-band-addr as a command-line flag alias for the existing -skaband-addr\nflag to provide a more convenient option with consistent hyphenation.\n\nBoth flags set the same underlying variable and work identically, with the\nnew alias including descriptive help text indicating it\u0027s an alias for the\noriginal flag. When both flags are provided, the last one takes precedence\nfollowing standard command-line flag behavior.\n\nCo-Authored-By: sketch \u003chello@sketch.dev\u003e\nChange-ID: sb035682896d54335k\n" }, { "commit": "d5c8d71adfec8b8cb5aa15c7ce74da19c697191f", "tree": "3875d82cf3791db0c49c160455616eeaafe208ea", "parents": [ "2343f8a73cb0a5a846a4f44075d8e039daac7816" ], "author": { "name": "Philip Zeyliger", "email": "philip@bold.dev", "time": "Tue Jun 17 15:19:45 2025 -0700" }, "committer": { "name": "Autoformatter", "email": "bot@sketch.dev", "time": "Tue Jun 17 22:21:57 2025 +0000" }, "message": "loop: avoid deadlock when pushing to a checked out branch\n\nSketch did a good job with this:\n\nThe Problem 🐛\nIn AgentGitState.handleGitCommits(), there was a double-locking scenario:\n\nMethod acquires mutex lock\nDuring git push retry logic, calls IncrementRetryNumber()\nIncrementRetryNumber() tries to acquire the same mutex again\nDeadlock - thread hangs forever waiting for a lock it already holds\n\nCo-Authored-By: sketch \u003chello@sketch.dev\u003e\nChange-ID: sfe0bcab73addc32ak\n" }, { "commit": "2343f8a73cb0a5a846a4f44075d8e039daac7816", "tree": "8f523dd283895b1d6dfd98ff7f683ee337df13f4", "parents": [ "f964b50b76225e209dfb940b7c6d2f737939510a" ], "author": { "name": "Philip Zeyliger", "email": "philip@bold.dev", "time": "Tue Jun 17 06:16:19 2025 -0700" }, "committer": { "name": "Autoformatter", "email": "bot@sketch.dev", "time": "Tue Jun 17 13:17:14 2025 +0000" }, "message": "dockerimg: fix Docker image reuse for Dockerfile.sketch\n\nAdd sketch_context label to Docker images built from Dockerfile.sketch to enable\nproper image reuse detection across runs, eliminating unnecessary rebuilds.\n\nCo-Authored-By: sketch \u003chello@sketch.dev\u003e\nChange-ID: sfa4d61590e7e00f9k\n" }, { "commit": "f964b50b76225e209dfb940b7c6d2f737939510a", "tree": "3412b5ec743551be03f69ffc553ee1393da43c52", "parents": [ "28e39ac7817834d258a0f75a33b4590c769cb1bc" ], "author": { "name": "Autoformatter", "email": "bot@sketch.dev", "time": "Tue Jun 17 04:30:35 2025 +0000" }, "committer": { "name": "Autoformatter", "email": "bot@sketch.dev", "time": "Tue Jun 17 04:30:35 2025 +0000" }, "message": "all: fix formatting\n" }, { "commit": "28e39ac7817834d258a0f75a33b4590c769cb1bc", "tree": "23eed3fd8cdc60e107d5070c300dfaf488b45507", "parents": [ "6b8b7660f2e2e964453ebace40dda7122f6d9eca" ], "author": { "name": "philip.zeyliger", "email": "philip.zeyliger@gmail.com", "time": "Mon Jun 16 22:04:35 2025 +0000" }, "committer": { "name": "Philip Zeyliger", "email": "philip@bold.dev", "time": "Mon Jun 16 21:30:06 2025 -0700" }, "message": "loop: remove unused waitForEnd parameter and endWaitGroup functionality\n\nRemove wait_for_end query parameter and associated synchronization logic\nthat was not being used in the codebase.\n\nChanges:\n- Remove waitForEnd query parameter parsing in SSE handler\n- Remove endWaitGroup sync.WaitGroup field from Server struct\n- Simplify shutdown logic to use basic 100ms delay instead of complex waitgroup timeout\n- Remove related comment documentation\n\nThis cleanup eliminates unused functionality while maintaining the same\nshutdown behavior with simpler code.\n\nCo-Authored-By: sketch \u003chello@sketch.dev\u003e\nChange-ID: s76684f9f4ec3a5d1k\n" }, { "commit": "6b8b7660f2e2e964453ebace40dda7122f6d9eca", "tree": "dcb6ba6d5a2d18fcffe8d44d6960bd41fd29121c", "parents": [ "7c1a687d03341b94b4a3c71706c47e3e14927707" ], "author": { "name": "philip.zeyliger", "email": "philip.zeyliger@gmail.com", "time": "Mon Jun 16 03:06:30 2025 +0000" }, "committer": { "name": "Philip Zeyliger", "email": "philip@bold.dev", "time": "Mon Jun 16 21:30:06 2025 -0700" }, "message": "webui: add mobile diff view with Monaco inline diffing\n\nThanks, Sketch. There are still some rough edges, but it\u0027s not bad.\n\nCo-Authored-By: sketch \u003chello@sketch.dev\u003e\nChange-ID: se4f6567dc0dabd31k\n" }, { "commit": "7c1a687d03341b94b4a3c71706c47e3e14927707", "tree": "18361873a51cd6217f10650f122b88fabd44ac07", "parents": [ "d4eea221b455e06fe7f897d1e04a8833015e893c" ], "author": { "name": "philip.zeyliger", "email": "philip.zeyliger@gmail.com", "time": "Mon Jun 16 03:54:37 2025 +0000" }, "committer": { "name": "Autoformatter", "email": "bot@sketch.dev", "time": "Tue Jun 17 04:27:18 2025 +0000" }, "message": "webui: implement Mermaid code splitting with lazy loading\n\nSplit Mermaid library into separate bundle with content-based hashing for\noptimal caching and reduced bundle size in main application components.\n\nImplementation Changes:\n\n1. Lazy Loading Infrastructure (sketch-timeline-message.ts):\n - Replace direct mermaid import with type-only import\n - Add loadMermaid() function with Promise-based dynamic loading\n - Implement __MERMAID_HASH__ constant injection pattern\n - Add global window.mermaid type declarations\n - Create mermaid loading promise with singleton pattern\n\n2. Bundle Splitting (esbuild.go):\n - Add createStandaloneMermaidBundle() function\n - Generate content-based hash from mermaid package.json\n - Create mermaid-standalone-{hash}.js as IIFE format bundle\n - Implement esbuildBundleWithExternals() replacing esbuildBundleWithExternal()\n - Add --external:mermaid to all TypeScript bundle builds\n - Inject __MERMAID_HASH__ constant at build time\n\n3. Async Rendering (sketch-timeline-message.ts):\n - Update renderMermaidDiagrams() to async/await pattern\n - Load mermaid library only when diagrams are present\n - Initialize mermaid configuration after dynamic loading\n - Maintain fallback to code blocks on loading errors\n - Preserve all existing mermaid functionality and configuration\n\nTechnical Details:\n- Uses content-based hashing for optimal browser caching\n- Mermaid loaded on-demand only when diagrams are present\n- Singleton loading pattern prevents duplicate network requests\n- Maintains existing mermaid initialization options\n- Preserves error handling with code block fallbacks\n- IIFE format enables direct window.mermaid assignment\n\nBenefits:\n- Reduces bundle size for components not using mermaid diagrams\n- Enables browser caching of mermaid library across sessions\n- Maintains existing functionality with lazy loading\n- Improves initial page load performance\n- Provides same user experience with deferred mermaid loading\n\nThis follows the same pattern established for Monaco editor bundling,\nproviding consistent lazy loading architecture for large dependencies.\n\nCo-Authored-By: sketch \u003chello@sketch.dev\u003e\nChange-ID: s0f8a82fcd28add05k\n" }, { "commit": "d4eea221b455e06fe7f897d1e04a8833015e893c", "tree": "c5dd56fd56611f5e1c930e9930e1449d8ade7cc6", "parents": [ "fe51d1d1b1f205ce2a417d312991e71d31ce6dc3" ], "author": { "name": "Philip Zeyliger", "email": "philip@bold.dev", "time": "Mon Jun 16 21:13:21 2025 -0700" }, "committer": { "name": "Philip Zeyliger", "email": "philip@bold.dev", "time": "Mon Jun 16 21:22:20 2025 -0700" }, "message": "Fix vet_error baseline?\n\nNo, I don\u0027t know how this crawled up.\n" }, { "commit": "fe51d1d1b1f205ce2a417d312991e71d31ce6dc3", "tree": "e45895b2546f9b0a54d6bbd7a635e47f821f36bb", "parents": [ "64f60461b00c474b0b4747a06177d5c7a357bba9" ], "author": { "name": "Philip Zeyliger", "email": "philip@bold.dev", "time": "Mon Jun 16 21:19:44 2025 -0700" }, "committer": { "name": "Philip Zeyliger", "email": "philip@bold.dev", "time": "Mon Jun 16 21:22:20 2025 -0700" }, "message": "Further loosen browser timeouts.\n" }, { "commit": "64f60461b00c474b0b4747a06177d5c7a357bba9", "tree": "cfeceff998a165af451099c0ec23b5d2b0fd42f2", "parents": [ "db8caa0eb8576b8c0d65cc0b7b6aa4e241a7cdb1" ], "author": { "name": "Philip Zeyliger", "email": "philip@bold.dev", "time": "Mon Jun 16 13:57:10 2025 -0700" }, "committer": { "name": "Autoformatter", "email": "bot@sketch.dev", "time": "Mon Jun 16 20:58:24 2025 +0000" }, "message": "loop: add diff stats from sketch-base to HEAD in /state endpoint\n\nAdd lines added/removed statistics computed from sketch-base to current HEAD,\ndisplayed in webui Diff mode button for quick change overview.\n\nCo-Authored-By: sketch \u003chello@sketch.dev\u003e\nChange-ID: s3f10ecf39df6b581k\n" }, { "commit": "db8caa0eb8576b8c0d65cc0b7b6aa4e241a7cdb1", "tree": "463538f0e72ca286642fb5ec0e26e2a6b53c4260", "parents": [ "95594bbd48412ca9621d18389badaf97e675f1f6" ], "author": { "name": "philip.zeyliger", "email": "philip.zeyliger@gmail.com", "time": "Mon Jun 16 15:37:24 2025 +0000" }, "committer": { "name": "Philip Zeyliger", "email": "philip@bold.dev", "time": "Mon Jun 16 08:58:42 2025 -0700" }, "message": "dockerimg: remove noisy debug log for missing tunnel removal\n\nCo-Authored-By: sketch \u003chello@sketch.dev\u003e\nChange-ID: s26e4ed4983c89781k\n" }, { "commit": "95594bbd48412ca9621d18389badaf97e675f1f6", "tree": "5a35a0e805e70098b1f76f935afa49c81c998c27", "parents": [ "7380a36bedf69c931ad03d69c67f23d9ccb7bf15" ], "author": { "name": "Philip Zeyliger", "email": "philip@bold.dev", "time": "Mon Jun 16 08:57:21 2025 -0700" }, "committer": { "name": "Philip Zeyliger", "email": "philip@bold.dev", "time": "Mon Jun 16 08:57:21 2025 -0700" }, "message": "bin/sk-ls: add number of messages\n" }, { "commit": "7380a36bedf69c931ad03d69c67f23d9ccb7bf15", "tree": "9c82c631958c729eb1f470ea8c023c39e4484867", "parents": [ "021231a933867854ad46ab6202ca4fd5bf50a8fd" ], "author": { "name": "Philip Zeyliger", "email": "philip@bold.dev", "time": "Mon Jun 16 08:27:44 2025 -0700" }, "committer": { "name": "Philip Zeyliger", "email": "philip@bold.dev", "time": "Mon Jun 16 08:27:44 2025 -0700" }, "message": "s/title/slug in bin/sk-ls\n" }, { "commit": "021231a933867854ad46ab6202ca4fd5bf50a8fd", "tree": "41f110e3aeeba8dc25483eea69e5138417039682", "parents": [ "2f8464cc1f0f25ec209ec5f710f6794a36700a5b" ], "author": { "name": "Sean McCullough", "email": "banksean@gmail.com", "time": "Thu Jun 12 09:35:24 2025 -0700" }, "committer": { "name": "Autoformatter", "email": "bot@sketch.dev", "time": "Mon Jun 16 04:52:33 2025 +0000" }, "message": "add /dist/messages-viewer.js bundle output\n" }, { "commit": "2f8464cc1f0f25ec209ec5f710f6794a36700a5b", "tree": "94a96915ba9a6f22dd031f0a77c99a06d8a090d7", "parents": [ "29c481c8d3bbe6124d3b273d2a154081d8472f08" ], "author": { "name": "Autoformatter", "email": "bot@sketch.dev", "time": "Mon Jun 16 04:27:05 2025 +0000" }, "committer": { "name": "Autoformatter", "email": "bot@sketch.dev", "time": "Mon Jun 16 04:27:05 2025 +0000" }, "message": "all: fix formatting\n" }, { "commit": "29c481c8d3bbe6124d3b273d2a154081d8472f08", "tree": "616a5f8097fa56da5e315ef2e2948fc049851a01", "parents": [ "c0a4459e3f5c8e68649bb45f2c309f6f01928ab7" ], "author": { "name": "Philip Zeyliger", "email": "philip@bold.dev", "time": "Sun Jun 15 21:25:45 2025 -0700" }, "committer": { "name": "Philip Zeyliger", "email": "philip@bold.dev", "time": "Sun Jun 15 21:25:45 2025 -0700" }, "message": "browser tests: further increasing timeouts\n" }, { "commit": "c0a4459e3f5c8e68649bb45f2c309f6f01928ab7", "tree": "3e239adc18145cac2f8cd920b7c6c63bf0a4def1", "parents": [ "38499cc1970fadc688567ec10ea92bfca187b929" ], "author": { "name": "philip.zeyliger", "email": "philip.zeyliger@gmail.com", "time": "Sun Jun 15 21:24:57 2025 -0700" }, "committer": { "name": "Philip Zeyliger", "email": "philip@bold.dev", "time": "Sun Jun 15 21:24:57 2025 -0700" }, "message": "webui: implement Monaco code splitting with external bundle loading\n\nSplit Monaco editor into separate bundle with content-based hashing, achieving\n99% size reduction in Monaco components (3.9MB to 42KB).\n\n- Enable minification in esbuild configuration\n- Create standalone Monaco bundle with content hash for optimal caching\n- Implement external Monaco loading with proper TypeScript types\n- Apply external Monaco to all TypeScript bundles for consistency\n\nBundle results:\n- sketch-monaco-view.js: 3.9MB → 42KB (99% reduction)\n- sketch-app-shell.js: 6.8MB → 3.0MB (Monaco external, still large due to mermaid/cytoscape/katex)\n- monaco-standalone-{hash}.js: 3.8MB cached separately\n\nApp shell remains large (3MB) due to mermaid dependencies - likely next optimization target.\n\nCo-Authored-By: sketch \u003chello@sketch.dev\u003e\nChange-ID: sc84907cb0ec24197k\n" }, { "commit": "38499cc1970fadc688567ec10ea92bfca187b929", "tree": "fcfdced525ed5818887872ffdab7666989bb6d95", "parents": [ "8a290e5a3df2ec7ba8de8ffbf52081e44b2d636f" ], "author": { "name": "Philip Zeyliger", "email": "philip@bold.dev", "time": "Sun Jun 15 21:17:05 2025 -0700" }, "committer": { "name": "Autoformatter", "email": "bot@sketch.dev", "time": "Mon Jun 16 04:17:53 2025 +0000" }, "message": "webui: restructure diff header layout for improved usability\n\nReorganize diff view header to show commits section always expanded on left\nand move file selector to right side, with expand/collapse button in header\nwhen single file is selected.\n\nCo-Authored-By: sketch \u003chello@sketch.dev\u003e\nChange-ID: s904ee76a60c89e75k\n" }, { "commit": "8a290e5a3df2ec7ba8de8ffbf52081e44b2d636f", "tree": "024a481c416e5ea04b0ca63427b6c1344d2d8f2c", "parents": [ "851d2bf4f9324b294c58bb5a79398269c2587a0d" ], "author": { "name": "Philip Zeyliger", "email": "philip@bold.dev", "time": "Sun Jun 15 20:59:58 2025 -0700" }, "committer": { "name": "Philip Zeyliger", "email": "philip@bold.dev", "time": "Sun Jun 15 21:05:25 2025 -0700" }, "message": "Run workflows on bigger machine.\n" }, { "commit": "851d2bf4f9324b294c58bb5a79398269c2587a0d", "tree": "eed22a219e4a53c9935c2dcebc5d5223b668b2e2", "parents": [ "6255411d3c2bd8cfe9a25c261e1c9a28e549441c" ], "author": { "name": "philip.zeyliger", "email": "philip.zeyliger@gmail.com", "time": "Mon Jun 16 03:10:10 2025 +0000" }, "committer": { "name": "Autoformatter", "email": "bot@sketch.dev", "time": "Mon Jun 16 03:42:24 2025 +0000" }, "message": "webui: add tool calls display to mobile chat timeline\n\nCo-Authored-By: sketch \u003chello@sketch.dev\u003e\nChange-ID: s654197301b832e70k\n" }, { "commit": "6255411d3c2bd8cfe9a25c261e1c9a28e549441c", "tree": "063eb2f7ec0793176b9b3528d7279d6c42fedc53", "parents": [ "5c6d82996aab8c390e43ee6d2b3f81f7f26de629" ], "author": { "name": "Autoformatter", "email": "bot@sketch.dev", "time": "Sun Jun 15 19:23:33 2025 +0000" }, "committer": { "name": "Autoformatter", "email": "bot@sketch.dev", "time": "Sun Jun 15 19:23:33 2025 +0000" }, "message": "all: fix formatting\n" }, { "commit": "5c6d82996aab8c390e43ee6d2b3f81f7f26de629", "tree": "769af94e9c5b73db806df2b019fed0fba1bcea7f", "parents": [ "4cd0129069c668cdd72f4d5b941e8d328c5d3caf" ], "author": { "name": "David Crawshaw", "email": "david@zentus.com", "time": "Sun Jun 15 19:09:19 2025 +0000" }, "committer": { "name": "David Crawshaw", "email": "david@zentus.com", "time": "Sun Jun 15 12:23:00 2025 -0700" }, "message": "webui: invert diff view layout and improve file selector behavior\n\nCo-Authored-By: sketch \u003chello@sketch.dev\u003e\nChange-ID: s5b7c42b431634f10k\n" }, { "commit": "4cd0129069c668cdd72f4d5b941e8d328c5d3caf", "tree": "c0b4d3101ed8d7f5a3ddd797451ff6b4dba3e560", "parents": [ "216d2fc77e55ca2e435f4d3d50a7a3a055b3545e" ], "author": { "name": "David Crawshaw", "email": "david@zentus.com", "time": "Sun Jun 15 18:59:13 2025 +0000" }, "committer": { "name": "David Crawshaw", "email": "david@zentus.com", "time": "Sun Jun 15 12:20:59 2025 -0700" }, "message": "webui: bring back the old per-file diff view as an option\n\nCo-Authored-By: sketch \u003chello@sketch.dev\u003e\nChange-ID: s46e7d05cb0615b8fk\n" }, { "commit": "216d2fc77e55ca2e435f4d3d50a7a3a055b3545e", "tree": "1425cab92b3c209221b9e1f8cb2de2620f658827", "parents": [ "d4be7a2d950cbc637e324210ce2e9904b736b701" ], "author": { "name": "David Crawshaw", "email": "david@zentus.com", "time": "Sun Jun 15 18:45:53 2025 +0000" }, "committer": { "name": "David Crawshaw", "email": "david@zentus.com", "time": "Sun Jun 15 12:20:57 2025 -0700" }, "message": "webui: clean up diff view interface by removing unused features\n\nRemove refresh button, file count display, single commit mode, and hide\ncommit range controls behind collapsible Commits dropdown to streamline\nthe diff view interface.\n\nThis streamlined interface focuses attention on the actual diff content while\nkeeping advanced controls easily accessible through progressive disclosure,\ncreating a cleaner and more professional diff viewing experience.\n\nCo-Authored-By: sketch \u003chello@sketch.dev\u003e\nChange-ID: se64b0db10984cba9k\n" }, { "commit": "d4be7a2d950cbc637e324210ce2e9904b736b701", "tree": "73d26c5c89be4ca8bcfc229bf0d3c52a8b76b5de", "parents": [ "dba26b57dbdf09c006a84314b2b919e8256d0089" ], "author": { "name": "Philip Zeyliger", "email": "philip@bold.dev", "time": "Sun Jun 15 09:39:00 2025 -0700" }, "committer": { "name": "Autoformatter", "email": "bot@sketch.dev", "time": "Sun Jun 15 16:40:32 2025 +0000" }, "message": "feat: add subtrace-token flag for development tracing\n\nAdd internal --subtrace-token flag to enable running sketch under\nsubtrace.dev for development purposes. Run with --skaband-addr\u003d for max\nhappiness.\n\nSubtrace manages to trace both incoming and outgoing traffic (e.g., to\nAnthropic), so it can be used.\n\nBeware that using this may leak your anthropic keys to subtrace.dev.\n\nCo-Authored-By: sketch \u003chello@sketch.dev\u003e\nChange-ID: s3521ac3b805c857fk\n" }, { "commit": "dba26b57dbdf09c006a84314b2b919e8256d0089", "tree": "c792f5452fe9a84abeaa0b6c421cf9c586fe8fcd", "parents": [ "ad15b6cc1ec990e139cbd0d462df301179a46f5e" ], "author": { "name": "David Crawshaw", "email": "david@zentus.com", "time": "Sun Jun 15 00:33:45 2025 +0000" }, "committer": { "name": "David Crawshaw", "email": "david@zentus.com", "time": "Sat Jun 14 17:57:26 2025 -0700" }, "message": "webui: fix Monaco editor horizontal scrollbar from border width overflow\n\nCo-Authored-By: sketch \u003chello@sketch.dev\u003e\nChange-ID: s555d4a157e574e32k\n" }, { "commit": "ad15b6cc1ec990e139cbd0d462df301179a46f5e", "tree": "7d45f57934a1ade6f21833d536219bcb847d1398", "parents": [ "f00c7b19133ee3e2d60bfb4eef117c0870c0bbc0" ], "author": { "name": "Autoformatter", "email": "bot@sketch.dev", "time": "Sun Jun 15 00:29:26 2025 +0000" }, "committer": { "name": "Autoformatter", "email": "bot@sketch.dev", "time": "Sun Jun 15 00:29:26 2025 +0000" }, "message": "all: fix formatting\n" }, { "commit": "f00c7b19133ee3e2d60bfb4eef117c0870c0bbc0", "tree": "acf2ac1953209027628f60c99fd4b41faec2de5f", "parents": [ "e2954ce9c186576151b5e0da05de1b37bb99afea" ], "author": { "name": "David Crawshaw", "email": "david@zentus.com", "time": "Sun Jun 15 00:24:46 2025 +0000" }, "committer": { "name": "David Crawshaw", "email": "david@zentus.com", "time": "Sat Jun 14 17:27:04 2025 -0700" }, "message": "webui: disable Monaco diff editor overview ruler\n\nRemove the overview ruler from Monaco diff editor by adding renderOverviewRuler: false\nto the editor configuration, providing a cleaner diff viewing experience.\n\nCo-Authored-By: sketch \u003chello@sketch.dev\u003e\nChange-ID: sc99558fc19a79a66k\n" }, { "commit": "e2954ce9c186576151b5e0da05de1b37bb99afea", "tree": "ef54edfec55171ff3faf8428e0f0e274b49e1ea5", "parents": [ "dbca8975c4616c02f284359fed07d4a2c1477301" ], "author": { "name": "David Crawshaw", "email": "david@zentus.com", "time": "Sun Jun 15 00:06:34 2025 +0000" }, "committer": { "name": "David Crawshaw", "email": "david@zentus.com", "time": "Sat Jun 14 17:12:58 2025 -0700" }, "message": "webui: fix diff view scrollbar visibility and resize handling\n\nFix Monaco editor scrollbar display issues and improve browser window resize\nresponsiveness in the diff view, providing a cleaner interface and better\nuser experience across different screen sizes.\n\nProblem Analysis:\nThe diff view had two significant issues affecting usability:\n\n1. Monaco Scrollbar Visibility: Despite setting scrollbar configuration to\n \u0027hidden\u0027, a large gray scrollbar remained visible on the right side of\n the Monaco diff editor. This was caused by insufficient CSS targeting\n of Monaco\u0027s complex DOM structure and scrollbar element hierarchy.\n\n2. Resize Handling: The diff view did not properly adapt when users resized\n their browser window. While the editor had automaticLayout: false and\n manual sizing, there was no window resize listener to trigger layout\n recalculation, causing the editor to maintain its original dimensions.\n\n3. Refresh Button Layout: At certain screen widths, the refresh button would\n wrap to its own line prematurely due to inflexible sizing constraints.\n\nImplementation Changes:\n\n1. Monaco Scrollbar Removal (sketch-diff2-view.ts):\n - Added comprehensive global CSS rules targeting all Monaco scrollbar elements\n - Targeted .monaco-editor, .monaco-diff-editor, and .monaco-scrollable-element\n - Applied multiple hiding techniques: display: none, visibility: hidden,\n width/height: 0, opacity: 0 for maximum coverage\n - Added padding/margin removal to prevent scrollbar space reservation\n - Ensured diff content takes full width without scrollbar spacing\n\n2. Window Resize Handler (sketch-monaco-view.ts):\n - Added setupWindowResizeHandler() method with debounced resize logic\n - Implemented 100ms debounce to prevent excessive layout calls\n - Added window \u0027resize\u0027 event listener that triggers fitEditorToContent()\n - Fallback layout call with current container dimensions if fit function unavailable\n - Proper cleanup in disconnectedCallback() to prevent memory leaks\n\n3. Layout Improvements (sketch-diff2-view.ts):\n - Set minimum width (400px) for sketch-diff-range-picker component\n - Added minimum width (120px) for file-count display\n - Ensured flex layout provides adequate space for all controls\n - Improved responsive behavior at various screen widths\n\n4. Enhanced Scrollbar Configuration (sketch-monaco-view.ts):\n - Extended scrollbar options with additional Monaco-specific settings:\n - useShadows: false to disable scrollbar shadows\n - verticalHasArrows: false / horizontalHasArrows: false to remove arrows\n - verticalScrollbarSize: 0 / horizontalScrollbarSize: 0 for zero track size\n - Combined configuration-based and CSS-based hiding for complete coverage\n\nTechnical Details:\n- Global CSS injection occurs once per diff view instance in constructor\n- Window resize handler uses setTimeout debouncing to avoid performance issues\n- Monaco editor layout() called with explicit dimensions during resize\n- CSS targeting covers all known Monaco scrollbar element patterns\n- Minimum width constraints prevent layout collapse at small screen sizes\n- Cleanup handlers prevent memory leaks when components are destroyed\n\nBenefits:\n- Clean, professional diff view appearance without distracting scrollbars\n- Smooth responsive behavior when browser window is resized\n- Improved layout stability for controls at various screen widths\n- Better user experience across desktop and mobile viewport sizes\n- Maintained full Monaco editor functionality (editing, syntax highlighting, etc.)\n\nTesting:\n- Verified scrollbar completely hidden at all screen sizes\n- Tested resize responsiveness from 600px to 1400px+ widths\n- Confirmed smooth transitions during window resize operations\n- Validated refresh button layout behavior at different breakpoints\n- Ensured Monaco editor features remain fully functional\n- Tested both horizontal and vertical window resize scenarios\n\nThis implementation provides a polished, responsive diff view experience\nthat properly adapts to user browser configurations while maintaining\nall advanced Monaco editor capabilities.\n\nCo-Authored-By: sketch \u003chello@sketch.dev\u003e\nChange-ID: sf19d359b4fcbcbdek\n" }, { "commit": "dbca8975c4616c02f284359fed07d4a2c1477301", "tree": "1752a1f4f1c16441d43f4f9b69e4120927d25bb3", "parents": [ "9abf803eeedd49261dc4e4c5b75dcb4d21cc6a0d" ], "author": { "name": "David Crawshaw", "email": "david@zentus.com", "time": "Sat Jun 14 23:46:58 2025 +0000" }, "committer": { "name": "Autoformatter", "email": "bot@sketch.dev", "time": "Sat Jun 14 23:50:10 2025 +0000" }, "message": "webui: improve diff view header layout and compactness\n\nConsolidate diff view header layout for better space efficiency and improved\nvisual organization of commit range selectors and file count display.\n\nChanges:\n1. Move file count to same line as commit range selectors\n2. Reduce per-file header padding from 12px to 8px\n3. Shorten commit selector entries to prevent overflow\n4. Change file count text from \u0027N files changed\u0027 to \u0027N files\u0027\n5. Prevent file count text from wrapping with white-space: nowrap\n\nLayout improvements create more compact header while maintaining usability.\n\nCo-Authored-By: sketch \u003chello@sketch.dev\u003e\nChange-ID: s54d391a2d5128fd4k\n" }, { "commit": "9abf803eeedd49261dc4e4c5b75dcb4d21cc6a0d", "tree": "abebff284ab5674aeacf125237619c26f998d1cb", "parents": [ "26f3f34c25e21717001f0230d1abe7debbc5e0c0" ], "author": { "name": "Autoformatter", "email": "bot@sketch.dev", "time": "Sat Jun 14 23:24:08 2025 +0000" }, "committer": { "name": "Autoformatter", "email": "bot@sketch.dev", "time": "Sat Jun 14 23:24:08 2025 +0000" }, "message": "all: fix formatting\n" }, { "commit": "26f3f34c25e21717001f0230d1abe7debbc5e0c0", "tree": "0ba518a643b4d165dd871b4a2cd28e5f096a017f", "parents": [ "938d2dcde4aaea8119e1c09ffa453de48560dd57" ], "author": { "name": "David Crawshaw", "email": "david@zentus.com", "time": "Sat Jun 14 19:58:32 2025 +0000" }, "committer": { "name": "David Crawshaw", "email": "david@zentus.com", "time": "Sat Jun 14 16:20:07 2025 -0700" }, "message": "webui: implement multi-file diff view with continuous scrolling\n\nReplace file selector with GitHub PR-style continuous scrolling through\nmultiple files in a single view, improving diff navigation experience\nwhile maintaining all Monaco editor features.\n\nProblem Analysis:\nThe existing diff view required users to navigate between files using a\ndropdown selector and Previous/Next buttons. This created friction when\nreviewing multi-file changes and broke the natural scrolling flow that\nusers expect from GitHub PR views or other modern diff interfaces.\n\nThe limitation was that Monaco doesn\u0027t provide a built-in multi-file diff\nwidget, requiring custom implementation with multiple IStandaloneDiffEditor\ninstances properly configured for stacking and auto-sizing.\n\nImplementation Changes:\n\n1. Multi-File Layout (sketch-diff2-view.ts):\n - Replaced sketch-diff-file-picker with simple file count display\n - Implemented renderFileDiff() to create separate diff sections per file\n - Added renderFileHeader() with status badges and path information\n - Created multi-file-diff-container with vertical stacking layout\n - Added loadAllFileContents() for parallel content loading\n - Replaced single originalCode/modifiedCode with Map\u003cstring, FileContent\u003e\n\n2. Monaco Auto-Sizing (sketch-monaco-view.ts):\n - Configured diff editors with hidden scrollbars per Monaco ≥0.49 pattern\n - Added setupAutoSizing() with content height calculation\n - Implemented fitEditorToContent() using getContentHeight() callbacks\n - Set automaticLayout: false for manual size control\n - Added scrollbar: { vertical: \u0027hidden\u0027, horizontal: \u0027hidden\u0027, handleMouseWheel: false }\n - Enabled minimap: false and scrollBeyondLastLine: false\n\n3. CSS Styling (sketch-diff2-view.ts):\n - Added file-diff-section with bottom borders for visual separation\n - Implemented sticky file headers with proper z-index\n - Created status badges (added, modified, deleted, renamed) with color coding\n - Added file-count display replacing old file picker interface\n - Configured diff-container with overflow: auto for outer scrolling\n\n4. Content Management:\n - Parallel loading of all file contents with error handling\n - Maintains editability detection per file based on commit range\n - Preserves comment and save functionality for individual files\n - Updated toggleHideUnchangedRegions to apply to all editors\n\nTechnical Details:\n- Uses Monaco\u0027s getContentHeight() and onDidContentSizeChange() for auto-sizing\n- Each diff editor sized to Math.max(originalHeight, modifiedHeight) + 18px padding\n- Outer container handles all scrolling while inner editors are sized to content\n- File headers show status (Added/Modified/Deleted/Renamed) with appropriate styling\n- Sticky positioning keeps file context visible during scrolling\n- Maintains all existing features: editing, commenting, expand/collapse toggles\n\nBenefits:\n- Natural scrolling workflow similar to GitHub PR reviews\n- Eliminates need for dropdown navigation between files\n- Better visual context with file headers and status indicators\n- Continuous viewing experience for multi-file changes\n- Preserves all advanced Monaco features (editing, commenting, etc.)\n- Improved performance with parallel content loading\n\nTesting:\n- Verified multi-file diff display with various commit ranges\n- Tested scrolling behavior between files works smoothly\n- Confirmed auto-sizing works correctly for different file sizes\n- Validated file headers show correct status and change counts\n- Ensured editing and commenting functionality preserved\n- Tested expand/collapse toggles apply to all editors\n\nThis implementation follows the Monaco ≥0.49 multi-file diff pattern with\ndisabled inner scrollbars, auto-sizing to content, and outer scroll container,\nproviding a modern diff experience while maintaining full editor functionality.\n\nCo-Authored-By: sketch \u003chello@sketch.dev\u003e\nChange-ID: s0724a00944669c80k\n" }, { "commit": "938d2dcde4aaea8119e1c09ffa453de48560dd57", "tree": "fe917e628d4ce1a671a15d1430668e92983289c4", "parents": [ "7351cd9b711db0e828d22d995fe56c7f9f6ddb07" ], "author": { "name": "David Crawshaw", "email": "david@zentus.com", "time": "Sat Jun 14 22:17:33 2025 +0000" }, "committer": { "name": "David Crawshaw", "email": "david@zentus.com", "time": "Sat Jun 14 16:20:07 2025 -0700" }, "message": "webui: add URL parameters for diff view from/to commit selection\n\nEnable direct linking to specific diff ranges by adding URL parameters that\nsync with the diff range picker controls, allowing users to bookmark and\nshare specific diff views.\n\nProblem Analysis:\nUsers couldn\u0027t link directly to specific diff ranges in the sketch diff view.\nThe from/to commit selectors would reset to defaults on page load, making it\nimpossible to bookmark or share links to specific commit comparisons. This\ncreated friction when collaborating or returning to specific diff views.\n\nImplementation Changes:\n\n1. URL Parameter Synchronization (sketch-diff-range-picker.ts):\n - Added updateUrlParams() to write from/to/commit parameters to URL\n - Integrated URL updates into dispatchRangeEvent() for automatic sync\n - Used history.replaceState() to update URL without page reload\n - Clear unused parameters when switching between range/single modes\n\n2. URL Parameter Initialization:\n - Added initializeFromUrlParams() to read URL parameters on load\n - Parse \u0027from\u0027/\u0027to\u0027 parameters for range mode initialization\n - Parse \u0027commit\u0027 parameter for single commit mode initialization\n - Return flag indicating successful URL-based initialization\n\n3. Load Flow Enhancement:\n - Modified loadCommits() to check URL parameters before setting defaults\n - Skip default commit selection when URL parameters are present\n - Always dispatch range event to ensure diff view updates correctly\n\n4. Browser Navigation Support:\n - Added popstate event listener for browser back/forward navigation\n - Implemented handlePopState() to re-initialize from URL parameters\n - Force component re-render and event dispatch on navigation\n\n5. Mode Switching Improvements:\n - Enhanced setRangeType() with better default handling\n - Auto-populate missing commits when switching between modes\n - Maintain proper URL state during mode transitions\n\nTechnical Details:\n- URL parameters: \u0027from\u0027, \u0027to\u0027 for range mode; \u0027commit\u0027 for single mode\n- Empty \u0027to\u0027 parameter represents uncommitted changes (working directory)\n- Parameters removed from URL when switching to incompatible modes\n- Browser history updated without triggering page reloads\n- Component lifecycle properly manages event listeners\n\nURL Format Examples:\n- Range mode: ?view\u003ddiff2\u0026from\u003dabc123\u0026to\u003ddef456\n- Uncommitted: ?view\u003ddiff2\u0026from\u003dabc123 (no \u0027to\u0027 parameter)\n- Single commit: ?view\u003ddiff2\u0026commit\u003dabc123\n\nBenefits:\n- Direct linking to specific diff ranges via URL\n- Bookmarkable diff views for easy return navigation\n- Shareable links for collaboration and code review\n- Browser back/forward navigation works correctly\n- URL reflects current diff state at all times\n- Seamless integration with existing diff view functionality\n\nTesting:\n- Verified URL updates when changing from/to commit selectors\n- Confirmed URL initialization on page load with parameters\n- Tested browser back/forward navigation updates UI correctly\n- Validated mode switching (range ↔ single) updates URL appropriately\n- Ensured uncommitted changes mode removes \u0027to\u0027 parameter\n- Confirmed sharing URLs loads correct diff view state\n\nThis enhancement enables direct linking and improved navigation for the\nsketch diff view while maintaining all existing functionality and providing\nseamless URL-based state management.\n\nCo-Authored-By: sketch \u003chello@sketch.dev\u003e\nChange-ID: sbf02a6a8bb4db673k\n" }, { "commit": "7351cd9b711db0e828d22d995fe56c7f9f6ddb07", "tree": "2c4014fb50f2ae0ea3c8922d89c4029846da240d", "parents": [ "a35de5f73d31756c8ac972a54bdb370bb26eed5a" ], "author": { "name": "philip.zeyliger", "email": "philip.zeyliger@gmail.com", "time": "Sat Jun 14 12:25:31 2025 -0700" }, "committer": { "name": "Philip Zeyliger", "email": "philip@bold.dev", "time": "Sat Jun 14 12:25:31 2025 -0700" }, "message": "webui: fix Monaco fonts\n\nIn Chrome, if you selectected a line in the diff view, it wouldn\u0027t\nselect the whole line, because Monaco was somehow confused about the\nfont widths or something. Turns out we had customized our fonts. We\ndon\u0027t need to do that!\n\nAlso adding a sketchDebug idea so that it\u0027s easier to poke at things.\n" }, { "commit": "a35de5f73d31756c8ac972a54bdb370bb26eed5a", "tree": "e86111f53c0e701a38510ed8543403f25665a891", "parents": [ "46be0967c78b0e60b18b4b9ff3c642ebc96c7e4d" ], "author": { "name": "Philip Zeyliger", "email": "philip@bold.dev", "time": "Sat Jun 14 12:00:48 2025 -0700" }, "committer": { "name": "Philip Zeyliger", "email": "philip@bold.dev", "time": "Sat Jun 14 12:00:48 2025 -0700" }, "message": "Using GH actions provided Chrome for test speedup (#149)\n\nOMG. This had wild behavior. Sometimes you\u0027d log into tmate, and it\nwould work. Something about running Chrome manually would tickle some\ndbus thing into working. The error would sometimes show up, but most\noften it would be swallowed.\n\nThe punchline? We had a context timeout of 5 or 10 seconds in the tests\nthat would trigger silently, and we\u0027d see nothing. Everything else\n(including maybe the dbus stuff) was a red herring: the test executor\nmachine is swamped, and shit\u0027s slow, and the various timeouts needed\ntweaking. I bet there are a few more timeouts to loosen eventually, but\nit seems to be passing now.\n\nError message:\n\tfailed to start browser (please apt get chromium or equivalent): chrome failed to start:\n" }, { "commit": "46be0967c78b0e60b18b4b9ff3c642ebc96c7e4d", "tree": "35db5a5725a69f5913102fe768c4103dc4188a56", "parents": [ "c013134814facb7da15b59c79399ec1939eb6ef9" ], "author": { "name": "philip.zeyliger", "email": "philip.zeyliger@gmail.com", "time": "Sat Jun 14 17:51:15 2025 +0000" }, "committer": { "name": "Philip Zeyliger", "email": "philip@bold.dev", "time": "Sat Jun 14 11:38:48 2025 -0700" }, "message": "ci: optimize APT package installation by skipping documentation\n\nCo-Authored-By: sketch \u003chello@sketch.dev\u003e\nChange-ID: sf483afee70439c11k\n" }, { "commit": "c013134814facb7da15b59c79399ec1939eb6ef9", "tree": "6072025f9c2e5a87af79a61070fab1f0500c32a5", "parents": [ "c886ac5478194e95f93b166572a7a081eb6cadb8" ], "author": { "name": "Philip Zeyliger", "email": "philip@bold.dev", "time": "Fri Jun 13 21:07:08 2025 -0700" }, "committer": { "name": "Philip Zeyliger", "email": "philip@bold.dev", "time": "Fri Jun 13 21:07:08 2025 -0700" }, "message": "Fail to speed up CI by not installing Chrome.\n\nI have no idea why the same \"vintage\" machine I logged into via tmate\nhas this working, but this doesn\u0027t, but the --no-sandbox thing is\ncorrect regardless.\n\nVariants of the following is what SHOULD work but doesn\u0027t yet.\n\n\tPATH\u003d/usr/local/share/chromium/chrome-linux:$PATH GOEXPERIMENT\u003dsynctest stdbuf -oL -eL go test -v -count\u003d1 -run TestBrowserInitialization ./claudetool/browse/...\n" }, { "commit": "c886ac5478194e95f93b166572a7a081eb6cadb8", "tree": "fd4be26cd6cf20162ff22ef21a8c1dc6e51e59d5", "parents": [ "1bd636c83311a9195fca38515ee254bf07ae0d12" ], "author": { "name": "David Crawshaw", "email": "david@zentus.com", "time": "Fri Jun 13 23:40:03 2025 +0000" }, "committer": { "name": "David Crawshaw", "email": "david@zentus.com", "time": "Sat Jun 14 01:03:45 2025 +0000" }, "message": "loop: add special instruction field\n\nIncludes a demo.\n\nCo-Authored-By: sketch \u003chello@sketch.dev\u003e\nChange-ID: sc7078aeb8c59e49ak\n" }, { "commit": "1bd636c83311a9195fca38515ee254bf07ae0d12", "tree": "e90ca194abe7274efbb520907b641f8fc27d2947", "parents": [ "c7c2cc1e9d2a90515e071527241e0ce680fe0738" ], "author": { "name": "David Crawshaw", "email": "david@zentus.com", "time": "Fri Jun 13 19:56:27 2025 +0000" }, "committer": { "name": "David Crawshaw", "email": "david@zentus.com", "time": "Fri Jun 13 14:18:04 2025 -0700" }, "message": "dockerimg: add seccomp filter to protect PID 1 from kill syscalls\n\nAdd automatic seccomp profile creation and injection to prevent sketch\nprocesses from killing themselves via pkill -f or similar commands that\ntarget PID 1 within Docker containers.\n\nCo-Authored-By: sketch \u003chello@sketch.dev\u003e\nChange-ID: s74e3bcc6e17ec376k\n" }, { "commit": "c7c2cc1e9d2a90515e071527241e0ce680fe0738", "tree": "df1b7548a47fa1e4f219bcd8a27e5fadaa0acc3c", "parents": [ "83c5be6f73607c6add6d5c389f7894e1d7b5e06a" ], "author": { "name": "Sean McCullough", "email": "banksean@gmail.com", "time": "Fri Jun 13 03:21:18 2025 +0000" }, "committer": { "name": "Autoformatter", "email": "bot@sketch.dev", "time": "Fri Jun 13 03:48:18 2025 +0000" }, "message": "webui: fix repository name parsing for names containing dots\n\nFix GitHub repository URL parsing in sketch-container-status component to\nproperly handle repository names containing dots, resolving broken GitHub\nlinks in the ongoing session log banner.\n\nProblem Analysis:\nThe formatGitHubRepo function used regex patterns with [^/\\s.]+ character\nclasses that excluded dots from repository names. This caused repository names\nlike \u0027boldsoftware/sketch.git\u0027 to be truncated to \u0027boldsoftware/sketch\u0027 when\nparsed, breaking GitHub links and repository display in the session banner.\n\nThe issue occurred in three regex patterns for different GitHub URL formats:\n- HTTPS URLs: /https:\\/\\/github\\.com\\/([^/]+)\\/([^/\\s.]+)(?:\\.git)?/\n- SSH URLs: /git@github\\.com:([^/]+)\\/([^/\\s.]+)(?:\\.git)?/\n- Git protocol: /git:\\/\\/github\\.com\\/([^/]+)\\/([^/\\s.]+)(?:\\.git)?/\n\nThe [^/\\s.]+ pattern specifically excluded dots (.) from matching, which was\nproblematic for legitimate repository names containing dots.\n\nImplementation Changes:\n\n1. Regex Pattern Updates:\n - Changed [^/\\s.]+ to [^/\\s]+? in all three URL patterns\n - Removed dot exclusion while maintaining whitespace and slash exclusion\n - Added non-greedy quantifier (?) to prevent over-matching\n - Added end-of-string anchor ($) for precise matching\n\n2. Updated patterns:\n - HTTPS: /https:\\/\\/github\\.com\\/([^/]+)\\/([^/\\s]+?)(?:\\.git)?$/\n - SSH: /git@github\\.com:([^/]+)\\/([^/\\s]+?)(?:\\.git)?$/\n - Git: /git:\\/\\/github\\.com\\/([^/]+)\\/([^/\\s]+?)(?:\\.git)?$/\n\nTechnical Details:\n- Non-greedy matching (+?) ensures proper handling of .git suffix\n- End anchors ($) prevent partial matches and improve precision\n- Dots now allowed in repository names while preserving .git detection\n- Existing functionality preserved for repositories without dots\n\nTesting:\nVerified fix with comprehensive test cases:\n- git@github.com:boldsoftware/sketch.git → boldsoftware/sketch ✓\n- https://github.com/user/repo.with.dots.git → user/repo.with.dots ✓\n- git@github.com:org/project.name.git → org/project.name ✓\n- https://github.com/test/normal-repo → test/normal-repo ✓\n\nBenefits:\n- GitHub links now work correctly for repositories with dots in names\n- Session banner displays proper repository information\n- Maintains backward compatibility with existing repository names\n- Improves user experience for repository navigation\n\nThis fix resolves the specific issue where repository names containing dots\nwould have their GitHub links truncated, breaking navigation to the actual\nrepository on GitHub.\n\nCo-Authored-By: sketch \u003chello@sketch.dev\u003e\nChange-ID: sda0a251af3d756b6k\n\nwebui: improve GitHub repo parsing tests\n\nReplace internal method testing with component behavior testing for better\nintegration coverage and maintainability.\n\n- Test actual GitHub link rendering in DOM instead of calling private methods\n- Add separate test cases for repository names with dots\n- Verify href attributes, text content, and title attributes are correct\n- Cover both general dot-containing names and the specific boldsoftware/sketch case\n\nCo-Authored-By: sketch \u003chello@sketch.dev\u003e\nChange-ID: s216977b6be91a2bak\n" }, { "commit": "83c5be6f73607c6add6d5c389f7894e1d7b5e06a", "tree": "e230051fe8efb82642792d2710b66a50167036c1", "parents": [ "e8da7af81f6414866ec20658c1c2a0ae4fc350bf" ], "author": { "name": "Sean McCullough", "email": "banksean@gmail.com", "time": "Thu Jun 12 15:42:40 2025 -0700" }, "committer": { "name": "Sean McCullough", "email": "banksean@gmail.com", "time": "Thu Jun 12 15:42:40 2025 -0700" }, "message": "cmd/genwebuizip\n" } ], "next": "e8da7af81f6414866ec20658c1c2a0ae4fc350bf" }