)]}' { "log": [ { "commit": "7735844caf9fa4e2d7bbe3bf64d20e86b9bf469e", "tree": "e5c73e24642f2dab2ac95ba3db4c04e1ac0ac82e", "parents": [ "bf66a2f9313894d63f204816ba90e412e02363c0" ], "author": { "name": "David Crawshaw", "email": "david@zentus.com", "time": "Wed Jun 25 00:26:08 2025 +0000" }, "committer": { "name": "Autoformatter", "email": "bot@sketch.dev", "time": "Wed Jun 25 03:12:26 2025 +0000" }, "message": "skaband: create forked app shell for /newsessions with shared base\n\nFactor out shared components from sketch/webui app shell and create\nnewsessions-specific version under skaband with pinned topbar/textarea layout.\n\nCo-Authored-By: sketch \u003chello@sketch.dev\u003e\nChange-ID: s9fcdda62becc98f9k\n" }, { "commit": "bf66a2f9313894d63f204816ba90e412e02363c0", "tree": "22acc34aa404c3ac5add1e2de7f4df1aadce8251", "parents": [ "194bfa8cc3970d28f2d072dc82142e24b7e56c9f" ], "author": { "name": "Sean McCullough", "email": "banksean@gmail.com", "time": "Mon Jun 23 21:53:55 2025 -0700" }, "committer": { "name": "Autoformatter", "email": "bot@sketch.dev", "time": "Tue Jun 24 16:43:42 2025 +0000" }, "message": "webui: convert sketch-app-shell to use tailwind\n\nDoing the conversion from shadowDOM to tailwind starting with the\noutermost elements in the page because shadowDOM hides dom nodes from\nancestor styles, which means tailwind styles don\u0027t apply to an element\nif its ancestors use shadowDOM.\n\n- add new SketchTailwindElement that disables shadowDOM for tailwind\n- convert sketch-app-shell to inherit from SketchTailwindElement\n- convert sketch-app-shell\u0027s CSS from shadowDOM to tailwind classes\n" }, { "commit": "ba351be3a9e50c67baef59af5ee35e3b654727e1", "tree": "b6d654a743e058ad357effd56287b40f469cce65", "parents": [ "5a85ffe8c6a3f6916fd3d7951af5486a784e87f0" ], "author": { "name": "Autoformatter", "email": "bot@sketch.dev", "time": "Mon Jun 23 21:59:08 2025 +0000" }, "committer": { "name": "Autoformatter", "email": "bot@sketch.dev", "time": "Mon Jun 23 21:59:08 2025 +0000" }, "message": "all: fix formatting\n" }, { "commit": "5a85ffe8c6a3f6916fd3d7951af5486a784e87f0", "tree": "0efa325e62b99fc366516f6575ce6d7bff95ccde", "parents": [ "d158f9d2954c8ad8b803aa257eba3084651b43e8" ], "author": { "name": "Philip Zeyliger", "email": "philip@bold.dev", "time": "Sat Jun 21 21:27:44 2025 -0700" }, "committer": { "name": "Philip Zeyliger", "email": "philip@bold.dev", "time": "Mon Jun 23 14:58:22 2025 -0700" }, "message": "webui: fix IDLE/WORKING indicator to ignore system messages\n\nFix bug where IDLE/WORKING status indicator in top-right incorrectly used\nsystem messages (like commit detection) to determine agent state instead\nof only considering user and agent messages.\n\nCo-Authored-By: sketch \u003chello@sketch.dev\u003e\nChange-ID: s7aecd377d88b46f8k\n" }, { "commit": "29d689f174f0a414ee818961118c2e9ec33a809c", "tree": "17ae059d3085a7905b9fe1d59ead9cb066511f49", "parents": [ "ebbdee49d9b9e7d5144a878135b7e222385a565b" ], "author": { "name": "banksean", "email": "banksean@gmail.com", "time": "Mon Jun 23 15:41:26 2025 +0000" }, "committer": { "name": "Autoformatter", "email": "bot@sketch.dev", "time": "Mon Jun 23 16:06:50 2025 +0000" }, "message": "dockerimg: rename ssh_theater to local_sshimmer\n\nCo-Authored-By: sketch \u003chello@sketch.dev\u003e\nChange-ID: s650e5e56560011fak\n" }, { "commit": "ebbdee49d9b9e7d5144a878135b7e222385a565b", "tree": "9c88a791806c9239b4e040a36348e8ff3de3d9e7", "parents": [ "8105fe6bfa914c17c0f474bacdbe9d4c62b6b2b3" ], "author": { "name": "cbro", "email": "cbro@gm.report", "time": "Fri Jun 20 09:57:44 2025 +0000" }, "committer": { "name": "David Crawshaw", "email": "david@zentus.com", "time": "Sun Jun 22 10:17:08 2025 -0700" }, "message": "webui: fix copy button functionality for new branch creation\n\nAdd click handler to copy icon in commit branch containers to enable copying\nbranch names by clicking the icon, not just the branch name text.\n\nCo-Authored-By: sketch \u003chello@sketch.dev\u003e\nChange-ID: saee9afbb466904efk\n" }, { "commit": "364b35a411afadef2531d600ca5b0da5d1b25d7f", "tree": "6feb28f2bee414abc51e62ef2ad67ddf94bee44e", "parents": [ "61a0f6758240d318e8d0ae778e2a93ef45a867cf" ], "author": { "name": "Philip Zeyliger", "email": "philip@bold.dev", "time": "Sat Jun 21 16:39:04 2025 -0700" }, "committer": { "name": "Autoformatter", "email": "bot@sketch.dev", "time": "Sat Jun 21 23:39:39 2025 +0000" }, "message": "webui: improve/simplify commit selector in Monaco diff view\n\nThe HTML select\u0027s cant be formatted to show tags nicely, so\ndid a \"custom\" select thing.\n\nFurthermore, I never use the \"to\" thing, so let\u0027s just get rid of\nit, and we\u0027re always going from someplace to someplace.\n\nI don\u0027t love the overflow behavior, but we\u0027ll see how it goes.\n\nCo-Authored-By: sketch \u003chello@sketch.dev\u003e\nChange-ID: s9f70e9aef1fb08c4k\n" }, { "commit": "61a0f6758240d318e8d0ae778e2a93ef45a867cf", "tree": "8b18ef5a7b1b4cb6312136ce25bb3a0f86f84ad7", "parents": [ "3cde282e7b12d14ec27400a2c0f9b167001ed60e" ], "author": { "name": "Philip Zeyliger", "email": "philip@bold.dev", "time": "Sat Jun 21 15:33:18 2025 -0700" }, "committer": { "name": "Autoformatter", "email": "bot@sketch.dev", "time": "Sat Jun 21 22:34:05 2025 +0000" }, "message": "webui: add Jump to Bottom button for mobile and desktop chat views\n\nAdd a floating Jump to Bottom button that appears when users scroll up\nfrom the bottom of chat interfaces, positioned at the boundary between\nchat content and input areas.\n\nCo-Authored-By: sketch \u003chello@sketch.dev\u003e\nChange-ID: sba26f10bfcccf392k\n" }, { "commit": "3cde282e7b12d14ec27400a2c0f9b167001ed60e", "tree": "ae7df9f0552e87ae7aa1c06ceb3210bf7343efcc", "parents": [ "d1832847e9d6566971088d7b1a255487b0ed0e0b" ], "author": { "name": "Philip Zeyliger", "email": "philip@bold.dev", "time": "Sat Jun 21 09:32:38 2025 -0700" }, "committer": { "name": "Autoformatter", "email": "bot@sketch.dev", "time": "Sat Jun 21 16:35:56 2025 +0000" }, "message": "webui: improve comment functionality for Monaco diff editor by using gutter\n\nThis was a bit of a journey. To me, the correct functionality is like\nthe breakpoint setting in VSCode. I had o3 find the relevant code and\ntried to feed it back into Sketch, but it turned out I had to break it\ndown into pieces. (Asking it for the whole thing failed several times.)\nIn the end, I asked Sketch first to add a comment icon in the gutters.\nThis required just the right \"glyphMargin\" settings and finally worked.\nIn the next session, it worked on showing/hiding them depending on where\nyou were hovering. In the one after that, it deleted the old comment box\nfunctionality, and then in the one after that, added that functionality\nback in. And now we\u0027re here, and it seems to work.\n\nCo-Authored-By: sketch \u003chello@sketch.dev\u003e\nChange-ID: sd81ff0507f3398a8k\n" }, { "commit": "d1832847e9d6566971088d7b1a255487b0ed0e0b", "tree": "554760d15b2c1cb04b85eb950641fcebb392e6c7", "parents": [ "cfd0fe64e379f066b117effe84100a38c48e493f" ], "author": { "name": "Sean McCullough", "email": "banksean@gmail.com", "time": "Fri Jun 20 22:42:06 2025 -0400" }, "committer": { "name": "Autoformatter", "email": "bot@sketch.dev", "time": "Sat Jun 21 02:48:15 2025 +0000" }, "message": "fix messages-viewer\n" }, { "commit": "c540e8ea6a8dd2a5297345b6f9b885988338f237", "tree": "fcae305b543bfc26cbee0480d57d0ecd8f628a92", "parents": [ "037f3160b72f05979c02787274b570a92da5a764" ], "author": { "name": "philip.zeyliger", "email": "philip.zeyliger@gmail.com", "time": "Wed Jun 18 21:05:46 2025 +0000" }, "committer": { "name": "Philip Zeyliger", "email": "philip@bold.dev", "time": "Fri Jun 20 19:15:24 2025 -0700" }, "message": "webui: add missing codicon font reference to mobile app shell\n\nThe mobile diff view uses sketch-monaco-view component which requires\nthe codicon font for Monaco editor icons. Added the same @font-face\ndeclaration that exists in sketch-app-shell.css to mobile-app-shell.css.\n\nThis ensures Monaco editor icons display properly in the mobile interface\nwhen viewing diffs, fixing missing codicon glyphs that would otherwise\nappear as empty squares or missing characters.\n\nThe font-face declaration must be in global CSS rather than component-\nscoped styles due to Chrome\u0027s shadow DOM font loading limitations.\n\nCo-Authored-By: sketch \u003chello@sketch.dev\u003e\nChange-ID: secee77cd7912efd9k\n" }, { "commit": "f0f9af07c40798f6424d428685338fd6fed2ae4c", "tree": "ebe89739754a049aa7446ae23d7bb07765ab7e87", "parents": [ "882e7ea7097129ff75e3595b049df585976e12a1" ], "author": { "name": "philip.zeyliger", "email": "philip.zeyliger@gmail.com", "time": "Fri Jun 20 15:29:14 2025 +0000" }, "committer": { "name": "Autoformatter", "email": "bot@sketch.dev", "time": "Fri Jun 20 18:08:22 2025 +0000" }, "message": "webui: remove unused sketch-diff-file-picker component\n\nRemove sketch-diff-file-picker component and all related imports/styles\nas it is no longer needed for multi-file diff view functionality.\n\nRemoved Files:\n- webui/src/web-components/sketch-diff-file-picker.ts (390 lines)\n\nUpdated Files:\n- Remove commented import from sketch-diff2-view.ts\n- Remove unused CSS styles for sketch-diff-file-picker\n- Clean up all references to SketchDiffFilePicker component\n\nThe multi-file diff view now uses a built-in file selector dropdown\ninstead of the separate picker component, simplifying the codebase\nand eliminating unused code.\n\nCo-Authored-By: sketch \u003chello@sketch.dev\u003e\nChange-ID: se8747dd5f2bfc50ak\n" }, { "commit": "1f8fe9c0531de311dc3847f766f748da28fc3368", "tree": "7301725c9d9270c286371790ef399edb0c670d16", "parents": [ "ffa94c65f4b7b3aabb0ecb50dbd9d8c2bfd40da3" ], "author": { "name": "Philip Zeyliger", "email": "philip@bold.dev", "time": "Fri Jun 20 02:56:28 2025 +0000" }, "committer": { "name": "Autoformatter", "email": "bot@sketch.dev", "time": "Fri Jun 20 03:04:47 2025 +0000" }, "message": "webui: fix Monaco editor initialization parentNode errors in diff view\n\nAdd proper Lit component lifecycle validation to ensure Monaco editor container\nis connected to the document before initialization, preventing \u0027undefined parentNode\u0027\nerrors during diff view loading.\n\nThe fix uses await this.updateComplete and validates both component and container\nconnection state, eliminating race conditions between component rendering and\nMonaco API calls without using timeouts or retries.\n\nCo-Authored-By: sketch \u003chello@sketch.dev\u003e\nChange-ID: s85d1738b85a64745k\n" }, { "commit": "ffa94c65f4b7b3aabb0ecb50dbd9d8c2bfd40da3", "tree": "5f677bbf845f2b00777c2b7babe7a7dbacb49b93", "parents": [ "5477736d9678803a245764439df767bf0e7c561d" ], "author": { "name": "philip.zeyliger", "email": "philip.zeyliger@gmail.com", "time": "Thu Jun 19 18:43:37 2025 -0700" }, "committer": { "name": "Autoformatter", "email": "bot@sketch.dev", "time": "Fri Jun 20 01:44:11 2025 +0000" }, "message": "webui: add print styles for full chat printing\n\nImplement CSS print media queries across key webui components to ensure\ncomplete chat conversations can be printed without content truncation.\n\nThey\u0027re not perfect but better than nothing.\n\nCo-Authored-By: sketch \u003chello@sketch.dev\u003e\nChange-ID: s3815b4291912c721k\n" }, { "commit": "5477736d9678803a245764439df767bf0e7c561d", "tree": "887290d2e601739a4bfeae0b4e6638feb8bb393e", "parents": [ "65ff909493e8f27bcdc507ed27253e28c98eb5ec" ], "author": { "name": "banksean", "email": "banksean@gmail.com", "time": "Thu Jun 19 16:38:30 2025 +0000" }, "committer": { "name": "Autoformatter", "email": "bot@sketch.dev", "time": "Thu Jun 19 23:08:56 2025 +0000" }, "message": "webui: implement explicit initial render detection using State.message_count\n\nAdd explicit initial load completion detection to SketchTimeline component using\nState.message_count to determine when all existing messages have been loaded\nand the timeline is ready for initial render.\n\nImplementation Changes:\n\n1. DataManager Enhancement (data.ts):\n - Add expectedMessageCount and isInitialLoadComplete state tracking\n - Add \u0027initialLoadComplete\u0027 event type to DataManagerEventType union\n - Add checkInitialLoadComplete() method to validate completion state\n - Add handleInitialLoadComplete() event emission with message counts\n - Handle empty conversation edge case (message_count: 0) with immediate completion\n - Reset initial load state on connection establishment to handle reconnection\n - Add getIsInitialLoadComplete() and getExpectedMessageCount() getters\n\n2. Timeline Component Enhancement (sketch-timeline.ts):\n - Add isInitialLoadComplete state property for render control\n - Add dataManager property reference for event listener setup\n - Add handleInitialLoadComplete() event handler with console logging\n - Update render logic to show loading indicator until initial load complete\n - Apply \u0027view-initialized\u0027 CSS class when initial load completes\n - Only render messages and thinking indicator after initial load completion\n - Set up DataManager event listeners in updated() lifecycle hook\n - Clean up event listeners in disconnectedCallback() lifecycle hook\n\n3. App Shell Integration (sketch-app-shell.ts):\n - Pass dataManager reference to sketch-timeline component property\n - Enable timeline component to receive initial load completion events\n - Maintain existing data flow while adding explicit completion detection\n\n4. Demo Mock Enhancement (handlers.ts):\n - Initialize currentState with correct message_count based on initial messages\n - Ensure proper message_count synchronization in SSE stream simulation\n - Handle empty conversation demo scenario with accurate state\n\n5. Enhanced CSS Styling (sketch-timeline.ts):\n - Add opacity-based transitions for message appearance\n - Show loading indicator before initial completion\n - Hide message content until view-initialized class is applied\n - Smooth transition from loading to content display\n\nTechnical Benefits:\n- Eliminates reliance on implicit \u0027first message means streaming started\u0027 detection\n- Provides explicit completion signal when all existing messages are loaded\n- Handles edge cases like empty conversations (0 messages) immediately\n- Prevents flash of incomplete content during initial load\n- Enables proper loading states and smooth transitions\n- Supports reconnection scenarios with state reset\n\nUser Experience Improvements:\n- Clear loading indicator until conversation is fully loaded\n- Smooth transition from loading to content display\n- No flash of partial message lists during initial load\n- Consistent behavior across different conversation sizes\n- Better feedback during network delays or large conversation loads\n\nEdge Case Handling:\n- Empty conversations (message_count: 0) marked complete immediately\n- Messages arriving before state handled gracefully\n- Reconnection scenarios reset initial load detection\n- Race conditions between state and message delivery resolved\n\nThis replaces the implicit initial load detection with explicit State.message_count\nbased completion detection, providing more reliable initial render timing and\nbetter user experience during conversation loading.\n\nCo-Authored-By: sketch \u003chello@sketch.dev\u003e\nChange-ID: s5126c2705d6ad6bak\n" }, { "commit": "65ff909493e8f27bcdc507ed27253e28c98eb5ec", "tree": "c5c8eb1dc785f62fa5b3843fcc3ff653200cce59", "parents": [ "b774437ff57fb95b14d326cc6be2c9937bdb6a78" ], "author": { "name": "banksean", "email": "banksean@gmail.com", "time": "Thu Jun 19 00:36:25 2025 +0000" }, "committer": { "name": "Sean McCullough", "email": "banksean@gmail.com", "time": "Wed Jun 18 21:22:21 2025 -0400" }, "message": "webui: preserve chat scroll position when switching tabs\n\nFix scroll position preservation in SketchAppShell to maintain chat timeline\nscroll position when navigating between tabs, preventing automatic scroll\nto top when returning to the chat view.\n\nImplementation Changes:\n\n1. Scroll Position Storage:\n - Add _chatScrollPosition state property to track chat scroll position\n - Store scroll position when leaving chat view in toggleViewMode()\n - Only store position if content is scrollable and user has actually scrolled\n - Validate scrollHeight \u003e clientHeight and scrollTop \u003e 0 before storing\n\n2. Scroll Position Restoration:\n - Restore scroll position when returning to chat view\n - Use requestAnimationFrame to ensure DOM is ready before restoration\n - Add safety checks to verify view mode and container connection\n - Validate container is still connected before applying scroll position\n\n3. Smart Reset Logic:\n - Reset stored scroll position when new messages arrive and user is near bottom\n - Check if user is within 50px of bottom (isNearBottom) before resetting\n - Allow timeline auto-scroll behavior for new messages when user is following\n - Preserve position when user has scrolled up to read older messages\n\n4. Defensive Programming:\n - Add comprehensive validation for scroll container existence\n - Check scrollHeight, clientHeight, and scrollTop before calculations\n - Validate viewMode matches expected state during restoration\n - Ensure container.isConnected before DOM manipulation\n\nTechnical Details:\n- Uses existing scrollContainerRef for scroll container access\n- Maintains compatibility with existing scroll behavior in sketch-timeline\n- Preserves timeline auto-scroll for new messages when user is at bottom\n- Only stores meaningful scroll positions (not zero or invalid values)\n- Handles edge cases like rapid tab switching or container changes\n\nUser Experience:\n- Chat tab now remembers scroll position when switching to diff/terminal tabs\n- Reading older messages no longer interrupted by tab navigation\n- New messages still auto-scroll when user is following conversation\n- Smooth restoration without visible jumps or layout shifts\n\nThis resolves the issue where the chat timeline would always scroll to the\noldest message when navigating back from other tabs, significantly improving\nthe user experience when reviewing conversation history.\n\nCo-Authored-By: sketch \u003chello@sketch.dev\u003e\nChange-ID: s3a52c0413098ade3k\n" }, { "commit": "b774437ff57fb95b14d326cc6be2c9937bdb6a78", "tree": "43fde963077252de8c57e3bcf4957aae70431e25", "parents": [ "e68613d5105c86652d5287102e1bd4ad0859b781" ], "author": { "name": "Sean McCullough", "email": "banksean@gmail.com", "time": "Thu Jun 19 00:01:07 2025 +0000" }, "committer": { "name": "Autoformatter", "email": "bot@sketch.dev", "time": "Thu Jun 19 00:32:20 2025 +0000" }, "message": "webui: add comprehensive unit tests for sketch-timeline incremental rendering\n\nCreate sketch-timeline.test.ts with comprehensive unit tests covering all major\nincremental rendering features and viewport management functionality.\n\nTest Categories:\n\n1. Basic Rendering Tests:\n - Empty state rendering with welcome box\n - Message rendering with timeline-message components\n - Thinking indicator display during agent activity\n - Message filtering (hide_output flag handling)\n\n2. Viewport Management Tests:\n - Initial message count limiting (initialMessageCount property)\n - Viewport expansion with loadChunkSize increments\n - resetViewport method functionality\n - Most recent message display prioritization\n\n3. Scroll State Management Tests:\n - Jump-to-latest button visibility based on scroll state\n - Button click triggering scroll-to-bottom functionality\n - Scroll state transitions (pinToLatest vs floating)\n\n4. Loading State Tests:\n - Loading indicator display during older message fetching\n - Loading indicator hiding when not in loading state\n - Loading spinner and text rendering\n\n5. Memory Management Tests:\n - Scroll container change handling with proper cleanup\n - Event listener management across container transitions\n - Loading operation cancellation on viewport reset\n\n6. Message Handling Tests:\n - Message ordering (chronological display)\n - Previous message context passing\n - Message array updates and re-rendering\n - Edge cases with empty filtered messages\n\n7. Event Handling Tests:\n - show-commit-diff event bubbling from message components\n - Custom event dispatching and detail handling\n\n8. Utility Function Tests:\n - messageKey method for unique message identification\n - Key generation with tool_calls consideration\n\nTechnical Implementation:\n- Uses @sand4rt/experimental-ct-web testing framework\n- Implements proper TypeScript types and component mounting\n- Creates comprehensive mock message factory functions\n- Uses component.evaluate() for internal state access and method calls\n- Includes proper cleanup and error handling patterns\n- Declares global window interface extensions for test utilities\n\nTest Coverage:\n- 25+ test cases covering all major incremental rendering features\n- Skips complex async operations that require integration testing\n- Focuses on state management, rendering logic, and event handling\n- Validates viewport calculation mathematics and edge cases\n\nThis provides thorough test coverage for the incremental rendering functionality\nwhile maintaining compatibility with the existing test infrastructure and\nensuring reliable behavior across all viewport management scenarios.\n\nCo-Authored-By: sketch \u003chello@sketch.dev\u003e\nChange-ID: s2da61be85adaca75k\n\nwebui: remove empty placeholder tests from sketch-timeline.test.ts\n\nRemove two skipped test placeholders that contained only comments:\n- \u0027handles scroll events correctly\u0027\n- \u0027performs loading operations with proper race condition prevention\u0027\n\nThese placeholder tests provided no value and the functionality they referenced\nis already covered by the interactive demo and other existing tests.\n\nCo-Authored-By: sketch \u003chello@sketch.dev\u003e\nChange-ID: s0119049ed970c057k\n\nwebui: fix TypeScript error in sketch-timeline test tool_calls structure\n\nFix ToolCall interface mismatch in messageKey test by using correct properties:\n- Replace incorrect \u0027type\u0027 and \u0027function\u0027 properties with \u0027name\u0027 and \u0027input\u0027\n- Add proper \u0027result_message\u0027 as AgentMessage instead of string\n- Ensure tool_calls array matches actual ToolCall interface from types.ts\n\nThis resolves the TypeScript compilation error:\n\u0027Type string is not assignable to type AgentMessage\u0027\n\nCo-Authored-By: sketch \u003chello@sketch.dev\u003e\nChange-ID: s8570c39653681f17k\n\nwebui: fix test failures in sketch-timeline.test.ts\n\nFix 4 failing test cases with proper Playwright test patterns:\n\n1. filters out messages with hide_output flag:\n - Replace problematic not.toContainText() on multiple elements\n - Use individual textContent() checks to verify hidden message exclusion\n - Check each visible message individually instead of using strict mode violation\n\n2. jump-to-latest button calls scroll method:\n - Fix window object type casting with (window as any)\n - Ensure scrollCalled property is properly set and retrieved\n\n3. handles scroll container changes properly:\n - Move mock container creation inside evaluate() to avoid serialization issues\n - Use window object to track addEventListener/removeEventListener calls\n - Initialize counters properly and retrieve them after operations\n\n4. handles empty filteredMessages gracefully:\n - Expect .timeline-container instead of .welcome-box for hidden messages\n - Welcome box only shows when messages array is completely empty\n - Hidden messages still render timeline container, just with no message elements\n\nThese fixes address Playwright\u0027s strict mode requirements and proper async\noperation handling in component tests.\n\nCo-Authored-By: sketch \u003chello@sketch.dev\u003e\nChange-ID: s30192a1528e84a61k\n\nwebui: fix remaining test failures in sketch-timeline.test.ts\n\nFix the last 2 failing test cases:\n\n1. jump-to-latest button calls scroll method:\n - Initialize scrollCalled flag to false before mocking\n - Combine all setup operations in single evaluate() call\n - Add verification that button is visible before clicking\n - Ensure proper order of mock setup and button interaction\n\n2. handles empty filteredMessages gracefully:\n - Correct test expectations to match actual component behavior\n - Component only shows welcome box when messages.length \u003d\u003d\u003d 0\n - Hidden messages (hide_output: true) still render timeline structure\n - Use toBeAttached() instead of toBeVisible() for timeline container\n - Timeline container may be CSS hidden but still attached to DOM\n\nThese fixes address the remaining Playwright test failures by properly\nunderstanding the component\u0027s conditional rendering logic and ensuring\nproper test setup order for async operations.\n\nCo-Authored-By: sketch \u003chello@sketch.dev\u003e\nChange-ID: s7fecd7e2c7824913k\n" }, { "commit": "e68613d5105c86652d5287102e1bd4ad0859b781", "tree": "ed2b409f2c3649ae0afc14cc3df31c89382106eb", "parents": [ "e0a9f7252a39c66ffa409daa9fd0ac5c6b08a100" ], "author": { "name": "Sean McCullough", "email": "banksean@gmail.com", "time": "Wed Jun 18 14:48:53 2025 +0000" }, "committer": { "name": "Autoformatter", "email": "bot@sketch.dev", "time": "Wed Jun 18 23:44:00 2025 +0000" }, "message": "webui: implement viewport-based message rendering in sketch-timeline\n\nAdd viewport-based rendering to SketchTimeline component to optimize performance\nwith large conversation histories by only rendering messages in current viewport.\n\nImplementation Changes:\n\n1. Viewport Management:\n - Add initialMessageCount property (default: 30) to control initial render\n - Add loadChunkSize property (default: 20) for batch loading older messages\n - Add visibleMessageStartIndex state to track current viewport window\n - Add isLoadingOlderMessages state to prevent concurrent load operations\n\n2. Message Filtering and Windowing:\n - Create filteredMessages getter to exclude hidden messages\n - Create visibleMessages getter to return current viewport slice\n - Implement loadOlderMessages() to expand viewport window on scroll\n - Preserve scroll position when prepending older messages\n\n3. Scroll-Based Loading:\n - Add loadMoreThreshold property (100px from top) for trigger distance\n - Enhance _handleScroll() to detect near-top scroll and trigger loading\n - Add loading indicator with spinner for older message loading states\n - Maintain existing \u0027pinToLatest\u0027 and \u0027floating\u0027 scroll behaviors\n\n4. Updated Rendering Logic:\n - Replace direct messages.filter() with visibleMessages getter\n - Add loading indicator rendering above message list\n - Preserve message key generation for efficient re-rendering\n - Maintain proper previousMessage calculation for filtered messages\n\n5. Lifecycle Management:\n - Reset viewport window on significant message changes\n - Preserve scroll-to-bottom behavior for new messages\n - Handle edge cases for empty messages and initial load states\n\nTechnical Details:\n- Uses slice-based windowing instead of full virtual scrolling for simplicity\n- Implements scroll position preservation using scrollHeight differences\n- Maintains efficient message key generation for Lit\u0027s repeat directive\n- Preserves all existing timeline functionality and styling\n- Loading indicator appears only during older message fetching operations\n\nBenefits:\n- Significant performance improvement for large conversation histories\n- Reduced initial render time by limiting message count\n- Progressive loading maintains responsive UI during scroll\n- Maintains existing scroll behaviors and user experience\n- Memory usage scales with viewport size rather than total messages\n\nThis implements the requested viewport-based rendering while preserving all\nexisting SketchTimeline functionality and user experience patterns.\n\nCo-Authored-By: sketch \u003chello@sketch.dev\u003e\nChange-ID: sbe64498bdb5fd1cck\n\nwebui: fix viewport rendering to always show most recent messages initially\n\nFix viewport calculation logic in SketchTimeline to ensure the most recent\nmessages are always displayed on initial load, addressing issue where first\nmessages were shown instead of latest ones.\n\nRoot Cause:\nThe original viewport calculation used subtraction logic that was prone to\nshowing older messages when the viewport state wasn\u0027t properly initialized\nor when messages loaded incrementally.\n\nImplementation Changes:\n\n1. Simplified Viewport Logic:\n - Replace complex subtraction-based calculation with direct slice approach\n - Use \u0027totalVisible \u003d initialMessageCount + visibleMessageStartIndex\u0027\n - Calculate startIndex as \u0027max(0, filteredMessages.length - totalVisible)\u0027\n - Always slice from startIndex to end to show most recent messages\n\n2. Enhanced Viewport Reset Logic:\n - Trigger viewport reset for large message count changes (\u003e20 difference)\n - Reset viewport on initial load (oldMessages.length \u003d\u003d\u003d 0)\n - Reset viewport when message count decreases (session change)\n\n3. Added Public Reset Method:\n - Add resetViewport() public method for external viewport reset\n - Useful for app shell to call when loading new sessions\n - Updated demo to demonstrate manual viewport reset\n\n4. Improved Demo:\n - Add expected message range display in demo info\n - Add viewport reset button for testing\n - Call resetViewport() on message generation for consistent behavior\n\nTechnical Details:\n- Viewport now correctly shows messages [N-30, N] initially for N total messages\n- Scroll-up loading expands to show [N-30-X, N] where X is loaded chunk size\n- Eliminates race conditions between message loading and viewport calculation\n- Maintains all existing scroll behaviors and performance optimizations\n\nThis ensures users always see the most recent conversation content when\nloading sessions with large message histories, matching expected chat UX.\n\nCo-Authored-By: sketch \u003chello@sketch.dev\u003e\nChange-ID: s56dda43278ce4d5bk\n\nwebui: fix scroll container height and demo setup for viewport rendering\n\nFix scroll container CSS and demo JavaScript to enable proper scrolling and\nviewport testing in the sketch-timeline component.\n\nCSS Fix:\n- Add \u0027height: 100%\u0027 to #scroll-container to properly constrain container height\n- Enables overflow scrolling when content exceeds available space\n- Fixes issue where scrollHeight \u003d\u003d\u003d clientHeight prevented scrolling\n\nDemo Setup Fix:\n- Correct scrollContainer property setup using shadow DOM reference\n- Wait for component render before setting scroll container reference\n- Use proper Lit Ref pattern: { value: scrollContainerElement }\n- Add console logging for debugging scroll container setup\n\nTesting Results:\n- Viewport rendering now works correctly with 500+ messages\n- Initial load shows most recent 20 messages (e.g., 481-500 for 500 total)\n- Scroll-up loading successfully expands viewport (20 → 30 → 40 messages)\n- Proper scroll position preservation when loading older messages\n- Jump-to-latest button appears when not pinned to bottom\n\nThis fixes the demo functionality and confirms viewport rendering works as\ndesigned for performance optimization with large conversation histories.\n\nCo-Authored-By: sketch \u003chello@sketch.dev\u003e\nChange-ID: s998bb29cf9f06291k\n\nwebui: eliminate setTimeout in viewport demo for reliable initialization\n\nReplace setTimeout-based initialization with proper event-driven setup using\nMutationObserver and Lit\u0027s updateComplete promise for robust demo functionality.\n\nProblems with setTimeout Approach:\n- Race conditions between component rendering and scroll setup\n- Arbitrary delays cause flakiness in different environments\n- No guarantee that shadow DOM or scroll container exists after timeout\n- Unreliable for automated testing or slower systems\n\nImproved Event-Driven Approach:\n\n1. MutationObserver Pattern:\n - Watch for shadow DOM creation using MutationObserver\n - Disconnect observer once shadow DOM is detected\n - Eliminates timing-based guesswork\n\n2. Lit updateComplete Promise:\n - Use timeline.updateComplete to ensure full component render\n - Promise-based approach guarantees completion before setup\n - Handles both initial render and re-renders reliably\n\n3. Robust Fallback Strategy:\n - Try immediate setup first (component may already be ready)\n - Use MutationObserver for shadow DOM detection\n - Apply updateComplete promise for render completion\n - Multiple strategies ensure setup works in all scenarios\n\n4. Promise-Based Message Generation:\n - Use updateComplete in generateMessages() for reliable info updates\n - Ensure scroll container setup after each message array change\n - Eliminates race between message updates and UI state\n\nTesting Results:\n- Reliable setup across page reloads and component re-initialization\n- Consistent scroll container configuration without timing issues\n- Proper viewport loading functionality (20→30 messages on scroll up)\n- No console errors or failed setup attempts\n\nThis eliminates demo flakiness and provides a robust example of proper\nLit component initialization patterns for complex shadow DOM interactions.\n\nCo-Authored-By: sketch \u003chello@sketch.dev\u003e\nChange-ID: s6b897544f3af8454k\n\nwebui: fix memory leaks and race conditions in sketch-timeline scroll handling\n\nImplement proper event listener cleanup and debounced scroll handling to prevent\nmemory leaks and race conditions in SketchTimeline incremental rendering.\n\nMemory Leak Fixes:\n\n1. Scroll Container Tracking:\n - Add currentScrollContainer property to track active scroll listener\n - Implement addScrollListener() with automatic cleanup of previous listeners\n - Implement removeScrollListener() with guaranteed cleanup\n - Replace fragile scrollContainer.value?.removeEventListener with tracked cleanup\n\n2. Event Listener Lifecycle:\n - Ensure proper cleanup in disconnectedCallback() using removeScrollListener()\n - Handle scrollContainer property changes with proper cleanup sequence\n - Add scroll timeout cleanup to prevent lingering timers\n - Track and clean up scroll container references to prevent stale listeners\n\nRace Condition Prevention:\n\n3. Debounced Scroll Handling:\n - Add scrollTimeout property to debounce scroll events\n - Implement 100ms debounce for loadOlderMessages() calls\n - Maintain immediate scroll state updates for responsive UI\n - Clear pending timeouts during cleanup to prevent memory leaks\n\n4. Loading State Protection:\n - Add comprehensive error handling in loadOlderMessages()\n - Implement 5-second timeout fallback to prevent stuck loading state\n - Add bounds checking for visibleMessageStartIndex calculation\n - Use try-catch blocks for scroll position restoration\n\n5. Robust Error Recovery:\n - Check container.isConnected before DOM manipulation\n - Add fallback timeout to reset loading state if updateComplete fails\n - Log warnings for debugging without breaking functionality\n - Ensure isLoadingOlderMessages always gets reset\n\nTechnical Implementation:\n- Uses proper TypeScript typing with HTMLElement | null for container tracking\n- Implements window.setTimeout for proper timeout management\n- Maintains all existing scroll behavior while preventing memory leaks\n- Preserves scroll position restoration with error recovery\n- Compatible with existing viewport rendering functionality\n\nTesting:\n- Add testMemoryLeakFix() function to viewport demo for validation\n- Verify cleanup happens correctly during scroll container changes\n- Confirm no lingering event listeners after component disconnection\n- Test loading state timeout recovery mechanisms\n\nThis resolves the critical memory leak issues identified in the timeline\ncomponent while maintaining all existing functionality and user experience.\n\nCo-Authored-By: sketch \u003chello@sketch.dev\u003e\nChange-ID: seb56a936de452cefk\n\nwebui: enhance memory leak test in timeline viewport demo\n\nAdd comprehensive test for scroll event listener cleanup validation with\nimproved logging and multiple cleanup scenarios for testing memory leak fixes.\n\nCo-Authored-By: sketch \u003chello@sketch.dev\u003e\nChange-ID: sd1928398dca67ad9k\n\nwebui: eliminate race conditions in sketch-timeline scroll handling and loading operations\n\nImplement comprehensive race condition prevention in SketchTimeline incremental\nrendering with async loading operations and proper state management.\n\nRace Condition Fixes:\n\n1. Async Loading Operations:\n - Convert loadOlderMessages() to async/await pattern for proper sequencing\n - Add currentLoadingOperation tracking to prevent concurrent loads\n - Implement executeScrollPositionRestoration() with proper error handling\n - Use Promise-based DOM update waiting instead of fire-and-forget callbacks\n\n2. Loading State Management:\n - Add cancelCurrentLoadingOperation() method for safe operation cancellation\n - Implement clearAllPendingOperations() to clean up all timeouts and operations\n - Add loadingTimeoutId tracking for proper timeout cleanup\n - Add pendingScrollRestoration tracking for cancellable scroll operations\n\n3. Scroll Container Validation:\n - Add isStableForLoading() method to validate component state before operations\n - Verify scroll container hasn\u0027t changed during async operations\n - Check container.isConnected before DOM manipulation\n - Validate container matches currentScrollContainer throughout operation lifecycle\n\n4. Property Change Coordination:\n - Cancel loading operations when scrollContainer property changes\n - Cancel operations during significant message array changes\n - Handle viewport resets during loading with proper state cleanup\n - Prevent scroll-to-bottom during loading operations to avoid conflicts\n\n5. Enhanced Scroll Position Restoration:\n - Add comprehensive validation for scroll calculations before applying\n - Implement bounds checking for scroll position values\n - Add debug logging for invalid restoration attempts\n - Ensure restoration only happens if calculations are mathematically valid\n\n6. Component Lifecycle Protection:\n - Cancel loading operations in disconnectedCallback() before cleanup\n - Handle rapid property changes without state corruption\n - Prevent operations on disconnected or invalid containers\n - Ensure all timeouts and promises are cleaned up during disconnection\n\nTechnical Implementation:\n- Uses async/await throughout loading pipeline for proper sequencing\n- Implements operation cancellation with proper cleanup guarantees\n- Added container stability checks before all DOM operations\n- Uses typed Promise returns for better error handling\n- Maintains backward compatibility with existing scroll behavior\n\nTesting Enhancements:\n- Add testRaceConditions() function to demo for validation\n- Test rapid viewport resets, container changes, and message updates\n- Verify graceful handling of component state changes during loading\n- Validate proper cleanup during simulated disconnection scenarios\n\nBenefits:\n- Eliminates concurrent loading operations that could corrupt state\n- Prevents scroll position restoration conflicts and invalid calculations\n- Ensures consistent component state during rapid user interactions\n- Provides robust error recovery for all async operations\n- Maintains responsive UI while preventing race-related bugs\n\nThis resolves all identified race conditions while preserving existing\nfunctionality and improving overall component reliability and performance.\n\nCo-Authored-By: sketch \u003chello@sketch.dev\u003e\nChange-ID: sc0c567cfff13ae3fk\n\nwebui: replace setTimeout with event-driven patterns in sketch-timeline\n\nEliminate setTimeout dependencies in favor of proper event-driven and async/await\npatterns for more reliable and performant timeline operations.\n\nEvent-Driven Replacements:\n\n1. Scroll Debouncing:\n - Replace setTimeout-based debouncing with requestAnimationFrame\n - Use scrollDebounceFrame with cancelAnimationFrame for smooth performance\n - Eliminate arbitrary 100ms delays in favor of browser-optimized frame timing\n - Maintain responsive UI updates while preventing excessive loading calls\n\n2. Loading Operation Management:\n - Replace setTimeout fallback with AbortController for proper cancellation\n - Add loadingAbortController for clean operation abortion\n - Implement signal-based cancellation throughout loading pipeline\n - Remove 5-second timeout fallback in favor of proper Promise rejection handling\n\n3. Scroll Position Restoration:\n - Replace setTimeout retry logic with ResizeObserver-based content detection\n - Add waitForContentReady() using ResizeObserver to detect when DOM is ready\n - Use requestAnimationFrame for frame-perfect scroll position updates\n - Eliminate arbitrary delays and retry intervals\n\n4. Auto-Scroll to Bottom:\n - Replace setTimeout-based retry with MutationObserver approach\n - Use scrollToBottomWithRetry() with event-driven content change detection\n - Implement requestAnimationFrame for smooth scroll operations\n - Remove hardcoded retry intervals and attempt limits\n\n5. Component Lifecycle:\n - Add disconnectObservers() for proper cleanup of ResizeObserver and MutationObserver\n - Replace clearTimeout calls with cancelAnimationFrame and AbortController.abort()\n - Ensure all async operations can be properly cancelled during component lifecycle\n\nTechnical Benefits:\n- Uses browser-native APIs (ResizeObserver, MutationObserver, AbortController)\n- Eliminates race conditions from setTimeout timing assumptions\n- Provides frame-perfect animations with requestAnimationFrame\n- Enables proper cancellation of async operations with AbortController\n- Reduces arbitrary delays and improves perceived performance\n\nImplementation Details:\n- AbortController provides clean cancellation semantics for loading operations\n- ResizeObserver detects content changes without polling or timeouts\n- MutationObserver monitors DOM changes for scroll position adjustments\n- requestAnimationFrame ensures operations happen at optimal frame timing\n- All observers are created on-demand and properly cleaned up\n\nTesting Enhancements:\n- Add testEventDriven() function to validate no setTimeout usage\n- Test AbortController availability and proper operation cancellation\n- Verify ResizeObserver, MutationObserver, and requestAnimationFrame support\n- Monitor setTimeout calls during operations to ensure elimination\n\nThis modernizes the timeline component to use proper browser APIs instead of\nsetTimeout workarounds, improving reliability and performance while eliminating\ntiming-based race conditions.\n\nCo-Authored-By: sketch \u003chello@sketch.dev\u003e\nChange-ID: se869d73b455454a5k\n" }, { "commit": "e08609352271d61acb57774cdbfa91f1d35b1931", "tree": "d2d0609057422a33579552a8a191c179158a0050", "parents": [ "963ae4b514ed20fc84c63c4cc6de028a99964448" ], "author": { "name": "Philip Zeyliger", "email": "philip@bold.dev", "time": "Wed Jun 18 13:01:17 2025 -0700" }, "committer": { "name": "Philip Zeyliger", "email": "philip@bold.dev", "time": "Wed Jun 18 13:01:17 2025 -0700" }, "message": "Re-enable monaco horizontal scroll bars.\n\nLike all things LLM and Monaco, the key here is to delete things\nthat aren\u0027t default until things get better. The scrollbars don\u0027t\nshow up because they aren\u0027t necessary, and, when the horizontal\nones are necessary, they now show up.\n\nI\u0027m still seeing two bugs:\n\n1. If you click into the diff the first time on some line, especially\nif it\u0027s the second diff block, Monaco jumps to a different area. This\nis kind of terrible and annoying.\n\n2. My touchpad should let me scroll right/left as well as vertical, but\nI\u0027m only getting vertical scrolling in this mode.\n" }, { "commit": "f964b50b76225e209dfb940b7c6d2f737939510a", "tree": "3412b5ec743551be03f69ffc553ee1393da43c52", "parents": [ "28e39ac7817834d258a0f75a33b4590c769cb1bc" ], "author": { "name": "Autoformatter", "email": "bot@sketch.dev", "time": "Tue Jun 17 04:30:35 2025 +0000" }, "committer": { "name": "Autoformatter", "email": "bot@sketch.dev", "time": "Tue Jun 17 04:30:35 2025 +0000" }, "message": "all: fix formatting\n" }, { "commit": "6b8b7660f2e2e964453ebace40dda7122f6d9eca", "tree": "dcb6ba6d5a2d18fcffe8d44d6960bd41fd29121c", "parents": [ "7c1a687d03341b94b4a3c71706c47e3e14927707" ], "author": { "name": "philip.zeyliger", "email": "philip.zeyliger@gmail.com", "time": "Mon Jun 16 03:06:30 2025 +0000" }, "committer": { "name": "Philip Zeyliger", "email": "philip@bold.dev", "time": "Mon Jun 16 21:30:06 2025 -0700" }, "message": "webui: add mobile diff view with Monaco inline diffing\n\nThanks, Sketch. There are still some rough edges, but it\u0027s not bad.\n\nCo-Authored-By: sketch \u003chello@sketch.dev\u003e\nChange-ID: se4f6567dc0dabd31k\n" }, { "commit": "7c1a687d03341b94b4a3c71706c47e3e14927707", "tree": "18361873a51cd6217f10650f122b88fabd44ac07", "parents": [ "d4eea221b455e06fe7f897d1e04a8833015e893c" ], "author": { "name": "philip.zeyliger", "email": "philip.zeyliger@gmail.com", "time": "Mon Jun 16 03:54:37 2025 +0000" }, "committer": { "name": "Autoformatter", "email": "bot@sketch.dev", "time": "Tue Jun 17 04:27:18 2025 +0000" }, "message": "webui: implement Mermaid code splitting with lazy loading\n\nSplit Mermaid library into separate bundle with content-based hashing for\noptimal caching and reduced bundle size in main application components.\n\nImplementation Changes:\n\n1. Lazy Loading Infrastructure (sketch-timeline-message.ts):\n - Replace direct mermaid import with type-only import\n - Add loadMermaid() function with Promise-based dynamic loading\n - Implement __MERMAID_HASH__ constant injection pattern\n - Add global window.mermaid type declarations\n - Create mermaid loading promise with singleton pattern\n\n2. Bundle Splitting (esbuild.go):\n - Add createStandaloneMermaidBundle() function\n - Generate content-based hash from mermaid package.json\n - Create mermaid-standalone-{hash}.js as IIFE format bundle\n - Implement esbuildBundleWithExternals() replacing esbuildBundleWithExternal()\n - Add --external:mermaid to all TypeScript bundle builds\n - Inject __MERMAID_HASH__ constant at build time\n\n3. Async Rendering (sketch-timeline-message.ts):\n - Update renderMermaidDiagrams() to async/await pattern\n - Load mermaid library only when diagrams are present\n - Initialize mermaid configuration after dynamic loading\n - Maintain fallback to code blocks on loading errors\n - Preserve all existing mermaid functionality and configuration\n\nTechnical Details:\n- Uses content-based hashing for optimal browser caching\n- Mermaid loaded on-demand only when diagrams are present\n- Singleton loading pattern prevents duplicate network requests\n- Maintains existing mermaid initialization options\n- Preserves error handling with code block fallbacks\n- IIFE format enables direct window.mermaid assignment\n\nBenefits:\n- Reduces bundle size for components not using mermaid diagrams\n- Enables browser caching of mermaid library across sessions\n- Maintains existing functionality with lazy loading\n- Improves initial page load performance\n- Provides same user experience with deferred mermaid loading\n\nThis follows the same pattern established for Monaco editor bundling,\nproviding consistent lazy loading architecture for large dependencies.\n\nCo-Authored-By: sketch \u003chello@sketch.dev\u003e\nChange-ID: s0f8a82fcd28add05k\n" }, { "commit": "64f60461b00c474b0b4747a06177d5c7a357bba9", "tree": "cfeceff998a165af451099c0ec23b5d2b0fd42f2", "parents": [ "db8caa0eb8576b8c0d65cc0b7b6aa4e241a7cdb1" ], "author": { "name": "Philip Zeyliger", "email": "philip@bold.dev", "time": "Mon Jun 16 13:57:10 2025 -0700" }, "committer": { "name": "Autoformatter", "email": "bot@sketch.dev", "time": "Mon Jun 16 20:58:24 2025 +0000" }, "message": "loop: add diff stats from sketch-base to HEAD in /state endpoint\n\nAdd lines added/removed statistics computed from sketch-base to current HEAD,\ndisplayed in webui Diff mode button for quick change overview.\n\nCo-Authored-By: sketch \u003chello@sketch.dev\u003e\nChange-ID: s3f10ecf39df6b581k\n" }, { "commit": "021231a933867854ad46ab6202ca4fd5bf50a8fd", "tree": "41f110e3aeeba8dc25483eea69e5138417039682", "parents": [ "2f8464cc1f0f25ec209ec5f710f6794a36700a5b" ], "author": { "name": "Sean McCullough", "email": "banksean@gmail.com", "time": "Thu Jun 12 09:35:24 2025 -0700" }, "committer": { "name": "Autoformatter", "email": "bot@sketch.dev", "time": "Mon Jun 16 04:52:33 2025 +0000" }, "message": "add /dist/messages-viewer.js bundle output\n" }, { "commit": "2f8464cc1f0f25ec209ec5f710f6794a36700a5b", "tree": "94a96915ba9a6f22dd031f0a77c99a06d8a090d7", "parents": [ "29c481c8d3bbe6124d3b273d2a154081d8472f08" ], "author": { "name": "Autoformatter", "email": "bot@sketch.dev", "time": "Mon Jun 16 04:27:05 2025 +0000" }, "committer": { "name": "Autoformatter", "email": "bot@sketch.dev", "time": "Mon Jun 16 04:27:05 2025 +0000" }, "message": "all: fix formatting\n" }, { "commit": "c0a4459e3f5c8e68649bb45f2c309f6f01928ab7", "tree": "3e239adc18145cac2f8cd920b7c6c63bf0a4def1", "parents": [ "38499cc1970fadc688567ec10ea92bfca187b929" ], "author": { "name": "philip.zeyliger", "email": "philip.zeyliger@gmail.com", "time": "Sun Jun 15 21:24:57 2025 -0700" }, "committer": { "name": "Philip Zeyliger", "email": "philip@bold.dev", "time": "Sun Jun 15 21:24:57 2025 -0700" }, "message": "webui: implement Monaco code splitting with external bundle loading\n\nSplit Monaco editor into separate bundle with content-based hashing, achieving\n99% size reduction in Monaco components (3.9MB to 42KB).\n\n- Enable minification in esbuild configuration\n- Create standalone Monaco bundle with content hash for optimal caching\n- Implement external Monaco loading with proper TypeScript types\n- Apply external Monaco to all TypeScript bundles for consistency\n\nBundle results:\n- sketch-monaco-view.js: 3.9MB → 42KB (99% reduction)\n- sketch-app-shell.js: 6.8MB → 3.0MB (Monaco external, still large due to mermaid/cytoscape/katex)\n- monaco-standalone-{hash}.js: 3.8MB cached separately\n\nApp shell remains large (3MB) due to mermaid dependencies - likely next optimization target.\n\nCo-Authored-By: sketch \u003chello@sketch.dev\u003e\nChange-ID: sc84907cb0ec24197k\n" }, { "commit": "38499cc1970fadc688567ec10ea92bfca187b929", "tree": "fcfdced525ed5818887872ffdab7666989bb6d95", "parents": [ "8a290e5a3df2ec7ba8de8ffbf52081e44b2d636f" ], "author": { "name": "Philip Zeyliger", "email": "philip@bold.dev", "time": "Sun Jun 15 21:17:05 2025 -0700" }, "committer": { "name": "Autoformatter", "email": "bot@sketch.dev", "time": "Mon Jun 16 04:17:53 2025 +0000" }, "message": "webui: restructure diff header layout for improved usability\n\nReorganize diff view header to show commits section always expanded on left\nand move file selector to right side, with expand/collapse button in header\nwhen single file is selected.\n\nCo-Authored-By: sketch \u003chello@sketch.dev\u003e\nChange-ID: s904ee76a60c89e75k\n" }, { "commit": "851d2bf4f9324b294c58bb5a79398269c2587a0d", "tree": "eed22a219e4a53c9935c2dcebc5d5223b668b2e2", "parents": [ "6255411d3c2bd8cfe9a25c261e1c9a28e549441c" ], "author": { "name": "philip.zeyliger", "email": "philip.zeyliger@gmail.com", "time": "Mon Jun 16 03:10:10 2025 +0000" }, "committer": { "name": "Autoformatter", "email": "bot@sketch.dev", "time": "Mon Jun 16 03:42:24 2025 +0000" }, "message": "webui: add tool calls display to mobile chat timeline\n\nCo-Authored-By: sketch \u003chello@sketch.dev\u003e\nChange-ID: s654197301b832e70k\n" }, { "commit": "6255411d3c2bd8cfe9a25c261e1c9a28e549441c", "tree": "063eb2f7ec0793176b9b3528d7279d6c42fedc53", "parents": [ "5c6d82996aab8c390e43ee6d2b3f81f7f26de629" ], "author": { "name": "Autoformatter", "email": "bot@sketch.dev", "time": "Sun Jun 15 19:23:33 2025 +0000" }, "committer": { "name": "Autoformatter", "email": "bot@sketch.dev", "time": "Sun Jun 15 19:23:33 2025 +0000" }, "message": "all: fix formatting\n" }, { "commit": "5c6d82996aab8c390e43ee6d2b3f81f7f26de629", "tree": "769af94e9c5b73db806df2b019fed0fba1bcea7f", "parents": [ "4cd0129069c668cdd72f4d5b941e8d328c5d3caf" ], "author": { "name": "David Crawshaw", "email": "david@zentus.com", "time": "Sun Jun 15 19:09:19 2025 +0000" }, "committer": { "name": "David Crawshaw", "email": "david@zentus.com", "time": "Sun Jun 15 12:23:00 2025 -0700" }, "message": "webui: invert diff view layout and improve file selector behavior\n\nCo-Authored-By: sketch \u003chello@sketch.dev\u003e\nChange-ID: s5b7c42b431634f10k\n" }, { "commit": "4cd0129069c668cdd72f4d5b941e8d328c5d3caf", "tree": "c0b4d3101ed8d7f5a3ddd797451ff6b4dba3e560", "parents": [ "216d2fc77e55ca2e435f4d3d50a7a3a055b3545e" ], "author": { "name": "David Crawshaw", "email": "david@zentus.com", "time": "Sun Jun 15 18:59:13 2025 +0000" }, "committer": { "name": "David Crawshaw", "email": "david@zentus.com", "time": "Sun Jun 15 12:20:59 2025 -0700" }, "message": "webui: bring back the old per-file diff view as an option\n\nCo-Authored-By: sketch \u003chello@sketch.dev\u003e\nChange-ID: s46e7d05cb0615b8fk\n" }, { "commit": "216d2fc77e55ca2e435f4d3d50a7a3a055b3545e", "tree": "1425cab92b3c209221b9e1f8cb2de2620f658827", "parents": [ "d4be7a2d950cbc637e324210ce2e9904b736b701" ], "author": { "name": "David Crawshaw", "email": "david@zentus.com", "time": "Sun Jun 15 18:45:53 2025 +0000" }, "committer": { "name": "David Crawshaw", "email": "david@zentus.com", "time": "Sun Jun 15 12:20:57 2025 -0700" }, "message": "webui: clean up diff view interface by removing unused features\n\nRemove refresh button, file count display, single commit mode, and hide\ncommit range controls behind collapsible Commits dropdown to streamline\nthe diff view interface.\n\nThis streamlined interface focuses attention on the actual diff content while\nkeeping advanced controls easily accessible through progressive disclosure,\ncreating a cleaner and more professional diff viewing experience.\n\nCo-Authored-By: sketch \u003chello@sketch.dev\u003e\nChange-ID: se64b0db10984cba9k\n" }, { "commit": "dba26b57dbdf09c006a84314b2b919e8256d0089", "tree": "c792f5452fe9a84abeaa0b6c421cf9c586fe8fcd", "parents": [ "ad15b6cc1ec990e139cbd0d462df301179a46f5e" ], "author": { "name": "David Crawshaw", "email": "david@zentus.com", "time": "Sun Jun 15 00:33:45 2025 +0000" }, "committer": { "name": "David Crawshaw", "email": "david@zentus.com", "time": "Sat Jun 14 17:57:26 2025 -0700" }, "message": "webui: fix Monaco editor horizontal scrollbar from border width overflow\n\nCo-Authored-By: sketch \u003chello@sketch.dev\u003e\nChange-ID: s555d4a157e574e32k\n" }, { "commit": "ad15b6cc1ec990e139cbd0d462df301179a46f5e", "tree": "7d45f57934a1ade6f21833d536219bcb847d1398", "parents": [ "f00c7b19133ee3e2d60bfb4eef117c0870c0bbc0" ], "author": { "name": "Autoformatter", "email": "bot@sketch.dev", "time": "Sun Jun 15 00:29:26 2025 +0000" }, "committer": { "name": "Autoformatter", "email": "bot@sketch.dev", "time": "Sun Jun 15 00:29:26 2025 +0000" }, "message": "all: fix formatting\n" }, { "commit": "f00c7b19133ee3e2d60bfb4eef117c0870c0bbc0", "tree": "acf2ac1953209027628f60c99fd4b41faec2de5f", "parents": [ "e2954ce9c186576151b5e0da05de1b37bb99afea" ], "author": { "name": "David Crawshaw", "email": "david@zentus.com", "time": "Sun Jun 15 00:24:46 2025 +0000" }, "committer": { "name": "David Crawshaw", "email": "david@zentus.com", "time": "Sat Jun 14 17:27:04 2025 -0700" }, "message": "webui: disable Monaco diff editor overview ruler\n\nRemove the overview ruler from Monaco diff editor by adding renderOverviewRuler: false\nto the editor configuration, providing a cleaner diff viewing experience.\n\nCo-Authored-By: sketch \u003chello@sketch.dev\u003e\nChange-ID: sc99558fc19a79a66k\n" }, { "commit": "e2954ce9c186576151b5e0da05de1b37bb99afea", "tree": "ef54edfec55171ff3faf8428e0f0e274b49e1ea5", "parents": [ "dbca8975c4616c02f284359fed07d4a2c1477301" ], "author": { "name": "David Crawshaw", "email": "david@zentus.com", "time": "Sun Jun 15 00:06:34 2025 +0000" }, "committer": { "name": "David Crawshaw", "email": "david@zentus.com", "time": "Sat Jun 14 17:12:58 2025 -0700" }, "message": "webui: fix diff view scrollbar visibility and resize handling\n\nFix Monaco editor scrollbar display issues and improve browser window resize\nresponsiveness in the diff view, providing a cleaner interface and better\nuser experience across different screen sizes.\n\nProblem Analysis:\nThe diff view had two significant issues affecting usability:\n\n1. Monaco Scrollbar Visibility: Despite setting scrollbar configuration to\n \u0027hidden\u0027, a large gray scrollbar remained visible on the right side of\n the Monaco diff editor. This was caused by insufficient CSS targeting\n of Monaco\u0027s complex DOM structure and scrollbar element hierarchy.\n\n2. Resize Handling: The diff view did not properly adapt when users resized\n their browser window. While the editor had automaticLayout: false and\n manual sizing, there was no window resize listener to trigger layout\n recalculation, causing the editor to maintain its original dimensions.\n\n3. Refresh Button Layout: At certain screen widths, the refresh button would\n wrap to its own line prematurely due to inflexible sizing constraints.\n\nImplementation Changes:\n\n1. Monaco Scrollbar Removal (sketch-diff2-view.ts):\n - Added comprehensive global CSS rules targeting all Monaco scrollbar elements\n - Targeted .monaco-editor, .monaco-diff-editor, and .monaco-scrollable-element\n - Applied multiple hiding techniques: display: none, visibility: hidden,\n width/height: 0, opacity: 0 for maximum coverage\n - Added padding/margin removal to prevent scrollbar space reservation\n - Ensured diff content takes full width without scrollbar spacing\n\n2. Window Resize Handler (sketch-monaco-view.ts):\n - Added setupWindowResizeHandler() method with debounced resize logic\n - Implemented 100ms debounce to prevent excessive layout calls\n - Added window \u0027resize\u0027 event listener that triggers fitEditorToContent()\n - Fallback layout call with current container dimensions if fit function unavailable\n - Proper cleanup in disconnectedCallback() to prevent memory leaks\n\n3. Layout Improvements (sketch-diff2-view.ts):\n - Set minimum width (400px) for sketch-diff-range-picker component\n - Added minimum width (120px) for file-count display\n - Ensured flex layout provides adequate space for all controls\n - Improved responsive behavior at various screen widths\n\n4. Enhanced Scrollbar Configuration (sketch-monaco-view.ts):\n - Extended scrollbar options with additional Monaco-specific settings:\n - useShadows: false to disable scrollbar shadows\n - verticalHasArrows: false / horizontalHasArrows: false to remove arrows\n - verticalScrollbarSize: 0 / horizontalScrollbarSize: 0 for zero track size\n - Combined configuration-based and CSS-based hiding for complete coverage\n\nTechnical Details:\n- Global CSS injection occurs once per diff view instance in constructor\n- Window resize handler uses setTimeout debouncing to avoid performance issues\n- Monaco editor layout() called with explicit dimensions during resize\n- CSS targeting covers all known Monaco scrollbar element patterns\n- Minimum width constraints prevent layout collapse at small screen sizes\n- Cleanup handlers prevent memory leaks when components are destroyed\n\nBenefits:\n- Clean, professional diff view appearance without distracting scrollbars\n- Smooth responsive behavior when browser window is resized\n- Improved layout stability for controls at various screen widths\n- Better user experience across desktop and mobile viewport sizes\n- Maintained full Monaco editor functionality (editing, syntax highlighting, etc.)\n\nTesting:\n- Verified scrollbar completely hidden at all screen sizes\n- Tested resize responsiveness from 600px to 1400px+ widths\n- Confirmed smooth transitions during window resize operations\n- Validated refresh button layout behavior at different breakpoints\n- Ensured Monaco editor features remain fully functional\n- Tested both horizontal and vertical window resize scenarios\n\nThis implementation provides a polished, responsive diff view experience\nthat properly adapts to user browser configurations while maintaining\nall advanced Monaco editor capabilities.\n\nCo-Authored-By: sketch \u003chello@sketch.dev\u003e\nChange-ID: sf19d359b4fcbcbdek\n" }, { "commit": "dbca8975c4616c02f284359fed07d4a2c1477301", "tree": "1752a1f4f1c16441d43f4f9b69e4120927d25bb3", "parents": [ "9abf803eeedd49261dc4e4c5b75dcb4d21cc6a0d" ], "author": { "name": "David Crawshaw", "email": "david@zentus.com", "time": "Sat Jun 14 23:46:58 2025 +0000" }, "committer": { "name": "Autoformatter", "email": "bot@sketch.dev", "time": "Sat Jun 14 23:50:10 2025 +0000" }, "message": "webui: improve diff view header layout and compactness\n\nConsolidate diff view header layout for better space efficiency and improved\nvisual organization of commit range selectors and file count display.\n\nChanges:\n1. Move file count to same line as commit range selectors\n2. Reduce per-file header padding from 12px to 8px\n3. Shorten commit selector entries to prevent overflow\n4. Change file count text from \u0027N files changed\u0027 to \u0027N files\u0027\n5. Prevent file count text from wrapping with white-space: nowrap\n\nLayout improvements create more compact header while maintaining usability.\n\nCo-Authored-By: sketch \u003chello@sketch.dev\u003e\nChange-ID: s54d391a2d5128fd4k\n" }, { "commit": "9abf803eeedd49261dc4e4c5b75dcb4d21cc6a0d", "tree": "abebff284ab5674aeacf125237619c26f998d1cb", "parents": [ "26f3f34c25e21717001f0230d1abe7debbc5e0c0" ], "author": { "name": "Autoformatter", "email": "bot@sketch.dev", "time": "Sat Jun 14 23:24:08 2025 +0000" }, "committer": { "name": "Autoformatter", "email": "bot@sketch.dev", "time": "Sat Jun 14 23:24:08 2025 +0000" }, "message": "all: fix formatting\n" }, { "commit": "26f3f34c25e21717001f0230d1abe7debbc5e0c0", "tree": "0ba518a643b4d165dd871b4a2cd28e5f096a017f", "parents": [ "938d2dcde4aaea8119e1c09ffa453de48560dd57" ], "author": { "name": "David Crawshaw", "email": "david@zentus.com", "time": "Sat Jun 14 19:58:32 2025 +0000" }, "committer": { "name": "David Crawshaw", "email": "david@zentus.com", "time": "Sat Jun 14 16:20:07 2025 -0700" }, "message": "webui: implement multi-file diff view with continuous scrolling\n\nReplace file selector with GitHub PR-style continuous scrolling through\nmultiple files in a single view, improving diff navigation experience\nwhile maintaining all Monaco editor features.\n\nProblem Analysis:\nThe existing diff view required users to navigate between files using a\ndropdown selector and Previous/Next buttons. This created friction when\nreviewing multi-file changes and broke the natural scrolling flow that\nusers expect from GitHub PR views or other modern diff interfaces.\n\nThe limitation was that Monaco doesn\u0027t provide a built-in multi-file diff\nwidget, requiring custom implementation with multiple IStandaloneDiffEditor\ninstances properly configured for stacking and auto-sizing.\n\nImplementation Changes:\n\n1. Multi-File Layout (sketch-diff2-view.ts):\n - Replaced sketch-diff-file-picker with simple file count display\n - Implemented renderFileDiff() to create separate diff sections per file\n - Added renderFileHeader() with status badges and path information\n - Created multi-file-diff-container with vertical stacking layout\n - Added loadAllFileContents() for parallel content loading\n - Replaced single originalCode/modifiedCode with Map\u003cstring, FileContent\u003e\n\n2. Monaco Auto-Sizing (sketch-monaco-view.ts):\n - Configured diff editors with hidden scrollbars per Monaco ≥0.49 pattern\n - Added setupAutoSizing() with content height calculation\n - Implemented fitEditorToContent() using getContentHeight() callbacks\n - Set automaticLayout: false for manual size control\n - Added scrollbar: { vertical: \u0027hidden\u0027, horizontal: \u0027hidden\u0027, handleMouseWheel: false }\n - Enabled minimap: false and scrollBeyondLastLine: false\n\n3. CSS Styling (sketch-diff2-view.ts):\n - Added file-diff-section with bottom borders for visual separation\n - Implemented sticky file headers with proper z-index\n - Created status badges (added, modified, deleted, renamed) with color coding\n - Added file-count display replacing old file picker interface\n - Configured diff-container with overflow: auto for outer scrolling\n\n4. Content Management:\n - Parallel loading of all file contents with error handling\n - Maintains editability detection per file based on commit range\n - Preserves comment and save functionality for individual files\n - Updated toggleHideUnchangedRegions to apply to all editors\n\nTechnical Details:\n- Uses Monaco\u0027s getContentHeight() and onDidContentSizeChange() for auto-sizing\n- Each diff editor sized to Math.max(originalHeight, modifiedHeight) + 18px padding\n- Outer container handles all scrolling while inner editors are sized to content\n- File headers show status (Added/Modified/Deleted/Renamed) with appropriate styling\n- Sticky positioning keeps file context visible during scrolling\n- Maintains all existing features: editing, commenting, expand/collapse toggles\n\nBenefits:\n- Natural scrolling workflow similar to GitHub PR reviews\n- Eliminates need for dropdown navigation between files\n- Better visual context with file headers and status indicators\n- Continuous viewing experience for multi-file changes\n- Preserves all advanced Monaco features (editing, commenting, etc.)\n- Improved performance with parallel content loading\n\nTesting:\n- Verified multi-file diff display with various commit ranges\n- Tested scrolling behavior between files works smoothly\n- Confirmed auto-sizing works correctly for different file sizes\n- Validated file headers show correct status and change counts\n- Ensured editing and commenting functionality preserved\n- Tested expand/collapse toggles apply to all editors\n\nThis implementation follows the Monaco ≥0.49 multi-file diff pattern with\ndisabled inner scrollbars, auto-sizing to content, and outer scroll container,\nproviding a modern diff experience while maintaining full editor functionality.\n\nCo-Authored-By: sketch \u003chello@sketch.dev\u003e\nChange-ID: s0724a00944669c80k\n" }, { "commit": "938d2dcde4aaea8119e1c09ffa453de48560dd57", "tree": "fe917e628d4ce1a671a15d1430668e92983289c4", "parents": [ "7351cd9b711db0e828d22d995fe56c7f9f6ddb07" ], "author": { "name": "David Crawshaw", "email": "david@zentus.com", "time": "Sat Jun 14 22:17:33 2025 +0000" }, "committer": { "name": "David Crawshaw", "email": "david@zentus.com", "time": "Sat Jun 14 16:20:07 2025 -0700" }, "message": "webui: add URL parameters for diff view from/to commit selection\n\nEnable direct linking to specific diff ranges by adding URL parameters that\nsync with the diff range picker controls, allowing users to bookmark and\nshare specific diff views.\n\nProblem Analysis:\nUsers couldn\u0027t link directly to specific diff ranges in the sketch diff view.\nThe from/to commit selectors would reset to defaults on page load, making it\nimpossible to bookmark or share links to specific commit comparisons. This\ncreated friction when collaborating or returning to specific diff views.\n\nImplementation Changes:\n\n1. URL Parameter Synchronization (sketch-diff-range-picker.ts):\n - Added updateUrlParams() to write from/to/commit parameters to URL\n - Integrated URL updates into dispatchRangeEvent() for automatic sync\n - Used history.replaceState() to update URL without page reload\n - Clear unused parameters when switching between range/single modes\n\n2. URL Parameter Initialization:\n - Added initializeFromUrlParams() to read URL parameters on load\n - Parse \u0027from\u0027/\u0027to\u0027 parameters for range mode initialization\n - Parse \u0027commit\u0027 parameter for single commit mode initialization\n - Return flag indicating successful URL-based initialization\n\n3. Load Flow Enhancement:\n - Modified loadCommits() to check URL parameters before setting defaults\n - Skip default commit selection when URL parameters are present\n - Always dispatch range event to ensure diff view updates correctly\n\n4. Browser Navigation Support:\n - Added popstate event listener for browser back/forward navigation\n - Implemented handlePopState() to re-initialize from URL parameters\n - Force component re-render and event dispatch on navigation\n\n5. Mode Switching Improvements:\n - Enhanced setRangeType() with better default handling\n - Auto-populate missing commits when switching between modes\n - Maintain proper URL state during mode transitions\n\nTechnical Details:\n- URL parameters: \u0027from\u0027, \u0027to\u0027 for range mode; \u0027commit\u0027 for single mode\n- Empty \u0027to\u0027 parameter represents uncommitted changes (working directory)\n- Parameters removed from URL when switching to incompatible modes\n- Browser history updated without triggering page reloads\n- Component lifecycle properly manages event listeners\n\nURL Format Examples:\n- Range mode: ?view\u003ddiff2\u0026from\u003dabc123\u0026to\u003ddef456\n- Uncommitted: ?view\u003ddiff2\u0026from\u003dabc123 (no \u0027to\u0027 parameter)\n- Single commit: ?view\u003ddiff2\u0026commit\u003dabc123\n\nBenefits:\n- Direct linking to specific diff ranges via URL\n- Bookmarkable diff views for easy return navigation\n- Shareable links for collaboration and code review\n- Browser back/forward navigation works correctly\n- URL reflects current diff state at all times\n- Seamless integration with existing diff view functionality\n\nTesting:\n- Verified URL updates when changing from/to commit selectors\n- Confirmed URL initialization on page load with parameters\n- Tested browser back/forward navigation updates UI correctly\n- Validated mode switching (range ↔ single) updates URL appropriately\n- Ensured uncommitted changes mode removes \u0027to\u0027 parameter\n- Confirmed sharing URLs loads correct diff view state\n\nThis enhancement enables direct linking and improved navigation for the\nsketch diff view while maintaining all existing functionality and providing\nseamless URL-based state management.\n\nCo-Authored-By: sketch \u003chello@sketch.dev\u003e\nChange-ID: sbf02a6a8bb4db673k\n" }, { "commit": "7351cd9b711db0e828d22d995fe56c7f9f6ddb07", "tree": "2c4014fb50f2ae0ea3c8922d89c4029846da240d", "parents": [ "a35de5f73d31756c8ac972a54bdb370bb26eed5a" ], "author": { "name": "philip.zeyliger", "email": "philip.zeyliger@gmail.com", "time": "Sat Jun 14 12:25:31 2025 -0700" }, "committer": { "name": "Philip Zeyliger", "email": "philip@bold.dev", "time": "Sat Jun 14 12:25:31 2025 -0700" }, "message": "webui: fix Monaco fonts\n\nIn Chrome, if you selectected a line in the diff view, it wouldn\u0027t\nselect the whole line, because Monaco was somehow confused about the\nfont widths or something. Turns out we had customized our fonts. We\ndon\u0027t need to do that!\n\nAlso adding a sketchDebug idea so that it\u0027s easier to poke at things.\n" }, { "commit": "c7c2cc1e9d2a90515e071527241e0ce680fe0738", "tree": "df1b7548a47fa1e4f219bcd8a27e5fadaa0acc3c", "parents": [ "83c5be6f73607c6add6d5c389f7894e1d7b5e06a" ], "author": { "name": "Sean McCullough", "email": "banksean@gmail.com", "time": "Fri Jun 13 03:21:18 2025 +0000" }, "committer": { "name": "Autoformatter", "email": "bot@sketch.dev", "time": "Fri Jun 13 03:48:18 2025 +0000" }, "message": "webui: fix repository name parsing for names containing dots\n\nFix GitHub repository URL parsing in sketch-container-status component to\nproperly handle repository names containing dots, resolving broken GitHub\nlinks in the ongoing session log banner.\n\nProblem Analysis:\nThe formatGitHubRepo function used regex patterns with [^/\\s.]+ character\nclasses that excluded dots from repository names. This caused repository names\nlike \u0027boldsoftware/sketch.git\u0027 to be truncated to \u0027boldsoftware/sketch\u0027 when\nparsed, breaking GitHub links and repository display in the session banner.\n\nThe issue occurred in three regex patterns for different GitHub URL formats:\n- HTTPS URLs: /https:\\/\\/github\\.com\\/([^/]+)\\/([^/\\s.]+)(?:\\.git)?/\n- SSH URLs: /git@github\\.com:([^/]+)\\/([^/\\s.]+)(?:\\.git)?/\n- Git protocol: /git:\\/\\/github\\.com\\/([^/]+)\\/([^/\\s.]+)(?:\\.git)?/\n\nThe [^/\\s.]+ pattern specifically excluded dots (.) from matching, which was\nproblematic for legitimate repository names containing dots.\n\nImplementation Changes:\n\n1. Regex Pattern Updates:\n - Changed [^/\\s.]+ to [^/\\s]+? in all three URL patterns\n - Removed dot exclusion while maintaining whitespace and slash exclusion\n - Added non-greedy quantifier (?) to prevent over-matching\n - Added end-of-string anchor ($) for precise matching\n\n2. Updated patterns:\n - HTTPS: /https:\\/\\/github\\.com\\/([^/]+)\\/([^/\\s]+?)(?:\\.git)?$/\n - SSH: /git@github\\.com:([^/]+)\\/([^/\\s]+?)(?:\\.git)?$/\n - Git: /git:\\/\\/github\\.com\\/([^/]+)\\/([^/\\s]+?)(?:\\.git)?$/\n\nTechnical Details:\n- Non-greedy matching (+?) ensures proper handling of .git suffix\n- End anchors ($) prevent partial matches and improve precision\n- Dots now allowed in repository names while preserving .git detection\n- Existing functionality preserved for repositories without dots\n\nTesting:\nVerified fix with comprehensive test cases:\n- git@github.com:boldsoftware/sketch.git → boldsoftware/sketch ✓\n- https://github.com/user/repo.with.dots.git → user/repo.with.dots ✓\n- git@github.com:org/project.name.git → org/project.name ✓\n- https://github.com/test/normal-repo → test/normal-repo ✓\n\nBenefits:\n- GitHub links now work correctly for repositories with dots in names\n- Session banner displays proper repository information\n- Maintains backward compatibility with existing repository names\n- Improves user experience for repository navigation\n\nThis fix resolves the specific issue where repository names containing dots\nwould have their GitHub links truncated, breaking navigation to the actual\nrepository on GitHub.\n\nCo-Authored-By: sketch \u003chello@sketch.dev\u003e\nChange-ID: sda0a251af3d756b6k\n\nwebui: improve GitHub repo parsing tests\n\nReplace internal method testing with component behavior testing for better\nintegration coverage and maintainability.\n\n- Test actual GitHub link rendering in DOM instead of calling private methods\n- Add separate test cases for repository names with dots\n- Verify href attributes, text content, and title attributes are correct\n- Cover both general dot-containing names and the specific boldsoftware/sketch case\n\nCo-Authored-By: sketch \u003chello@sketch.dev\u003e\nChange-ID: s216977b6be91a2bak\n" }, { "commit": "e8da7af81f6414866ec20658c1c2a0ae4fc350bf", "tree": "c13fcf9d456f03706ea0470043af85b106a1b0ef", "parents": [ "d2ba10c9e2ea1487262eaefbfbd6493200a9200a" ], "author": { "name": "philip.zeyliger", "email": "philip.zeyliger@gmail.com", "time": "Thu Jun 12 14:24:28 2025 -0700" }, "committer": { "name": "Autoformatter", "email": "bot@sketch.dev", "time": "Thu Jun 12 21:25:28 2025 +0000" }, "message": "fix: correct SSH connection string format for VS Code remote SSH\n\nCo-Authored-By: sketch \u003chello@sketch.dev\u003e\nChange-ID: s43df80ba5e0e7cd3k\n" }, { "commit": "8773e68fcce9965da3c6a1ef91c88476f84e29bb", "tree": "cb8d586ac3e5a833670c038344509621b61725be", "parents": [ "542bda3968c6dd5b79392dd63e2955e04520401a" ], "author": { "name": "philip.zeyliger", "email": "philip.zeyliger@gmail.com", "time": "Wed Jun 11 21:36:21 2025 -0700" }, "committer": { "name": "Autoformatter", "email": "bot@sketch.dev", "time": "Thu Jun 12 04:37:26 2025 +0000" }, "message": "feat: add ssh-connection-string option for container SSH access\n\nAdd internal -ssh-connection-string flag to pass SSH hostname from dockerimg\nto sketch container, allowing the UI to display the correct SSH connection\nstring based on SSH Theater configuration rather than generating it locally.\n\nCo-Authored-By: sketch \u003chello@sketch.dev\u003e\nChange-ID: s1872f10f74da5f9bk\n" }, { "commit": "542bda3968c6dd5b79392dd63e2955e04520401a", "tree": "ea1a0743849495ca2489c6363d2dc689dd0a56a7", "parents": [ "225e9668aeebc0cae667872dd45222d69ac3cbd8" ], "author": { "name": "Philip Zeyliger", "email": "philip@bold.dev", "time": "Wed Jun 11 18:31:03 2025 -0700" }, "committer": { "name": "Autoformatter", "email": "bot@sketch.dev", "time": "Thu Jun 12 01:31:34 2025 +0000" }, "message": "browser: rename browser_read_image to read_image and auto-send screenshots to LLM\n\nRename browser_read_image tool to read_image and modify browser_take_screenshot\nto automatically send image content to the LLM instead of requiring a separate\nread_image tool call, streamlining the screenshot workflow.\n\nProblem Analysis:\nThe current browser screenshot workflow required two separate tool calls:\n1. browser_take_screenshot - saves screenshot and returns file path\n2. browser_read_image - reads saved screenshot and sends to LLM\n\nThis two-step process was inefficient and created unnecessary round trips.\nAdditionally, browser_read_image was specific to browser automation but\nthe functionality of reading and encoding images is more general purpose.\n\nImplementation Changes:\n\n1. Screenshot Tool Behavior (claudetool/browse/browse.go):\n - Modified browser_take_screenshot to automatically return image content\n - Removed screenshotOutput struct as ID-only response no longer needed\n - Added base64 encoding of screenshot data directly in screenshotRun\n - Returns []llm.Content with both text description and image data\n - Still saves screenshot file for potential future reference\n - Uses same image encoding format as existing read_image tool\n\n2. Tool Rename (claudetool/browse/browse.go):\n - Renamed browser_read_image tool to read_image\n - Updated tool name in NewReadImageTool from \u0027browser_read_image\u0027 to \u0027read_image\u0027\n - Maintained all existing functionality and input/output format\n - Tool description and schema remain unchanged\n\n3. UI Updates (termui/termui.go):\n - Updated template condition from \u0027browser_read_image\u0027 to \u0027read_image\u0027\n - Maintains existing emoji and display format for read_image tool calls\n\n4. WebUI Updates (webui/src/web-components/):\n - Updated sketch-tool-calls.ts to reference \u0027read_image\u0027 instead of \u0027browser_read_image\u0027\n - Renamed sketch-tool-card-browser-read-image.ts to sketch-tool-card-read-image.ts\n - Updated component class name from SketchToolCardBrowserReadImage to SketchToolCardReadImage\n - Updated custom element name from \u0027sketch-tool-card-browser-read-image\u0027 to \u0027sketch-tool-card-read-image\u0027\n - Updated import statement to reference new component file name\n - Removed old component file and updated TypeScript declarations\n\n5. Test Updates (claudetool/browse/browse_test.go):\n - Modified TestGetTools to allow read_image tool without \u0027browser_\u0027 prefix\n - Added special case handling for read_image in tool naming convention check\n - All existing tests continue to pass with updated tool name\n\nTechnical Details:\n- Screenshot auto-send uses same base64 encoding as existing read_image tool\n- Content structure matches browser_read_image output format for consistency\n- File saving still occurs for potential debugging or future reference\n- Error handling preserves existing behavior with proper fallbacks\n- Tool count remains the same (12 tools with screenshots, 10 without)\n\nBenefits:\n- Eliminates need for two-step screenshot workflow\n- Reduces round trips and simplifies user experience\n- More intuitive tool naming (read_image is general purpose)\n- Maintains full backward compatibility for read_image functionality\n- Consistent image encoding across all browser tools\n- Automatic screenshot viewing improves debugging and validation workflows\n\nTesting:\n- All existing browser tool tests pass with updated expectations\n- TestReadImageTool verifies renamed tool functionality\n- Tool naming convention test updated to handle read_image exception\n- TypeScript compilation successful with no type errors\n- Web component functionality preserved across rename\n\nThis enhancement streamlines screenshot workflows while maintaining the\ngeneral-purpose read_image tool for reading arbitrary image files, creating\na more efficient and intuitive browser automation experience.\n\nCo-Authored-By: sketch \u003chello@sketch.dev\u003e\nChange-ID: se3e81f997f30f01ek\n" }, { "commit": "225e9668aeebc0cae667872dd45222d69ac3cbd8", "tree": "5ed3bd693b61ba13c6609d8afefb343cf919abb8", "parents": [ "6d3de48ec0ec2fb8f194a11f1711b7128b7d1699" ], "author": { "name": "philip.zeyliger", "email": "philip.zeyliger@gmail.com", "time": "Tue Jun 10 23:05:06 2025 +0000" }, "committer": { "name": "Philip Zeyliger", "email": "philip@bold.dev", "time": "Wed Jun 11 12:14:50 2025 -0700" }, "message": "webui: remove deprecated @types/dompurify dependency\n\nRemove @types/dompurify package dependency since modern dompurify includes\nbuilt-in TypeScript definitions, eliminating the npm deprecation warning.\n\nProblem Analysis:\nnpm install was showing deprecation warning:\n\u0027@types/dompurify@3.2.0: This is a stub types definition. dompurify provides\nits own type definitions, so you do not need this installed.\u0027\n\nThe webui package.json included both dompurify@^3.2.6 and @types/dompurify@^3.2.0\nas dependencies. Modern versions of dompurify (3.x+) ship with their own\nTypeScript definitions built-in, making the separate @types package redundant\nand deprecated. This created unnecessary dependency bloat and triggered warnings\nduring npm install operations.\n\nImplementation Changes:\n\n1. Package Dependency Cleanup:\n - Removed \u0027@types/dompurify\u0027: \u0027^3.2.0\u0027 from webui/package.json dependencies\n - Preserved dompurify@^3.2.6 which provides both runtime code and TypeScript types\n - No code changes required since imports remain identical\n\n2. TypeScript Compatibility:\n - Verified existing DOMPurify imports continue working with built-in types\n - Confirmed TypeScript compilation passes without @types/dompurify\n - No changes needed to mobile-chat.ts, sketch-tool-card.ts, or sketch-timeline-message.ts\n\nTechnical Details:\n- dompurify 3.x series includes index.d.ts with complete TypeScript definitions\n- Import syntax \u0027import DOMPurify from \"dompurify\"\u0027 unchanged and fully typed\n- npm install completes cleanly without deprecation warnings\n- TypeScript check (tsc --noEmit) passes successfully with built-in types\n\nBenefits:\n- Eliminates npm deprecation warning during install operations\n- Reduces dependency count and package.json complexity\n- Uses official TypeScript definitions from dompurify maintainers\n- Maintains identical functionality and type safety\n- Cleaner dependency tree without redundant type packages\n\nTesting:\n- npm install runs successfully without warnings\n- TypeScript compilation (npm run check) passes without errors\n- All DOMPurify usage in web components maintains full type safety\n- Build process completes successfully with built-in type definitions\n\nThis cleanup removes technical debt and follows best practices for modern\nTypeScript package management by using built-in type definitions rather\nthan deprecated stub packages.\n\nCo-Authored-By: sketch \u003chello@sketch.dev\u003e\nChange-ID: sf9e195a31b2adb28k\n\nwebui: update package-lock.json after removing @types/dompurify\n\nUpdate package-lock.json to reflect removal of deprecated @types/dompurify\ndependency, completing the cleanup of redundant type definitions.\n\nCo-Authored-By: sketch \u003chello@sketch.dev\u003e\nChange-ID: s0cdb73feadefc7b1k\n" }, { "commit": "6d3de48ec0ec2fb8f194a11f1711b7128b7d1699", "tree": "14325a290001d13a482c116c83ee0b87aa7e36c5", "parents": [ "a1762b94e6ddf5db0a0f6b7a5104fa236855320b" ], "author": { "name": "philip.zeyliger", "email": "philip.zeyliger@gmail.com", "time": "Tue Jun 10 19:38:14 2025 -0700" }, "committer": { "name": "Philip Zeyliger", "email": "philip@bold.dev", "time": "Tue Jun 10 19:40:16 2025 -0700" }, "message": "feat: add -link-to-github flag with Octocat icon for GitHub branch linking\n\nAdd internal flag to enable GitHub branch linking in both termui and webui\ninterfaces, displaying clickable Octocat icons next to copy icons for pushed\nbranches when working with GitHub repositories.\n\nProblem Analysis:\nWhen sketch pushes branches to GitHub repositories, users had no direct way to\nnavigate from the sketch interface to view those branches on GitHub. Branch\nnames were displayed as plain text in both terminal and web interfaces,\nrequiring users to manually construct GitHub URLs or switch to external tools\nto view their pushed changes on the GitHub platform.\n\nThis created friction in the workflow, especially for teams collaborating on\nGitHub where quick access to branch views, pull request creation, and code\nreview processes are essential parts of the development workflow.\n\nImplementation Changes:\n\n1. Command Line Flag Infrastructure:\n - Added linkToGitHub bool field to CLIFlags struct\n - Configured -link-to-github as internal flag with false default\n - Integrated flag passing through ContainerConfig and AgentConfig chains\n - Added flag to dockerimg launch command arguments for container mode\n\n2. Agent Interface Enhancement:\n - Added LinkToGitHub() method to CodingAgent interface\n - Implemented method in Agent struct returning config.LinkToGitHub\n - Extended State struct with link_to_github JSON field (with omitempty)\n - Updated getState() function to include agent\u0027s GitHub linking preference\n - Updated mockAgent in tests to support new LinkToGitHub() method\n\n3. Terminal UI GitHub Integration:\n - Added isGitHubRepo() method with regex pattern matching for GitHub URLs\n - Implemented getGitHubBranchURL() for constructing GitHub branch links\n - Enhanced commit message display to show GitHub URLs when flag enabled\n - Updated exit summary to include GitHub links for single and multiple branches\n - Added regex import for GitHub URL pattern validation\n\n4. Web UI TypeScript Integration:\n - Added link_to_github field to State interface in types.ts\n - Enhanced formatGitHubRepo() method to return owner/repo extraction\n - Implemented getGitHubBranchLink() helper in container status component\n - Created parallel helper methods in timeline message component\n\n5. Container Status Component Updates:\n - Added commit-info-container with flexbox layout for proper alignment\n - Implemented layout: Branch Text → Copy Icon → Octocat Icon\n - Added 16px clipboard copy icon with opacity states (70% default, 100% on hover)\n - Integrated 16px Octocat SVG icon as clickable GitHub link\n - Maintained existing copyCommitInfo click functionality for branch text\n\n6. Timeline Message Component Enhancement:\n - Added commit-branch-container for consistent layout structure\n - Implemented same layout pattern: Branch Text → Copy Icon → Octocat Icon\n - Added 14px clipboard and Octocat icons matching timeline scale\n - Enhanced CSS with hover states and proper alignment\n - Preserved existing copyToClipboard functionality for branch text clicks\n\n7. Data Flow Integration:\n - Updated sketch-timeline component to pass state to message components\n - Modified sketch-app-shell to provide containerState to timeline\n - Ensured proper state propagation through component hierarchy\n - Maintained backward compatibility with existing state management\n\nTechnical Details:\n- GitHub URL detection supports HTTPS, SSH, and git protocol formats\n- Regex patterns: ^https://github\\.com/, ^git@github\\.com:, ^git://github\\.com/\n- Link format: https://github.com/{owner}/{repo}/tree/{branch-name}\n- Internal flag prevents exposure in user-visible help documentation\n- SVG Octocat uses official GitHub icon design with 16-point grid\n- Copy icons use standard clipboard SVG with overlapping rectangles design\n- Event propagation properly stopped to prevent interference with copy actions\n- Conditional rendering ensures icons only appear when GitHub links available\n- Flexbox layout ensures proper alignment across different screen sizes\n- CSS transitions provide smooth hover state animations\n\nBenefits:\n- Direct navigation from sketch UI to GitHub branch views\n- Seamless integration with GitHub-based development workflows\n- Enhanced productivity for teams using GitHub collaboration features\n- Clear functional separation: text copy vs external GitHub link\n- Familiar clipboard icon reinforces copy functionality\n- Improved visual hierarchy guides user interaction patterns\n- Maintains existing copy-to-clipboard functionality as fallback\n- Zero impact on non-GitHub repositories or when flag disabled\n- Consistent experience across terminal and web interfaces\n- Enhanced accessibility with distinct click targets and hover states\n\nTesting:\n- Verified flag parsing and configuration propagation through all layers\n- Confirmed GitHub URL detection works with various GitHub URL formats\n- Tested conditional rendering in both web UI components\n- Validated CSS styling and hover effects for GitHub branch links\n- Ensured backward compatibility with non-GitHub repositories\n- Verified TypeScript compilation with new template structures\n- Confirmed proper icon positioning and spacing in test layouts\n- Validated hover states and opacity transitions function correctly\n- All Go tests and TypeScript compilation successful\n\nThis enhancement bridges the gap between sketch\u0027s development environment and\nGitHub\u0027s collaboration platform, enabling more efficient workflows for teams\nusing GitHub repositories while preserving full functionality for other Git\nhosting solutions. The visual design provides intuitive flow from local\noperations (copy) to external actions (GitHub), creating a more organized\nand user-friendly interface for branch management workflows.\n\nCo-Authored-By: sketch \u003chello@sketch.dev\u003e\nChange-ID: s1c083b45b5401c2bk\n" }, { "commit": "57d28bc892e9ec4d842593d6cdd944b6afba532e", "tree": "1f96828c72ed462c616ba611d6ac68f245fbd047", "parents": [ "8bc681bceec47e9f0150defd4bf7df879e1dede4" ], "author": { "name": "Philip Zeyliger", "email": "philip@bold.dev", "time": "Fri Jun 06 20:28:34 2025 +0000" }, "committer": { "name": "Philip Zeyliger", "email": "philip@bold.dev", "time": "Tue Jun 10 15:28:36 2025 -0700" }, "message": "webui: fix white text visibility in pre-compaction message view\n\nAdd explicit dark text color (#333) to pre-compaction message styling to\nensure readability against the striped background pattern.\n\nProblem Analysis:\nPre-compaction messages in the conversation timeline displayed white-on-white\ntext, making content completely invisible to users. The .pre-compaction CSS\nclass applied a white/light-gray striped background but didn\u0027t override the\ninherited text color, resulting in poor contrast and unreadable content.\n\nImplementation Changes:\n- Added color: #333 to .pre-compaction .message-content selector\n- Added color: #333 to .pre-compaction .message-text selector\n- Ensures dark text is explicitly set for all pre-compaction message content\n- Maintains existing diagonal stripe background pattern and opacity\n\nTechnical Details:\n- Text color inheritance was causing white text against white background\n- Dark gray (#333) provides sufficient contrast against stripe pattern\n- Preserves all existing pre-compaction styling except text color\n- No impact on normal message styling or other component functionality\n\nBenefits:\n- Pre-compaction messages are now fully readable\n- Maintains visual distinction with diagonal stripe pattern\n- Consistent text contrast across all message types\n- Preserves existing design aesthetic while fixing usability issue\n\nTesting:\n- Created standalone HTML test demonstrating fix effectiveness\n- Verified text visibility in various pre-compaction message scenarios\n- Confirmed no regression in normal message display styling\n- Validated contrast meets readability standards\n\nCo-Authored-By: sketch \u003chello@sketch.dev\u003e\nChange-ID: scc5ddb83f1e04940k\n" }, { "commit": "8bc681bceec47e9f0150defd4bf7df879e1dede4", "tree": "3676987151352442281db156efe22f89249a47ab", "parents": [ "0d09284f0319105ee548b78881f6076c45212740" ], "author": { "name": "Philip Zeyliger", "email": "philip@bold.dev", "time": "Tue Jun 10 02:03:02 2025 +0000" }, "committer": { "name": "Autoformatter", "email": "bot@sketch.dev", "time": "Tue Jun 10 02:18:41 2025 +0000" }, "message": "webui: fix mobile UI displaying subconversations\n\nFix mobile UI incorrectly showing subconversations (messages with parent_conversation_id)\nthat should be hidden like in the regular UI to maintain consistent behavior across\nall interfaces.\n\nProblem Analysis:\nThe mobile UI was displaying all messages including subconversations, while the regular\ndesktop UI correctly filters out messages with hide_output\u003dtrue. This created an\ninconsistent user experience where subconversations (used for internal agent processing)\nwere visible in the mobile interface but hidden in the desktop interface.\n\nSubconversations are marked with hide_output\u003dtrue based on conversation.Hidden when\nthe message\u0027s conversation has a parent conversation. These are internal processing\nmessages that shouldn\u0027t be shown to users in either interface.\n\nImplementation Changes:\n\n1. Mobile Chat Filtering Enhancement:\n - Modified shouldShowMessage() method in mobile-chat.ts\n - Added hide_output check at start of filtering logic\n - Returns false immediately for any message with hide_output\u003dtrue\n - Mirrors the filtering logic used in sketch-timeline.ts (.filter((msg) \u003d\u003e !msg.hide_output))\n\n2. Consistent Filtering Logic:\n - Mobile UI now matches regular UI filtering behavior\n - Preserves existing content and type filtering for visible messages\n - Maintains all other message display logic unchanged\n - Uses same pattern as desktop: early return false for hidden messages\n\nTechnical Details:\n- hide_output field is set based on conversation.Hidden in AgentMessage.SetConvo()\n- Subconversations have parent_conversation_id and are marked as hidden\n- Regular UI filters with messages.filter((msg) \u003d\u003e !msg.hide_output)\n- Mobile UI now filters with if (message.hide_output) { return false; }\n- No changes needed to aggregateAgentMessages as filtering happens at display level\n\nBenefits:\n- Consistent user experience across desktop and mobile interfaces\n- Proper hiding of internal agent processing messages\n- Clean mobile chat interface without subconversation clutter\n- Maintains all existing mobile UI functionality for visible messages\n\nTesting:\n- TypeScript compilation passes without errors\n- Filtering logic matches pattern used successfully in desktop UI\n- Mobile chat component is only message rendering location in mobile UI\n- Change isolated to display filtering without affecting message aggregation\n\nThis fix ensures mobile users see the same clean conversation view as desktop\nusers, with internal agent subconversations properly hidden from the interface.\n\nCo-Authored-By: sketch \u003chello@sketch.dev\u003e\nChange-ID: s40a49bd924bde7e2k\n" }, { "commit": "0d09284f0319105ee548b78881f6076c45212740", "tree": "285d7162c2791d3e0a102d109275ce5b2f5ae0db", "parents": [ "4168263109e4f5dfa9b24d3ce66594d90c6cf66a" ], "author": { "name": "Philip Zeyliger", "email": "philip@bold.dev", "time": "Mon Jun 09 18:57:12 2025 -0700" }, "committer": { "name": "Autoformatter", "email": "bot@sketch.dev", "time": "Tue Jun 10 01:58:44 2025 +0000" }, "message": "webui: fix HTML escaping in markdown code blocks\n\nThe mermaid stuff didn\u0027t hook up the right code block rendering,\nor so I think. I don\u0027t love how the cut and paste stuff works,\nbut not changing that now.\n\nCo-Authored-By: sketch \u003chello@sketch.dev\u003e\nChange-ID: s3b56d06b8ee8a15ak\n" }, { "commit": "4168263109e4f5dfa9b24d3ce66594d90c6cf66a", "tree": "7a359884219f736a0da706f098d277d6713d8fad", "parents": [ "209ea91bc220b945936250f8aecd9d69974e0ada" ], "author": { "name": "philip.zeyliger", "email": "philip.zeyliger@gmail.com", "time": "Mon Jun 09 22:23:25 2025 +0000" }, "committer": { "name": "Autoformatter", "email": "bot@sketch.dev", "time": "Mon Jun 09 22:24:32 2025 +0000" }, "message": "webui: fix mobile error message styling to display in red\n\nAdd proper red styling for error messages in mobile chat interface to match\ndesktop behavior and fix GitHub issue #141.\n\nProblem Analysis:\nMobile error messages lacked visual distinction from regular messages, appearing\nwith the same gray background as assistant messages. The desktop interface\nproperly displays error messages with red background (#ffebee) and red text\n(#d32f2f), but the mobile-chat component was missing this styling, creating\ninconsistent user experience across interfaces.\n\nThe mobile chat component correctly filtered error messages (type: \u0027error\u0027)\nand displayed them, but the getMessageRole() method didn\u0027t handle error types,\ndefaulting them to \u0027assistant\u0027 styling.\n\nImplementation Changes:\n\n1. CSS Error Message Styling:\n - Added .message.error .message-bubble styles with red theme\n - Background: #ffebee (light red background matching desktop)\n - Text color: #d32f2f (dark red text for readability)\n - Border-radius: 18px (uniform rounding for clean appearance)\n - Maintains mobile-optimized layout and touch-friendly design\n\n2. Message Role Classification:\n - Enhanced getMessageRole() method to properly handle error message types\n - Added explicit \u0027error\u0027 case returning \u0027error\u0027 class name\n - Ensures error messages receive proper CSS class assignment\n\n3. Test Coverage:\n - Added comprehensive mobile-chat component tests\n - Specific test for error message red styling verification\n - CSS color validation using computed styles\n - Message filtering and rendering tests for all message types\n\nTechnical Details:\n- Styling follows existing mobile component patterns with touch-friendly design\n- Color scheme matches desktop timeline-message component for consistency\n- Error messages maintain left alignment like other system messages\n- Clean, uniformly rounded corners without extra borders for polished appearance\n\nBenefits:\n- Visual consistency between desktop and mobile error message presentation\n- Clear error message identification for mobile users\n- Improved accessibility with distinct error styling\n- Maintains touch-friendly mobile design principles\n- Clean, professional appearance without visual clutter\n- Resolves GitHub issue #141 mobile error visibility\n\nTesting:\n- Added mobile-chat.test.ts with error message styling verification\n- TypeScript compilation successful with no type errors\n- Build process completes without warnings\n- CSS computed style validation confirms red color application\n\nThis fix ensures error messages are visually distinctive on mobile devices,\nproviding users with clear feedback when errors occur while maintaining\nthe clean, touch-optimized mobile interface design.\n\nCo-Authored-By: sketch \u003chello@sketch.dev\u003e\nChange-ID: s8b70f2efae56458ck\n" }, { "commit": "0113be559976cfb1ce0e78a9a69c19a6394b2c3d", "tree": "103ea687419bd792471f057727d2f174428b4215", "parents": [ "8ad17ba9f185be76a4e715d9f21868b0cf27b366" ], "author": { "name": "Philip Zeyliger", "email": "philip@bold.dev", "time": "Sat Jun 07 23:53:41 2025 +0000" }, "committer": { "name": "Autoformatter", "email": "bot@sketch.dev", "time": "Mon Jun 09 19:47:55 2025 +0000" }, "message": "webui: add skaband navigation link with image to desktop and mobile\n\nAdd conditional linking functionality to make the \u0027sketch\u0027 title in both desktop\nand mobile web UI clickable when a skaband address is configured, displaying\nthe sketch.dev.png image alongside the text for enhanced branding and navigation\nback to the skaband dashboard.\n\nProblem Analysis:\nWhen users access sketch through skaband (the hosted service), they lose easy\nnavigation back to their skaband dashboard since the sketch title in the header\nwas always static text. This created a disconnected experience between the\nskaband interface and individual sketch sessions, and lacked visual branding\nconsistency with the hosted service. The feature needed to work in both\ncontainer mode and unsafe mode deployments.\n\nImplementation Changes:\n\n1. Backend Infrastructure:\n - Added SkabandAddr() method to CodingAgent interface for state management\n - Enhanced State struct with skaband_addr field (with omitempty for clean JSON)\n - Modified getState() function to include agent\u0027s skaband address in responses\n - Updated mockAgent in tests to support new SkabandAddr() method\n\n2. SkabandClient Integration:\n - Added Addr() method to SkabandClient to expose stored skaband server address\n - Updated Agent.SkabandAddr() to get address from existing SkabandClient\n - Leverages existing skaband infrastructure used for session history tools\n - No duplicate storage or additional configuration required\n\n3. TypeScript Type Updates:\n - Regenerated webui/src/types.ts to include skaband_addr field in State interface\n - Maintained backward compatibility with existing state structure\n - Auto-generated types ensure type safety across Go/TypeScript boundary\n\n4. Desktop Web UI Enhancement:\n - Modified sketch-app-shell.ts to conditionally render sketch title as link\n - Added conditional logic: renders link with image when skaband_addr exists\n - Uses target\u003d\u0027_blank\u0027 and rel\u003d\u0027noopener noreferrer\u0027 for secure external linking\n - Displays skaband_addr/sketch.dev.png image alongside \u0027sketch\u0027 text\n - Maintains existing appearance and behavior when no skaband address configured\n\n5. Mobile Web UI Implementation:\n - Added skabandAddr property to mobile-title component\n - Implemented conditional rendering matching desktop functionality\n - Mobile-optimized CSS with appropriate image sizing (18px vs 20px desktop)\n - Integrated with existing mobile-shell state management infrastructure\n\n6. CSS Styling Integration:\n - Added .banner-title a styles for seamless link appearance with flexbox layout\n - Configured color: inherit to match existing title styling\n - Added hover effects with opacity transition and underline for user feedback\n - Image styling with rounded corners and appropriate dimensions\n - Mobile-responsive design with media queries for different screen sizes\n\n7. Test Coverage:\n - Updated test infrastructure to support new SkabandAddr() method\n - Comprehensive testing of state endpoint with and without skaband address\n - Verified omitempty behavior for clean JSON responses\n - All existing tests continue passing without modification\n\nTechnical Details:\n- Uses omitempty JSON tag to exclude empty skaband addresses from API responses\n- Leverages existing containerState property in web components for state access\n- Maintains full backward compatibility with non-skaband sketch deployments\n- Clean separation between configuration, state management, and presentation layers\n- Flexbox layout for proper image and text alignment in banner links\n\nSecurity Considerations:\n- External links use target\u003d\u0027_blank\u0027 with rel\u003d\u0027noopener noreferrer\u0027\n- No user input validation needed since skaband_addr comes from server configuration\n- Link destination controlled by deployment configuration, not user input\n- Image source follows same security model as main skaband address\n\nBenefits:\n- Seamless navigation between sketch sessions and skaband dashboard\n- Enhanced visual branding with sketch.dev.png image display\n- Improved user experience for hosted skaband users across all device types\n- Mobile-optimized responsive design for touch interfaces\n- Zero impact on standalone sketch deployments\n- Uses existing, tested skaband infrastructure without additional complexity\n\nTesting:\n- Verified end-to-end functionality with real sketch.dev skaband server\n- Confirmed web UI displays clickable sketch logo link in desktop and mobile views\n- Tested state endpoint returns correct skaband_addr from SkabandClient\n- Validated responsive design across different screen sizes\n- All Go tests and TypeScript compilation successful\n\nThis enhancement provides intuitive navigation for skaband users while\nmaintaining the existing experience for standalone sketch deployments,\ncreating a more cohesive and visually branded interface across all deployment\nmodes and device types.\n\nCo-Authored-By: sketch \u003chello@sketch.dev\u003e\nChange-ID: sa6158676609fe9f0k\n" }, { "commit": "f825e69e62896f588496b5b33673de58293a6ba2", "tree": "b12c428cd68c71d580132d9998382b8ff414c6f6", "parents": [ "737570847f2c6b0a27266aa00662308f19f4de60" ], "author": { "name": "Autoformatter", "email": "bot@sketch.dev", "time": "Sat Jun 07 04:19:43 2025 +0000" }, "committer": { "name": "Autoformatter", "email": "bot@sketch.dev", "time": "Sat Jun 07 04:19:43 2025 +0000" }, "message": "all: fix formatting\n" }, { "commit": "737570847f2c6b0a27266aa00662308f19f4de60", "tree": "c4bc73898f0d8be2723efd00866f4e53eb279532", "parents": [ "5f778949e023268d0bd39cb7f102952e575e9602" ], "author": { "name": "Philip Zeyliger", "email": "philip@bold.dev", "time": "Sat Jun 07 00:06:27 2025 +0000" }, "committer": { "name": "Philip Zeyliger", "email": "philip@bold.dev", "time": "Sat Jun 07 04:12:57 2025 +0000" }, "message": "webui: add image paste functionality to mobile chat input\n\nAdd comprehensive file paste support to mobile input matching desktop\nfunctionality with upload progress indicators and error handling.\n\nProblem Analysis:\nMobile webui lacked image paste functionality available on desktop,\npreventing users from easily sharing screenshots, images, and files\nvia clipboard paste. This created workflow friction for mobile users\nwho needed to upload images for code assistance, debugging, or\ndocumentation purposes.\n\nImplementation Changes:\n\n1. Clipboard Paste Handler:\n - Added paste event listener for detecting clipboard files\n - Integrated with existing upload infrastructure via fetch API\n - Cursor position preservation for inline file insertion\n - Prevented default paste behavior for file content\n\n2. File Upload Infrastructure:\n - Reused desktop upload patterns with FormData and ./upload endpoint\n - Added loading placeholder with emoji indicator during upload\n - Implemented error handling with user-friendly error messages\n - File path insertion in [bracket] format matching desktop behavior\n\n3. Upload Progress Management:\n - Added upload counter to track multiple concurrent uploads\n - Upload progress indicator with file count display\n - Disabled send button during active uploads to prevent premature sending\n - Visual feedback with hourglass icon and tooltip messages\n\n4. Mobile-Optimized UI:\n - Positioned upload progress indicator above input field\n - Touch-friendly styling with appropriate spacing\n - Responsive design for various mobile screen sizes\n - Integrated seamlessly with existing mobile input styling\n\n5. Lifecycle Management:\n - Proper event listener setup and cleanup\n - Component disconnection cleanup to prevent memory leaks\n - Textarea reference management for event binding\n - Focus restoration after upload completion\n\nTechnical Details:\n- Uses ClipboardEvent.clipboardData.files for file detection\n- FormData upload with POST to ./upload endpoint matching desktop\n- Upload state management with progress counter and visual indicators\n- Cursor position tracking via selectionStart for inline insertion\n- Error handling with try/catch and user feedback\n\nBenefits:\n- Consistent file upload experience across desktop and mobile\n- Improved mobile workflow for image sharing and file uploads\n- Visual feedback during upload process prevents user confusion\n- Proper error handling with informative messages\n- Seamless integration with existing mobile chat functionality\n\nTesting:\n- Verified paste event detection works on mobile browsers\n- Confirmed upload progress indicators display correctly\n- Tested error handling with network failures\n- Validated file path insertion and cursor positioning\n\nThis enhancement brings mobile webui file paste functionality to feature\nparity with desktop while maintaining mobile-specific optimizations.\n\nCo-Authored-By: sketch \u003chello@sketch.dev\u003e\nChange-ID: s495601fcaa89f012k\n" }, { "commit": "5f778949e023268d0bd39cb7f102952e575e9602", "tree": "d606847a802b46013eb99f6881084498c774beb3", "parents": [ "c3ecabb720cbf3fa7bf1372ec8ed449f0b9a4b91" ], "author": { "name": "Philip Zeyliger", "email": "philip@bold.dev", "time": "Sat Jun 07 00:05:20 2025 +0000" }, "committer": { "name": "Philip Zeyliger", "email": "philip@bold.dev", "time": "Sat Jun 07 04:12:53 2025 +0000" }, "message": "webui: add markdown rendering to mobile chat messages\n\nAdd comprehensive markdown support to mobile agent messages matching\ndesktop functionality with mobile-optimized styling and performance.\n\nProblem Analysis:\nMobile webui was displaying agent messages as plain text while desktop\nversion rendered rich markdown content including code blocks, headers,\nlists, and formatting. This created inconsistent user experience where\nmobile users lost important formatting context, making code examples\nand structured responses harder to read and understand.\n\nImplementation Changes:\n\n1. Markdown Library Integration:\n - Added marked library import for markdown parsing\n - Integrated DOMPurify for HTML sanitization security\n - Added unsafeHTML directive for rendering parsed content\n - Reused desktop markdown parsing patterns for consistency\n\n2. Mobile-Optimized Rendering:\n - Created simplified renderer without complex features like Mermaid\n - Focused on essential markdown elements: headers, code, lists, links\n - Maintained security through DOMPurify sanitization\n - Preserved plain text rendering for user messages\n\n3. Responsive Typography:\n - Mobile-specific font sizes for headers (1.05em - 1.2em range)\n - Optimized code block styling with horizontal scroll\n - Touch-friendly spacing and line heights\n - Compact margins for small screen readability\n\n4. Content Styling:\n - Subtle code highlighting with background colors\n - Proper blockquote styling with left border\n - List indentation optimized for mobile viewing\n - Link styling that maintains message bubble aesthetics\n\nTechnical Details:\n- Uses marked.parse() with GFM and breaks enabled for GitHub compatibility\n- DOMPurify whitelist approach for security (HTML tags and attributes)\n- Conditional rendering: markdown for assistant, plain text for user\n- CSS optimized for mobile viewport constraints and touch interaction\n\nBenefits:\n- Consistent markdown experience across desktop and mobile\n- Improved readability of code examples and structured content\n- Maintained security through proper HTML sanitization\n- Mobile-optimized styling for touch interfaces\n- Better user experience for technical discussions\n\nTesting:\n- Verified markdown parsing works with common elements\n- Confirmed code blocks render properly with scroll\n- Tested security sanitization prevents XSS\n- Validated mobile typography and spacing\n\nThis enhancement brings mobile webui markdown rendering to feature\nparity with desktop while maintaining mobile-specific optimizations.\n\nCo-Authored-By: sketch \u003chello@sketch.dev\u003e\nChange-ID: s99e90082addd4eadk\n" }, { "commit": "e08c7ffc8f1ec0cd3899d2fedad79f408b6dc2f9", "tree": "3e09e7b3a86faed4eaabb640eed0c4b148a9d8d6", "parents": [ "ba15aeb81e5fd3e98870eba91398dfb31d4cd6e9" ], "author": { "name": "Philip Zeyliger", "email": "philip@bold.dev", "time": "Fri Jun 06 13:22:12 2025 -0700" }, "committer": { "name": "Autoformatter", "email": "bot@sketch.dev", "time": "Fri Jun 06 20:26:10 2025 +0000" }, "message": "webui: add mobile interface with URL parameter switching\n\nTL;DR: ?m and ?d should load mobile and desktop versions respectively.\nIt should auto-detect to the right onen and redirect. Server chooses\nwhat to serve.\n\nThis took a few tries. Re-using the existing components didn\u0027t work,\ndespite repeated attempts. The prompt that eventually worked was:\n\n\tSketch\u0027s webui uses lit and webcomponents. I want to create an alternate\n\tweb ui, started with \"/m\" for mobile. Don\u0027t use the same components, but\n\tcreate a new mobile-shell component and a mobile-title, mobile-chat, and\n\tmobile-chat-input components. The design should be a title at the top, a\n\tsimplified chat (that doesn\u0027t display tool cards or anything; just the\n\tmessages, with user messages right-aligned and other messages left\n\taligned), and an input for new messages. Do include an indicator for\n\twhether or not the agent is thinking. Again: this is a parallel\n\timplementation, intended for mobile screens. Use the \"npm run dev\"\n\tserver to test it out and show me some screenshots. Use mobile browser\n\tsizes. Focus on simplicity in the CSS\n\nIt had some trouble with the data loading that took some iterations, and\nit kept saying, \"We\u0027re almost done\" and giving up, but I coaxed it\nthrough.\n\nI\u0027m not too sad right now about the duplication. We can see if there\u0027s\nany traction.\n\n~~~~\n\nAdd complete mobile-optimized interface for Sketch accessible via URL\nparameters, providing seamless device-specific user experience.\n\nProblem Analysis:\nSketch\u0027s existing web interface was designed for desktop use with complex\nlayouts, detailed toolbars, and mouse-focused interactions that don\u0027t\ntranslate well to mobile devices. Mobile users needed a simplified,\ntouch-friendly interface optimized for smaller screens while maintaining\ncore functionality for coding assistance on mobile devices.\n\nImplementation Changes:\n\n1. Mobile-Specific Components:\n - Created mobile-shell as main container with mobile-optimized layout\n - Built mobile-title with connection status and clean header design\n - Implemented mobile-chat with simplified message bubbles and alignment\n - Developed mobile-chat-input with touch-friendly controls and auto-resize\n\n2. URL Parameter-Based Interface Selection:\n - Added server-side parameter detection (?m for mobile, ?d for desktop)\n - Consolidated routing logic into main / handler with parameter checking\n - Eliminated separate URL paths in favor of clean parameter approach\n - Removed interface switching buttons for minimal UI approach\n\n3. Intelligent Auto-Detection:\n - Implemented client-side device detection using screen size and touch capability\n - Automatic URL parameter addition for detected mobile devices\n - Graceful parameter-based overrides for user preference\n - Seamless redirection maintaining all URL context and query parameters\n\n4. Mobile-Optimized Design:\n - iOS-style message bubbles with proper user/assistant alignment\n - Touch-friendly input controls with appropriate sizing\n - Responsive design scaling across mobile screen sizes\n - Animated thinking indicator with smooth dot animations\n - Clean, distraction-free interface focused on core chat functionality\n\n5. Data Integration:\n - Reused existing DataManager and SSE infrastructure\n - Maintained real-time message updates via /stream endpoint\n - Implemented message aggregation using existing patterns\n - Preserved connection status and error handling functionality\n\nTechnical Details:\n- Built using Lit web components for consistency with existing architecture\n- Server parameter detection uses URL.Query().Has() for efficient checking\n- Auto-detection preserves all existing query parameters during redirection\n- Mobile components filter messages to show user, agent, and error types\n- Responsive CSS with mobile-first design principles and touch optimization\n\nBenefits:\n- Seamless mobile experience with automatic device-appropriate interface\n- Clean URL parameter approach (?m/?d) works with any route or session\n- No UI clutter from interface switching buttons\n- Maintains full real-time functionality on mobile devices\n- Easy to bookmark and share mobile-specific URLs\n- Preserves session context during interface switching\n\nTesting:\n- Verified auto-detection works across different mobile screen sizes\n- Confirmed URL parameters function with complex session URLs\n- Tested message sending, receiving, and real-time updates\n- Validated thinking indicator and connection status display\n- Ensured responsive design across portrait and landscape orientations\n\nThis implementation provides a complete mobile solution while maintaining\nthe full-featured desktop interface, enabling Sketch usage across all\ndevice types with appropriate user experiences.\n\nCo-Authored-By: sketch \u003chello@sketch.dev\u003e\nChange-ID: sdbce185f247638c1k\n" }, { "commit": "3d040bd66f81a9211e616ef755b261323d4fea95", "tree": "7c5cc14efb4e335586292b0e4225549d4a3a3438", "parents": [ "19969a9af6da4b5b5e25d02aa635dabad196e464" ], "author": { "name": "Autoformatter", "email": "bot@sketch.dev", "time": "Fri Jun 06 02:35:19 2025 +0000" }, "committer": { "name": "Autoformatter", "email": "bot@sketch.dev", "time": "Fri Jun 06 02:35:19 2025 +0000" }, "message": "all: fix formatting\n" }, { "commit": "19969a9af6da4b5b5e25d02aa635dabad196e464", "tree": "d4701576dce7bdffd962b1d11cd3e6b37d4be443", "parents": [ "44f847a93e7e0953abd42880f5e87c8b3e213134" ], "author": { "name": "Josh Bleecher Snyder", "email": "josharian@gmail.com", "time": "Thu Jun 05 14:34:02 2025 -0700" }, "committer": { "name": "Josh Bleecher Snyder", "email": "josharian@gmail.com", "time": "Thu Jun 05 19:30:39 2025 -0700" }, "message": "all: s/title/slug/, adjust branch handling\n\nThere are two intertwined changes here.\n\nFirst, replace title with slug, and precommit with commit-message-style.\n\nThe slug makes enough of a title, and it provides a single human-readable\nidentifier we can use everywhere.\n\nSecond, construct the branch name on the fly instead of storing it,\nout of slug, branch prefix, and retryNumber.\nThis removes some duplicated data, and makes the retry loop\neasier to follow and reason about." }, { "commit": "44f847a93e7e0953abd42880f5e87c8b3e213134", "tree": "477e9410248ed5983742660e4637ba5016bd9589", "parents": [ "0337623c8e014f4446cfb72ffc271b20cedb80fe" ], "author": { "name": "Josh Bleecher Snyder", "email": "josharian@gmail.com", "time": "Thu Jun 05 14:33:50 2025 -0700" }, "committer": { "name": "Josh Bleecher Snyder", "email": "josharian@gmail.com", "time": "Thu Jun 05 19:30:39 2025 -0700" }, "message": "webui: move cost display to popup info panel and hide when zero\n\nAnd remove a top column, because we now can.\n\nCo-Authored-By: sketch \u003chello@sketch.dev\u003e\nChange-ID: s523262bb871c97d6k" }, { "commit": "7e5fe3cc66dd9e76408a0ae27e7c29d119288dcb", "tree": "cb6014b342813fe466a790ada94a0d0de089340e", "parents": [ "3fef3ca1012c5838a38dd7fec15272c2cbcb3e0a" ], "author": { "name": "Autoformatter", "email": "bot@sketch.dev", "time": "Wed Jun 04 22:24:53 2025 +0000" }, "committer": { "name": "Autoformatter", "email": "bot@sketch.dev", "time": "Wed Jun 04 22:24:53 2025 +0000" }, "message": "all: fix formatting\n" }, { "commit": "3fef3ca1012c5838a38dd7fec15272c2cbcb3e0a", "tree": "4be617fb453f6fca0c19c871efc328c88eb4519c", "parents": [ "be7802ab0605e7cf116d0979bda6e0b6af8f120d" ], "author": { "name": "dependabot[bot]", "email": "49699333+dependabot[bot]@users.noreply.github.com", "time": "Wed Jun 04 16:58:39 2025 +0000" }, "committer": { "name": "Philip Zeyliger", "email": "philip@bold.dev", "time": "Wed Jun 04 15:23:08 2025 -0700" }, "message": "build(deps): bump tar-fs from 3.0.8 to 3.0.9 in /webui\n\nBumps [tar-fs](https://github.com/mafintosh/tar-fs) from 3.0.8 to 3.0.9.\n- [Commits](https://github.com/mafintosh/tar-fs/compare/v3.0.8...v3.0.9)\n\n---\nupdated-dependencies:\n- dependency-name: tar-fs\n dependency-version: 3.0.9\n dependency-type: indirect\n...\n\nSigned-off-by: dependabot[bot] \u003csupport@github.com\u003e" }, { "commit": "be7802ab0605e7cf116d0979bda6e0b6af8f120d", "tree": "d9b2bc73b8bf5fcef160e83c10638b62bcc85863", "parents": [ "2abd467f1bd5fd5cc1de8719eb414a67a412f655" ], "author": { "name": "Philip Zeyliger", "email": "philip@bold.dev", "time": "Wed Jun 04 20:15:25 2025 +0000" }, "committer": { "name": "Philip Zeyliger", "email": "philip@bold.dev", "time": "Wed Jun 04 15:19:01 2025 -0700" }, "message": "loop: add configurable branch prefix option\n\nAdd -branch-prefix flag to customize git branch prefix instead of\nhardcoded \u0027sketch/\u0027 for better integration with different workflows.\n\nProblem Analysis:\nThe sketch system hardcoded \u0027sketch/\u0027 as the branch prefix throughout\nthe codebase, making it difficult for users who wanted different\nbranch naming conventions or needed to integrate with existing\ndevelopment workflows that used different prefixes.\n\nImplementation Changes:\n\n1. CLI Flag Addition:\n - Added -branch-prefix flag to main.go with default \u0027sketch/\u0027\n - Integrated flag into CLIFlags struct and argument parsing\n - Maintains backward compatibility with existing workflows\n\n2. Configuration Threading:\n - Added BranchPrefix field to AgentConfig struct\n - Added BranchPrefix field to ContainerConfig struct\n - Modified container argument passing to include branch prefix\n - Set sensible default of \u0027sketch/\u0027 when not specified\n\n3. Agent Implementation:\n - Added BranchPrefix() method to CodingAgent interface\n - Updated precommit tool to use configurable prefix\n - Modified git commit handling to use configurable prefix\n - Updated all hardcoded \u0027sketch/\u0027 references in logic\n\n4. UI Integration:\n - Enhanced termui template to use configurable branch prefix\n - Added branch_prefix field to server State response\n - Updated webui TypeScript types via auto-generation\n - Modified sketch-tool-card to display configurable prefix\n\n5. Container Integration:\n - Modified dockerimg to pass branch prefix to inner sketch\n - Updated container command arguments construction\n - Ensured proper flag threading through container boundary\n\nTechnical Details:\n- Maintains full backward compatibility with existing usage\n- Default behavior unchanged for existing users\n- Type-safe implementation with proper error handling\n- Clean interface design without type casts or fallbacks\n\nBenefits:\n- Enables custom branch naming conventions\n- Better integration with team workflows\n- Maintains existing sketch functionality\n- Improves flexibility for different use cases\n\nTesting:\n- Verified default behavior remains unchanged\n- Confirmed custom prefix works in both termui and webui\n- All existing tests continue to pass\n- Build verification successful across all components\n\nThis enhancement provides workflow flexibility while maintaining\nthe reliability and functionality of the existing branch management\nsystem.\n\nCo-Authored-By: sketch \u003chello@sketch.dev\u003e\nChange-ID: s71341dca2cfeeb24k\n" }, { "commit": "53ab24547cd684fc38254a6bd63759d7121ca7d6", "tree": "15122689ee81490ea8d3497b6baade986c6bad2c", "parents": [ "16098932295e067fb0a6b3ca2082b0d4b06027b4" ], "author": { "name": "Philip Zeyliger", "email": "philip@bold.dev", "time": "Wed Jun 04 17:49:33 2025 +0000" }, "committer": { "name": "Autoformatter", "email": "bot@sketch.dev", "time": "Wed Jun 04 18:10:57 2025 +0000" }, "message": "webui: implement DOMPurify sanitization for markdown security\n\nImplement comprehensive HTML sanitization using DOMPurify library to\nprevent XSS vulnerabilities in markdown rendering while preserving\nfull markdown functionality.\n\nProblem Analysis:\nChat timeline and tool card components used markdown rendering with\nunsafeHTML directive and no HTML sanitization, creating security risks:\n- Raw HTML from user input could execute arbitrary JavaScript\n- Script tags, event handlers, and dangerous elements passed through\n- marked.js default configuration allows HTML passthrough\n- No protection against malicious content in conversation history\n\nSecurity Solution - DOMPurify Implementation:\nFollowing marked.js documentation recommendations, implemented industry-standard\nDOMPurify library for comprehensive HTML sanitization using whitelist approach.\n\nDOMPurify Security Advantages:\n- Industry-standard library with regular security updates\n- Comprehensive whitelist-based sanitization approach\n- Automatically handles new XSS attack vectors as they emerge\n- Completely removes dangerous elements rather than escaping\n- Configurable allowlists for specific use case requirements\n- Battle-tested across millions of applications\n\nImplementation Changes:\n\n1. Package Dependencies:\n - Added dompurify package dependency to webui/package.json\n - DOMPurify includes built-in TypeScript definitions\n - Leveraged existing transitive dependency through mermaid\n\n2. Enhanced sketch-timeline-message.ts Security:\n - Integrated DOMPurify.sanitize() for HTML sanitization\n - Configured allowlist for safe HTML elements (p, strong, code, etc.)\n - Added support for mermaid diagram elements (svg, path, etc.)\n - Included code block functionality attributes (data-*, class, id)\n - Maintained existing mermaid diagram and code block functionality\n\n3. Enhanced sketch-tool-card.ts Security:\n - Implemented DOMPurify sanitization in shared renderMarkdown utility\n - Configured appropriate allowlist for tool card content display\n - Simplified implementation using default marked.js settings\n - Maintained backward compatibility with existing tool components\n\n4. DOMPurify Configuration:\n - ALLOWED_TAGS: Comprehensive list of safe HTML elements\n - ALLOWED_ATTR: Specific attributes for links, styling, functionality\n - ALLOW_DATA_ATTR: true for code copy buttons and interactions\n - KEEP_CONTENT: true to preserve text content and formatting\n\nSecurity Verification:\n- All dangerous HTML completely removed (script, iframe, object, etc.)\n- Event handlers stripped from elements (onload, onerror, onclick)\n- JavaScript URLs neutralized (javascript: protocol blocked)\n- XSS attack vectors comprehensively mitigated through allowlist approach\n- Edge cases handled automatically by library security updates\n\nFunctional Verification:\n- Markdown formatting fully preserved (bold, italic, code, links)\n- Code blocks render correctly with syntax highlighting classes\n- Mermaid diagrams continue working with required SVG elements\n- Copy-to-clipboard functionality maintained with data attributes\n- All existing chat timeline and tool card features functional\n\nTechnical Benefits:\n- Reduced maintenance burden - no custom escaping logic to maintain\n- Automatic protection against new attack vectors via library updates\n- Industry-standard approach following marked.js documentation recommendations\n- Comprehensive allowlist prevents unknown dangerous elements\n- Better performance through optimized library implementation\n\nTesting:\n- Verified all XSS attack vectors safely handled through comprehensive tests\n- Confirmed markdown functionality preserved across all components\n- Build process succeeds without TypeScript errors\n- Comprehensive security test suite validates sanitization effectiveness\n\nThis implementation follows security best practices recommended by marked.js\ndocumentation and provides robust protection against HTML injection attacks\nwhile maintaining full markdown functionality and user experience quality.\n\nCo-Authored-By: sketch \u003chello@sketch.dev\u003e\nChange-ID: s233c12c6daac5bb0k\n" }, { "commit": "16098932295e067fb0a6b3ca2082b0d4b06027b4", "tree": "60a47204f50aab38d803f4cc53594ff754cc0265", "parents": [ "e6c294dc139cf229ba790abc87a524016f98627f" ], "author": { "name": "Philip Zeyliger", "email": "philip@bold.dev", "time": "Wed Jun 04 11:02:55 2025 -0700" }, "committer": { "name": "Autoformatter", "email": "bot@sketch.dev", "time": "Wed Jun 04 18:03:43 2025 +0000" }, "message": "loop/webui: remove end session feedback survey functionality\n\nRemove end session feedback survey system that was previously implemented\nto collect user satisfaction ratings and comments when ending sessions.\n\nProblem Analysis:\nThe feedback survey system added complexity to the end session flow\nand included several components:\n- Modal dialog with thumbs up/down rating buttons\n- Optional text feedback collection\n- Backend storage and processing of feedback data\n- Complex synchronization logic with skaband clients\n- Extended State struct and API surface area\n\nThe feedback collection mechanism, while well-implemented, added\nunnecessary friction to session termination and required maintenance\nof additional state management infrastructure.\n\nImplementation Changes:\n\n1. Frontend Simplification (sketch-app-shell.ts):\n - Replace custom survey modal with simple window.confirm dialog\n - Remove showEndSessionSurvey() method and associated UI logic\n - Simplify end session request to basic reason-only payload\n - Remove complex button state management and form handling\n\n2. Type Definition Cleanup (types.ts):\n - Remove EndFeedback interface definition\n - Remove end field from State interface\n - Simplify TypeScript type definitions\n\n3. Backend Refactoring (agent.go):\n - Remove EndFeedback struct definition\n - Remove GetEndFeedback/SetEndFeedback methods from CodingAgent interface\n - Remove endFeedback field from Agent struct\n - Eliminate feedback-related state management\n\n4. HTTP Server Cleanup (loophttp.go):\n - Remove End field from State struct\n - Simplify /end endpoint request body parsing\n - Remove feedback storage and processing logic\n - Eliminate endWaitGroup synchronization mechanism\n - Remove wait_for_end query parameter handling\n - Simplify session termination to immediate exit with basic delay\n\n5. Test Cleanup (loophttp_test.go):\n - Remove TestEndFeedback test function\n - Remove endFeedback field from mockAgent\n - Remove GetEndFeedback/SetEndFeedback mock methods\n - Simplify test fixtures and expectations\n\nTechnical Details:\n- Session termination now uses simple confirmation dialog workflow\n- /end endpoint accepts only reason field in request body\n- Process exit occurs after 100ms delay without client coordination\n- All existing session management functionality preserved\n- TypeScript compilation verified with simplified type definitions\n\nBenefits:\n- Simplified end session user experience with standard confirmation\n- Reduced code complexity and maintenance burden\n- Eliminated complex state synchronization requirements\n- Cleaner API surface with fewer fields and methods\n- Faster session termination without feedback collection overhead\n- Standard web UI patterns for session ending confirmation\n\nTesting:\n- All existing tests pass without regression\n- TypeScript compilation succeeds with updated type definitions\n- End session functionality verified through manual testing\n- Build verification confirms no compilation errors\n\nThis change restores the end session flow to a simple, straightforward\nconfirmation-based approach while maintaining all core session management\nfunctionality and improving overall system simplicity.\n\nCo-Authored-By: sketch \u003chello@sketch.dev\u003e\nChange-ID: s9406002b5ac20a89k\n" }, { "commit": "457dfd12f281dbe9b1af8d1a7429f2977e234a6f", "tree": "ecc1d171fe104f88493e322e23c0a5a164301b95", "parents": [ "bd52faf66d7dcb1067ac44b66bc2aa1f7142e4f3" ], "author": { "name": "Autoformatter", "email": "bot@sketch.dev", "time": "Tue Jun 03 00:18:36 2025 +0000" }, "committer": { "name": "Autoformatter", "email": "bot@sketch.dev", "time": "Tue Jun 03 00:18:36 2025 +0000" }, "message": "all: fix formatting\n" }, { "commit": "bd52faf66d7dcb1067ac44b66bc2aa1f7142e4f3", "tree": "ccab71649bf24430ff66bbb6d7f6eee89232d08e", "parents": [ "fea9e27ac3067027b0483b85de9869ce200d984f" ], "author": { "name": "Josh Bleecher Snyder", "email": "josharian@gmail.com", "time": "Mon Jun 02 21:21:37 2025 +0000" }, "committer": { "name": "Josh Bleecher Snyder", "email": "josharian@gmail.com", "time": "Mon Jun 02 17:17:41 2025 -0700" }, "message": "webui: add TODO item comment functionality similar to diff comments\n\nCo-Authored-By: sketch \u003chello@sketch.dev\u003e\nChange-ID: s1040817099be5124k\n" }, { "commit": "b8a8f35348326b8daf69e31efc77d37fac4bd276", "tree": "fa7a59c5951dbd3ecb5e6bf840ac7b45167a9e74", "parents": [ "b5739403b1b6ec6fac909b258bd47ce5a338940e" ], "author": { "name": "Philip Zeyliger", "email": "philip@bold.dev", "time": "Mon Jun 02 07:39:37 2025 -0700" }, "committer": { "name": "Philip Zeyliger", "email": "philip@bold.dev", "time": "Mon Jun 02 17:01:19 2025 -0700" }, "message": "loop: implement comprehensive conversation compaction system\n\n\"comprehensive\" is over-stating it. Currently, users get\nthe dreaded:\n\n\terror: failed to continue conversation: status 400 Bad Request:\n\t{\"type\":\"error\",\"error\":{\"type\":\"invalid_request_error\",\"message\":\"input\n\tlength and max_tokens exceed context limit: 197257 + 8192 \u003e 200000,\n\tdecrease input length or max_tokens and try again\"}}\n\nThat\u0027s... annoying. Instead, let\u0027s compact automatically. I was going to\nstart with adding a /compact command or button, but it turns out that\nteasing that through the system is annoying, because the agent state\nmachine is intended to be somewhat single-threaded, and what do you do\nwhen a /compact comes in while other things are going on. It\u0027s possible,\nbut it was genuinely easier to prompt my way into doing it\nautomatically.\n\nI originally set the threshold to 75%, but given that 8192/200000 is 4%,\nI just changed it to 94%.\n\nWe\u0027ll see how well it works!\n\n~~~~\n\nImplement automatic conversation compaction to manage token limits and prevent\ncontext overflow, with enhanced UX feedback and accurate token tracking.\n\nProblem Analysis:\nLarge conversations could exceed model context limits, causing failures\nwhen total tokens approached or exceeded the maximum context window.\nWithout automatic management, users would experience unexpected errors\nand conversation interruptions in long sessions.\n\nImplementation:\n\n1. Automatic Compaction Infrastructure:\n - Added ShouldCompact() method to detect when compaction is needed\n - Configurable token thresholds for different compaction triggers\n - Integration with existing loop state machine for seamless operation\n\n2. Accurate Token Counting:\n - Enhanced context size estimation using actual token usage from LLM responses\n - Track real token consumption rather than relying on estimates\n - Account for tool calls, system prompts, and conversation history\n\n3. Compaction Logic and Timing:\n - Triggered at 75% of context limit (configurable threshold)\n - Preserves recent conversation context while compacting older messages\n - Maintains conversation continuity and coherence\n\n4. Enhanced User Experience:\n - Visual indicators in webui when compaction occurs\n - Token count display showing current usage vs limits\n - Clear messaging about compaction status and reasoning\n - Timeline updates to reflect compacted conversation state\n\n5. UI Component Updates:\n - sketch-timeline.ts: Added compaction status display\n - sketch-timeline-message.ts: Enhanced message rendering for compacted state\n - sketch-app-shell.ts: Token count integration and status updates\n\nTechnical Details:\n- Thread-safe implementation with proper mutex usage\n- Preserves conversation metadata and essential context\n- Configurable compaction strategies for different use cases\n- Comprehensive error handling and fallback behavior\n- Integration with existing LLM provider implementations (Claude, OpenAI, Gemini)\n\nTesting:\n- Added unit tests for ShouldCompact logic with various scenarios\n- Verified compaction triggers at correct token thresholds\n- Confirmed UI updates reflect compaction status accurately\n- All existing tests continue to pass without regression\n\nBenefits:\n- Prevents context overflow errors in long conversations\n- Maintains conversation quality while managing resource limits\n- Provides clear user feedback about system behavior\n- Enables unlimited conversation length with automatic management\n- Improves overall system reliability and user experience\n\nThis system ensures sketch can handle conversations of any length while\nmaintaining performance and providing transparent feedback to users about\ntoken usage and compaction activities.\n\nCo-Authored-By: sketch \u003chello@sketch.dev\u003e\nChange-ID: s28a53f4e442aa169k\n" }, { "commit": "b5739403b1b6ec6fac909b258bd47ce5a338940e", "tree": "0dcc652908a7978912d1e5c20d6b95431da2a6e0", "parents": [ "364f741483c1bd2c18cb3ff2ad255c9042c5362d" ], "author": { "name": "Philip Zeyliger", "email": "philip@bold.dev", "time": "Mon Jun 02 07:04:34 2025 -0700" }, "committer": { "name": "Philip Zeyliger", "email": "philip@bold.dev", "time": "Mon Jun 02 07:04:34 2025 -0700" }, "message": "Add end session user feedback survey with skaband client coordination\n\nImplement comprehensive end session feedback system with thumbs up/down rating,\noptional text comments, and proper coordination with skaband clients to ensure\nfeedback delivery before process termination.\n\n- Add EndFeedback struct with Happy boolean and Comment string fields\n- Extend Agent struct with endFeedback field and GetEndFeedback/SetEndFeedback methods\n- Update State struct to include End field for exposing feedback in API\n- Modify /end handler to accept survey data (happy, comment fields)\n- Add skaband client coordination with WaitGroup and wait_for_end parameter\n\n- Replace simple window.confirm with custom modal dialog\n- Create comprehensive survey UI with thumbs up/down buttons\n- Add optional textarea for detailed feedback\n- Implement proper button state management and validation\n- Maintain existing redirect behavior after successful end request\n\n- Track clients connecting with /stream?wait_for_end\u003dtrue parameter\n- Use WaitGroup to coordinate end session messaging\n- Proper WaitGroup management with conditional defer to prevent double-decrement\n- Smart timeout handling: measure elapsed time and ensure minimum 100ms response delay\n- Wait up to 2 seconds for waiting clients, timeout gracefully if needed\n\n**Survey Dialog Features:**\n- Modal overlay with centered positioning and backdrop click handling\n- Visual feedback for thumbs up/down selection with color coding\n- Expandable textarea for optional detailed comments\n- Cancel option to abort end session process\n- Proper event handling and cleanup\n\n**State Management:**\n- EndFeedback data flows through Agent -\u003e State -\u003e SSE streams\n- Clients waiting for end automatically receive feedback via state updates\n- WaitGroup ensures coordinated shutdown after notification delivery\n- Exactly one Done() call per Add() to prevent race conditions\n\n**API Contract:**\nPOST /end now accepts:\n{\n \"reason\": \"user requested end of session\",\n \"happy\": true, // optional boolean\n \"comment\": \"Great experience!\" // optional string\n}\n\n**Error Handling:**\n- Survey submission proceeds even if rating not selected (null happy value)\n- Empty comments are handled gracefully\n- Network failures fall back to existing error reporting\n- Proper resource cleanup and thread-safe operations\n\n**Testing:**\n- Added comprehensive unit tests for EndFeedback functionality\n- Updated mockAgent to implement new CodingAgent interface methods\n- All existing tests continue to pass\n- Manual API testing confirmed survey data flows correctly\n\nThis enhances user experience by collecting valuable feedback while maintaining\nrobust session termination and proper coordination with external monitoring\nsystems via the skaband protocol.\n\nCo-Authored-By: sketch \u003chello@sketch.dev\u003e\nChange-ID: s16561e134e8e81aak\n" }, { "commit": "6cad861fbb3dbb646d190b7a5efc2fe982ea3aa8", "tree": "a806f698dea80e939896d5bb8817b42979305b2e", "parents": [ "33032d3d37b25537fe85f0afd9238ca2ece4bd71" ], "author": { "name": "Josh Bleecher Snyder", "email": "josharian@gmail.com", "time": "Fri May 30 19:25:39 2025 +0000" }, "committer": { "name": "Josh Bleecher Snyder", "email": "josharian@gmail.com", "time": "Fri May 30 12:34:24 2025 -0700" }, "message": "webui: fix multiple choice to append instead of replace chat content\n\nFix multiple choice button behavior to append selected text to existing\nchat input content instead of replacing it entirely, providing a better\nuser experience when users have already typed text.\n\nProblem Analysis:\nWhen users clicked multiple choice buttons, the _handleMutlipleChoiceSelected\nmethod was replacing all existing content in the chat input textarea:\n\n chatInput.content \u003d e.detail.responseText; // Replaces everything\n\nThis meant if users had typed some text and then clicked a multiple choice\noption, their previous text would be completely lost.\n\nImplementation:\nModified _handleMutlipleChoiceSelected in sketch-app-shell.ts to:\n\n1. Check if existing content is present in the chat input\n2. If content exists, add proper spacing (\\n\\n) between existing and new text\n3. Append the selected response text instead of replacing\n4. Call adjustChatSpacing() to resize textarea for new content\n5. Maintain focus on the input field\n\nTechnical Details:\n- Uses same append pattern as _handleDiffComment method in chat input\n- Adds two newlines for proper visual separation when appending\n- Triggers textarea height adjustment via requestAnimationFrame\n- Preserves existing behavior when chat input is empty (no spacing added)\n\nTesting:\n- All existing Playwright tests continue to pass (40 passed, 4 skipped)\n- TypeScript compilation successful with no errors\n- Changes isolated to single method with clear behavioral improvement\n\nThis ensures users can build up their messages incrementally by typing\ntext and then selecting from multiple choice options without losing\ntheir previous input.\n\nCo-Authored-By: sketch \u003chello@sketch.dev\u003e\nChange-ID: s284c59aa73ee4311k\n" }, { "commit": "00bcaef0355aaff1daea17ac0631fd17cabb0235", "tree": "7b1c05bafa95d90c682af161579c93012ef22a16", "parents": [ "c7cdd77f99dece73f223597263f8495c15d7f35f" ], "author": { "name": "Philip Zeyliger", "email": "philip@bold.dev", "time": "Fri May 30 04:21:15 2025 +0000" }, "committer": { "name": "Autoformatter", "email": "bot@sketch.dev", "time": "Fri May 30 05:13:07 2025 +0000" }, "message": "webui: remove unused diff2html-based diff view\n\nRemove the old diff view implementation that used diff2html library\nin favor of the Monaco-based diff2 view. This cleanup removes:\n\n- sketch-diff-view.ts component that used diff2html library\n- diff2html static CSS files (diff2html.min.css, diff2.css)\n- diff2html npm package dependency from package.json\n- Old diff view mode references throughout the codebase\n- Demo files for the old diff view component\n\nChanges include:\n\n1. Removed Files:\n - webui/src/web-components/sketch-diff-view.ts\n - webui/src/diff2html.min.css\n - webui/src/diff2.css\n - webui/src/web-components/demo/sketch-diff-view.demo.html\n\n2. Updated Components:\n - sketch-app-shell.ts: Remove old diff view import, ViewMode type,\n CSS selectors, and view switching logic\n - sketch-view-mode-select.ts: Update type definitions to remove \u0027diff\u0027 mode\n - sketch-terminal.ts: Fix view mode type and correct CSS loading comments\n\n3. Package Management:\n - Removed diff2html 3.4.51 dependency from package.json\n - Updated package-lock.json to reflect removed dependency\n\n4. Demo Cleanup:\n - Removed reference to old diff view demo from index.html\n - Updated timeline demo to remove diff2html from dependencies list\n\nThe Monaco-based diff2 view (sketch-diff2-view.ts) remains fully\nfunctional and is now the only diff view implementation. All file\npicker, range picker, and empty view components continue to work\nwith the new diff view.\n\nTesting confirms the diff functionality works correctly after cleanup.\n\nCo-Authored-By: sketch \u003chello@sketch.dev\u003e\nChange-ID: s22dd1dc722d02125k\n" }, { "commit": "71c73b513bc51a5cf6108394a84fcf143cc5e3f8", "tree": "afd670203456ef144614f3e709227c595dab99f9", "parents": [ "bcc1c41fbb3a2b36f012d698d9dc02bda5cc9b19" ], "author": { "name": "Autoformatter", "email": "bot@sketch.dev", "time": "Thu May 29 20:18:43 2025 +0000" }, "committer": { "name": "Autoformatter", "email": "bot@sketch.dev", "time": "Thu May 29 20:18:43 2025 +0000" }, "message": "all: fix formatting\n" }, { "commit": "bcc1c41fbb3a2b36f012d698d9dc02bda5cc9b19", "tree": "89a63acd37aa8a24392b2425174f644b2c22afa2", "parents": [ "dee39e0926915213ccb6722a7e24b8ac7288bd87" ], "author": { "name": "Josh Bleecher Snyder", "email": "josharian@gmail.com", "time": "Thu May 29 00:36:49 2025 +0000" }, "committer": { "name": "Josh Bleecher Snyder", "email": "josharian@gmail.com", "time": "Thu May 29 12:50:41 2025 -0700" }, "message": "git_tools: add rename detection and proper handling of moved files\n\nEnhance GitRawDiff to properly handle file renames and moves by:\n\n1. Add -M flag to git diff commands to enable rename detection\n2. Update parseRawDiff to handle the different output format for renames:\n - Rename format: :oldmode newmode oldhash newhash R100 old_path new_path\n - Split rename operations into separate delete and add entries\n - This allows Monaco diff view to display both old and new files\n\n3. Update DiffFile comment to document rename/copy status codes\n\nThe fix addresses GitHub issue #120 where Monaco diff view would error\nwhen displaying files that were both modified and renamed. By splitting\nrenames into delete/add pairs, the existing UI can handle moved files\nwithout requiring frontend changes.\n\nFixes #120\n\nCo-Authored-By: sketch \u003chello@sketch.dev\u003e\nChange-ID: s172724445cadbd68k\n" }, { "commit": "dee39e0926915213ccb6722a7e24b8ac7288bd87", "tree": "e487922e47a18eb94b13ac9e2212e7652f776e0f", "parents": [ "2d08119c97f1a909ba4f17827aee31aa98b8b2e7" ], "author": { "name": "Josh Bleecher Snyder", "email": "josharian@gmail.com", "time": "Thu May 29 14:25:08 2025 +0000" }, "committer": { "name": "Josh Bleecher Snyder", "email": "josharian@gmail.com", "time": "Thu May 29 12:50:41 2025 -0700" }, "message": "webui: fix chat timeline scrolling to reach exact bottom\n\nImplement robust scroll-to-bottom behavior with retry logic to handle\ndynamic content rendering and ensure chat view scrolls completely to\nthe bottom when browser windows are opened.\n\nThe issue occurred when popping browser windows - the chat timeline\nwould scroll toward the bottom but not reach the exact bottom position,\nleaving some content (like the input field) partially visible or cut off.\n\nRoot cause analysis:\n- 50ms timeout insufficient for dynamic content (images, tool cards) to render\n- scrollHeight calculation happened before final layout was complete\n- smooth scroll behavior could be interrupted by subsequent layout changes\n- 1px tolerance in scroll detection too strict for various screen sizes\n\nImplementation improvements:\n\n1. Enhanced scrollToBottom() method:\n - Switch from \u0027smooth\u0027 to \u0027instant\u0027 scroll behavior for reliability\n - Calculate exact target scroll position (scrollHeight - clientHeight)\n - Add null safety checks for scroll container\n\n2. New scrollToBottomWithRetry() method:\n - Retry logic with up to 5 attempts at 50ms intervals\n - Verify actual scroll position after each attempt\n - Continue retrying until exactly at bottom or max attempts reached\n - Prevents race conditions with dynamic content loading\n\n3. Improved scroll detection accuracy:\n - Increased tolerance from 1px to 3px for isAtBottom detection\n - Better handling of fractional pixel differences across browsers\n - More reliable detection of \u0027pinToLatest\u0027 vs \u0027floating\u0027 states\n\n4. Enhanced timing and integration:\n - Increased initial timeout from 50ms to 100ms for content rendering\n - Updated both automatic scroll (on message changes) and manual scroll (jump-to-latest button)\n - Consistent behavior across all scroll triggers\n\nTechnical benefits:\n- Eliminates incomplete scrolling that left content partially visible\n- Handles dynamic content loading (images, expanding tool cards, etc.)\n- Provides immediate feedback with instant scroll behavior\n- Self-correcting through retry mechanism for timing edge cases\n- Better cross-browser compatibility with increased tolerance\n\nTesting verification:\n- Started test sketch instance and verified complete scroll behavior\n- Confirmed chat scrolls to exact bottom showing input field fully\n- Verified manual \u0027jump to latest\u0027 button works correctly\n- Screenshots show complete message content and input accessibility\n\nThis ensures users always see the complete conversation and can easily\naccess the input field when browser windows are opened, resolving the\nreported incomplete scrolling behavior.\n\nCo-Authored-By: sketch \u003chello@sketch.dev\u003e\nChange-ID: sa9a8755f69c688cfk\n" }, { "commit": "2d08119c97f1a909ba4f17827aee31aa98b8b2e7", "tree": "05b909119621bbcd6cb258324b0bf0f1cbaf950e", "parents": [ "991164f3a46ff109723105b737eb9e4ed3426873" ], "author": { "name": "Josh Bleecher Snyder", "email": "josharian@gmail.com", "time": "Thu May 29 13:46:04 2025 +0000" }, "committer": { "name": "Josh Bleecher Snyder", "email": "josharian@gmail.com", "time": "Thu May 29 12:50:41 2025 -0700" }, "message": "webui: add comprehensive browser tool cards and termui support\n\nImplement complete browser tool card coverage with simple, clean styling\nfollowing the established bash tool card pattern and add missing termui\nhandling for all browser tools.\n\nMissing tool coverage identified after commit e7806fbc which added\nbrowser_navigate tool card, revealing gaps in both webui and termui\nsupport for the complete browser tool suite.\n\nChanges include:\n\n1. New browser tool cards with simple, consistent styling:\n - browser_click: Shows CSS selector with mouse pointer icon\n - browser_type: Shows selector and text input with keyboard icon\n - browser_wait_for: Shows selector with hourglass icon for waiting\n - browser_get_text: Shows selector with book icon for text extraction\n - browser_eval: Shows JavaScript expression with mobile phone icon\n - browser_scroll_into_view: Shows selector with arrows icon for scrolling\n - browser_resize: Shows dimensions in WxH format with frame icon\n - browser_read_image: Shows filename with truncated path display\n - browser_recent_console_logs: Shows log count with document icon\n - browser_clear_console_logs: Shows clear action with broom icon\n\n2. Updated tool calls mapping system:\n - Added all 10 new browser tool card imports to sketch-tool-calls.ts\n - Extended cardForToolCall() switch statement with proper case handling\n - Consistent HTML template pattern following existing tool cards\n - Proper TypeScript declarations for all new components\n\n3. Enhanced termui template with browser tool support:\n - Added template cases for all 12 browser tools in toolUseTemplTxt\n - Consistent emoji icons and concise display formatting\n - Proper parameter extraction for selectors, URLs, dimensions\n - Truncation and formatting for clean terminal display\n\n4. Simple, maintainable styling approach:\n - Monospace fonts for technical data (selectors, expressions)\n - Subtle background highlights for input parameters\n - Break-word handling for long selectors and URLs\n - Consistent icon usage for quick visual tool identification\n - Minimal CSS to keep cards lightweight and debuggable\n\nTechnical implementation:\n- All tool cards extend LitElement with standard properties\n- JSON input parsing with error handling for malformed data\n- Slot-based content organization following base tool card pattern\n- Consistent summary, input, and result slot population\n- TypeScript interface declarations for proper type checking\n\nTesting verification:\n- Started test sketch instance and verified tool cards render correctly\n- Confirmed browser_take_screenshot card shows timing and status icons\n- Verified browser_type card displays selectors and input text properly\n- Validated browser_read_image card shows filename truncation\n- All tool cards follow established simple styling without visual clutter\n\nThis provides complete browser tool coverage in both webui and termui,\nmaintaining the clean, simple aesthetic while ensuring all browser\nautomation tools have proper visual representation and status reporting.\n\nCo-Authored-By: sketch \u003chello@sketch.dev\u003e\nChange-ID: s79b2200705afaee8k\n" }, { "commit": "991164f3a46ff109723105b737eb9e4ed3426873", "tree": "2130a0ea66503cd5123d2f340a91684698266ce9", "parents": [ "112b92376c97b8da64cc1c954896957cfc479f3d" ], "author": { "name": "Josh Bleecher Snyder", "email": "josharian@gmail.com", "time": "Thu May 29 05:02:10 2025 +0000" }, "committer": { "name": "Josh Bleecher Snyder", "email": "josharian@gmail.com", "time": "Thu May 29 12:50:41 2025 -0700" }, "message": "webui: add specialized tool card for keyword_search tool\n\nCreate dedicated tool card component for keyword_search with enhanced\nvisual presentation and proper display formatting to improve tool\nvisibility and user experience in the webui interface.\n\nImplementation Details:\n\n1. Created SketchToolCardKeywordSearch component:\n - Displays search icon (🔍) with query text in summary\n - Shows truncated search terms with \"...\" indicator for overflow\n - Structured input display with Query and Search terms sections\n - Proper result display in pre-formatted text block\n\n2. Enhanced visual presentation:\n - Flexible layout with query text taking available space\n - Search terms displayed in monospace font with subtle background\n - Responsive design that handles long queries and term lists\n - Consistent styling with other specialized tool cards\n\n3. Integrated with tool card system:\n - Added keyword_search case to cardForToolCall() switch statement\n - Registered component in HTMLElementTagNameMap declarations\n - Follows established pattern for specialized tool card components\n\n4. Visual summary improvements:\n - Query text with search icon for immediate recognition\n - First 3 search terms shown with overflow indication\n - Clean separation between query and search terms\n - Maintains compact display in timeline view\n\nThe specialized tool card replaces the generic fallback for keyword_search\noperations, providing better visual hierarchy and more intuitive display\nof search parameters and results. This enhances the debugging and review\nexperience when working with keyword search operations in the interface.\n\nTesting confirmed the component renders correctly and displays keyword_search\ntool calls with proper formatting and visual indicators in the webui timeline.\n\nCo-Authored-By: sketch \u003chello@sketch.dev\u003e\nChange-ID: sd04c9e87873b5d0ck\n" }, { "commit": "112b92376c97b8da64cc1c954896957cfc479f3d", "tree": "1497eb8b2927f1334d712aabb19625db11a148bf", "parents": [ "d203b7de7d49cc5da03440d5a00b2efd0f8bb2c8" ], "author": { "name": "Josh Bleecher Snyder", "email": "josharian@gmail.com", "time": "Fri May 23 11:26:33 2025 -0700" }, "committer": { "name": "Josh Bleecher Snyder", "email": "josharian@gmail.com", "time": "Thu May 29 12:50:41 2025 -0700" }, "message": "loop: add todo checklist\n\nThis should improve Sketch\u0027s executive function and user communication." }, { "commit": "57893c274ca6d7936580b8bd97af9e5a4b4dcd51", "tree": "bcb821ad46e0197c71979dbefbac597c33f0b9c1", "parents": [ "4d90f34a3acf65e369cddd0f6838e2ec1d23dfcf" ], "author": { "name": "Autoformatter", "email": "bot@sketch.dev", "time": "Thu May 29 13:49:53 2025 +0000" }, "committer": { "name": "Autoformatter", "email": "bot@sketch.dev", "time": "Thu May 29 13:49:53 2025 +0000" }, "message": "all: fix formatting\n" }, { "commit": "4d90f34a3acf65e369cddd0f6838e2ec1d23dfcf", "tree": "01a1b5df4228299a4fac2f95830bd72f9856336c", "parents": [ "d9b1eb4d5342d6be3b4f975463a3831abb581f7f" ], "author": { "name": "Josh Bleecher Snyder", "email": "josharian@gmail.com", "time": "Thu May 29 02:18:38 2025 +0000" }, "committer": { "name": "Josh Bleecher Snyder", "email": "josharian@gmail.com", "time": "Thu May 29 06:39:30 2025 -0700" }, "message": "webui: add cmd+s keyboard shortcut to Monaco diff editor\n\nAdd Cmd+S (Ctrl+S on Windows/Linux) keyboard shortcut to trigger save\nin Monaco diff editor instead of browser save dialog.\n\nThis prevents people with cmd+s-in-editor habits from constantly\nhaving to dismiss browser save pop-up dialogs.\n\nCo-Authored-By: sketch \u003chello@sketch.dev\u003e\nChange-ID: sd86641652ae6f54ak" }, { "commit": "e89b3080f934a4bc70a0cfa85ffff49ac78d6f2b", "tree": "f3bcf44b2907c5c18f555b31df923488bb5efdc7", "parents": [ "7ad1c7a4b759f4ba110d092a0fbbed0b95fc80a9" ], "author": { "name": "Philip Zeyliger", "email": "philip@bold.dev", "time": "Thu May 29 03:16:06 2025 +0000" }, "committer": { "name": "Autoformatter", "email": "bot@sketch.dev", "time": "Thu May 29 03:20:15 2025 +0000" }, "message": "webui: comprehensive diff view improvements\n\nImplement multiple enhancements to the diff view interface for better\nusability and visual consistency with file change statistics and\nimproved navigation controls.\n\nBackend Changes:\n1. Enhanced git diff endpoint with --numstat support:\n - Modified GitRawDiff to execute both --raw and --numstat commands\n - Added Additions/Deletions fields to DiffFile struct\n - Parse numstat output to show line change statistics (+X, -Y)\n - Handle binary files and edge cases properly\n\nFrontend UI Improvements:\n2. File picker enhancements:\n - Display (+X, -Y) change indicators next to file names\n - Move file position indicator (\"X of Y\") between navigation buttons\n - Simplified file info to show only status (Modified/Added/Deleted)\n - Better visual grouping of navigation-related information\n\n3. Commit range picker refresh functionality:\n - Added refresh button with subtle styling (gray background)\n - 🔄 icon with \"Refresh commit list\" tooltip\n - Reloads git log to get updated branch and commit information\n - Proper disabled state during loading operations\n\n4. Editable file indicator improvements:\n - Moved \"Editable\" indicator to Monaco editor save indicator area\n - Shows \"Editable\" when file is editable but unchanged\n - Consistent styling with \"Modified\", \"Saving\", \"Saved\" states\n - Added proper CSS styling with gray background for idle state\n\n5. Expand/collapse button redesign:\n - Custom SVG icons replacing text buttons\n - Expand All: dotted line with arrows pointing away (outward)\n - Collapse: dotted line with arrows pointing inward (toward line)\n - Intuitive visual metaphor for show/hide functionality\n - Enhanced tooltips with full action descriptions\n - Renamed \"Hide Unchanged\" to \"Collapse Expanded Lines\"\n\nTechnical Improvements:\n6. TypeScript compatibility fixes:\n - Updated mock data service with new DiffFile fields\n - Fixed MSW handler type compatibility with proper type assertion\n - Maintained full TypeScript checking without exclusions\n - Added realistic mock data for testing change indicators\n\nInterface Consistency:\n- All buttons use consistent styling and hover effects\n- Better separation between navigation controls and file information\n- Improved logical grouping of related UI elements\n- Enhanced accessibility with descriptive tooltips\n\nThese changes significantly improve the diff view experience by providing\nclear visual indicators of file changes, intuitive navigation controls,\nand better organization of interface elements according to their function.\n\nCo-Authored-By: sketch \u003chello@sketch.dev\u003e\n\nChange-ID: s738289d132773bc3k\n" }, { "commit": "7ad1c7a4b759f4ba110d092a0fbbed0b95fc80a9", "tree": "a8d2543ec9c660b69289a2233442208d29ba29b2", "parents": [ "444f7f00ff439e79b65cf3d2efd4ad66a698af2c" ], "author": { "name": "Autoformatter", "email": "bot@sketch.dev", "time": "Thu May 29 02:00:19 2025 +0000" }, "committer": { "name": "Autoformatter", "email": "bot@sketch.dev", "time": "Thu May 29 02:00:19 2025 +0000" }, "message": "all: fix formatting\n" }, { "commit": "444f7f00ff439e79b65cf3d2efd4ad66a698af2c", "tree": "7271aaf5cbf3ba074b732c3d264bd47082fa9d2a", "parents": [ "b34b8b307e8d804b6ea3f2596388708839f30e58" ], "author": { "name": "Josh Bleecher Snyder", "email": "josharian@gmail.com", "time": "Wed May 28 21:16:55 2025 +0000" }, "committer": { "name": "Josh Bleecher Snyder", "email": "josharian@gmail.com", "time": "Wed May 28 18:59:10 2025 -0700" }, "message": "webui: expand Monaco comment selections to full lines for better context\n\nEnhances the Monaco diff editor comment functionality to automatically\nexpand any text selection to include complete lines, providing better\ncontext for LLM analysis and code review discussions.\n\nChanges include:\n\n1. Modified handleSelectionChange method in sketch-monaco-view.ts:\n - Automatically expands selection start to column 1 (beginning of line)\n - Expands selection end to the maximum column of the end line\n - Updates both selectedText and selectionRange to reflect full lines\n - Maintains existing line number calculation for comment headers\n\n2. Enhanced selection behavior:\n - Partial line selections now include the entire line(s)\n - Multi-line partial selections expand to include complete first and last lines\n - Already full-line selections remain unchanged\n - Preserves line number information for accurate comment context\n\nThe expansion logic uses Monaco\u0027s getLineMaxColumn() method to determine\nproper line boundaries and getValueInRange() to extract the complete\ntext. This ensures that comments always include meaningful, complete\ncode segments rather than partial fragments.\n\nCo-Authored-By: sketch \u003chello@sketch.dev\u003e\nChange-ID: s7a8b9c2d3e4f5g6k\n" }, { "commit": "b34b8b307e8d804b6ea3f2596388708839f30e58", "tree": "d11dfa24942aae9784b18cfa0a3e47758ffb57f5", "parents": [ "efa8f436182a310f7c5eaaf0f9f4787ba4fd3693" ], "author": { "name": "Josh Bleecher Snyder", "email": "josharian@gmail.com", "time": "Wed May 28 21:00:56 2025 +0000" }, "committer": { "name": "Josh Bleecher Snyder", "email": "josharian@gmail.com", "time": "Wed May 28 18:58:56 2025 -0700" }, "message": "webui: add line numbers to Monaco diff view comment auto-inserted text\n\nEnhances the Monaco diff editor comment functionality to include line\nnumbers in the auto-inserted context text when users add comments to\nselected code. The comments now show specific line information along\nwith the filename and editor type.\n\nChanges include:\n\n1. Modified sketch-monaco-view.ts submitComment method:\n - Added line number calculation logic using this.selectionRange\n - Single line selections show \u0027(line N)\u0027 format\n - Multi-line selections show \u0027(lines N-M)\u0027 format\n - No line info added when selectionRange is unavailable\n - Line info is appended to the existing fileContext and editorLabel\n\n2. Enhanced comment format from:\n \u0027filename [Modified]:\u0027\n to:\n \u0027filename [Modified] (line 42):\u0027\n or:\n \u0027filename [Modified] (lines 10-15):\u0027\n\n3. Line number extraction uses Monaco\u0027s selection tracking:\n - Leverages existing selectionRange state from handleSelectionChange\n - Works for both original and modified editors in diff view\n - Maintains backwards compatibility when selectionRange is null\n\nThe auto-inserted comment text now provides precise line context,\nmaking comments more useful for code review and collaboration by\nclearly indicating which specific lines are being referenced.\nThis addresses the issue where comments lacked line number context,\nmaking it difficult to locate the referenced code.\n\nCo-Authored-By: sketch \u003chello@sketch.dev\u003e\nChange-ID: s2b4c8f9a1e6d7e3k\n" }, { "commit": "7027307b381e2b8421c95ebb2f872b8e3c567f3e", "tree": "7f9027f4ba1f57b305ebfba47d3b0d920093de95", "parents": [ "837699bf55d27975e9e5b881b8794683bb1b10c8" ], "author": { "name": "Philip Zeyliger", "email": "philip@bold.dev", "time": "Wed May 28 18:26:14 2025 +0000" }, "committer": { "name": "Autoformatter", "email": "bot@sketch.dev", "time": "Wed May 28 22:47:10 2025 +0000" }, "message": "webui: replace hardcoded Monaco language map with dynamic detection\n\nReplace the static language mapping in the Monaco diff editor with\nMonaco\u0027s built-in language registry for automatic language detection.\n\nChanges:\n1. Remove hardcoded langMap that only supported 8 languages (js, ts, py,\n html, css, json, md, go)\n2. Implement dynamic language detection using monaco.languages.getLanguages()\n3. Cache language list for performance since it doesn\u0027t change at runtime\n4. Maintain exact extension matching including the dot prefix (.js, .ts, etc.)\n5. Preserve fallback to \u0027plaintext\u0027 for unknown extensions\n\nBenefits:\n- Automatically supports all languages Monaco knows about (40+ languages)\n- No maintenance burden when Monaco adds new language support\n- Removes duplication between Monaco\u0027s registry and our hardcoded map\n- Better future-proofing as Monaco language support evolves\n\nThe implementation uses Monaco\u0027s ILanguageExtensionPoint interface which\nprovides language.extensions arrays for each registered language. This\nis more reliable than maintaining our own mapping and ensures consistency\nwith Monaco\u0027s actual language support.\n\nCo-Authored-By: sketch \u003chello@sketch.dev\u003e\n\nChange-ID: sca31f0ae899ae54dk\n" }, { "commit": "77bac8c26324bad3c4b903a5321a2b0a078881ba", "tree": "56fae11aa90aa418eca2c72bee7d4b0510f6160f", "parents": [ "d85e97d97d2e88415bf1a87557278afd14f6d202" ], "author": { "name": "Josh Bleecher Snyder", "email": "josharian@gmail.com", "time": "Wed May 28 11:04:09 2025 -0700" }, "committer": { "name": "Josh Bleecher Snyder", "email": "josharian@gmail.com", "time": "Wed May 28 11:33:56 2025 -0700" }, "message": "webui: make diff loading error message more useful\n" }, { "commit": "d85e97d97d2e88415bf1a87557278afd14f6d202", "tree": "88e36c41930314fc74901b9de9794ad8ac49c2ba", "parents": [ "a442ce32ac95d7e8337fba0a82f94cbd60be1296" ], "author": { "name": "Philip Zeyliger", "email": "philip@bold.dev", "time": "Wed May 28 17:59:08 2025 +0000" }, "committer": { "name": "Philip Zeyliger", "email": "philip@bold.dev", "time": "Wed May 28 11:17:24 2025 -0700" }, "message": "webui: remove unused language property from Monaco editor\n\nRemove dead code - the language property was never set when the component\nis used, so it always defaulted to \u0027javascript\u0027 and was never meaningful.\n\nThe getLanguageForFile method now uses a simpler fallback:\nlangMap[extension] || \u0027plaintext\u0027\n\nSince filenames always have extensions in practice, this removes an\nunnecessary intermediate fallback that was never actually used.\n\nCo-Authored-By: sketch \u003chello@sketch.dev\u003e\nChange-ID: s16c137c6267b58a5k\n" }, { "commit": "217e987e1c8d16907849e1f8ba7e5dd8ad4af052", "tree": "65e06a1dedfccabd81e28a9585adce6d210a38ea", "parents": [ "f178755c781c74ef242762ceb2c707c9a4dd2676" ], "author": { "name": "Josh Bleecher Snyder", "email": "josharian@gmail.com", "time": "Wed May 28 09:26:05 2025 -0700" }, "committer": { "name": "Josh Bleecher Snyder", "email": "josharian@gmail.com", "time": "Wed May 28 10:36:09 2025 -0700" }, "message": "Revert \"webui: fix diff view failing when added file doesn\u0027t exist in working directory\"\n\nThis reverts commit 4c7865b4763552f4294e7a3738b796ea918a7c3d.\n\nThe real problem appears to be a race of some kind.\nThis is not the fix.\n" }, { "commit": "afeafea91f20db4e5b99620df98baa1628bfeaf1", "tree": "7ba3f14d663cbc73bf78f8986bb5d3afe332e7b2", "parents": [ "4c7865b4763552f4294e7a3738b796ea918a7c3d" ], "author": { "name": "Josh Bleecher Snyder", "email": "josharian@gmail.com", "time": "Fri May 23 20:27:39 2025 +0000" }, "committer": { "name": "Josh Bleecher Snyder", "email": "josharian@gmail.com", "time": "Fri May 23 14:25:55 2025 -0700" }, "message": "webui: change Monaco editor comment submit button from Submit to Add\n\nUpdates the Monaco editor\u0027s comment submission button text from \u0027Submit\u0027\nto \u0027Add\u0027 for better consistency with the UI and more concise labeling.\n\nThe button functionality remains unchanged - it still submits comments\non selected code sections in the Monaco editor view.\n\nCo-Authored-By: sketch \u003chello@sketch.dev\u003e\nChange-ID: seca3827c274ff3cdk\n" }, { "commit": "4c7865b4763552f4294e7a3738b796ea918a7c3d", "tree": "7e26038aaf5393a2df9d5b945a6840555e7a661d", "parents": [ "ed17fdf0b3ea6c0b8a8f96125ccc785c5587bb9c" ], "author": { "name": "Josh Bleecher Snyder", "email": "josharian@gmail.com", "time": "Fri May 23 17:26:34 2025 +0000" }, "committer": { "name": "Josh Bleecher Snyder", "email": "josharian@gmail.com", "time": "Fri May 23 13:51:38 2025 -0700" }, "message": "webui: fix diff view failing when added file doesn\u0027t exist in working directory\n\nWhen viewing uncommitted changes in the diff view and there\u0027s a file that\nwas added in the latest commit but doesn\u0027t exist in the current working\ndirectory, the code was trying to fetch the working copy content and\nfailing with \u0027Failed to fetch working copy content\u0027.\n\nThis adds fallback logic for added files (status \u0027A\u0027) to use the\ncommitted content from git when the working copy cannot be retrieved,\nsimilar to how deleted files are already handled.\n\nThe fix changes the error handling in loadFileContent() to:\n- Check if file status is \u0027A\u0027 (added) and has a new_hash\n- Fall back to using gitService.getFileContent(file.new_hash) instead\n of failing completely\n- Log a warning but continue gracefully\n\nThis ensures the diff view works correctly when showing ranges ending\nin \u0027uncommitted changes\u0027 even with files that were added but later\nremoved from the working directory.\n\nCo-Authored-By: sketch \u003chello@sketch.dev\u003e\nChange-ID: s73a6d30e7af97e82k\n" }, { "commit": "9bca61ef623ea8cd72a906752be73af572af02a9", "tree": "4d6488b6e6e8543c3f0b5e1682d11e0927c27d1b", "parents": [ "75bd37d2a3067b6f431d56e891064b73dc2def2c" ], "author": { "name": "Philip Zeyliger", "email": "philip@bold.dev", "time": "Thu May 22 12:40:06 2025 -0700" }, "committer": { "name": "Philip Zeyliger", "email": "philip@bold.dev", "time": "Thu May 22 12:44:59 2025 -0700" }, "message": "feat: enhance UI with commit pulsing animation and improved copy icon\n\nCo-Authored-By: sketch \u003chello@sketch.dev\u003e\nChange-ID: s80fdaac660ea645ek\n" }, { "commit": "8c3b53a97ae2a204842c0c86ca859947ce20b1dd", "tree": "6532221877cdcb1bd572144fcc5926cfd4231ecb", "parents": [ "456d5f9d4213deab28a1f528cb8edc3a1f8d5262" ], "author": { "name": "Autoformatter", "email": "bot@sketch.dev", "time": "Thu May 22 18:30:58 2025 +0000" }, "committer": { "name": "Autoformatter", "email": "bot@sketch.dev", "time": "Thu May 22 18:30:58 2025 +0000" }, "message": "all: fix formatting\n" }, { "commit": "14fe75d6ece5116b3887b6fc027e564c4de518e6", "tree": "5a3e72a02da8d06818fcd3531147087f8741f81b", "parents": [ "f28729932fdf9ecc67d3fabbfca297178a323a14" ], "author": { "name": "Philip Zeyliger", "email": "philip@bold.dev", "time": "Thu May 22 17:39:38 2025 +0000" }, "committer": { "name": "Philip Zeyliger", "email": "philip@bold.dev", "time": "Thu May 22 11:28:39 2025 -0700" }, "message": "webui: Remove restart conversation button and modal component\n\nCo-Authored-By: sketch \u003chello@sketch.dev\u003e\nChange-ID: s0da284ec42d4da59k\n" }, { "commit": "55c87e3ababb0800b5710cbb11bec4dea8c13515", "tree": "13517efe8467be99714a65a24963873cbe18e137", "parents": [ "9d7f0ccec1317b68c754b6b154f7c362395028c2" ], "author": { "name": "Pokey Rule", "email": "755842+pokey@users.noreply.github.com", "time": "Tue May 20 14:08:18 2025 +0100" }, "committer": { "name": "Pokey Rule", "email": "755842+pokey@users.noreply.github.com", "time": "Tue May 20 13:11:23 2025 +0000" }, "message": "webui: Fix cursor jumping during image uploads\n\nWhen pasting an image and continuing to type while it\u0027s uploading,\nthe cursor position would jump when upload completed, disrupting typing.\n\nThis fix simply removes the explicit cursor positioning code after\nimage upload, allowing the browser to maintain the user\u0027s current cursor\nposition naturally. This provides a more intuitive experience, especially\nwhen typing while an image is uploading.\n\nThe approach is simpler and more robust than trying to track cursor\nposition changes and calculate offsets manually.\n" }, { "commit": "397871d299216f63dc38a9cc6f2ca386d0f4bd75", "tree": "ea1cec9278f37739f972a390b0ec564a1fe9219f", "parents": [ "a8322202f36c35f677b8834cdce8f21ab3d8c6dc" ], "author": { "name": "Pokey Rule", "email": "755842+pokey@users.noreply.github.com", "time": "Mon May 19 15:02:45 2025 +0100" }, "committer": { "name": "Autoformatter", "email": "bot@sketch.dev", "time": "Mon May 19 14:03:43 2025 +0000" }, "message": "webui: Add End button to shutdown container\n\nThis change adds a new button to the sketch-app-shell UI alongside the\nexisting Restart and Stop buttons. When clicked, the End button shows a\nconfirmation dialog and then sends a request to a new /end endpoint.\n\nThe /end endpoint gracefully shuts down the inner sketch container.\n\nFixes #88\n" }, { "commit": "8c4636270be67625cc27ce356f6da1a11e245069", "tree": "f6a4db58f1eb71033410150daa7290d4e41aca0a", "parents": [ "5e3570280bf3bb0f84482ff9556739d34eb08093" ], "author": { "name": "Autoformatter", "email": "bot@sketch.dev", "time": "Fri May 16 21:54:17 2025 +0000" }, "committer": { "name": "Autoformatter", "email": "bot@sketch.dev", "time": "Fri May 16 21:54:17 2025 +0000" }, "message": "all: fix formatting\n" }, { "commit": "5e3570280bf3bb0f84482ff9556739d34eb08093", "tree": "0721d16a93a8744466fb5206114d1f25b5b8cadb", "parents": [ "272a90ee1a74bda5618d4866e03f4b7067947784" ], "author": { "name": "Philip Zeyliger", "email": "philip@bold.dev", "time": "Fri May 16 04:50:34 2025 +0000" }, "committer": { "name": "Philip Zeyliger", "email": "philip@bold.dev", "time": "Fri May 16 14:53:24 2025 -0700" }, "message": "webui: Update status indicators\n\n- Remove green dot connection indicator\n- Add DISCONNECTED state with red styling when connection is lost\n- Update the status bar to show DISCONNECTED instead of IDLE/WORKING when disconnected\n- Create demo page to preview all three status states\n\nCo-Authored-By: sketch \u003chello@sketch.dev\u003e\nChange-ID: skR3m0v3Gr3nD0tD1sc0nn3ct3dR3d\n\nChange-ID: sa2b3679b9cdcaf80k\n" }, { "commit": "272a90ee1a74bda5618d4866e03f4b7067947784", "tree": "9baf4f84ce80b1c7073a95b6959f6dd11ab3b48b", "parents": [ "d3ac112a45111abf0e57c327d55e2cc66a136abb" ], "author": { "name": "Philip Zeyliger", "email": "philip@bold.dev", "time": "Fri May 16 14:49:51 2025 -0700" }, "committer": { "name": "Philip Zeyliger", "email": "philip@bold.dev", "time": "Fri May 16 14:51:40 2025 -0700" }, "message": "Add Monaco diff-view, the saga ...\n\nI set out to use Monaco to support the diff view. diff2html is lovely,\nbut there were a ton of usability improvements I wanted to make (line\nnumbers not making things double spaced, choosing which diff, editing\nthe right-hand side), and it seemed a dead end. Furthermore, Phabricator\nand Gerrit\u0027s experience is that diffs should be shown file by file,\nbecause you\u0027ll inevitably see a diff with a file that\u0027s too large, and\nthe GitHub PR view often breaks on big changes... so I wanted to show\nfiles diff-by-diff, with \"infinite\" context when unchanged sections are\nexpanded. So...\n\nUltimately, all of this was sketch-coded over maybe 30 Sketch sessions.\nI threw away a lot of branches. My git reflog is a superfund site.\n\nPrompting whole-hog didn\u0027t work. Or, rather, it made significant\nprogress, but something very serious wouldn\u0027t work, and I couldn\u0027t\nfigure out what, and nor could Sketch.\n\nInstead, I started by adding a new webcomponent that was just a\nplaceholder. Then, using https://rodydavis.com/posts/lit-monaco-editor,\nI nudged Sketch into adding Monaco to it. Sketch pulled out:\n\n You\u0027re right, I should properly read the blog post before implementing the\n solution. Let me check the referenced blog post.\n\nI worked heavily in the demo environment at first, but here I ran into\nthe issue that we have two different esbuild systems: one is vite and\none is esbuild.go, and they\u0027re configured differently enough.\n\nMonaco is unusable and confusingly so when its CSS isn\u0027t loaded. The right\nway to load it, I\u0027ve found, is via\n\n @import url(\u0027./static/monaco/min/vs/editor/editor.main.css\u0027);\n\nI spent more time than I care to admit noticing that originally\nthis wasn\u0027t relative, and when we use a skaband setting, the\npaths need to be relative-aware.\n\nThe paths to the various workers need to be similarly correctly placed.\n\nGetting Sketch to build demo data but not put testing code into production\ncode was tricky. (I threw away a lot of efforts and factories and singletons...)\n\nWhen I set out to do the git commit selection, I wanted to do a bunch of\nbackend /git/* handlers. These were easy enough to code in sketch. I had\nto convince Sketch to put them in git_tools.go and not in the agent.\nIt doesn\u0027t really matter: these functions to parse git are pretty stateless,\nbut it\u0027s less work to have them separate. Sketch was mediocre at writing\ntests for them. Did you know that our container has an older version\nof git that doesn\u0027t have the same options to decorate ref names? Yeah, nor did\nI.\n\nHandling unstaged changes was fun. git diff --raw shows unstaged files\nas having identity 0000. Ideally we\u0027d be using jj and there\u0027d be\na synthetic commit, but instead uncommitted-possible files are read\nby content.\n\nA real big challenge was getting the Monaco view to use the right vertical and\nhorizontal space. I did this many, many times. I don\u0027t claim to understand flex\nand the virtual dom, and :host, and all the interactions. It would fix one\nthing and break another. The chat window would shrink. The terminal would\nshrink.\n\nScreenshot support was excellent. I eventually added paste support just so\nthat I could expedite my workflow, and Sketch coded that easily on the first\npass with minor feedback.\n\nI learned the hard way that Safari\u0027s support for WebComponents/shadow\ndom in its web inspector is rough. See https://fediverse.zachleat.com/@zachleat/114518629612122858\n\nI also learned the hard way that Chrome doesn\u0027t use fonts loaded in CSS\nin a shadow dom. That\u0027s why the codicon font had to be in the global\nstyle sheet.\n\nKudos to John Reese who kindly allowed me, a long time ago, to adapt a\nshell script he had at work to look over diffs into https://github.com/philz/git-vimdiff.\nThat\u0027s the inspiration for having the \"new code\" be editable when you\u0027re\nreviewing it; why shouldn\u0027t it be!?!\n\nThere are a handful of follow up tasks:\n\n* We lose state when we switch to the Chat view and back.\n* Need URL-based support for where we are.\n* Maybe need shortcut keys to move between diffs and changes.\n* Maybe need caching or look-ahead for downloading the next or previous\n file.\n* We spend too much vertical real estate on all the diff selections;\n could we scroll it out of the way, collapse it, tighten it, etc.\n* The workers sometimes throw errors into the console. I think they\u0027re\n harmless and merely need to be caught and suppressed.\n* Needing to commit changes when things are saved is weird. Should we\n commit automatically? Amend the previous commit? Have a button for\n that? Show the git dirty state?\n* Our JS bundle is big. We could maybe delay loading the monaco bundle\n to help.\n\nThanks for coming to my TED talk.\n" }, { "commit": "8bdf627180b64b0dc09018bf512f6ebf192ab674", "tree": "47d9b1e5348a33846fc11704f99c3cf7151ec3f1", "parents": [ "0ead54d4591b9de1dedb897302f3ffaf36454c8e" ], "author": { "name": "Philip Zeyliger", "email": "philip@bold.dev", "time": "Fri May 16 13:36:21 2025 -0700" }, "committer": { "name": "Philip Zeyliger", "email": "philip@bold.dev", "time": "Fri May 16 14:51:40 2025 -0700" }, "message": "Playwright: don\u0027t use junit inside Sketch.\n\nI\u0027ve found Sketch doesn\u0027t understand the JUnit failure nearly\nas well as the usual way.\n" }, { "commit": "044a62e8e3d28a573c624d722f0fde38c30a19e2", "tree": "cfed4a459489b6f8c08c7aa98aa6ea416dc0f427", "parents": [ "276f460cc7136e50a07cf544ee5ef6bf2a1c2630" ], "author": { "name": "Pokey Rule", "email": "755842+pokey@users.noreply.github.com", "time": "Fri May 16 10:40:59 2025 +0000" }, "committer": { "name": "Autoformatter", "email": "bot@sketch.dev", "time": "Fri May 16 10:47:11 2025 +0000" }, "message": "webui: Prevent sending messages while uploads are in progress\n\nThis fixes an issue where users could press Enter immediately after pasting an image,\nwhich would submit the message with just the \u0027[Uploading image.png...]\u0027 placeholder text.\n\nNow the system:\n1. Tracks uploads in progress\n2. Prevents message submission while uploads are active\n3. Shows visual feedback to the user\n4. Disables the send button during uploads\n" }, { "commit": "bd7b625d4ca17b5cb5207b4917a6e61ea398f2d0", "tree": "32c1588d9cd5854d1322615d0aa14cc35d33f3a9", "parents": [ "e3c2f22ee87eb9830dad42ca0388b9743923ec59" ], "author": { "name": "Philip Zeyliger", "email": "philip@bold.dev", "time": "Thu May 15 16:21:36 2025 +0000" }, "committer": { "name": "Philip Zeyliger", "email": "philip@bold.dev", "time": "Thu May 15 15:14:37 2025 -0700" }, "message": "webui: reposition working/idle banner over lightbulb/wrench icons\n\nCo-Authored-By: sketch \u003chello@sketch.dev\u003e\nChange-ID: sb695b8b61b1f5134k\n" }, { "commit": "fbbf83bba97e2e2fd5e5ea1693c96efce1fdc3b1", "tree": "968706f07817a92905dbbc28a5bcdd1125bf4467", "parents": [ "a4092d26857aa5aeba70813e8942f321232e987c" ], "author": { "name": "Josh Bleecher Snyder", "email": "josharian@gmail.com", "time": "Thu May 15 10:55:55 2025 -0700" }, "committer": { "name": "Josh Bleecher Snyder", "email": "josharian@gmail.com", "time": "Thu May 15 13:17:42 2025 -0700" }, "message": "webui: tweak done tool card emojis\n\nDear Sketch, please stop using big red angry failure emojis.\nAlso, gender neutral is fine thank you very much.\n" } ], "next": "74d690e7b4794f2c164a9da30dd106a002b935d9" }