)]}'
{
  "log": [
    {
      "commit": "9abf803eeedd49261dc4e4c5b75dcb4d21cc6a0d",
      "tree": "abebff284ab5674aeacf125237619c26f998d1cb",
      "parents": [
        "26f3f34c25e21717001f0230d1abe7debbc5e0c0"
      ],
      "author": {
        "name": "Autoformatter",
        "email": "bot@sketch.dev",
        "time": "Sat Jun 14 23:24:08 2025 +0000"
      },
      "committer": {
        "name": "Autoformatter",
        "email": "bot@sketch.dev",
        "time": "Sat Jun 14 23:24:08 2025 +0000"
      },
      "message": "all: fix formatting\n"
    },
    {
      "commit": "26f3f34c25e21717001f0230d1abe7debbc5e0c0",
      "tree": "0ba518a643b4d165dd871b4a2cd28e5f096a017f",
      "parents": [
        "938d2dcde4aaea8119e1c09ffa453de48560dd57"
      ],
      "author": {
        "name": "David Crawshaw",
        "email": "david@zentus.com",
        "time": "Sat Jun 14 19:58:32 2025 +0000"
      },
      "committer": {
        "name": "David Crawshaw",
        "email": "david@zentus.com",
        "time": "Sat Jun 14 16:20:07 2025 -0700"
      },
      "message": "webui: implement multi-file diff view with continuous scrolling\n\nReplace file selector with GitHub PR-style continuous scrolling through\nmultiple files in a single view, improving diff navigation experience\nwhile maintaining all Monaco editor features.\n\nProblem Analysis:\nThe existing diff view required users to navigate between files using a\ndropdown selector and Previous/Next buttons. This created friction when\nreviewing multi-file changes and broke the natural scrolling flow that\nusers expect from GitHub PR views or other modern diff interfaces.\n\nThe limitation was that Monaco doesn\u0027t provide a built-in multi-file diff\nwidget, requiring custom implementation with multiple IStandaloneDiffEditor\ninstances properly configured for stacking and auto-sizing.\n\nImplementation Changes:\n\n1. Multi-File Layout (sketch-diff2-view.ts):\n   - Replaced sketch-diff-file-picker with simple file count display\n   - Implemented renderFileDiff() to create separate diff sections per file\n   - Added renderFileHeader() with status badges and path information\n   - Created multi-file-diff-container with vertical stacking layout\n   - Added loadAllFileContents() for parallel content loading\n   - Replaced single originalCode/modifiedCode with Map\u003cstring, FileContent\u003e\n\n2. Monaco Auto-Sizing (sketch-monaco-view.ts):\n   - Configured diff editors with hidden scrollbars per Monaco ≥0.49 pattern\n   - Added setupAutoSizing() with content height calculation\n   - Implemented fitEditorToContent() using getContentHeight() callbacks\n   - Set automaticLayout: false for manual size control\n   - Added scrollbar: { vertical: \u0027hidden\u0027, horizontal: \u0027hidden\u0027, handleMouseWheel: false }\n   - Enabled minimap: false and scrollBeyondLastLine: false\n\n3. CSS Styling (sketch-diff2-view.ts):\n   - Added file-diff-section with bottom borders for visual separation\n   - Implemented sticky file headers with proper z-index\n   - Created status badges (added, modified, deleted, renamed) with color coding\n   - Added file-count display replacing old file picker interface\n   - Configured diff-container with overflow: auto for outer scrolling\n\n4. Content Management:\n   - Parallel loading of all file contents with error handling\n   - Maintains editability detection per file based on commit range\n   - Preserves comment and save functionality for individual files\n   - Updated toggleHideUnchangedRegions to apply to all editors\n\nTechnical Details:\n- Uses Monaco\u0027s getContentHeight() and onDidContentSizeChange() for auto-sizing\n- Each diff editor sized to Math.max(originalHeight, modifiedHeight) + 18px padding\n- Outer container handles all scrolling while inner editors are sized to content\n- File headers show status (Added/Modified/Deleted/Renamed) with appropriate styling\n- Sticky positioning keeps file context visible during scrolling\n- Maintains all existing features: editing, commenting, expand/collapse toggles\n\nBenefits:\n- Natural scrolling workflow similar to GitHub PR reviews\n- Eliminates need for dropdown navigation between files\n- Better visual context with file headers and status indicators\n- Continuous viewing experience for multi-file changes\n- Preserves all advanced Monaco features (editing, commenting, etc.)\n- Improved performance with parallel content loading\n\nTesting:\n- Verified multi-file diff display with various commit ranges\n- Tested scrolling behavior between files works smoothly\n- Confirmed auto-sizing works correctly for different file sizes\n- Validated file headers show correct status and change counts\n- Ensured editing and commenting functionality preserved\n- Tested expand/collapse toggles apply to all editors\n\nThis implementation follows the Monaco ≥0.49 multi-file diff pattern with\ndisabled inner scrollbars, auto-sizing to content, and outer scroll container,\nproviding a modern diff experience while maintaining full editor functionality.\n\nCo-Authored-By: sketch \u003chello@sketch.dev\u003e\nChange-ID: s0724a00944669c80k\n"
    },
    {
      "commit": "e89b3080f934a4bc70a0cfa85ffff49ac78d6f2b",
      "tree": "f3bcf44b2907c5c18f555b31df923488bb5efdc7",
      "parents": [
        "7ad1c7a4b759f4ba110d092a0fbbed0b95fc80a9"
      ],
      "author": {
        "name": "Philip Zeyliger",
        "email": "philip@bold.dev",
        "time": "Thu May 29 03:16:06 2025 +0000"
      },
      "committer": {
        "name": "Autoformatter",
        "email": "bot@sketch.dev",
        "time": "Thu May 29 03:20:15 2025 +0000"
      },
      "message": "webui: comprehensive diff view improvements\n\nImplement multiple enhancements to the diff view interface for better\nusability and visual consistency with file change statistics and\nimproved navigation controls.\n\nBackend Changes:\n1. Enhanced git diff endpoint with --numstat support:\n   - Modified GitRawDiff to execute both --raw and --numstat commands\n   - Added Additions/Deletions fields to DiffFile struct\n   - Parse numstat output to show line change statistics (+X, -Y)\n   - Handle binary files and edge cases properly\n\nFrontend UI Improvements:\n2. File picker enhancements:\n   - Display (+X, -Y) change indicators next to file names\n   - Move file position indicator (\"X of Y\") between navigation buttons\n   - Simplified file info to show only status (Modified/Added/Deleted)\n   - Better visual grouping of navigation-related information\n\n3. Commit range picker refresh functionality:\n   - Added refresh button with subtle styling (gray background)\n   - 🔄 icon with \"Refresh commit list\" tooltip\n   - Reloads git log to get updated branch and commit information\n   - Proper disabled state during loading operations\n\n4. Editable file indicator improvements:\n   - Moved \"Editable\" indicator to Monaco editor save indicator area\n   - Shows \"Editable\" when file is editable but unchanged\n   - Consistent styling with \"Modified\", \"Saving\", \"Saved\" states\n   - Added proper CSS styling with gray background for idle state\n\n5. Expand/collapse button redesign:\n   - Custom SVG icons replacing text buttons\n   - Expand All: dotted line with arrows pointing away (outward)\n   - Collapse: dotted line with arrows pointing inward (toward line)\n   - Intuitive visual metaphor for show/hide functionality\n   - Enhanced tooltips with full action descriptions\n   - Renamed \"Hide Unchanged\" to \"Collapse Expanded Lines\"\n\nTechnical Improvements:\n6. TypeScript compatibility fixes:\n   - Updated mock data service with new DiffFile fields\n   - Fixed MSW handler type compatibility with proper type assertion\n   - Maintained full TypeScript checking without exclusions\n   - Added realistic mock data for testing change indicators\n\nInterface Consistency:\n- All buttons use consistent styling and hover effects\n- Better separation between navigation controls and file information\n- Improved logical grouping of related UI elements\n- Enhanced accessibility with descriptive tooltips\n\nThese changes significantly improve the diff view experience by providing\nclear visual indicators of file changes, intuitive navigation controls,\nand better organization of interface elements according to their function.\n\nCo-Authored-By: sketch \u003chello@sketch.dev\u003e\n\nChange-ID: s738289d132773bc3k\n"
    },
    {
      "commit": "217e987e1c8d16907849e1f8ba7e5dd8ad4af052",
      "tree": "65e06a1dedfccabd81e28a9585adce6d210a38ea",
      "parents": [
        "f178755c781c74ef242762ceb2c707c9a4dd2676"
      ],
      "author": {
        "name": "Josh Bleecher Snyder",
        "email": "josharian@gmail.com",
        "time": "Wed May 28 09:26:05 2025 -0700"
      },
      "committer": {
        "name": "Josh Bleecher Snyder",
        "email": "josharian@gmail.com",
        "time": "Wed May 28 10:36:09 2025 -0700"
      },
      "message": "Revert \"webui: fix diff view failing when added file doesn\u0027t exist in working directory\"\n\nThis reverts commit 4c7865b4763552f4294e7a3738b796ea918a7c3d.\n\nThe real problem appears to be a race of some kind.\nThis is not the fix.\n"
    },
    {
      "commit": "4c7865b4763552f4294e7a3738b796ea918a7c3d",
      "tree": "7e26038aaf5393a2df9d5b945a6840555e7a661d",
      "parents": [
        "ed17fdf0b3ea6c0b8a8f96125ccc785c5587bb9c"
      ],
      "author": {
        "name": "Josh Bleecher Snyder",
        "email": "josharian@gmail.com",
        "time": "Fri May 23 17:26:34 2025 +0000"
      },
      "committer": {
        "name": "Josh Bleecher Snyder",
        "email": "josharian@gmail.com",
        "time": "Fri May 23 13:51:38 2025 -0700"
      },
      "message": "webui: fix diff view failing when added file doesn\u0027t exist in working directory\n\nWhen viewing uncommitted changes in the diff view and there\u0027s a file that\nwas added in the latest commit but doesn\u0027t exist in the current working\ndirectory, the code was trying to fetch the working copy content and\nfailing with \u0027Failed to fetch working copy content\u0027.\n\nThis adds fallback logic for added files (status \u0027A\u0027) to use the\ncommitted content from git when the working copy cannot be retrieved,\nsimilar to how deleted files are already handled.\n\nThe fix changes the error handling in loadFileContent() to:\n- Check if file status is \u0027A\u0027 (added) and has a new_hash\n- Fall back to using gitService.getFileContent(file.new_hash) instead\n  of failing completely\n- Log a warning but continue gracefully\n\nThis ensures the diff view works correctly when showing ranges ending\nin \u0027uncommitted changes\u0027 even with files that were added but later\nremoved from the working directory.\n\nCo-Authored-By: sketch \u003chello@sketch.dev\u003e\nChange-ID: s73a6d30e7af97e82k\n"
    },
    {
      "commit": "8c4636270be67625cc27ce356f6da1a11e245069",
      "tree": "f6a4db58f1eb71033410150daa7290d4e41aca0a",
      "parents": [
        "5e3570280bf3bb0f84482ff9556739d34eb08093"
      ],
      "author": {
        "name": "Autoformatter",
        "email": "bot@sketch.dev",
        "time": "Fri May 16 21:54:17 2025 +0000"
      },
      "committer": {
        "name": "Autoformatter",
        "email": "bot@sketch.dev",
        "time": "Fri May 16 21:54:17 2025 +0000"
      },
      "message": "all: fix formatting\n"
    },
    {
      "commit": "272a90ee1a74bda5618d4866e03f4b7067947784",
      "tree": "9baf4f84ce80b1c7073a95b6959f6dd11ab3b48b",
      "parents": [
        "d3ac112a45111abf0e57c327d55e2cc66a136abb"
      ],
      "author": {
        "name": "Philip Zeyliger",
        "email": "philip@bold.dev",
        "time": "Fri May 16 14:49:51 2025 -0700"
      },
      "committer": {
        "name": "Philip Zeyliger",
        "email": "philip@bold.dev",
        "time": "Fri May 16 14:51:40 2025 -0700"
      },
      "message": "Add Monaco diff-view, the saga ...\n\nI set out to use Monaco to support the diff view. diff2html is lovely,\nbut there were a ton of usability improvements I wanted to make (line\nnumbers not making things double spaced, choosing which diff, editing\nthe right-hand side), and it seemed a dead end. Furthermore, Phabricator\nand Gerrit\u0027s experience is that diffs should be shown file by file,\nbecause you\u0027ll inevitably see a diff with a file that\u0027s too large, and\nthe GitHub PR view often breaks on big changes... so I wanted to show\nfiles diff-by-diff, with \"infinite\" context when unchanged sections are\nexpanded. So...\n\nUltimately, all of this was sketch-coded over maybe 30 Sketch sessions.\nI threw away a lot of branches. My git reflog is a superfund site.\n\nPrompting whole-hog didn\u0027t work. Or, rather, it made significant\nprogress, but something very serious wouldn\u0027t work, and I couldn\u0027t\nfigure out what, and nor could Sketch.\n\nInstead, I started by adding a new webcomponent that was just a\nplaceholder. Then, using https://rodydavis.com/posts/lit-monaco-editor,\nI nudged Sketch into adding Monaco to it. Sketch pulled out:\n\n   You\u0027re right, I should properly read the blog post before implementing the\n   solution. Let me check the referenced blog post.\n\nI worked heavily in the demo environment at first, but here I ran into\nthe issue that we have two different esbuild systems: one is vite and\none is esbuild.go, and they\u0027re configured differently enough.\n\nMonaco is unusable and confusingly so when its CSS isn\u0027t loaded. The right\nway to load it, I\u0027ve found, is via\n\n  @import url(\u0027./static/monaco/min/vs/editor/editor.main.css\u0027);\n\nI spent more time than I care to admit noticing that originally\nthis wasn\u0027t relative, and when we use a skaband setting, the\npaths need to be relative-aware.\n\nThe paths to the various workers need to be similarly correctly placed.\n\nGetting Sketch to build demo data but not put testing code into production\ncode was tricky. (I threw away a lot of efforts and factories and singletons...)\n\nWhen I set out to do the git commit selection, I wanted to do a bunch of\nbackend /git/* handlers. These were easy enough to code in sketch. I had\nto convince Sketch to put them in git_tools.go and not in the agent.\nIt doesn\u0027t really matter: these functions to parse git are pretty stateless,\nbut it\u0027s less work to have them separate. Sketch was mediocre at writing\ntests for them. Did you know that our container has an older version\nof git that doesn\u0027t have the same options to decorate ref names? Yeah, nor did\nI.\n\nHandling unstaged changes was fun. git diff --raw shows unstaged files\nas having identity 0000. Ideally we\u0027d be using jj and there\u0027d be\na synthetic commit, but instead uncommitted-possible files are read\nby content.\n\nA real big challenge was getting the Monaco view to use the right vertical and\nhorizontal space. I did this many, many times. I don\u0027t claim to understand flex\nand the virtual dom, and :host, and all the interactions. It would fix one\nthing and break another. The chat window would shrink. The terminal would\nshrink.\n\nScreenshot support was excellent. I eventually added paste support just so\nthat I could expedite my workflow, and Sketch coded that easily on the first\npass with minor feedback.\n\nI learned the hard way that Safari\u0027s support for WebComponents/shadow\ndom in its web inspector is rough. See https://fediverse.zachleat.com/@zachleat/114518629612122858\n\nI also learned the hard way that Chrome doesn\u0027t use fonts loaded in CSS\nin a shadow dom. That\u0027s why the codicon font had to be in the global\nstyle sheet.\n\nKudos to John Reese who kindly allowed me, a long time ago, to adapt a\nshell script he had at work to look over diffs into https://github.com/philz/git-vimdiff.\nThat\u0027s the inspiration for having the \"new code\" be editable when you\u0027re\nreviewing it; why shouldn\u0027t it be!?!\n\nThere are a handful of follow up tasks:\n\n* We lose state when we switch to the Chat view and back.\n* Need URL-based support for where we are.\n* Maybe need shortcut keys to move between diffs and changes.\n* Maybe need caching or look-ahead for downloading the next or previous\n  file.\n* We spend too much vertical real estate on all the diff selections;\n  could we scroll it out of the way, collapse it, tighten it, etc.\n* The workers sometimes throw errors into the console. I think they\u0027re\n  harmless and merely need to be caught and suppressed.\n* Needing to commit changes when things are saved is weird. Should we\n  commit automatically? Amend the previous commit? Have a button for\n  that? Show the git dirty state?\n* Our JS bundle is big. We could maybe delay loading the monaco bundle\n  to help.\n\nThanks for coming to my TED talk.\n"
    }
  ]
}