)]}' { "log": [ { "commit": "d4eea221b455e06fe7f897d1e04a8833015e893c", "tree": "c5dd56fd56611f5e1c930e9930e1449d8ade7cc6", "parents": [ "fe51d1d1b1f205ce2a417d312991e71d31ce6dc3" ], "author": { "name": "Philip Zeyliger", "email": "philip@bold.dev", "time": "Mon Jun 16 21:13:21 2025 -0700" }, "committer": { "name": "Philip Zeyliger", "email": "philip@bold.dev", "time": "Mon Jun 16 21:22:20 2025 -0700" }, "message": "Fix vet_error baseline?\n\nNo, I don\u0027t know how this crawled up.\n" }, { "commit": "fe51d1d1b1f205ce2a417d312991e71d31ce6dc3", "tree": "e45895b2546f9b0a54d6bbd7a635e47f821f36bb", "parents": [ "64f60461b00c474b0b4747a06177d5c7a357bba9" ], "author": { "name": "Philip Zeyliger", "email": "philip@bold.dev", "time": "Mon Jun 16 21:19:44 2025 -0700" }, "committer": { "name": "Philip Zeyliger", "email": "philip@bold.dev", "time": "Mon Jun 16 21:22:20 2025 -0700" }, "message": "Further loosen browser timeouts.\n" }, { "commit": "64f60461b00c474b0b4747a06177d5c7a357bba9", "tree": "cfeceff998a165af451099c0ec23b5d2b0fd42f2", "parents": [ "db8caa0eb8576b8c0d65cc0b7b6aa4e241a7cdb1" ], "author": { "name": "Philip Zeyliger", "email": "philip@bold.dev", "time": "Mon Jun 16 13:57:10 2025 -0700" }, "committer": { "name": "Autoformatter", "email": "bot@sketch.dev", "time": "Mon Jun 16 20:58:24 2025 +0000" }, "message": "loop: add diff stats from sketch-base to HEAD in /state endpoint\n\nAdd lines added/removed statistics computed from sketch-base to current HEAD,\ndisplayed in webui Diff mode button for quick change overview.\n\nCo-Authored-By: sketch \u003chello@sketch.dev\u003e\nChange-ID: s3f10ecf39df6b581k\n" }, { "commit": "db8caa0eb8576b8c0d65cc0b7b6aa4e241a7cdb1", "tree": "463538f0e72ca286642fb5ec0e26e2a6b53c4260", "parents": [ "95594bbd48412ca9621d18389badaf97e675f1f6" ], "author": { "name": "philip.zeyliger", "email": "philip.zeyliger@gmail.com", "time": "Mon Jun 16 15:37:24 2025 +0000" }, "committer": { "name": "Philip Zeyliger", "email": "philip@bold.dev", "time": "Mon Jun 16 08:58:42 2025 -0700" }, "message": "dockerimg: remove noisy debug log for missing tunnel removal\n\nCo-Authored-By: sketch \u003chello@sketch.dev\u003e\nChange-ID: s26e4ed4983c89781k\n" }, { "commit": "95594bbd48412ca9621d18389badaf97e675f1f6", "tree": "5a35a0e805e70098b1f76f935afa49c81c998c27", "parents": [ "7380a36bedf69c931ad03d69c67f23d9ccb7bf15" ], "author": { "name": "Philip Zeyliger", "email": "philip@bold.dev", "time": "Mon Jun 16 08:57:21 2025 -0700" }, "committer": { "name": "Philip Zeyliger", "email": "philip@bold.dev", "time": "Mon Jun 16 08:57:21 2025 -0700" }, "message": "bin/sk-ls: add number of messages\n" }, { "commit": "7380a36bedf69c931ad03d69c67f23d9ccb7bf15", "tree": "9c82c631958c729eb1f470ea8c023c39e4484867", "parents": [ "021231a933867854ad46ab6202ca4fd5bf50a8fd" ], "author": { "name": "Philip Zeyliger", "email": "philip@bold.dev", "time": "Mon Jun 16 08:27:44 2025 -0700" }, "committer": { "name": "Philip Zeyliger", "email": "philip@bold.dev", "time": "Mon Jun 16 08:27:44 2025 -0700" }, "message": "s/title/slug in bin/sk-ls\n" }, { "commit": "021231a933867854ad46ab6202ca4fd5bf50a8fd", "tree": "41f110e3aeeba8dc25483eea69e5138417039682", "parents": [ "2f8464cc1f0f25ec209ec5f710f6794a36700a5b" ], "author": { "name": "Sean McCullough", "email": "banksean@gmail.com", "time": "Thu Jun 12 09:35:24 2025 -0700" }, "committer": { "name": "Autoformatter", "email": "bot@sketch.dev", "time": "Mon Jun 16 04:52:33 2025 +0000" }, "message": "add /dist/messages-viewer.js bundle output\n" }, { "commit": "2f8464cc1f0f25ec209ec5f710f6794a36700a5b", "tree": "94a96915ba9a6f22dd031f0a77c99a06d8a090d7", "parents": [ "29c481c8d3bbe6124d3b273d2a154081d8472f08" ], "author": { "name": "Autoformatter", "email": "bot@sketch.dev", "time": "Mon Jun 16 04:27:05 2025 +0000" }, "committer": { "name": "Autoformatter", "email": "bot@sketch.dev", "time": "Mon Jun 16 04:27:05 2025 +0000" }, "message": "all: fix formatting\n" }, { "commit": "29c481c8d3bbe6124d3b273d2a154081d8472f08", "tree": "616a5f8097fa56da5e315ef2e2948fc049851a01", "parents": [ "c0a4459e3f5c8e68649bb45f2c309f6f01928ab7" ], "author": { "name": "Philip Zeyliger", "email": "philip@bold.dev", "time": "Sun Jun 15 21:25:45 2025 -0700" }, "committer": { "name": "Philip Zeyliger", "email": "philip@bold.dev", "time": "Sun Jun 15 21:25:45 2025 -0700" }, "message": "browser tests: further increasing timeouts\n" }, { "commit": "c0a4459e3f5c8e68649bb45f2c309f6f01928ab7", "tree": "3e239adc18145cac2f8cd920b7c6c63bf0a4def1", "parents": [ "38499cc1970fadc688567ec10ea92bfca187b929" ], "author": { "name": "philip.zeyliger", "email": "philip.zeyliger@gmail.com", "time": "Sun Jun 15 21:24:57 2025 -0700" }, "committer": { "name": "Philip Zeyliger", "email": "philip@bold.dev", "time": "Sun Jun 15 21:24:57 2025 -0700" }, "message": "webui: implement Monaco code splitting with external bundle loading\n\nSplit Monaco editor into separate bundle with content-based hashing, achieving\n99% size reduction in Monaco components (3.9MB to 42KB).\n\n- Enable minification in esbuild configuration\n- Create standalone Monaco bundle with content hash for optimal caching\n- Implement external Monaco loading with proper TypeScript types\n- Apply external Monaco to all TypeScript bundles for consistency\n\nBundle results:\n- sketch-monaco-view.js: 3.9MB → 42KB (99% reduction)\n- sketch-app-shell.js: 6.8MB → 3.0MB (Monaco external, still large due to mermaid/cytoscape/katex)\n- monaco-standalone-{hash}.js: 3.8MB cached separately\n\nApp shell remains large (3MB) due to mermaid dependencies - likely next optimization target.\n\nCo-Authored-By: sketch \u003chello@sketch.dev\u003e\nChange-ID: sc84907cb0ec24197k\n" }, { "commit": "38499cc1970fadc688567ec10ea92bfca187b929", "tree": "fcfdced525ed5818887872ffdab7666989bb6d95", "parents": [ "8a290e5a3df2ec7ba8de8ffbf52081e44b2d636f" ], "author": { "name": "Philip Zeyliger", "email": "philip@bold.dev", "time": "Sun Jun 15 21:17:05 2025 -0700" }, "committer": { "name": "Autoformatter", "email": "bot@sketch.dev", "time": "Mon Jun 16 04:17:53 2025 +0000" }, "message": "webui: restructure diff header layout for improved usability\n\nReorganize diff view header to show commits section always expanded on left\nand move file selector to right side, with expand/collapse button in header\nwhen single file is selected.\n\nCo-Authored-By: sketch \u003chello@sketch.dev\u003e\nChange-ID: s904ee76a60c89e75k\n" }, { "commit": "8a290e5a3df2ec7ba8de8ffbf52081e44b2d636f", "tree": "024a481c416e5ea04b0ca63427b6c1344d2d8f2c", "parents": [ "851d2bf4f9324b294c58bb5a79398269c2587a0d" ], "author": { "name": "Philip Zeyliger", "email": "philip@bold.dev", "time": "Sun Jun 15 20:59:58 2025 -0700" }, "committer": { "name": "Philip Zeyliger", "email": "philip@bold.dev", "time": "Sun Jun 15 21:05:25 2025 -0700" }, "message": "Run workflows on bigger machine.\n" }, { "commit": "851d2bf4f9324b294c58bb5a79398269c2587a0d", "tree": "eed22a219e4a53c9935c2dcebc5d5223b668b2e2", "parents": [ "6255411d3c2bd8cfe9a25c261e1c9a28e549441c" ], "author": { "name": "philip.zeyliger", "email": "philip.zeyliger@gmail.com", "time": "Mon Jun 16 03:10:10 2025 +0000" }, "committer": { "name": "Autoformatter", "email": "bot@sketch.dev", "time": "Mon Jun 16 03:42:24 2025 +0000" }, "message": "webui: add tool calls display to mobile chat timeline\n\nCo-Authored-By: sketch \u003chello@sketch.dev\u003e\nChange-ID: s654197301b832e70k\n" }, { "commit": "6255411d3c2bd8cfe9a25c261e1c9a28e549441c", "tree": "063eb2f7ec0793176b9b3528d7279d6c42fedc53", "parents": [ "5c6d82996aab8c390e43ee6d2b3f81f7f26de629" ], "author": { "name": "Autoformatter", "email": "bot@sketch.dev", "time": "Sun Jun 15 19:23:33 2025 +0000" }, "committer": { "name": "Autoformatter", "email": "bot@sketch.dev", "time": "Sun Jun 15 19:23:33 2025 +0000" }, "message": "all: fix formatting\n" }, { "commit": "5c6d82996aab8c390e43ee6d2b3f81f7f26de629", "tree": "769af94e9c5b73db806df2b019fed0fba1bcea7f", "parents": [ "4cd0129069c668cdd72f4d5b941e8d328c5d3caf" ], "author": { "name": "David Crawshaw", "email": "david@zentus.com", "time": "Sun Jun 15 19:09:19 2025 +0000" }, "committer": { "name": "David Crawshaw", "email": "david@zentus.com", "time": "Sun Jun 15 12:23:00 2025 -0700" }, "message": "webui: invert diff view layout and improve file selector behavior\n\nCo-Authored-By: sketch \u003chello@sketch.dev\u003e\nChange-ID: s5b7c42b431634f10k\n" }, { "commit": "4cd0129069c668cdd72f4d5b941e8d328c5d3caf", "tree": "c0b4d3101ed8d7f5a3ddd797451ff6b4dba3e560", "parents": [ "216d2fc77e55ca2e435f4d3d50a7a3a055b3545e" ], "author": { "name": "David Crawshaw", "email": "david@zentus.com", "time": "Sun Jun 15 18:59:13 2025 +0000" }, "committer": { "name": "David Crawshaw", "email": "david@zentus.com", "time": "Sun Jun 15 12:20:59 2025 -0700" }, "message": "webui: bring back the old per-file diff view as an option\n\nCo-Authored-By: sketch \u003chello@sketch.dev\u003e\nChange-ID: s46e7d05cb0615b8fk\n" }, { "commit": "216d2fc77e55ca2e435f4d3d50a7a3a055b3545e", "tree": "1425cab92b3c209221b9e1f8cb2de2620f658827", "parents": [ "d4be7a2d950cbc637e324210ce2e9904b736b701" ], "author": { "name": "David Crawshaw", "email": "david@zentus.com", "time": "Sun Jun 15 18:45:53 2025 +0000" }, "committer": { "name": "David Crawshaw", "email": "david@zentus.com", "time": "Sun Jun 15 12:20:57 2025 -0700" }, "message": "webui: clean up diff view interface by removing unused features\n\nRemove refresh button, file count display, single commit mode, and hide\ncommit range controls behind collapsible Commits dropdown to streamline\nthe diff view interface.\n\nThis streamlined interface focuses attention on the actual diff content while\nkeeping advanced controls easily accessible through progressive disclosure,\ncreating a cleaner and more professional diff viewing experience.\n\nCo-Authored-By: sketch \u003chello@sketch.dev\u003e\nChange-ID: se64b0db10984cba9k\n" }, { "commit": "d4be7a2d950cbc637e324210ce2e9904b736b701", "tree": "73d26c5c89be4ca8bcfc229bf0d3c52a8b76b5de", "parents": [ "dba26b57dbdf09c006a84314b2b919e8256d0089" ], "author": { "name": "Philip Zeyliger", "email": "philip@bold.dev", "time": "Sun Jun 15 09:39:00 2025 -0700" }, "committer": { "name": "Autoformatter", "email": "bot@sketch.dev", "time": "Sun Jun 15 16:40:32 2025 +0000" }, "message": "feat: add subtrace-token flag for development tracing\n\nAdd internal --subtrace-token flag to enable running sketch under\nsubtrace.dev for development purposes. Run with --skaband-addr\u003d for max\nhappiness.\n\nSubtrace manages to trace both incoming and outgoing traffic (e.g., to\nAnthropic), so it can be used.\n\nBeware that using this may leak your anthropic keys to subtrace.dev.\n\nCo-Authored-By: sketch \u003chello@sketch.dev\u003e\nChange-ID: s3521ac3b805c857fk\n" }, { "commit": "dba26b57dbdf09c006a84314b2b919e8256d0089", "tree": "c792f5452fe9a84abeaa0b6c421cf9c586fe8fcd", "parents": [ "ad15b6cc1ec990e139cbd0d462df301179a46f5e" ], "author": { "name": "David Crawshaw", "email": "david@zentus.com", "time": "Sun Jun 15 00:33:45 2025 +0000" }, "committer": { "name": "David Crawshaw", "email": "david@zentus.com", "time": "Sat Jun 14 17:57:26 2025 -0700" }, "message": "webui: fix Monaco editor horizontal scrollbar from border width overflow\n\nCo-Authored-By: sketch \u003chello@sketch.dev\u003e\nChange-ID: s555d4a157e574e32k\n" }, { "commit": "ad15b6cc1ec990e139cbd0d462df301179a46f5e", "tree": "7d45f57934a1ade6f21833d536219bcb847d1398", "parents": [ "f00c7b19133ee3e2d60bfb4eef117c0870c0bbc0" ], "author": { "name": "Autoformatter", "email": "bot@sketch.dev", "time": "Sun Jun 15 00:29:26 2025 +0000" }, "committer": { "name": "Autoformatter", "email": "bot@sketch.dev", "time": "Sun Jun 15 00:29:26 2025 +0000" }, "message": "all: fix formatting\n" }, { "commit": "f00c7b19133ee3e2d60bfb4eef117c0870c0bbc0", "tree": "acf2ac1953209027628f60c99fd4b41faec2de5f", "parents": [ "e2954ce9c186576151b5e0da05de1b37bb99afea" ], "author": { "name": "David Crawshaw", "email": "david@zentus.com", "time": "Sun Jun 15 00:24:46 2025 +0000" }, "committer": { "name": "David Crawshaw", "email": "david@zentus.com", "time": "Sat Jun 14 17:27:04 2025 -0700" }, "message": "webui: disable Monaco diff editor overview ruler\n\nRemove the overview ruler from Monaco diff editor by adding renderOverviewRuler: false\nto the editor configuration, providing a cleaner diff viewing experience.\n\nCo-Authored-By: sketch \u003chello@sketch.dev\u003e\nChange-ID: sc99558fc19a79a66k\n" }, { "commit": "e2954ce9c186576151b5e0da05de1b37bb99afea", "tree": "ef54edfec55171ff3faf8428e0f0e274b49e1ea5", "parents": [ "dbca8975c4616c02f284359fed07d4a2c1477301" ], "author": { "name": "David Crawshaw", "email": "david@zentus.com", "time": "Sun Jun 15 00:06:34 2025 +0000" }, "committer": { "name": "David Crawshaw", "email": "david@zentus.com", "time": "Sat Jun 14 17:12:58 2025 -0700" }, "message": "webui: fix diff view scrollbar visibility and resize handling\n\nFix Monaco editor scrollbar display issues and improve browser window resize\nresponsiveness in the diff view, providing a cleaner interface and better\nuser experience across different screen sizes.\n\nProblem Analysis:\nThe diff view had two significant issues affecting usability:\n\n1. Monaco Scrollbar Visibility: Despite setting scrollbar configuration to\n \u0027hidden\u0027, a large gray scrollbar remained visible on the right side of\n the Monaco diff editor. This was caused by insufficient CSS targeting\n of Monaco\u0027s complex DOM structure and scrollbar element hierarchy.\n\n2. Resize Handling: The diff view did not properly adapt when users resized\n their browser window. While the editor had automaticLayout: false and\n manual sizing, there was no window resize listener to trigger layout\n recalculation, causing the editor to maintain its original dimensions.\n\n3. Refresh Button Layout: At certain screen widths, the refresh button would\n wrap to its own line prematurely due to inflexible sizing constraints.\n\nImplementation Changes:\n\n1. Monaco Scrollbar Removal (sketch-diff2-view.ts):\n - Added comprehensive global CSS rules targeting all Monaco scrollbar elements\n - Targeted .monaco-editor, .monaco-diff-editor, and .monaco-scrollable-element\n - Applied multiple hiding techniques: display: none, visibility: hidden,\n width/height: 0, opacity: 0 for maximum coverage\n - Added padding/margin removal to prevent scrollbar space reservation\n - Ensured diff content takes full width without scrollbar spacing\n\n2. Window Resize Handler (sketch-monaco-view.ts):\n - Added setupWindowResizeHandler() method with debounced resize logic\n - Implemented 100ms debounce to prevent excessive layout calls\n - Added window \u0027resize\u0027 event listener that triggers fitEditorToContent()\n - Fallback layout call with current container dimensions if fit function unavailable\n - Proper cleanup in disconnectedCallback() to prevent memory leaks\n\n3. Layout Improvements (sketch-diff2-view.ts):\n - Set minimum width (400px) for sketch-diff-range-picker component\n - Added minimum width (120px) for file-count display\n - Ensured flex layout provides adequate space for all controls\n - Improved responsive behavior at various screen widths\n\n4. Enhanced Scrollbar Configuration (sketch-monaco-view.ts):\n - Extended scrollbar options with additional Monaco-specific settings:\n - useShadows: false to disable scrollbar shadows\n - verticalHasArrows: false / horizontalHasArrows: false to remove arrows\n - verticalScrollbarSize: 0 / horizontalScrollbarSize: 0 for zero track size\n - Combined configuration-based and CSS-based hiding for complete coverage\n\nTechnical Details:\n- Global CSS injection occurs once per diff view instance in constructor\n- Window resize handler uses setTimeout debouncing to avoid performance issues\n- Monaco editor layout() called with explicit dimensions during resize\n- CSS targeting covers all known Monaco scrollbar element patterns\n- Minimum width constraints prevent layout collapse at small screen sizes\n- Cleanup handlers prevent memory leaks when components are destroyed\n\nBenefits:\n- Clean, professional diff view appearance without distracting scrollbars\n- Smooth responsive behavior when browser window is resized\n- Improved layout stability for controls at various screen widths\n- Better user experience across desktop and mobile viewport sizes\n- Maintained full Monaco editor functionality (editing, syntax highlighting, etc.)\n\nTesting:\n- Verified scrollbar completely hidden at all screen sizes\n- Tested resize responsiveness from 600px to 1400px+ widths\n- Confirmed smooth transitions during window resize operations\n- Validated refresh button layout behavior at different breakpoints\n- Ensured Monaco editor features remain fully functional\n- Tested both horizontal and vertical window resize scenarios\n\nThis implementation provides a polished, responsive diff view experience\nthat properly adapts to user browser configurations while maintaining\nall advanced Monaco editor capabilities.\n\nCo-Authored-By: sketch \u003chello@sketch.dev\u003e\nChange-ID: sf19d359b4fcbcbdek\n" }, { "commit": "dbca8975c4616c02f284359fed07d4a2c1477301", "tree": "1752a1f4f1c16441d43f4f9b69e4120927d25bb3", "parents": [ "9abf803eeedd49261dc4e4c5b75dcb4d21cc6a0d" ], "author": { "name": "David Crawshaw", "email": "david@zentus.com", "time": "Sat Jun 14 23:46:58 2025 +0000" }, "committer": { "name": "Autoformatter", "email": "bot@sketch.dev", "time": "Sat Jun 14 23:50:10 2025 +0000" }, "message": "webui: improve diff view header layout and compactness\n\nConsolidate diff view header layout for better space efficiency and improved\nvisual organization of commit range selectors and file count display.\n\nChanges:\n1. Move file count to same line as commit range selectors\n2. Reduce per-file header padding from 12px to 8px\n3. Shorten commit selector entries to prevent overflow\n4. Change file count text from \u0027N files changed\u0027 to \u0027N files\u0027\n5. Prevent file count text from wrapping with white-space: nowrap\n\nLayout improvements create more compact header while maintaining usability.\n\nCo-Authored-By: sketch \u003chello@sketch.dev\u003e\nChange-ID: s54d391a2d5128fd4k\n" }, { "commit": "9abf803eeedd49261dc4e4c5b75dcb4d21cc6a0d", "tree": "abebff284ab5674aeacf125237619c26f998d1cb", "parents": [ "26f3f34c25e21717001f0230d1abe7debbc5e0c0" ], "author": { "name": "Autoformatter", "email": "bot@sketch.dev", "time": "Sat Jun 14 23:24:08 2025 +0000" }, "committer": { "name": "Autoformatter", "email": "bot@sketch.dev", "time": "Sat Jun 14 23:24:08 2025 +0000" }, "message": "all: fix formatting\n" }, { "commit": "26f3f34c25e21717001f0230d1abe7debbc5e0c0", "tree": "0ba518a643b4d165dd871b4a2cd28e5f096a017f", "parents": [ "938d2dcde4aaea8119e1c09ffa453de48560dd57" ], "author": { "name": "David Crawshaw", "email": "david@zentus.com", "time": "Sat Jun 14 19:58:32 2025 +0000" }, "committer": { "name": "David Crawshaw", "email": "david@zentus.com", "time": "Sat Jun 14 16:20:07 2025 -0700" }, "message": "webui: implement multi-file diff view with continuous scrolling\n\nReplace file selector with GitHub PR-style continuous scrolling through\nmultiple files in a single view, improving diff navigation experience\nwhile maintaining all Monaco editor features.\n\nProblem Analysis:\nThe existing diff view required users to navigate between files using a\ndropdown selector and Previous/Next buttons. This created friction when\nreviewing multi-file changes and broke the natural scrolling flow that\nusers expect from GitHub PR views or other modern diff interfaces.\n\nThe limitation was that Monaco doesn\u0027t provide a built-in multi-file diff\nwidget, requiring custom implementation with multiple IStandaloneDiffEditor\ninstances properly configured for stacking and auto-sizing.\n\nImplementation Changes:\n\n1. Multi-File Layout (sketch-diff2-view.ts):\n - Replaced sketch-diff-file-picker with simple file count display\n - Implemented renderFileDiff() to create separate diff sections per file\n - Added renderFileHeader() with status badges and path information\n - Created multi-file-diff-container with vertical stacking layout\n - Added loadAllFileContents() for parallel content loading\n - Replaced single originalCode/modifiedCode with Map\u003cstring, FileContent\u003e\n\n2. Monaco Auto-Sizing (sketch-monaco-view.ts):\n - Configured diff editors with hidden scrollbars per Monaco ≥0.49 pattern\n - Added setupAutoSizing() with content height calculation\n - Implemented fitEditorToContent() using getContentHeight() callbacks\n - Set automaticLayout: false for manual size control\n - Added scrollbar: { vertical: \u0027hidden\u0027, horizontal: \u0027hidden\u0027, handleMouseWheel: false }\n - Enabled minimap: false and scrollBeyondLastLine: false\n\n3. CSS Styling (sketch-diff2-view.ts):\n - Added file-diff-section with bottom borders for visual separation\n - Implemented sticky file headers with proper z-index\n - Created status badges (added, modified, deleted, renamed) with color coding\n - Added file-count display replacing old file picker interface\n - Configured diff-container with overflow: auto for outer scrolling\n\n4. Content Management:\n - Parallel loading of all file contents with error handling\n - Maintains editability detection per file based on commit range\n - Preserves comment and save functionality for individual files\n - Updated toggleHideUnchangedRegions to apply to all editors\n\nTechnical Details:\n- Uses Monaco\u0027s getContentHeight() and onDidContentSizeChange() for auto-sizing\n- Each diff editor sized to Math.max(originalHeight, modifiedHeight) + 18px padding\n- Outer container handles all scrolling while inner editors are sized to content\n- File headers show status (Added/Modified/Deleted/Renamed) with appropriate styling\n- Sticky positioning keeps file context visible during scrolling\n- Maintains all existing features: editing, commenting, expand/collapse toggles\n\nBenefits:\n- Natural scrolling workflow similar to GitHub PR reviews\n- Eliminates need for dropdown navigation between files\n- Better visual context with file headers and status indicators\n- Continuous viewing experience for multi-file changes\n- Preserves all advanced Monaco features (editing, commenting, etc.)\n- Improved performance with parallel content loading\n\nTesting:\n- Verified multi-file diff display with various commit ranges\n- Tested scrolling behavior between files works smoothly\n- Confirmed auto-sizing works correctly for different file sizes\n- Validated file headers show correct status and change counts\n- Ensured editing and commenting functionality preserved\n- Tested expand/collapse toggles apply to all editors\n\nThis implementation follows the Monaco ≥0.49 multi-file diff pattern with\ndisabled inner scrollbars, auto-sizing to content, and outer scroll container,\nproviding a modern diff experience while maintaining full editor functionality.\n\nCo-Authored-By: sketch \u003chello@sketch.dev\u003e\nChange-ID: s0724a00944669c80k\n" }, { "commit": "938d2dcde4aaea8119e1c09ffa453de48560dd57", "tree": "fe917e628d4ce1a671a15d1430668e92983289c4", "parents": [ "7351cd9b711db0e828d22d995fe56c7f9f6ddb07" ], "author": { "name": "David Crawshaw", "email": "david@zentus.com", "time": "Sat Jun 14 22:17:33 2025 +0000" }, "committer": { "name": "David Crawshaw", "email": "david@zentus.com", "time": "Sat Jun 14 16:20:07 2025 -0700" }, "message": "webui: add URL parameters for diff view from/to commit selection\n\nEnable direct linking to specific diff ranges by adding URL parameters that\nsync with the diff range picker controls, allowing users to bookmark and\nshare specific diff views.\n\nProblem Analysis:\nUsers couldn\u0027t link directly to specific diff ranges in the sketch diff view.\nThe from/to commit selectors would reset to defaults on page load, making it\nimpossible to bookmark or share links to specific commit comparisons. This\ncreated friction when collaborating or returning to specific diff views.\n\nImplementation Changes:\n\n1. URL Parameter Synchronization (sketch-diff-range-picker.ts):\n - Added updateUrlParams() to write from/to/commit parameters to URL\n - Integrated URL updates into dispatchRangeEvent() for automatic sync\n - Used history.replaceState() to update URL without page reload\n - Clear unused parameters when switching between range/single modes\n\n2. URL Parameter Initialization:\n - Added initializeFromUrlParams() to read URL parameters on load\n - Parse \u0027from\u0027/\u0027to\u0027 parameters for range mode initialization\n - Parse \u0027commit\u0027 parameter for single commit mode initialization\n - Return flag indicating successful URL-based initialization\n\n3. Load Flow Enhancement:\n - Modified loadCommits() to check URL parameters before setting defaults\n - Skip default commit selection when URL parameters are present\n - Always dispatch range event to ensure diff view updates correctly\n\n4. Browser Navigation Support:\n - Added popstate event listener for browser back/forward navigation\n - Implemented handlePopState() to re-initialize from URL parameters\n - Force component re-render and event dispatch on navigation\n\n5. Mode Switching Improvements:\n - Enhanced setRangeType() with better default handling\n - Auto-populate missing commits when switching between modes\n - Maintain proper URL state during mode transitions\n\nTechnical Details:\n- URL parameters: \u0027from\u0027, \u0027to\u0027 for range mode; \u0027commit\u0027 for single mode\n- Empty \u0027to\u0027 parameter represents uncommitted changes (working directory)\n- Parameters removed from URL when switching to incompatible modes\n- Browser history updated without triggering page reloads\n- Component lifecycle properly manages event listeners\n\nURL Format Examples:\n- Range mode: ?view\u003ddiff2\u0026from\u003dabc123\u0026to\u003ddef456\n- Uncommitted: ?view\u003ddiff2\u0026from\u003dabc123 (no \u0027to\u0027 parameter)\n- Single commit: ?view\u003ddiff2\u0026commit\u003dabc123\n\nBenefits:\n- Direct linking to specific diff ranges via URL\n- Bookmarkable diff views for easy return navigation\n- Shareable links for collaboration and code review\n- Browser back/forward navigation works correctly\n- URL reflects current diff state at all times\n- Seamless integration with existing diff view functionality\n\nTesting:\n- Verified URL updates when changing from/to commit selectors\n- Confirmed URL initialization on page load with parameters\n- Tested browser back/forward navigation updates UI correctly\n- Validated mode switching (range ↔ single) updates URL appropriately\n- Ensured uncommitted changes mode removes \u0027to\u0027 parameter\n- Confirmed sharing URLs loads correct diff view state\n\nThis enhancement enables direct linking and improved navigation for the\nsketch diff view while maintaining all existing functionality and providing\nseamless URL-based state management.\n\nCo-Authored-By: sketch \u003chello@sketch.dev\u003e\nChange-ID: sbf02a6a8bb4db673k\n" }, { "commit": "7351cd9b711db0e828d22d995fe56c7f9f6ddb07", "tree": "2c4014fb50f2ae0ea3c8922d89c4029846da240d", "parents": [ "a35de5f73d31756c8ac972a54bdb370bb26eed5a" ], "author": { "name": "philip.zeyliger", "email": "philip.zeyliger@gmail.com", "time": "Sat Jun 14 12:25:31 2025 -0700" }, "committer": { "name": "Philip Zeyliger", "email": "philip@bold.dev", "time": "Sat Jun 14 12:25:31 2025 -0700" }, "message": "webui: fix Monaco fonts\n\nIn Chrome, if you selectected a line in the diff view, it wouldn\u0027t\nselect the whole line, because Monaco was somehow confused about the\nfont widths or something. Turns out we had customized our fonts. We\ndon\u0027t need to do that!\n\nAlso adding a sketchDebug idea so that it\u0027s easier to poke at things.\n" }, { "commit": "a35de5f73d31756c8ac972a54bdb370bb26eed5a", "tree": "e86111f53c0e701a38510ed8543403f25665a891", "parents": [ "46be0967c78b0e60b18b4b9ff3c642ebc96c7e4d" ], "author": { "name": "Philip Zeyliger", "email": "philip@bold.dev", "time": "Sat Jun 14 12:00:48 2025 -0700" }, "committer": { "name": "Philip Zeyliger", "email": "philip@bold.dev", "time": "Sat Jun 14 12:00:48 2025 -0700" }, "message": "Using GH actions provided Chrome for test speedup (#149)\n\nOMG. This had wild behavior. Sometimes you\u0027d log into tmate, and it\nwould work. Something about running Chrome manually would tickle some\ndbus thing into working. The error would sometimes show up, but most\noften it would be swallowed.\n\nThe punchline? We had a context timeout of 5 or 10 seconds in the tests\nthat would trigger silently, and we\u0027d see nothing. Everything else\n(including maybe the dbus stuff) was a red herring: the test executor\nmachine is swamped, and shit\u0027s slow, and the various timeouts needed\ntweaking. I bet there are a few more timeouts to loosen eventually, but\nit seems to be passing now.\n\nError message:\n\tfailed to start browser (please apt get chromium or equivalent): chrome failed to start:\n" }, { "commit": "46be0967c78b0e60b18b4b9ff3c642ebc96c7e4d", "tree": "35db5a5725a69f5913102fe768c4103dc4188a56", "parents": [ "c013134814facb7da15b59c79399ec1939eb6ef9" ], "author": { "name": "philip.zeyliger", "email": "philip.zeyliger@gmail.com", "time": "Sat Jun 14 17:51:15 2025 +0000" }, "committer": { "name": "Philip Zeyliger", "email": "philip@bold.dev", "time": "Sat Jun 14 11:38:48 2025 -0700" }, "message": "ci: optimize APT package installation by skipping documentation\n\nCo-Authored-By: sketch \u003chello@sketch.dev\u003e\nChange-ID: sf483afee70439c11k\n" }, { "commit": "c013134814facb7da15b59c79399ec1939eb6ef9", "tree": "6072025f9c2e5a87af79a61070fab1f0500c32a5", "parents": [ "c886ac5478194e95f93b166572a7a081eb6cadb8" ], "author": { "name": "Philip Zeyliger", "email": "philip@bold.dev", "time": "Fri Jun 13 21:07:08 2025 -0700" }, "committer": { "name": "Philip Zeyliger", "email": "philip@bold.dev", "time": "Fri Jun 13 21:07:08 2025 -0700" }, "message": "Fail to speed up CI by not installing Chrome.\n\nI have no idea why the same \"vintage\" machine I logged into via tmate\nhas this working, but this doesn\u0027t, but the --no-sandbox thing is\ncorrect regardless.\n\nVariants of the following is what SHOULD work but doesn\u0027t yet.\n\n\tPATH\u003d/usr/local/share/chromium/chrome-linux:$PATH GOEXPERIMENT\u003dsynctest stdbuf -oL -eL go test -v -count\u003d1 -run TestBrowserInitialization ./claudetool/browse/...\n" }, { "commit": "c886ac5478194e95f93b166572a7a081eb6cadb8", "tree": "fd4be26cd6cf20162ff22ef21a8c1dc6e51e59d5", "parents": [ "1bd636c83311a9195fca38515ee254bf07ae0d12" ], "author": { "name": "David Crawshaw", "email": "david@zentus.com", "time": "Fri Jun 13 23:40:03 2025 +0000" }, "committer": { "name": "David Crawshaw", "email": "david@zentus.com", "time": "Sat Jun 14 01:03:45 2025 +0000" }, "message": "loop: add special instruction field\n\nIncludes a demo.\n\nCo-Authored-By: sketch \u003chello@sketch.dev\u003e\nChange-ID: sc7078aeb8c59e49ak\n" }, { "commit": "1bd636c83311a9195fca38515ee254bf07ae0d12", "tree": "e90ca194abe7274efbb520907b641f8fc27d2947", "parents": [ "c7c2cc1e9d2a90515e071527241e0ce680fe0738" ], "author": { "name": "David Crawshaw", "email": "david@zentus.com", "time": "Fri Jun 13 19:56:27 2025 +0000" }, "committer": { "name": "David Crawshaw", "email": "david@zentus.com", "time": "Fri Jun 13 14:18:04 2025 -0700" }, "message": "dockerimg: add seccomp filter to protect PID 1 from kill syscalls\n\nAdd automatic seccomp profile creation and injection to prevent sketch\nprocesses from killing themselves via pkill -f or similar commands that\ntarget PID 1 within Docker containers.\n\nCo-Authored-By: sketch \u003chello@sketch.dev\u003e\nChange-ID: s74e3bcc6e17ec376k\n" }, { "commit": "c7c2cc1e9d2a90515e071527241e0ce680fe0738", "tree": "df1b7548a47fa1e4f219bcd8a27e5fadaa0acc3c", "parents": [ "83c5be6f73607c6add6d5c389f7894e1d7b5e06a" ], "author": { "name": "Sean McCullough", "email": "banksean@gmail.com", "time": "Fri Jun 13 03:21:18 2025 +0000" }, "committer": { "name": "Autoformatter", "email": "bot@sketch.dev", "time": "Fri Jun 13 03:48:18 2025 +0000" }, "message": "webui: fix repository name parsing for names containing dots\n\nFix GitHub repository URL parsing in sketch-container-status component to\nproperly handle repository names containing dots, resolving broken GitHub\nlinks in the ongoing session log banner.\n\nProblem Analysis:\nThe formatGitHubRepo function used regex patterns with [^/\\s.]+ character\nclasses that excluded dots from repository names. This caused repository names\nlike \u0027boldsoftware/sketch.git\u0027 to be truncated to \u0027boldsoftware/sketch\u0027 when\nparsed, breaking GitHub links and repository display in the session banner.\n\nThe issue occurred in three regex patterns for different GitHub URL formats:\n- HTTPS URLs: /https:\\/\\/github\\.com\\/([^/]+)\\/([^/\\s.]+)(?:\\.git)?/\n- SSH URLs: /git@github\\.com:([^/]+)\\/([^/\\s.]+)(?:\\.git)?/\n- Git protocol: /git:\\/\\/github\\.com\\/([^/]+)\\/([^/\\s.]+)(?:\\.git)?/\n\nThe [^/\\s.]+ pattern specifically excluded dots (.) from matching, which was\nproblematic for legitimate repository names containing dots.\n\nImplementation Changes:\n\n1. Regex Pattern Updates:\n - Changed [^/\\s.]+ to [^/\\s]+? in all three URL patterns\n - Removed dot exclusion while maintaining whitespace and slash exclusion\n - Added non-greedy quantifier (?) to prevent over-matching\n - Added end-of-string anchor ($) for precise matching\n\n2. Updated patterns:\n - HTTPS: /https:\\/\\/github\\.com\\/([^/]+)\\/([^/\\s]+?)(?:\\.git)?$/\n - SSH: /git@github\\.com:([^/]+)\\/([^/\\s]+?)(?:\\.git)?$/\n - Git: /git:\\/\\/github\\.com\\/([^/]+)\\/([^/\\s]+?)(?:\\.git)?$/\n\nTechnical Details:\n- Non-greedy matching (+?) ensures proper handling of .git suffix\n- End anchors ($) prevent partial matches and improve precision\n- Dots now allowed in repository names while preserving .git detection\n- Existing functionality preserved for repositories without dots\n\nTesting:\nVerified fix with comprehensive test cases:\n- git@github.com:boldsoftware/sketch.git → boldsoftware/sketch ✓\n- https://github.com/user/repo.with.dots.git → user/repo.with.dots ✓\n- git@github.com:org/project.name.git → org/project.name ✓\n- https://github.com/test/normal-repo → test/normal-repo ✓\n\nBenefits:\n- GitHub links now work correctly for repositories with dots in names\n- Session banner displays proper repository information\n- Maintains backward compatibility with existing repository names\n- Improves user experience for repository navigation\n\nThis fix resolves the specific issue where repository names containing dots\nwould have their GitHub links truncated, breaking navigation to the actual\nrepository on GitHub.\n\nCo-Authored-By: sketch \u003chello@sketch.dev\u003e\nChange-ID: sda0a251af3d756b6k\n\nwebui: improve GitHub repo parsing tests\n\nReplace internal method testing with component behavior testing for better\nintegration coverage and maintainability.\n\n- Test actual GitHub link rendering in DOM instead of calling private methods\n- Add separate test cases for repository names with dots\n- Verify href attributes, text content, and title attributes are correct\n- Cover both general dot-containing names and the specific boldsoftware/sketch case\n\nCo-Authored-By: sketch \u003chello@sketch.dev\u003e\nChange-ID: s216977b6be91a2bak\n" }, { "commit": "83c5be6f73607c6add6d5c389f7894e1d7b5e06a", "tree": "e230051fe8efb82642792d2710b66a50167036c1", "parents": [ "e8da7af81f6414866ec20658c1c2a0ae4fc350bf" ], "author": { "name": "Sean McCullough", "email": "banksean@gmail.com", "time": "Thu Jun 12 15:42:40 2025 -0700" }, "committer": { "name": "Sean McCullough", "email": "banksean@gmail.com", "time": "Thu Jun 12 15:42:40 2025 -0700" }, "message": "cmd/genwebuizip\n" }, { "commit": "e8da7af81f6414866ec20658c1c2a0ae4fc350bf", "tree": "c13fcf9d456f03706ea0470043af85b106a1b0ef", "parents": [ "d2ba10c9e2ea1487262eaefbfbd6493200a9200a" ], "author": { "name": "philip.zeyliger", "email": "philip.zeyliger@gmail.com", "time": "Thu Jun 12 14:24:28 2025 -0700" }, "committer": { "name": "Autoformatter", "email": "bot@sketch.dev", "time": "Thu Jun 12 21:25:28 2025 +0000" }, "message": "fix: correct SSH connection string format for VS Code remote SSH\n\nCo-Authored-By: sketch \u003chello@sketch.dev\u003e\nChange-ID: s43df80ba5e0e7cd3k\n" }, { "commit": "d2ba10c9e2ea1487262eaefbfbd6493200a9200a", "tree": "1288e9a79a0be715bf1afe99b7f6abd4ff33fccd", "parents": [ "1417b69f8aaee33e9e96341e7e97ffbb9e7bb051" ], "author": { "name": "Philip Zeyliger", "email": "philip@bold.dev", "time": "Thu Jun 12 13:51:27 2025 -0700" }, "committer": { "name": "Philip Zeyliger", "email": "philip@bold.dev", "time": "Thu Jun 12 13:51:27 2025 -0700" }, "message": "Speed up formatter workflow.\n" }, { "commit": "1417b69f8aaee33e9e96341e7e97ffbb9e7bb051", "tree": "1568f44bbb31dde125571a7b9a3aa1eabc2d6002", "parents": [ "8773e68fcce9965da3c6a1ef91c88476f84e29bb" ], "author": { "name": "Philip Zeyliger", "email": "philip@bold.dev", "time": "Thu Jun 12 11:07:04 2025 -0700" }, "committer": { "name": "Philip Zeyliger", "email": "philip@bold.dev", "time": "Thu Jun 12 11:07:04 2025 -0700" }, "message": "Fixing git checkout after retrying hooks.\n\nA place where we didn\u0027t update the wip branch thing.\n" }, { "commit": "8773e68fcce9965da3c6a1ef91c88476f84e29bb", "tree": "cb8d586ac3e5a833670c038344509621b61725be", "parents": [ "542bda3968c6dd5b79392dd63e2955e04520401a" ], "author": { "name": "philip.zeyliger", "email": "philip.zeyliger@gmail.com", "time": "Wed Jun 11 21:36:21 2025 -0700" }, "committer": { "name": "Autoformatter", "email": "bot@sketch.dev", "time": "Thu Jun 12 04:37:26 2025 +0000" }, "message": "feat: add ssh-connection-string option for container SSH access\n\nAdd internal -ssh-connection-string flag to pass SSH hostname from dockerimg\nto sketch container, allowing the UI to display the correct SSH connection\nstring based on SSH Theater configuration rather than generating it locally.\n\nCo-Authored-By: sketch \u003chello@sketch.dev\u003e\nChange-ID: s1872f10f74da5f9bk\n" }, { "commit": "542bda3968c6dd5b79392dd63e2955e04520401a", "tree": "ea1a0743849495ca2489c6363d2dc689dd0a56a7", "parents": [ "225e9668aeebc0cae667872dd45222d69ac3cbd8" ], "author": { "name": "Philip Zeyliger", "email": "philip@bold.dev", "time": "Wed Jun 11 18:31:03 2025 -0700" }, "committer": { "name": "Autoformatter", "email": "bot@sketch.dev", "time": "Thu Jun 12 01:31:34 2025 +0000" }, "message": "browser: rename browser_read_image to read_image and auto-send screenshots to LLM\n\nRename browser_read_image tool to read_image and modify browser_take_screenshot\nto automatically send image content to the LLM instead of requiring a separate\nread_image tool call, streamlining the screenshot workflow.\n\nProblem Analysis:\nThe current browser screenshot workflow required two separate tool calls:\n1. browser_take_screenshot - saves screenshot and returns file path\n2. browser_read_image - reads saved screenshot and sends to LLM\n\nThis two-step process was inefficient and created unnecessary round trips.\nAdditionally, browser_read_image was specific to browser automation but\nthe functionality of reading and encoding images is more general purpose.\n\nImplementation Changes:\n\n1. Screenshot Tool Behavior (claudetool/browse/browse.go):\n - Modified browser_take_screenshot to automatically return image content\n - Removed screenshotOutput struct as ID-only response no longer needed\n - Added base64 encoding of screenshot data directly in screenshotRun\n - Returns []llm.Content with both text description and image data\n - Still saves screenshot file for potential future reference\n - Uses same image encoding format as existing read_image tool\n\n2. Tool Rename (claudetool/browse/browse.go):\n - Renamed browser_read_image tool to read_image\n - Updated tool name in NewReadImageTool from \u0027browser_read_image\u0027 to \u0027read_image\u0027\n - Maintained all existing functionality and input/output format\n - Tool description and schema remain unchanged\n\n3. UI Updates (termui/termui.go):\n - Updated template condition from \u0027browser_read_image\u0027 to \u0027read_image\u0027\n - Maintains existing emoji and display format for read_image tool calls\n\n4. WebUI Updates (webui/src/web-components/):\n - Updated sketch-tool-calls.ts to reference \u0027read_image\u0027 instead of \u0027browser_read_image\u0027\n - Renamed sketch-tool-card-browser-read-image.ts to sketch-tool-card-read-image.ts\n - Updated component class name from SketchToolCardBrowserReadImage to SketchToolCardReadImage\n - Updated custom element name from \u0027sketch-tool-card-browser-read-image\u0027 to \u0027sketch-tool-card-read-image\u0027\n - Updated import statement to reference new component file name\n - Removed old component file and updated TypeScript declarations\n\n5. Test Updates (claudetool/browse/browse_test.go):\n - Modified TestGetTools to allow read_image tool without \u0027browser_\u0027 prefix\n - Added special case handling for read_image in tool naming convention check\n - All existing tests continue to pass with updated tool name\n\nTechnical Details:\n- Screenshot auto-send uses same base64 encoding as existing read_image tool\n- Content structure matches browser_read_image output format for consistency\n- File saving still occurs for potential debugging or future reference\n- Error handling preserves existing behavior with proper fallbacks\n- Tool count remains the same (12 tools with screenshots, 10 without)\n\nBenefits:\n- Eliminates need for two-step screenshot workflow\n- Reduces round trips and simplifies user experience\n- More intuitive tool naming (read_image is general purpose)\n- Maintains full backward compatibility for read_image functionality\n- Consistent image encoding across all browser tools\n- Automatic screenshot viewing improves debugging and validation workflows\n\nTesting:\n- All existing browser tool tests pass with updated expectations\n- TestReadImageTool verifies renamed tool functionality\n- Tool naming convention test updated to handle read_image exception\n- TypeScript compilation successful with no type errors\n- Web component functionality preserved across rename\n\nThis enhancement streamlines screenshot workflows while maintaining the\ngeneral-purpose read_image tool for reading arbitrary image files, creating\na more efficient and intuitive browser automation experience.\n\nCo-Authored-By: sketch \u003chello@sketch.dev\u003e\nChange-ID: se3e81f997f30f01ek\n" }, { "commit": "225e9668aeebc0cae667872dd45222d69ac3cbd8", "tree": "5ed3bd693b61ba13c6609d8afefb343cf919abb8", "parents": [ "6d3de48ec0ec2fb8f194a11f1711b7128b7d1699" ], "author": { "name": "philip.zeyliger", "email": "philip.zeyliger@gmail.com", "time": "Tue Jun 10 23:05:06 2025 +0000" }, "committer": { "name": "Philip Zeyliger", "email": "philip@bold.dev", "time": "Wed Jun 11 12:14:50 2025 -0700" }, "message": "webui: remove deprecated @types/dompurify dependency\n\nRemove @types/dompurify package dependency since modern dompurify includes\nbuilt-in TypeScript definitions, eliminating the npm deprecation warning.\n\nProblem Analysis:\nnpm install was showing deprecation warning:\n\u0027@types/dompurify@3.2.0: This is a stub types definition. dompurify provides\nits own type definitions, so you do not need this installed.\u0027\n\nThe webui package.json included both dompurify@^3.2.6 and @types/dompurify@^3.2.0\nas dependencies. Modern versions of dompurify (3.x+) ship with their own\nTypeScript definitions built-in, making the separate @types package redundant\nand deprecated. This created unnecessary dependency bloat and triggered warnings\nduring npm install operations.\n\nImplementation Changes:\n\n1. Package Dependency Cleanup:\n - Removed \u0027@types/dompurify\u0027: \u0027^3.2.0\u0027 from webui/package.json dependencies\n - Preserved dompurify@^3.2.6 which provides both runtime code and TypeScript types\n - No code changes required since imports remain identical\n\n2. TypeScript Compatibility:\n - Verified existing DOMPurify imports continue working with built-in types\n - Confirmed TypeScript compilation passes without @types/dompurify\n - No changes needed to mobile-chat.ts, sketch-tool-card.ts, or sketch-timeline-message.ts\n\nTechnical Details:\n- dompurify 3.x series includes index.d.ts with complete TypeScript definitions\n- Import syntax \u0027import DOMPurify from \"dompurify\"\u0027 unchanged and fully typed\n- npm install completes cleanly without deprecation warnings\n- TypeScript check (tsc --noEmit) passes successfully with built-in types\n\nBenefits:\n- Eliminates npm deprecation warning during install operations\n- Reduces dependency count and package.json complexity\n- Uses official TypeScript definitions from dompurify maintainers\n- Maintains identical functionality and type safety\n- Cleaner dependency tree without redundant type packages\n\nTesting:\n- npm install runs successfully without warnings\n- TypeScript compilation (npm run check) passes without errors\n- All DOMPurify usage in web components maintains full type safety\n- Build process completes successfully with built-in type definitions\n\nThis cleanup removes technical debt and follows best practices for modern\nTypeScript package management by using built-in type definitions rather\nthan deprecated stub packages.\n\nCo-Authored-By: sketch \u003chello@sketch.dev\u003e\nChange-ID: sf9e195a31b2adb28k\n\nwebui: update package-lock.json after removing @types/dompurify\n\nUpdate package-lock.json to reflect removal of deprecated @types/dompurify\ndependency, completing the cleanup of redundant type definitions.\n\nCo-Authored-By: sketch \u003chello@sketch.dev\u003e\nChange-ID: s0cdb73feadefc7b1k\n" }, { "commit": "6d3de48ec0ec2fb8f194a11f1711b7128b7d1699", "tree": "14325a290001d13a482c116c83ee0b87aa7e36c5", "parents": [ "a1762b94e6ddf5db0a0f6b7a5104fa236855320b" ], "author": { "name": "philip.zeyliger", "email": "philip.zeyliger@gmail.com", "time": "Tue Jun 10 19:38:14 2025 -0700" }, "committer": { "name": "Philip Zeyliger", "email": "philip@bold.dev", "time": "Tue Jun 10 19:40:16 2025 -0700" }, "message": "feat: add -link-to-github flag with Octocat icon for GitHub branch linking\n\nAdd internal flag to enable GitHub branch linking in both termui and webui\ninterfaces, displaying clickable Octocat icons next to copy icons for pushed\nbranches when working with GitHub repositories.\n\nProblem Analysis:\nWhen sketch pushes branches to GitHub repositories, users had no direct way to\nnavigate from the sketch interface to view those branches on GitHub. Branch\nnames were displayed as plain text in both terminal and web interfaces,\nrequiring users to manually construct GitHub URLs or switch to external tools\nto view their pushed changes on the GitHub platform.\n\nThis created friction in the workflow, especially for teams collaborating on\nGitHub where quick access to branch views, pull request creation, and code\nreview processes are essential parts of the development workflow.\n\nImplementation Changes:\n\n1. Command Line Flag Infrastructure:\n - Added linkToGitHub bool field to CLIFlags struct\n - Configured -link-to-github as internal flag with false default\n - Integrated flag passing through ContainerConfig and AgentConfig chains\n - Added flag to dockerimg launch command arguments for container mode\n\n2. Agent Interface Enhancement:\n - Added LinkToGitHub() method to CodingAgent interface\n - Implemented method in Agent struct returning config.LinkToGitHub\n - Extended State struct with link_to_github JSON field (with omitempty)\n - Updated getState() function to include agent\u0027s GitHub linking preference\n - Updated mockAgent in tests to support new LinkToGitHub() method\n\n3. Terminal UI GitHub Integration:\n - Added isGitHubRepo() method with regex pattern matching for GitHub URLs\n - Implemented getGitHubBranchURL() for constructing GitHub branch links\n - Enhanced commit message display to show GitHub URLs when flag enabled\n - Updated exit summary to include GitHub links for single and multiple branches\n - Added regex import for GitHub URL pattern validation\n\n4. Web UI TypeScript Integration:\n - Added link_to_github field to State interface in types.ts\n - Enhanced formatGitHubRepo() method to return owner/repo extraction\n - Implemented getGitHubBranchLink() helper in container status component\n - Created parallel helper methods in timeline message component\n\n5. Container Status Component Updates:\n - Added commit-info-container with flexbox layout for proper alignment\n - Implemented layout: Branch Text → Copy Icon → Octocat Icon\n - Added 16px clipboard copy icon with opacity states (70% default, 100% on hover)\n - Integrated 16px Octocat SVG icon as clickable GitHub link\n - Maintained existing copyCommitInfo click functionality for branch text\n\n6. Timeline Message Component Enhancement:\n - Added commit-branch-container for consistent layout structure\n - Implemented same layout pattern: Branch Text → Copy Icon → Octocat Icon\n - Added 14px clipboard and Octocat icons matching timeline scale\n - Enhanced CSS with hover states and proper alignment\n - Preserved existing copyToClipboard functionality for branch text clicks\n\n7. Data Flow Integration:\n - Updated sketch-timeline component to pass state to message components\n - Modified sketch-app-shell to provide containerState to timeline\n - Ensured proper state propagation through component hierarchy\n - Maintained backward compatibility with existing state management\n\nTechnical Details:\n- GitHub URL detection supports HTTPS, SSH, and git protocol formats\n- Regex patterns: ^https://github\\.com/, ^git@github\\.com:, ^git://github\\.com/\n- Link format: https://github.com/{owner}/{repo}/tree/{branch-name}\n- Internal flag prevents exposure in user-visible help documentation\n- SVG Octocat uses official GitHub icon design with 16-point grid\n- Copy icons use standard clipboard SVG with overlapping rectangles design\n- Event propagation properly stopped to prevent interference with copy actions\n- Conditional rendering ensures icons only appear when GitHub links available\n- Flexbox layout ensures proper alignment across different screen sizes\n- CSS transitions provide smooth hover state animations\n\nBenefits:\n- Direct navigation from sketch UI to GitHub branch views\n- Seamless integration with GitHub-based development workflows\n- Enhanced productivity for teams using GitHub collaboration features\n- Clear functional separation: text copy vs external GitHub link\n- Familiar clipboard icon reinforces copy functionality\n- Improved visual hierarchy guides user interaction patterns\n- Maintains existing copy-to-clipboard functionality as fallback\n- Zero impact on non-GitHub repositories or when flag disabled\n- Consistent experience across terminal and web interfaces\n- Enhanced accessibility with distinct click targets and hover states\n\nTesting:\n- Verified flag parsing and configuration propagation through all layers\n- Confirmed GitHub URL detection works with various GitHub URL formats\n- Tested conditional rendering in both web UI components\n- Validated CSS styling and hover effects for GitHub branch links\n- Ensured backward compatibility with non-GitHub repositories\n- Verified TypeScript compilation with new template structures\n- Confirmed proper icon positioning and spacing in test layouts\n- Validated hover states and opacity transitions function correctly\n- All Go tests and TypeScript compilation successful\n\nThis enhancement bridges the gap between sketch\u0027s development environment and\nGitHub\u0027s collaboration platform, enabling more efficient workflows for teams\nusing GitHub repositories while preserving full functionality for other Git\nhosting solutions. The visual design provides intuitive flow from local\noperations (copy) to external actions (GitHub), creating a more organized\nand user-friendly interface for branch management workflows.\n\nCo-Authored-By: sketch \u003chello@sketch.dev\u003e\nChange-ID: s1c083b45b5401c2bk\n" }, { "commit": "a1762b94e6ddf5db0a0f6b7a5104fa236855320b", "tree": "7ec924eef43f400a9975e7ac1fb0b02fc7ae9de1", "parents": [ "57d28bc892e9ec4d842593d6cdd944b6afba532e" ], "author": { "name": "Sean McCullough", "email": "banksean@gmail.com", "time": "Tue Jun 10 22:04:15 2025 +0000" }, "committer": { "name": "Sean McCullough", "email": "banksean@gmail.com", "time": "Tue Jun 10 16:11:54 2025 -0700" }, "message": "cmd/sketch: add -dump-dist internal flag to extract embedded filesystem\n\nAdd internal CLI flag to dump embedded /dist/ filesystem contents to\na specified directory for debugging and development purposes.\n\nProblem Analysis:\nDevelopers and debugging scenarios sometimes need access to the built\nembedded filesystem contents that are generated by webui.Build(). The\nembedded filesystem is created dynamically and cached, making it difficult\nto inspect or extract its contents for analysis, debugging, or external\nuse without complex workarounds.\n\nImplementation Changes:\n\n1. CLI Flag Addition:\n - Added -dump-dist string flag as internal/debugging option\n - Positioned in internal flags section alongside other developer tools\n - Flag accepts filesystem path as parameter for output directory\n - Implements early exit pattern after processing like -version and -list-models\n\n2. Filesystem Extraction Function:\n - Created dumpDistFilesystem() function with comprehensive error handling\n - Uses webui.Build() to generate the embedded filesystem\n - Implements fs.WalkDir pattern for complete directory tree traversal\n - Handles both files and directories with appropriate permissions (0o755 for dirs, default for files)\n\n3. File Copy Implementation:\n - Uses io.Copy for efficient file content transfer\n - Proper resource cleanup with defer statements for file handles\n - Preserves directory structure and file hierarchy\n - Creates output directory tree as needed with os.MkdirAll\n\n4. Error Handling and User Feedback:\n - Comprehensive error messages for each failure point\n - Clear success message showing output directory path\n - Proper exit handling - program terminates after successful dump\n - Validates output directory creation before proceeding\n\nTechnical Details:\n- Leverages existing webui.Build() infrastructure for filesystem generation\n- Added required imports: io, io/fs for filesystem operations\n- Uses filepath.Join for cross-platform path handling\n- Implements early exit pattern consistent with other informational flags\n- Positioned as internal flag visible only with -help-internal\n\nBenefits:\n- Enables inspection of generated webui assets for debugging\n- Supports development workflows requiring filesystem analysis\n- Provides clean extraction mechanism without modifying build process\n- Useful for troubleshooting webui bundle generation issues\n- Maintains separation as internal-only feature\n\nTesting:\n- Verified successful filesystem dump with proper directory structure\n- Tested error handling with invalid output paths\n- Confirmed program exits correctly after dump completion\n- Validated flag appears in -help-internal output\n- Tested with various output directory scenarios including existing/new paths\n\nThis addition provides essential debugging capability for webui filesystem\ninspection while maintaining clean separation as an internal development tool.\n\nCo-Authored-By: sketch \u003chello@sketch.dev\u003e\nChange-ID: s5fee523a25bc33dak\n" }, { "commit": "57d28bc892e9ec4d842593d6cdd944b6afba532e", "tree": "1f96828c72ed462c616ba611d6ac68f245fbd047", "parents": [ "8bc681bceec47e9f0150defd4bf7df879e1dede4" ], "author": { "name": "Philip Zeyliger", "email": "philip@bold.dev", "time": "Fri Jun 06 20:28:34 2025 +0000" }, "committer": { "name": "Philip Zeyliger", "email": "philip@bold.dev", "time": "Tue Jun 10 15:28:36 2025 -0700" }, "message": "webui: fix white text visibility in pre-compaction message view\n\nAdd explicit dark text color (#333) to pre-compaction message styling to\nensure readability against the striped background pattern.\n\nProblem Analysis:\nPre-compaction messages in the conversation timeline displayed white-on-white\ntext, making content completely invisible to users. The .pre-compaction CSS\nclass applied a white/light-gray striped background but didn\u0027t override the\ninherited text color, resulting in poor contrast and unreadable content.\n\nImplementation Changes:\n- Added color: #333 to .pre-compaction .message-content selector\n- Added color: #333 to .pre-compaction .message-text selector\n- Ensures dark text is explicitly set for all pre-compaction message content\n- Maintains existing diagonal stripe background pattern and opacity\n\nTechnical Details:\n- Text color inheritance was causing white text against white background\n- Dark gray (#333) provides sufficient contrast against stripe pattern\n- Preserves all existing pre-compaction styling except text color\n- No impact on normal message styling or other component functionality\n\nBenefits:\n- Pre-compaction messages are now fully readable\n- Maintains visual distinction with diagonal stripe pattern\n- Consistent text contrast across all message types\n- Preserves existing design aesthetic while fixing usability issue\n\nTesting:\n- Created standalone HTML test demonstrating fix effectiveness\n- Verified text visibility in various pre-compaction message scenarios\n- Confirmed no regression in normal message display styling\n- Validated contrast meets readability standards\n\nCo-Authored-By: sketch \u003chello@sketch.dev\u003e\nChange-ID: scc5ddb83f1e04940k\n" }, { "commit": "8bc681bceec47e9f0150defd4bf7df879e1dede4", "tree": "3676987151352442281db156efe22f89249a47ab", "parents": [ "0d09284f0319105ee548b78881f6076c45212740" ], "author": { "name": "Philip Zeyliger", "email": "philip@bold.dev", "time": "Tue Jun 10 02:03:02 2025 +0000" }, "committer": { "name": "Autoformatter", "email": "bot@sketch.dev", "time": "Tue Jun 10 02:18:41 2025 +0000" }, "message": "webui: fix mobile UI displaying subconversations\n\nFix mobile UI incorrectly showing subconversations (messages with parent_conversation_id)\nthat should be hidden like in the regular UI to maintain consistent behavior across\nall interfaces.\n\nProblem Analysis:\nThe mobile UI was displaying all messages including subconversations, while the regular\ndesktop UI correctly filters out messages with hide_output\u003dtrue. This created an\ninconsistent user experience where subconversations (used for internal agent processing)\nwere visible in the mobile interface but hidden in the desktop interface.\n\nSubconversations are marked with hide_output\u003dtrue based on conversation.Hidden when\nthe message\u0027s conversation has a parent conversation. These are internal processing\nmessages that shouldn\u0027t be shown to users in either interface.\n\nImplementation Changes:\n\n1. Mobile Chat Filtering Enhancement:\n - Modified shouldShowMessage() method in mobile-chat.ts\n - Added hide_output check at start of filtering logic\n - Returns false immediately for any message with hide_output\u003dtrue\n - Mirrors the filtering logic used in sketch-timeline.ts (.filter((msg) \u003d\u003e !msg.hide_output))\n\n2. Consistent Filtering Logic:\n - Mobile UI now matches regular UI filtering behavior\n - Preserves existing content and type filtering for visible messages\n - Maintains all other message display logic unchanged\n - Uses same pattern as desktop: early return false for hidden messages\n\nTechnical Details:\n- hide_output field is set based on conversation.Hidden in AgentMessage.SetConvo()\n- Subconversations have parent_conversation_id and are marked as hidden\n- Regular UI filters with messages.filter((msg) \u003d\u003e !msg.hide_output)\n- Mobile UI now filters with if (message.hide_output) { return false; }\n- No changes needed to aggregateAgentMessages as filtering happens at display level\n\nBenefits:\n- Consistent user experience across desktop and mobile interfaces\n- Proper hiding of internal agent processing messages\n- Clean mobile chat interface without subconversation clutter\n- Maintains all existing mobile UI functionality for visible messages\n\nTesting:\n- TypeScript compilation passes without errors\n- Filtering logic matches pattern used successfully in desktop UI\n- Mobile chat component is only message rendering location in mobile UI\n- Change isolated to display filtering without affecting message aggregation\n\nThis fix ensures mobile users see the same clean conversation view as desktop\nusers, with internal agent subconversations properly hidden from the interface.\n\nCo-Authored-By: sketch \u003chello@sketch.dev\u003e\nChange-ID: s40a49bd924bde7e2k\n" }, { "commit": "0d09284f0319105ee548b78881f6076c45212740", "tree": "285d7162c2791d3e0a102d109275ce5b2f5ae0db", "parents": [ "4168263109e4f5dfa9b24d3ce66594d90c6cf66a" ], "author": { "name": "Philip Zeyliger", "email": "philip@bold.dev", "time": "Mon Jun 09 18:57:12 2025 -0700" }, "committer": { "name": "Autoformatter", "email": "bot@sketch.dev", "time": "Tue Jun 10 01:58:44 2025 +0000" }, "message": "webui: fix HTML escaping in markdown code blocks\n\nThe mermaid stuff didn\u0027t hook up the right code block rendering,\nor so I think. I don\u0027t love how the cut and paste stuff works,\nbut not changing that now.\n\nCo-Authored-By: sketch \u003chello@sketch.dev\u003e\nChange-ID: s3b56d06b8ee8a15ak\n" }, { "commit": "4168263109e4f5dfa9b24d3ce66594d90c6cf66a", "tree": "7a359884219f736a0da706f098d277d6713d8fad", "parents": [ "209ea91bc220b945936250f8aecd9d69974e0ada" ], "author": { "name": "philip.zeyliger", "email": "philip.zeyliger@gmail.com", "time": "Mon Jun 09 22:23:25 2025 +0000" }, "committer": { "name": "Autoformatter", "email": "bot@sketch.dev", "time": "Mon Jun 09 22:24:32 2025 +0000" }, "message": "webui: fix mobile error message styling to display in red\n\nAdd proper red styling for error messages in mobile chat interface to match\ndesktop behavior and fix GitHub issue #141.\n\nProblem Analysis:\nMobile error messages lacked visual distinction from regular messages, appearing\nwith the same gray background as assistant messages. The desktop interface\nproperly displays error messages with red background (#ffebee) and red text\n(#d32f2f), but the mobile-chat component was missing this styling, creating\ninconsistent user experience across interfaces.\n\nThe mobile chat component correctly filtered error messages (type: \u0027error\u0027)\nand displayed them, but the getMessageRole() method didn\u0027t handle error types,\ndefaulting them to \u0027assistant\u0027 styling.\n\nImplementation Changes:\n\n1. CSS Error Message Styling:\n - Added .message.error .message-bubble styles with red theme\n - Background: #ffebee (light red background matching desktop)\n - Text color: #d32f2f (dark red text for readability)\n - Border-radius: 18px (uniform rounding for clean appearance)\n - Maintains mobile-optimized layout and touch-friendly design\n\n2. Message Role Classification:\n - Enhanced getMessageRole() method to properly handle error message types\n - Added explicit \u0027error\u0027 case returning \u0027error\u0027 class name\n - Ensures error messages receive proper CSS class assignment\n\n3. Test Coverage:\n - Added comprehensive mobile-chat component tests\n - Specific test for error message red styling verification\n - CSS color validation using computed styles\n - Message filtering and rendering tests for all message types\n\nTechnical Details:\n- Styling follows existing mobile component patterns with touch-friendly design\n- Color scheme matches desktop timeline-message component for consistency\n- Error messages maintain left alignment like other system messages\n- Clean, uniformly rounded corners without extra borders for polished appearance\n\nBenefits:\n- Visual consistency between desktop and mobile error message presentation\n- Clear error message identification for mobile users\n- Improved accessibility with distinct error styling\n- Maintains touch-friendly mobile design principles\n- Clean, professional appearance without visual clutter\n- Resolves GitHub issue #141 mobile error visibility\n\nTesting:\n- Added mobile-chat.test.ts with error message styling verification\n- TypeScript compilation successful with no type errors\n- Build process completes without warnings\n- CSS computed style validation confirms red color application\n\nThis fix ensures error messages are visually distinctive on mobile devices,\nproviding users with clear feedback when errors occur while maintaining\nthe clean, touch-optimized mobile interface design.\n\nCo-Authored-By: sketch \u003chello@sketch.dev\u003e\nChange-ID: s8b70f2efae56458ck\n" }, { "commit": "209ea91bc220b945936250f8aecd9d69974e0ada", "tree": "e0b83da2543678561379e523c95c79f221361c3c", "parents": [ "4c1cea85b222a1ec94890be8960c69f549870454" ], "author": { "name": "Philip Zeyliger", "email": "philip@bold.dev", "time": "Mon Jun 09 21:54:12 2025 +0000" }, "committer": { "name": "Autoformatter", "email": "bot@sketch.dev", "time": "Mon Jun 09 21:58:59 2025 +0000" }, "message": "test: fix unicode filename testdata causing Go module packaging issues\n\nReplace static unicode testdata files with dynamic file creation to avoid Go\nmodule zip creation errors while preserving comprehensive unicode filename\ntesting functionality.\n\nProblem Analysis:\nUnicode characters in testdata filenames (🚀rocket.md, café.js, 测试文件.go,\nрусский.py, Übung.html, Makefile-日本語, readme-español.md, claude.한국어.md)\nwere causing go get failures when creating module zip files. The error\n\u0027malformed file path \"claudetool/onstart/testdata/🚀rocket.md\": invalid char \u0027🚀\u0027\u0027\nprevented users from downloading the sketch.dev module using go get.\n\nThe existing tests verified that AnalyzeCodebase could handle unicode filenames\ncorrectly, which is important functionality for international users. However,\nthe static testdata approach was incompatible with Go module packaging.\n\nImplementation Changes:\n\n1. Test File Modification:\n - Modified TestAnalyzeCodebase Non-ASCII Filenames test to use t.TempDir()\n - Added dynamic creation of unicode test files at runtime instead of static testdata\n - Created temporary git repository with proper unicode configuration\n - Added comprehensive git setup with core.quotepath\u003dfalse and core.precomposeunicode\u003dtrue\n\n2. Dynamic File Creation:\n - Implemented map[string]string for test files with unicode filenames as keys\n - Files include same content as original testdata but created dynamically\n - Added proper subdirectory creation for subdir/claude.한국어.md test case\n - Git repository initialization and file addition handled programmatically\n\n3. Git Configuration:\n - Added proper git config setup for unicode filename handling\n - Set user.name and user.email for temporary test repositories\n - Configured core.quotepath\u003dfalse to handle unicode paths correctly\n - Used \u0027git add .\u0027 to add all files at once avoiding individual unicode filename issues\n\n4. Static File Removal:\n - Removed all 8 problematic unicode testdata files\n - Deleted empty testdata directory structure\n - Cleaned up repository to eliminate unicode filenames from git history\n\n5. Test Preservation:\n - Maintained identical test coverage for unicode filename functionality\n - Preserved all categorization tests (build files, documentation, guidance)\n - Kept extension counting verification for unicode files\n - Added proper imports (os/exec, path/filepath) for dynamic file creation\n\nTechnical Details:\n- Uses Go\u0027s testing.T.TempDir() for isolated test environments\n- Temporary git repositories prevent unicode files from entering main repository\n- Same unicode characters tested: Chinese (测试), Korean (한국어), Russian (русский),\n French (café), German (Übung), Japanese (日本語), and emoji (🚀)\n- File categorization still validates Makefile detection, README recognition, and claude.md guidance\n- Error handling for git commands ensures test failures provide clear diagnostics\n\nBenefits:\n- Resolves Go module packaging issues allowing successful go get operations\n- Maintains comprehensive unicode filename testing without repository pollution\n- Dynamic approach is more robust and doesn\u0027t require static test file maintenance\n- Tests run in isolation with proper cleanup via t.TempDir()\n- Preserves international user support validation while fixing distribution issues\n\nTesting:\n- All tests pass with dynamic file creation approach\n- Unicode filename categorization works identically to static file approach\n- Extension counting and file analysis functionality preserved\n- Git operations handle unicode filenames correctly in test environment\n\nCo-Authored-By: sketch \u003chello@sketch.dev\u003e\nChange-ID: s31257070090e907dk\n" }, { "commit": "4c1cea85b222a1ec94890be8960c69f549870454", "tree": "fd605725458f4a3b010292b927368963aeb3fcdd", "parents": [ "0113be559976cfb1ce0e78a9a69c19a6394b2c3d" ], "author": { "name": "Philip Zeyliger", "email": "philip@bold.dev", "time": "Mon Jun 09 14:16:52 2025 -0700" }, "committer": { "name": "Philip Zeyliger", "email": "philip@bold.dev", "time": "Mon Jun 09 14:16:52 2025 -0700" }, "message": "Fix up sketch-wip handling when --commit is not specified.\n\nIf -git-remote-url and -commit are both specified, we check out\nsketch-wip. We should do so always when we\u0027re in a container, so\ndoing that now.\n\nThe new sketch-wip stuff is weird if we\u0027re not in a container (the\n\"unsafe\" mode without -outside-hostname). I\u0027ve changed the system\nprompt slightly to try to figure that out.\n" }, { "commit": "0113be559976cfb1ce0e78a9a69c19a6394b2c3d", "tree": "103ea687419bd792471f057727d2f174428b4215", "parents": [ "8ad17ba9f185be76a4e715d9f21868b0cf27b366" ], "author": { "name": "Philip Zeyliger", "email": "philip@bold.dev", "time": "Sat Jun 07 23:53:41 2025 +0000" }, "committer": { "name": "Autoformatter", "email": "bot@sketch.dev", "time": "Mon Jun 09 19:47:55 2025 +0000" }, "message": "webui: add skaband navigation link with image to desktop and mobile\n\nAdd conditional linking functionality to make the \u0027sketch\u0027 title in both desktop\nand mobile web UI clickable when a skaband address is configured, displaying\nthe sketch.dev.png image alongside the text for enhanced branding and navigation\nback to the skaband dashboard.\n\nProblem Analysis:\nWhen users access sketch through skaband (the hosted service), they lose easy\nnavigation back to their skaband dashboard since the sketch title in the header\nwas always static text. This created a disconnected experience between the\nskaband interface and individual sketch sessions, and lacked visual branding\nconsistency with the hosted service. The feature needed to work in both\ncontainer mode and unsafe mode deployments.\n\nImplementation Changes:\n\n1. Backend Infrastructure:\n - Added SkabandAddr() method to CodingAgent interface for state management\n - Enhanced State struct with skaband_addr field (with omitempty for clean JSON)\n - Modified getState() function to include agent\u0027s skaband address in responses\n - Updated mockAgent in tests to support new SkabandAddr() method\n\n2. SkabandClient Integration:\n - Added Addr() method to SkabandClient to expose stored skaband server address\n - Updated Agent.SkabandAddr() to get address from existing SkabandClient\n - Leverages existing skaband infrastructure used for session history tools\n - No duplicate storage or additional configuration required\n\n3. TypeScript Type Updates:\n - Regenerated webui/src/types.ts to include skaband_addr field in State interface\n - Maintained backward compatibility with existing state structure\n - Auto-generated types ensure type safety across Go/TypeScript boundary\n\n4. Desktop Web UI Enhancement:\n - Modified sketch-app-shell.ts to conditionally render sketch title as link\n - Added conditional logic: renders link with image when skaband_addr exists\n - Uses target\u003d\u0027_blank\u0027 and rel\u003d\u0027noopener noreferrer\u0027 for secure external linking\n - Displays skaband_addr/sketch.dev.png image alongside \u0027sketch\u0027 text\n - Maintains existing appearance and behavior when no skaband address configured\n\n5. Mobile Web UI Implementation:\n - Added skabandAddr property to mobile-title component\n - Implemented conditional rendering matching desktop functionality\n - Mobile-optimized CSS with appropriate image sizing (18px vs 20px desktop)\n - Integrated with existing mobile-shell state management infrastructure\n\n6. CSS Styling Integration:\n - Added .banner-title a styles for seamless link appearance with flexbox layout\n - Configured color: inherit to match existing title styling\n - Added hover effects with opacity transition and underline for user feedback\n - Image styling with rounded corners and appropriate dimensions\n - Mobile-responsive design with media queries for different screen sizes\n\n7. Test Coverage:\n - Updated test infrastructure to support new SkabandAddr() method\n - Comprehensive testing of state endpoint with and without skaband address\n - Verified omitempty behavior for clean JSON responses\n - All existing tests continue passing without modification\n\nTechnical Details:\n- Uses omitempty JSON tag to exclude empty skaband addresses from API responses\n- Leverages existing containerState property in web components for state access\n- Maintains full backward compatibility with non-skaband sketch deployments\n- Clean separation between configuration, state management, and presentation layers\n- Flexbox layout for proper image and text alignment in banner links\n\nSecurity Considerations:\n- External links use target\u003d\u0027_blank\u0027 with rel\u003d\u0027noopener noreferrer\u0027\n- No user input validation needed since skaband_addr comes from server configuration\n- Link destination controlled by deployment configuration, not user input\n- Image source follows same security model as main skaband address\n\nBenefits:\n- Seamless navigation between sketch sessions and skaband dashboard\n- Enhanced visual branding with sketch.dev.png image display\n- Improved user experience for hosted skaband users across all device types\n- Mobile-optimized responsive design for touch interfaces\n- Zero impact on standalone sketch deployments\n- Uses existing, tested skaband infrastructure without additional complexity\n\nTesting:\n- Verified end-to-end functionality with real sketch.dev skaband server\n- Confirmed web UI displays clickable sketch logo link in desktop and mobile views\n- Tested state endpoint returns correct skaband_addr from SkabandClient\n- Validated responsive design across different screen sizes\n- All Go tests and TypeScript compilation successful\n\nThis enhancement provides intuitive navigation for skaband users while\nmaintaining the existing experience for standalone sketch deployments,\ncreating a more cohesive and visually branded interface across all deployment\nmodes and device types.\n\nCo-Authored-By: sketch \u003chello@sketch.dev\u003e\nChange-ID: sa6158676609fe9f0k\n" }, { "commit": "8ad17ba9f185be76a4e715d9f21868b0cf27b366", "tree": "a9fbd574980919ed4871a529e1a030b7e343687c", "parents": [ "f1e517d64fe4a726552f5d240a1ecb3d418f16b6" ], "author": { "name": "Sean McCullough", "email": "banksean@gmail.com", "time": "Mon Jun 09 00:43:57 2025 +0000" }, "committer": { "name": "Sean McCullough", "email": "banksean@gmail.com", "time": "Sun Jun 08 17:59:07 2025 -0700" }, "message": "dockerimg: improve git config error messages for user guidance\n\nFix for #140\n\nReplace generic git config error messages with helpful instructions when\nuser.email or user.name are not configured in local git settings.\n\nProblem Analysis:\nThe findOrBuildDockerImage function retrieves git user.email and user.name\nto pass as build arguments to Docker builds. When these values are not set,\nthe function returned generic error messages that didn\u0027t clearly indicate\nwhat the user needed to do to resolve the issue.\n\nImplementation Changes:\n- Updated error message for missing user.email to provide specific command\n- Updated error message for missing user.name to provide specific command\n- Both messages now include exact git config commands users need to run\n- Error messages are user-friendly and actionable for quick resolution\n\nTechnical Details:\nThe git config --get commands now return clear error messages:\n- user.email: \"Please run \u0027git config --global user.email \\\"your.email@example.com\\\"\u0027\"\n- user.name: \"Please run \u0027git config --global user.name \\\"Your Name\\\"\u0027\"\n\nBenefits:\n- Users get immediate, actionable guidance when git config is incomplete\n- Reduces support requests and user confusion during Docker image builds\n- Clear instructions help users resolve configuration issues quickly\n- Maintains existing functionality while improving user experience\n\nCo-Authored-By: sketch \u003chello@sketch.dev\u003e\nChange-ID: s39a72147550faa4ak\n" }, { "commit": "f1e517d64fe4a726552f5d240a1ecb3d418f16b6", "tree": "ace5b25920201d79054a8b3f7cc17cf884fae8c5", "parents": [ "de19aca257ab21956f2fba828d9265ef218687da" ], "author": { "name": "Marc-Antoine Ruel", "email": "maruel@gmail.com", "time": "Sun Jun 08 17:30:37 2025 +0000" }, "committer": { "name": "Philip Zeyliger", "email": "philip.zeyliger@gmail.com", "time": "Sun Jun 08 13:08:59 2025 -0700" }, "message": "claudetool/onstart: add comprehensive tests for non-ASCII filename handling\n\nAdd test cases validating AnalyzeCodebase() correctly processes files with\nUnicode characters in filenames, ensuring proper categorization and analysis.\n\nProblem Analysis:\nThe AnalyzeCodebase function uses git ls-files to enumerate repository files\nand categorize them by type. While the implementation should theoretically\nhandle Unicode filenames, there were no existing tests to verify this\nbehavior with international characters, emojis, combining characters, or\nright-to-left scripts.\n\nImplementation Changes:\n\n1. Test Data Creation:\n - Created testdata directory with files containing non-ASCII characters\n - Included Chinese (\\u6d4b\\u8bd5\\u6587\\u4ef6.go), French (café.js), Russian (\\u0440\\u0443\\u0441\\u0441\\u043a\\u0438\\u0439.py)\n - Added emoji (\\ud83d\\ude80rocket.md), German umlauts (\\u00dcbung.html)\n - Included Japanese (Makefile-\\u65e5\\u672c\\u8a9e), Spanish (readme-español.md)\n - Added Korean guidance file (subdir/claude.\\ud55c\\uad6d\\uc5b4.md) in subdirectory\n\n2. Comprehensive Test Cases:\n - TestAnalyzeCodebase validates file counting and extension tracking\n - Verifies proper categorization of build, documentation, and guidance files\n - Tests git ls-files integration with Unicode filenames\n - Confirms extension counting works with non-ASCII characters\n\n3. Edge Case Testing:\n - Added combining characters test (file\\u0301\\u0302.go)\n - Arabic right-to-left script test (\\u0645\\u0631\\u062d\\u0628\\u0627.py)\n - Mixed Unicode with emoji test (test\\u4e2d\\u6587\\ud83d\\ude80.txt)\n - Validates categorizeFile function handles Unicode paths correctly\n\n4. File Categorization Validation:\n - Japanese Makefile correctly identified as build file\n - Spanish README properly categorized as documentation\n - Korean Claude file in subdirectory marked as guidance file\n - Extension counting accurate across all Unicode filenames\n\nTechnical Details:\n- Uses git ls-files -z for null-separated output handling Unicode safely\n- Test files represent major Unicode blocks: CJK, Latin Extended, Cyrillic\n- Proper handling of combining characters and emoji sequences\n- Validates both filename parsing and categorization logic paths\n\nBenefits:\n- Ensures international users can use non-ASCII filenames\n- Validates Unicode safety in codebase analysis pipeline\n- Prevents regressions in Unicode filename handling\n- Comprehensive coverage of real-world filename scenarios\n\nTesting:\n- All tests pass with current implementation\n- Verified git ls-files correctly enumerates Unicode filenames\n- Confirmed extension extraction works with international characters\n- Validated categorization logic handles Unicode paths properly\n\nThis test suite ensures AnalyzeCodebase robustly handles international\ncodebases with diverse filename conventions and character encodings.\n\nCo-Authored-By: sketch \u003chello@sketch.dev\u003e\nChange-ID: s2431e70f6f23ec83k\n" }, { "commit": "de19aca257ab21956f2fba828d9265ef218687da", "tree": "dc32644d65f2fa9b7feb3581da953e0467eb0e45", "parents": [ "c139982287731dfab910389deeba766d73cf1bd4" ], "author": { "name": "Marc-Antoine Ruel", "email": "maruel@gmail.com", "time": "Sun Jun 08 13:20:43 2025 -0400" }, "committer": { "name": "Philip Zeyliger", "email": "philip.zeyliger@gmail.com", "time": "Sun Jun 08 13:08:59 2025 -0700" }, "message": "analyze: use git ls-files -z\n\nThis unblock support for non-ascii characters.\n\nCoded with my bare hands.\n" }, { "commit": "c139982287731dfab910389deeba766d73cf1bd4", "tree": "7ee64dbc9d7545fa46a6edda17d55cbe064f8e42", "parents": [ "f825e69e62896f588496b5b33673de58293a6ba2" ], "author": { "name": "Marc-Antoine Ruel", "email": "maruel@gmail.com", "time": "Sun Jun 08 17:47:50 2025 +0000" }, "committer": { "name": "Philip Zeyliger", "email": "philip.zeyliger@gmail.com", "time": "Sun Jun 08 12:54:24 2025 -0700" }, "message": "github: prevent discord webhook from running on forks\n\nFix Discord notification workflow triggering on forked repositories where\nsecrets are unavailable and notifications are unnecessary for contributors.\n\nProblem Analysis:\nThe Discord webhook workflow was configured to run on all repositories,\nincluding forks, where the DISCORD_WEBHOOK_FOR_COMMITS secret would be\nunavailable. This caused workflow failures and attempted notifications\nfrom forks that serve no purpose for the main project\u0027s Discord channel.\n\nImplementation Changes:\n- Added if: github.event.repository.fork \u003d\u003d false condition to notify-discord job\n- Prevents execution on forked repositories while maintaining functionality on origin\n- Uses GitHub\u0027s built-in repository metadata for reliable fork detection\n\nBenefits:\n- Eliminates workflow failures on forks due to missing secrets\n- Reduces unnecessary workflow runs on contributor forks\n- Maintains proper Discord notifications only for the main repository\n- Clean workflow execution without configuration changes required\n\nThis ensures Discord notifications only occur for the main repository\nwhile preventing errors and resource waste on community forks.\n\nCo-Authored-By: sketch \u003chello@sketch.dev\u003e\nChange-ID: s5a155846902dd30fk\n" }, { "commit": "f825e69e62896f588496b5b33673de58293a6ba2", "tree": "b12c428cd68c71d580132d9998382b8ff414c6f6", "parents": [ "737570847f2c6b0a27266aa00662308f19f4de60" ], "author": { "name": "Autoformatter", "email": "bot@sketch.dev", "time": "Sat Jun 07 04:19:43 2025 +0000" }, "committer": { "name": "Autoformatter", "email": "bot@sketch.dev", "time": "Sat Jun 07 04:19:43 2025 +0000" }, "message": "all: fix formatting\n" }, { "commit": "737570847f2c6b0a27266aa00662308f19f4de60", "tree": "c4bc73898f0d8be2723efd00866f4e53eb279532", "parents": [ "5f778949e023268d0bd39cb7f102952e575e9602" ], "author": { "name": "Philip Zeyliger", "email": "philip@bold.dev", "time": "Sat Jun 07 00:06:27 2025 +0000" }, "committer": { "name": "Philip Zeyliger", "email": "philip@bold.dev", "time": "Sat Jun 07 04:12:57 2025 +0000" }, "message": "webui: add image paste functionality to mobile chat input\n\nAdd comprehensive file paste support to mobile input matching desktop\nfunctionality with upload progress indicators and error handling.\n\nProblem Analysis:\nMobile webui lacked image paste functionality available on desktop,\npreventing users from easily sharing screenshots, images, and files\nvia clipboard paste. This created workflow friction for mobile users\nwho needed to upload images for code assistance, debugging, or\ndocumentation purposes.\n\nImplementation Changes:\n\n1. Clipboard Paste Handler:\n - Added paste event listener for detecting clipboard files\n - Integrated with existing upload infrastructure via fetch API\n - Cursor position preservation for inline file insertion\n - Prevented default paste behavior for file content\n\n2. File Upload Infrastructure:\n - Reused desktop upload patterns with FormData and ./upload endpoint\n - Added loading placeholder with emoji indicator during upload\n - Implemented error handling with user-friendly error messages\n - File path insertion in [bracket] format matching desktop behavior\n\n3. Upload Progress Management:\n - Added upload counter to track multiple concurrent uploads\n - Upload progress indicator with file count display\n - Disabled send button during active uploads to prevent premature sending\n - Visual feedback with hourglass icon and tooltip messages\n\n4. Mobile-Optimized UI:\n - Positioned upload progress indicator above input field\n - Touch-friendly styling with appropriate spacing\n - Responsive design for various mobile screen sizes\n - Integrated seamlessly with existing mobile input styling\n\n5. Lifecycle Management:\n - Proper event listener setup and cleanup\n - Component disconnection cleanup to prevent memory leaks\n - Textarea reference management for event binding\n - Focus restoration after upload completion\n\nTechnical Details:\n- Uses ClipboardEvent.clipboardData.files for file detection\n- FormData upload with POST to ./upload endpoint matching desktop\n- Upload state management with progress counter and visual indicators\n- Cursor position tracking via selectionStart for inline insertion\n- Error handling with try/catch and user feedback\n\nBenefits:\n- Consistent file upload experience across desktop and mobile\n- Improved mobile workflow for image sharing and file uploads\n- Visual feedback during upload process prevents user confusion\n- Proper error handling with informative messages\n- Seamless integration with existing mobile chat functionality\n\nTesting:\n- Verified paste event detection works on mobile browsers\n- Confirmed upload progress indicators display correctly\n- Tested error handling with network failures\n- Validated file path insertion and cursor positioning\n\nThis enhancement brings mobile webui file paste functionality to feature\nparity with desktop while maintaining mobile-specific optimizations.\n\nCo-Authored-By: sketch \u003chello@sketch.dev\u003e\nChange-ID: s495601fcaa89f012k\n" }, { "commit": "5f778949e023268d0bd39cb7f102952e575e9602", "tree": "d606847a802b46013eb99f6881084498c774beb3", "parents": [ "c3ecabb720cbf3fa7bf1372ec8ed449f0b9a4b91" ], "author": { "name": "Philip Zeyliger", "email": "philip@bold.dev", "time": "Sat Jun 07 00:05:20 2025 +0000" }, "committer": { "name": "Philip Zeyliger", "email": "philip@bold.dev", "time": "Sat Jun 07 04:12:53 2025 +0000" }, "message": "webui: add markdown rendering to mobile chat messages\n\nAdd comprehensive markdown support to mobile agent messages matching\ndesktop functionality with mobile-optimized styling and performance.\n\nProblem Analysis:\nMobile webui was displaying agent messages as plain text while desktop\nversion rendered rich markdown content including code blocks, headers,\nlists, and formatting. This created inconsistent user experience where\nmobile users lost important formatting context, making code examples\nand structured responses harder to read and understand.\n\nImplementation Changes:\n\n1. Markdown Library Integration:\n - Added marked library import for markdown parsing\n - Integrated DOMPurify for HTML sanitization security\n - Added unsafeHTML directive for rendering parsed content\n - Reused desktop markdown parsing patterns for consistency\n\n2. Mobile-Optimized Rendering:\n - Created simplified renderer without complex features like Mermaid\n - Focused on essential markdown elements: headers, code, lists, links\n - Maintained security through DOMPurify sanitization\n - Preserved plain text rendering for user messages\n\n3. Responsive Typography:\n - Mobile-specific font sizes for headers (1.05em - 1.2em range)\n - Optimized code block styling with horizontal scroll\n - Touch-friendly spacing and line heights\n - Compact margins for small screen readability\n\n4. Content Styling:\n - Subtle code highlighting with background colors\n - Proper blockquote styling with left border\n - List indentation optimized for mobile viewing\n - Link styling that maintains message bubble aesthetics\n\nTechnical Details:\n- Uses marked.parse() with GFM and breaks enabled for GitHub compatibility\n- DOMPurify whitelist approach for security (HTML tags and attributes)\n- Conditional rendering: markdown for assistant, plain text for user\n- CSS optimized for mobile viewport constraints and touch interaction\n\nBenefits:\n- Consistent markdown experience across desktop and mobile\n- Improved readability of code examples and structured content\n- Maintained security through proper HTML sanitization\n- Mobile-optimized styling for touch interfaces\n- Better user experience for technical discussions\n\nTesting:\n- Verified markdown parsing works with common elements\n- Confirmed code blocks render properly with scroll\n- Tested security sanitization prevents XSS\n- Validated mobile typography and spacing\n\nThis enhancement brings mobile webui markdown rendering to feature\nparity with desktop while maintaining mobile-specific optimizations.\n\nCo-Authored-By: sketch \u003chello@sketch.dev\u003e\nChange-ID: s99e90082addd4eadk\n" }, { "commit": "c3ecabb720cbf3fa7bf1372ec8ed449f0b9a4b91", "tree": "dc3cbb30ff7f291acfc1522bd0302bf0c0ba4adb", "parents": [ "e08c7ffc8f1ec0cd3899d2fedad79f408b6dc2f9" ], "author": { "name": "Philip Zeyliger", "email": "philip@bold.dev", "time": "Fri Jun 06 22:29:03 2025 +0000" }, "committer": { "name": "Philip Zeyliger", "email": "philip@bold.dev", "time": "Fri Jun 06 21:09:32 2025 -0700" }, "message": "github: fix discord webhook payload truncation for long commit messages\n\nFix Discord webhook failures caused by overly long commit body content\nthat exceeds Discord embed size limits, preventing notification delivery.\n\nProblem Analysis:\nDiscord webhooks were failing with HTTP 400 errors when commit messages\ncontained extensive body content. The error response {\"embeds\": [\"0\"]}\nindicated the first embed was invalid, typically due to field length\nviolations. Discord enforces strict limits on embed field sizes:\n- Title: 256 characters maximum\n- Description: 4096 characters maximum\n- Field values: 1024 characters maximum\n\nLarge commits with detailed implementation notes, problem analysis, and\ntechnical documentation were exceeding these limits, causing webhook\ndelivery failures and missed commit notifications.\n\nImplementation Changes:\n\n1. Text Truncation Function:\n - Added truncate_text() with intelligent content preservation\n - Attempts truncation at paragraph boundaries (double newlines)\n - Falls back to sentence boundaries (periods with spaces)\n - Uses ellipsis (...) to indicate truncated content\n - Ensures truncation only when more than half content remains\n\n2. Field Length Management:\n - Title truncated to 256 character Discord limit\n - Description conservatively limited to 2000 characters for safety\n - Maintains existing field structure and formatting\n - Preserves commit author and URL fields unchanged\n\n3. Debug Information:\n - Added payload size reporting in test mode\n - Character count logging for title and description fields\n - Enhanced troubleshooting capabilities for future issues\n\n4. Backward Compatibility:\n - No changes to function signatures or environment variables\n - Existing webhook URLs and configuration remain unchanged\n - Short commit messages pass through unmodified\n - All existing functionality preserved\n\nTechnical Details:\n- Truncation uses string slicing with boundary detection\n- Conservative 2000 character limit provides buffer below Discord\u0027s 4096 limit\n- Test mode provides detailed payload analysis for debugging\n- JSON payload generation unchanged except for field content\n\nBenefits:\n- Reliable Discord notification delivery for all commit types\n- Intelligent content preservation maintains readability\n- Debug capabilities improve webhook troubleshooting\n- Zero configuration changes required for existing setups\n\nTesting:\n- Verified fix resolves HTTP 400 errors for problematic commit e08c7ffc\n- Confirmed short commit messages remain unaffected\n- Tested intelligent truncation at paragraph and sentence boundaries\n- Validated payload size reduction maintains Discord compatibility\n\nThis fix ensures consistent Discord webhook delivery while preserving\nessential commit information through intelligent content truncation.\n\nCo-Authored-By: sketch \u003chello@sketch.dev\u003e\nChange-ID: s1859815462496f8ak\n" }, { "commit": "e08c7ffc8f1ec0cd3899d2fedad79f408b6dc2f9", "tree": "3e09e7b3a86faed4eaabb640eed0c4b148a9d8d6", "parents": [ "ba15aeb81e5fd3e98870eba91398dfb31d4cd6e9" ], "author": { "name": "Philip Zeyliger", "email": "philip@bold.dev", "time": "Fri Jun 06 13:22:12 2025 -0700" }, "committer": { "name": "Autoformatter", "email": "bot@sketch.dev", "time": "Fri Jun 06 20:26:10 2025 +0000" }, "message": "webui: add mobile interface with URL parameter switching\n\nTL;DR: ?m and ?d should load mobile and desktop versions respectively.\nIt should auto-detect to the right onen and redirect. Server chooses\nwhat to serve.\n\nThis took a few tries. Re-using the existing components didn\u0027t work,\ndespite repeated attempts. The prompt that eventually worked was:\n\n\tSketch\u0027s webui uses lit and webcomponents. I want to create an alternate\n\tweb ui, started with \"/m\" for mobile. Don\u0027t use the same components, but\n\tcreate a new mobile-shell component and a mobile-title, mobile-chat, and\n\tmobile-chat-input components. The design should be a title at the top, a\n\tsimplified chat (that doesn\u0027t display tool cards or anything; just the\n\tmessages, with user messages right-aligned and other messages left\n\taligned), and an input for new messages. Do include an indicator for\n\twhether or not the agent is thinking. Again: this is a parallel\n\timplementation, intended for mobile screens. Use the \"npm run dev\"\n\tserver to test it out and show me some screenshots. Use mobile browser\n\tsizes. Focus on simplicity in the CSS\n\nIt had some trouble with the data loading that took some iterations, and\nit kept saying, \"We\u0027re almost done\" and giving up, but I coaxed it\nthrough.\n\nI\u0027m not too sad right now about the duplication. We can see if there\u0027s\nany traction.\n\n~~~~\n\nAdd complete mobile-optimized interface for Sketch accessible via URL\nparameters, providing seamless device-specific user experience.\n\nProblem Analysis:\nSketch\u0027s existing web interface was designed for desktop use with complex\nlayouts, detailed toolbars, and mouse-focused interactions that don\u0027t\ntranslate well to mobile devices. Mobile users needed a simplified,\ntouch-friendly interface optimized for smaller screens while maintaining\ncore functionality for coding assistance on mobile devices.\n\nImplementation Changes:\n\n1. Mobile-Specific Components:\n - Created mobile-shell as main container with mobile-optimized layout\n - Built mobile-title with connection status and clean header design\n - Implemented mobile-chat with simplified message bubbles and alignment\n - Developed mobile-chat-input with touch-friendly controls and auto-resize\n\n2. URL Parameter-Based Interface Selection:\n - Added server-side parameter detection (?m for mobile, ?d for desktop)\n - Consolidated routing logic into main / handler with parameter checking\n - Eliminated separate URL paths in favor of clean parameter approach\n - Removed interface switching buttons for minimal UI approach\n\n3. Intelligent Auto-Detection:\n - Implemented client-side device detection using screen size and touch capability\n - Automatic URL parameter addition for detected mobile devices\n - Graceful parameter-based overrides for user preference\n - Seamless redirection maintaining all URL context and query parameters\n\n4. Mobile-Optimized Design:\n - iOS-style message bubbles with proper user/assistant alignment\n - Touch-friendly input controls with appropriate sizing\n - Responsive design scaling across mobile screen sizes\n - Animated thinking indicator with smooth dot animations\n - Clean, distraction-free interface focused on core chat functionality\n\n5. Data Integration:\n - Reused existing DataManager and SSE infrastructure\n - Maintained real-time message updates via /stream endpoint\n - Implemented message aggregation using existing patterns\n - Preserved connection status and error handling functionality\n\nTechnical Details:\n- Built using Lit web components for consistency with existing architecture\n- Server parameter detection uses URL.Query().Has() for efficient checking\n- Auto-detection preserves all existing query parameters during redirection\n- Mobile components filter messages to show user, agent, and error types\n- Responsive CSS with mobile-first design principles and touch optimization\n\nBenefits:\n- Seamless mobile experience with automatic device-appropriate interface\n- Clean URL parameter approach (?m/?d) works with any route or session\n- No UI clutter from interface switching buttons\n- Maintains full real-time functionality on mobile devices\n- Easy to bookmark and share mobile-specific URLs\n- Preserves session context during interface switching\n\nTesting:\n- Verified auto-detection works across different mobile screen sizes\n- Confirmed URL parameters function with complex session URLs\n- Tested message sending, receiving, and real-time updates\n- Validated thinking indicator and connection status display\n- Ensured responsive design across portrait and landscape orientations\n\nThis implementation provides a complete mobile solution while maintaining\nthe full-featured desktop interface, enabling Sketch usage across all\ndevice types with appropriate user experiences.\n\nCo-Authored-By: sketch \u003chello@sketch.dev\u003e\nChange-ID: sdbce185f247638c1k\n" }, { "commit": "ba15aeb81e5fd3e98870eba91398dfb31d4cd6e9", "tree": "0b317ecbf35b2a52d8736af16478d87350d5c5ff", "parents": [ "6c5beffcea347f8b5a738f9563980e64a9f8ccc0" ], "author": { "name": "Philip Zeyliger", "email": "philip@bold.dev", "time": "Fri Jun 06 13:11:34 2025 -0700" }, "committer": { "name": "Philip Zeyliger", "email": "philip@bold.dev", "time": "Fri Jun 06 13:11:52 2025 -0700" }, "message": "Port forwarding: delete noisy log line\n" }, { "commit": "6c5beffcea347f8b5a738f9563980e64a9f8ccc0", "tree": "15e46908d94afd6ac357ab44e8bd72f34f2ad705", "parents": [ "715b8d9e46757b1254624e8b1329a9581baa10d3" ], "author": { "name": "Philip Zeyliger", "email": "philip@bold.dev", "time": "Fri Jun 06 13:03:49 2025 -0700" }, "committer": { "name": "Philip Zeyliger", "email": "philip@bold.dev", "time": "Fri Jun 06 13:07:02 2025 -0700" }, "message": "Disable pager in post commit hook we install.\n\nMakes using the terminal to do git operations miserable.\n" }, { "commit": "715b8d9e46757b1254624e8b1329a9581baa10d3", "tree": "2e7d423e145ccd8746b1bf1e0c441224530e691a", "parents": [ "cecba06431da9aa134898d23a353e1897f3e3625" ], "author": { "name": "Josh Bleecher Snyder", "email": "josharian@gmail.com", "time": "Fri Jun 06 12:36:38 2025 -0700" }, "committer": { "name": "Philip Zeyliger", "email": "philip@bold.dev", "time": "Fri Jun 06 12:36:38 2025 -0700" }, "message": "loop: always use branch sketch-wip in innie\n\nModify innie sketch to always create and work on a dedicated \u0027sketch-wip\u0027\nbranch for all git operations, pushing this branch to outie instead of\npushing HEAD directly.\n\nHaving a dedicated branch name makes it clearer how to operate\ninside the container, for both humans and sketch.\nIt also prevents the container from pushing whatever transient\ncommits occur while sketch does (say) a bisection or other git work.\nIt should also prevent sketch from constantly spinning up new\nbranches as it starts new tasks in a long conversation.\n\nI\u0027d rather have called the branch \u0027sketch\u0027 instead of \u0027sketch-wip\u0027,\nbut that conflicts with all the branches called \u0027sketch/foo\u0027. Alas.\n\nThis was mostly written by Josh, but I made it work whether or not\nsketch-wip already exists as a branch.\n\nCo-Authored-By: sketch \u003chello@sketch.dev\u003e\nChange-ID: s4ea6db2873a60129k\n" }, { "commit": "cecba06431da9aa134898d23a353e1897f3e3625", "tree": "82917d622941ab58c975ceaaf8c2044174309c8d", "parents": [ "c17ffe37ff9ac2c5e0f19a67854b77955976c1bb" ], "author": { "name": "Philip Zeyliger", "email": "philip@bold.dev", "time": "Fri Jun 06 18:40:16 2025 +0000" }, "committer": { "name": "Philip Zeyliger", "email": "philip@bold.dev", "time": "Fri Jun 06 11:42:51 2025 -0700" }, "message": "browser: add SKETCH_BROWSER environment variable support\n\nAdd configurable browser selection through SKETCH_BROWSER environment\nvariable for customized browser launching across different platforms.\n\nProblem Analysis:\nUsers needed the ability to specify which browser application to use\nwhen opening URLs through Sketch, rather than being limited to system\ndefaults. Different development workflows require specific browsers\n(e.g., Chrome for debugging, Firefox for testing), and the existing\nimplementation only supported system default browser opening.\n\nImplementation Changes:\n\n1. Environment Variable Integration:\n - Read SKETCH_BROWSER environment variable in Open() function\n - Pass browser application name to platform-specific commands\n - Graceful fallback to default behavior when variable not set\n\n2. Platform-Specific Command Generation:\n - macOS: Use \u0027open -a [browser]\u0027 when SKETCH_BROWSER set\n - Windows: Use browser executable directly when SKETCH_BROWSER set\n - Linux/Unix: Use browser executable directly (xdg-open doesn\u0027t support app selection)\n - Preserve existing default behavior for each platform\n\n3. Enhanced Debug Logging:\n - Added browser parameter to debug log output\n - Improved error visibility for custom browser failures\n - Maintains existing error handling patterns\n\n4. Comprehensive Test Coverage:\n - Added browser_test.go with platform-specific test cases\n - Environment variable manipulation testing\n - Cross-platform command generation validation\n - Empty URL handling verification\n\nTechnical Details:\n- Uses os.Getenv() for environment variable access\n- Platform detection via runtime.GOOS for appropriate command selection\n- Direct executable invocation for Windows/Linux custom browsers\n- macOS leverages \u0027open -a\u0027 for application-specific launching\n\nBenefits:\n- Developers can specify preferred browser for Sketch URLs\n- Cross-platform compatibility maintained for all use cases\n- Zero configuration required - works with existing setups\n- Enhanced debugging capabilities through improved logging\n\nTesting:\n- Unit tests verify environment variable handling across platforms\n- Command generation logic tested for all platform combinations\n- Integration testing confirms no regression in default behavior\n- Empty/invalid input handling validated\n\nThis enhancement provides flexible browser selection while maintaining\nfull backward compatibility with existing default browser workflows.\n\nCo-Authored-By: sketch \u003chello@sketch.dev\u003e\nChange-ID: s0ae93ccc20b0a8c2k\n" }, { "commit": "c17ffe37ff9ac2c5e0f19a67854b77955976c1bb", "tree": "2318aae7918bd74a4391b0faac4355f0e861b7d5", "parents": [ "2a32f01e45169200bfb252031ca880ef09d7c0c2" ], "author": { "name": "Philip Zeyliger", "email": "philip.zeyliger@gmail.com", "time": "Thu Jun 05 19:49:13 2025 -0700" }, "committer": { "name": "Philip Zeyliger", "email": "philip.zeyliger@gmail.com", "time": "Thu Jun 05 19:49:46 2025 -0700" }, "message": "sketch: add session history tools using markdown table API\n\nAdd session history tools to allow the LLM to access previous sketch sessions:\n- New list_recent_sketch_sessions and read_sketch_session tools\n- Integration with skaband client for session data retrieval\n- Session history tools automatically added when skaband client available\n- Updated agent configuration to include skaband client\n- Client handles plain text markdown table response from API\n- Display server-generated markdown table directly to LLM\n\nCo-Authored-By: sketch \u003chello@sketch.dev\u003e\nChange-ID: s693acdfdaaa392c8k\n" }, { "commit": "2a32f01e45169200bfb252031ca880ef09d7c0c2", "tree": "012e403e57be0c333ff1107b3f096f619c08c33a", "parents": [ "3d040bd66f81a9211e616ef755b261323d4fea95" ], "author": { "name": "Josh Bleecher Snyder", "email": "josharian@gmail.com", "time": "Thu Jun 05 19:40:07 2025 -0700" }, "committer": { "name": "Josh Bleecher Snyder", "email": "josharian@gmail.com", "time": "Thu Jun 05 19:42:17 2025 -0700" }, "message": "go.mod: bump to Go 1.24.4\n\nand use this opportunity to bust the cache.\ngood to do every once in a while.\n" }, { "commit": "3d040bd66f81a9211e616ef755b261323d4fea95", "tree": "7c5cc14efb4e335586292b0e4225549d4a3a3438", "parents": [ "19969a9af6da4b5b5e25d02aa635dabad196e464" ], "author": { "name": "Autoformatter", "email": "bot@sketch.dev", "time": "Fri Jun 06 02:35:19 2025 +0000" }, "committer": { "name": "Autoformatter", "email": "bot@sketch.dev", "time": "Fri Jun 06 02:35:19 2025 +0000" }, "message": "all: fix formatting\n" }, { "commit": "19969a9af6da4b5b5e25d02aa635dabad196e464", "tree": "d4701576dce7bdffd962b1d11cd3e6b37d4be443", "parents": [ "44f847a93e7e0953abd42880f5e87c8b3e213134" ], "author": { "name": "Josh Bleecher Snyder", "email": "josharian@gmail.com", "time": "Thu Jun 05 14:34:02 2025 -0700" }, "committer": { "name": "Josh Bleecher Snyder", "email": "josharian@gmail.com", "time": "Thu Jun 05 19:30:39 2025 -0700" }, "message": "all: s/title/slug/, adjust branch handling\n\nThere are two intertwined changes here.\n\nFirst, replace title with slug, and precommit with commit-message-style.\n\nThe slug makes enough of a title, and it provides a single human-readable\nidentifier we can use everywhere.\n\nSecond, construct the branch name on the fly instead of storing it,\nout of slug, branch prefix, and retryNumber.\nThis removes some duplicated data, and makes the retry loop\neasier to follow and reason about." }, { "commit": "44f847a93e7e0953abd42880f5e87c8b3e213134", "tree": "477e9410248ed5983742660e4637ba5016bd9589", "parents": [ "0337623c8e014f4446cfb72ffc271b20cedb80fe" ], "author": { "name": "Josh Bleecher Snyder", "email": "josharian@gmail.com", "time": "Thu Jun 05 14:33:50 2025 -0700" }, "committer": { "name": "Josh Bleecher Snyder", "email": "josharian@gmail.com", "time": "Thu Jun 05 19:30:39 2025 -0700" }, "message": "webui: move cost display to popup info panel and hide when zero\n\nAnd remove a top column, because we now can.\n\nCo-Authored-By: sketch \u003chello@sketch.dev\u003e\nChange-ID: s523262bb871c97d6k" }, { "commit": "0337623c8e014f4446cfb72ffc271b20cedb80fe", "tree": "23a7ec7d151428e65dbace42e1c25fc31968f730", "parents": [ "068f4bbc12594cd48a4d2b19803849434d0bdb24" ], "author": { "name": "Josh Bleecher Snyder", "email": "josharian@gmail.com", "time": "Thu Jun 05 14:29:48 2025 -0700" }, "committer": { "name": "Josh Bleecher Snyder", "email": "josharian@gmail.com", "time": "Thu Jun 05 19:30:39 2025 -0700" }, "message": "termui: only display money when non-zero\n\n" }, { "commit": "068f4bbc12594cd48a4d2b19803849434d0bdb24", "tree": "e703926e4d61f3a3b0e8cc117bc4ea4f0327aa6e", "parents": [ "d27921f73b315dc1e01b92cc27370c29c3986f64" ], "author": { "name": "Josh Bleecher Snyder", "email": "josharian@gmail.com", "time": "Thu Jun 05 19:12:22 2025 +0000" }, "committer": { "name": "Josh Bleecher Snyder", "email": "josharian@gmail.com", "time": "Thu Jun 05 19:30:39 2025 -0700" }, "message": "loop: remove pointless fmt.Sprintf" }, { "commit": "d27921f73b315dc1e01b92cc27370c29c3986f64", "tree": "8d245ab695e991337b7c11cdef23d280d10df466", "parents": [ "5c654f6e66db881f17e202ec60cf7c997f7c0bad" ], "author": { "name": "Jon Friesen", "email": "jon@jonfriesen.ca", "time": "Thu Jun 05 13:15:56 2025 +0000" }, "committer": { "name": "Josh Bleecher Snyder", "email": "josharian@gmail.com", "time": "Thu Jun 05 19:29:47 2025 -0700" }, "message": "dockerimg: prioritize Dockerfile.sketch over Dockerfile\n\nImplement prioritization system for Dockerfile discovery that prefers\nDockerfile.sketch when available, falling back to standard Dockerfile\nbehavior when not present.\n\nProblem Analysis:\nThe existing code had a TODO comment requesting preference for\n\u0027Dockerfile.sketch\u0027 to allow users to tailor environments specifically\nfor Sketch usage. The current logic only handled single Dockerfile\nscenarios or fell back to generated dockerfiles, missing the\nopportunity to prioritize sketch-specific configurations.\n\nImplementation Changes:\n\n1. Prioritization Function:\n - Added prioritizeDockerfiles() function with clear priority order\n - Priority: Dockerfile.sketch \u003e Dockerfile \u003e other Dockerfile.*\n - Case-insensitive matching for broader compatibility\n - Returns first candidate when no priority matches\n\n2. Discovery Logic Update:\n - Modified findOrBuildDockerImage() to use prioritization\n - Removed single-dockerfile restriction for better flexibility\n - Uses prioritizeDockerfiles() for any number of candidates\n - Maintains existing behavior for generated dockerfile fallback\n\n3. User Experience Enhancement:\n - Clear console output showing which dockerfile is being used\n - Consistent behavior regardless of dockerfile count\n - Preserves all existing functionality and error handling\n\nTechnical Details:\n- Maintains backward compatibility with existing Dockerfile usage\n- No changes to function signatures or public interfaces\n- Efficient O(n) prioritization with early returns\n- Proper filepath handling for cross-platform compatibility\n\nBenefits:\n- Users can create Dockerfile.sketch for sketch-specific environments\n- Automatic preference without requiring configuration changes\n- Maintains existing Dockerfile support as fallback\n- Clear, predictable behavior for dockerfile selection\n\nTesting:\n- Added comprehensive unit tests for prioritizeDockerfiles()\n- Integration tests verify findDirDockerfiles() compatibility\n- End-to-end tests confirm findRepoDockerfiles() behavior\n- All existing tests continue to pass without modification\n\nThis enhancement enables users to create sketch-optimized Docker\nenvironments while preserving full backward compatibility with\nexisting Dockerfile workflows.\n\nCo-Authored-By: sketch \u003chello@sketch.dev\u003e\nChange-ID: s1d7f47401929e175k\n" }, { "commit": "5c654f6e66db881f17e202ec60cf7c997f7c0bad", "tree": "592c244e6468ffbbe3bc2c1f80270877402f5ea6", "parents": [ "664404e9e53fe0d28a35f9b6da2274e3bdea4c4b" ], "author": { "name": "Autoformatter", "email": "bot@sketch.dev", "time": "Thu Jun 05 19:06:51 2025 +0000" }, "committer": { "name": "Autoformatter", "email": "bot@sketch.dev", "time": "Thu Jun 05 19:06:51 2025 +0000" }, "message": "all: fix formatting\n" }, { "commit": "664404e9e53fe0d28a35f9b6da2274e3bdea4c4b", "tree": "be94392672a64c991b962e55e7a297e9631fa0af", "parents": [ "a9fd88ff17fe6d59ed2295b46dd8f389d30fdf23" ], "author": { "name": "Josh Bleecher Snyder", "email": "josharian@gmail.com", "time": "Wed Jun 04 21:56:42 2025 +0000" }, "committer": { "name": "Josh Bleecher Snyder", "email": "josharian@gmail.com", "time": "Thu Jun 05 12:05:33 2025 -0700" }, "message": "cmd/sketch: add -upstream flag for git branch management\n\nTo be used in future work.\n\nCo-Authored-By: sketch \u003chello@sketch.dev\u003e\nChange-ID: s40fdfb9a579bf6f2k\n" }, { "commit": "a9fd88ff17fe6d59ed2295b46dd8f389d30fdf23", "tree": "260472eca9bc1eecbe22f7dd4de99155089dcf27", "parents": [ "59bb27d160b935287944f39588d9fef84d9c2036" ], "author": { "name": "Josh Bleecher Snyder", "email": "josharian@gmail.com", "time": "Thu Jun 05 10:43:22 2025 -0700" }, "committer": { "name": "Josh Bleecher Snyder", "email": "josharian@gmail.com", "time": "Thu Jun 05 12:05:33 2025 -0700" }, "message": "dockerimg: detect more dockerfiles\n\n" }, { "commit": "59bb27d160b935287944f39588d9fef84d9c2036", "tree": "a30a97916af6798745f9baf9c9a24aba24adc6e1", "parents": [ "883e758cfa6b41658158d3ceff2dd69eb01d8b81" ], "author": { "name": "Josh Bleecher Snyder", "email": "josharian@gmail.com", "time": "Thu Jun 05 07:32:10 2025 -0700" }, "committer": { "name": "Josh Bleecher Snyder", "email": "josharian@gmail.com", "time": "Thu Jun 05 12:05:33 2025 -0700" }, "message": "llm: get costs from server\n\nCalculating costs on the client has the advantage\nthat it works when not using skaband.\n\nIt requires that we maintain multiple sources of truth, though.\nAnd it makes it very challenging to add serverside tools,\nsuch as Anthropic\u0027s web tool.\n\nThis commit switches sketch to rely on the server for all costs.\nIf not using skaband, no costs will be calculated, which also\nmeans that budget constraints won\u0027t work.\n\nIt\u0027s unfortunate, but at the moment it seems like the best path.\n" }, { "commit": "883e758cfa6b41658158d3ceff2dd69eb01d8b81", "tree": "d77cb5b23f599191fc23eb1a673b860c6572ba2d", "parents": [ "27585457d8229499d95b8dc77ced3827eb7a429f" ], "author": { "name": "David Crawshaw", "email": "david@zentus.com", "time": "Thu Jun 05 11:35:22 2025 -0700" }, "committer": { "name": "David Crawshaw", "email": "david@zentus.com", "time": "Thu Jun 05 11:35:24 2025 -0700" }, "message": ".clabot: add jonfriesen\n\nSigned CLA\n" }, { "commit": "27585457d8229499d95b8dc77ced3827eb7a429f", "tree": "88a74c7da23fbe550356137e61859d03bdb65030", "parents": [ "203724192f37239c3a2ee35fd6a982ff810aefcc" ], "author": { "name": "Philip Zeyliger", "email": "philip@bold.dev", "time": "Thu Jun 05 09:13:59 2025 -0700" }, "committer": { "name": "Philip Zeyliger", "email": "philip@bold.dev", "time": "Thu Jun 05 09:13:59 2025 -0700" }, "message": "Adding dependabot to have signed the CLA.\n\n(Which, of course, it hasn\u0027t, since it\u0027s a bot.)\n" }, { "commit": "203724192f37239c3a2ee35fd6a982ff810aefcc", "tree": "0bc75e1a7334186d070112b52a0c590688b9dce5", "parents": [ "95632c8a1e5953eddcb3073764b3db2c7f7bddb5" ], "author": { "name": "Philip Zeyliger", "email": "philip@bold.dev", "time": "Thu Jun 05 02:12:10 2025 +0000" }, "committer": { "name": "Philip Zeyliger", "email": "philip@bold.dev", "time": "Wed Jun 04 20:35:18 2025 -0700" }, "message": "git_tools: improve commit range selection when fewer than 10 commits exist\n\nReplace hardcoded fromCommit~10 check with flexible loop that tries\noffsets from 10 down to 0, selecting the first valid range.\n\nProblem Analysis:\nThe getGitLog function was failing when repositories had fewer than\n10 commits total. It attempted to check if fromCommit~10 existed and\nfell back to fromCommit..HEAD only if that check failed, causing\nissues in new repositories or shallow clones.\n\nImplementation Changes:\n- Added loop from i\u003d10 down to i\u003d0 to find the largest valid offset\n- Use git rev-parse --verify to test each fromCommit~i combination\n- Fall back to fromCommit..HEAD when no offset works (i\u003d0 case)\n- Maintain same git log command structure and output format\n\nBenefits:\n- Works correctly with repositories of any size\n- Gracefully handles edge cases like single commits\n- Maintains existing functionality for larger repositories\n- No changes to function signature or return format\n\nTesting:\nAll existing tests continue to pass, confirming backward compatibility.\n\nCo-Authored-By: sketch \u003chello@sketch.dev\u003e\nChange-ID: sc8c08e32b68c72dck\n" }, { "commit": "95632c8a1e5953eddcb3073764b3db2c7f7bddb5", "tree": "30d2fd9f686e10dd26506c3da1b4fb5438532d4e", "parents": [ "a727f7073c024573017c2f46517fc2e90545f9c1" ], "author": { "name": "Josh Bleecher Snyder", "email": "josharian@gmail.com", "time": "Thu Jun 05 01:23:05 2025 +0000" }, "committer": { "name": "Josh Bleecher Snyder", "email": "josharian@gmail.com", "time": "Wed Jun 04 19:03:43 2025 -0700" }, "message": "claudetool/codereview: fix runGenerate to filter pre-existing modified files\n\nThe runGenerate function was returning all files that appear modified in git\nstatus after running \u0027go generate\u0027, including files that were already modified\nbefore the generate command ran. This led to misleading output suggesting that\n\u0027go generate\u0027 had changed files like .DS_Store, .projections.json, and other\nunrelated dirty files.\n\nCo-Authored-By: sketch \u003chello@sketch.dev\u003e\nChange-ID: sfdde2d72136bfb64k\n" }, { "commit": "a727f7073c024573017c2f46517fc2e90545f9c1", "tree": "71b2925c4d3cbf2b4d3563157ff95a0c5c6378c4", "parents": [ "cf19190dd743f3f3c906a7b6f4fd89b87913663e" ], "author": { "name": "Josh Bleecher Snyder", "email": "josharian@gmail.com", "time": "Wed Jun 04 18:47:33 2025 -0700" }, "committer": { "name": "Josh Bleecher Snyder", "email": "josharian@gmail.com", "time": "Wed Jun 04 19:03:43 2025 -0700" }, "message": "claudetool/codereview: stabilize related files list\n" }, { "commit": "cf19190dd743f3f3c906a7b6f4fd89b87913663e", "tree": "94c715b3c77e417940dd043388847860031ec358", "parents": [ "272c4a9aab39b3b7eadb6c6ae7b275da4663e9d7" ], "author": { "name": "Josh Bleecher Snyder", "email": "josharian@gmail.com", "time": "Wed Jun 04 18:18:40 2025 +0000" }, "committer": { "name": "Josh Bleecher Snyder", "email": "josharian@gmail.com", "time": "Wed Jun 04 17:00:43 2025 -0700" }, "message": "claudetool/codereview: add go generate support\n\nAutomatically run \u0027go generate\u0027 as part of codereview,\nsince sketch sometimes forgets to do it.\n\nCo-Authored-By: sketch \u003chello@sketch.dev\u003e\nChange-ID: safe9348e7c24beffk" }, { "commit": "272c4a9aab39b3b7eadb6c6ae7b275da4663e9d7", "tree": "fe8322570545314e03f8869ce3a9ae37e3576cb4", "parents": [ "008f9580cb1df44d70f1daa32b2122e10b7d8f79" ], "author": { "name": "Josh Bleecher Snyder", "email": "josharian@gmail.com", "time": "Wed Jun 04 16:08:42 2025 -0700" }, "committer": { "name": "Josh Bleecher Snyder", "email": "josharian@gmail.com", "time": "Wed Jun 04 16:55:23 2025 -0700" }, "message": "claudetool/codereview: nudge agent to call codereview after each round" }, { "commit": "008f9580cb1df44d70f1daa32b2122e10b7d8f79", "tree": "74ec1fe7013c16a11e3886424740a9b80411eee8", "parents": [ "9236cce91da9ced563cf87dcde423dfbe18a1f1e" ], "author": { "name": "Josh Bleecher Snyder", "email": "josharian@gmail.com", "time": "Wed Jun 04 16:26:15 2025 -0700" }, "committer": { "name": "Josh Bleecher Snyder", "email": "josharian@gmail.com", "time": "Wed Jun 04 16:26:52 2025 -0700" }, "message": ".github: don\u0027t notify Discord from dev queue (sigh)" }, { "commit": "9236cce91da9ced563cf87dcde423dfbe18a1f1e", "tree": "e3d689020c47d841d2bdfd9958c60e18c01ea75a", "parents": [ "7e5fe3cc66dd9e76408a0ae27e7c29d119288dcb" ], "author": { "name": "Josh Bleecher Snyder", "email": "josharian@gmail.com", "time": "Wed Jun 04 15:35:35 2025 -0700" }, "committer": { "name": "Josh Bleecher Snyder", "email": "josharian@gmail.com", "time": "Wed Jun 04 15:52:10 2025 -0700" }, "message": ".github: download gofumpt instead of installing go\n\n" }, { "commit": "7e5fe3cc66dd9e76408a0ae27e7c29d119288dcb", "tree": "cb6014b342813fe466a790ada94a0d0de089340e", "parents": [ "3fef3ca1012c5838a38dd7fec15272c2cbcb3e0a" ], "author": { "name": "Autoformatter", "email": "bot@sketch.dev", "time": "Wed Jun 04 22:24:53 2025 +0000" }, "committer": { "name": "Autoformatter", "email": "bot@sketch.dev", "time": "Wed Jun 04 22:24:53 2025 +0000" }, "message": "all: fix formatting\n" }, { "commit": "3fef3ca1012c5838a38dd7fec15272c2cbcb3e0a", "tree": "4be617fb453f6fca0c19c871efc328c88eb4519c", "parents": [ "be7802ab0605e7cf116d0979bda6e0b6af8f120d" ], "author": { "name": "dependabot[bot]", "email": "49699333+dependabot[bot]@users.noreply.github.com", "time": "Wed Jun 04 16:58:39 2025 +0000" }, "committer": { "name": "Philip Zeyliger", "email": "philip@bold.dev", "time": "Wed Jun 04 15:23:08 2025 -0700" }, "message": "build(deps): bump tar-fs from 3.0.8 to 3.0.9 in /webui\n\nBumps [tar-fs](https://github.com/mafintosh/tar-fs) from 3.0.8 to 3.0.9.\n- [Commits](https://github.com/mafintosh/tar-fs/compare/v3.0.8...v3.0.9)\n\n---\nupdated-dependencies:\n- dependency-name: tar-fs\n dependency-version: 3.0.9\n dependency-type: indirect\n...\n\nSigned-off-by: dependabot[bot] \u003csupport@github.com\u003e" }, { "commit": "be7802ab0605e7cf116d0979bda6e0b6af8f120d", "tree": "d9b2bc73b8bf5fcef160e83c10638b62bcc85863", "parents": [ "2abd467f1bd5fd5cc1de8719eb414a67a412f655" ], "author": { "name": "Philip Zeyliger", "email": "philip@bold.dev", "time": "Wed Jun 04 20:15:25 2025 +0000" }, "committer": { "name": "Philip Zeyliger", "email": "philip@bold.dev", "time": "Wed Jun 04 15:19:01 2025 -0700" }, "message": "loop: add configurable branch prefix option\n\nAdd -branch-prefix flag to customize git branch prefix instead of\nhardcoded \u0027sketch/\u0027 for better integration with different workflows.\n\nProblem Analysis:\nThe sketch system hardcoded \u0027sketch/\u0027 as the branch prefix throughout\nthe codebase, making it difficult for users who wanted different\nbranch naming conventions or needed to integrate with existing\ndevelopment workflows that used different prefixes.\n\nImplementation Changes:\n\n1. CLI Flag Addition:\n - Added -branch-prefix flag to main.go with default \u0027sketch/\u0027\n - Integrated flag into CLIFlags struct and argument parsing\n - Maintains backward compatibility with existing workflows\n\n2. Configuration Threading:\n - Added BranchPrefix field to AgentConfig struct\n - Added BranchPrefix field to ContainerConfig struct\n - Modified container argument passing to include branch prefix\n - Set sensible default of \u0027sketch/\u0027 when not specified\n\n3. Agent Implementation:\n - Added BranchPrefix() method to CodingAgent interface\n - Updated precommit tool to use configurable prefix\n - Modified git commit handling to use configurable prefix\n - Updated all hardcoded \u0027sketch/\u0027 references in logic\n\n4. UI Integration:\n - Enhanced termui template to use configurable branch prefix\n - Added branch_prefix field to server State response\n - Updated webui TypeScript types via auto-generation\n - Modified sketch-tool-card to display configurable prefix\n\n5. Container Integration:\n - Modified dockerimg to pass branch prefix to inner sketch\n - Updated container command arguments construction\n - Ensured proper flag threading through container boundary\n\nTechnical Details:\n- Maintains full backward compatibility with existing usage\n- Default behavior unchanged for existing users\n- Type-safe implementation with proper error handling\n- Clean interface design without type casts or fallbacks\n\nBenefits:\n- Enables custom branch naming conventions\n- Better integration with team workflows\n- Maintains existing sketch functionality\n- Improves flexibility for different use cases\n\nTesting:\n- Verified default behavior remains unchanged\n- Confirmed custom prefix works in both termui and webui\n- All existing tests continue to pass\n- Build verification successful across all components\n\nThis enhancement provides workflow flexibility while maintaining\nthe reliability and functionality of the existing branch management\nsystem.\n\nCo-Authored-By: sketch \u003chello@sketch.dev\u003e\nChange-ID: s71341dca2cfeeb24k\n" }, { "commit": "2abd467f1bd5fd5cc1de8719eb414a67a412f655", "tree": "280bb2f1f3bb8a723ea7fcaecdb543d8b3b807e0", "parents": [ "322dae94823e6e55ee8e5d0c567cb972f231695c" ], "author": { "name": "Josh Bleecher Snyder", "email": "josharian@gmail.com", "time": "Wed Jun 04 14:56:33 2025 -0700" }, "committer": { "name": "Josh Bleecher Snyder", "email": "josharian@gmail.com", "time": "Wed Jun 04 14:57:14 2025 -0700" }, "message": "cmd/sketch: expand ~ in host path in mounts" }, { "commit": "322dae94823e6e55ee8e5d0c567cb972f231695c", "tree": "e9f514f654fe1451ee0c7fff10c9eedd1a27ff81", "parents": [ "43448c674f4cf1f6de7950f6ec9e2d197d7f700a" ], "author": { "name": "Josh Bleecher Snyder", "email": "josharian@gmail.com", "time": "Wed Jun 04 12:27:07 2025 -0700" }, "committer": { "name": "Josh Bleecher Snyder", "email": "josharian@gmail.com", "time": "Wed Jun 04 14:00:10 2025 -0700" }, "message": "dear_llm: simplify, shorten\n" }, { "commit": "43448c674f4cf1f6de7950f6ec9e2d197d7f700a", "tree": "65369f28dd9e2acd13a6506923ccc165d2240f3a", "parents": [ "53ab24547cd684fc38254a6bd63759d7121ca7d6" ], "author": { "name": "Josh Bleecher Snyder", "email": "josharian@gmail.com", "time": "Wed Jun 04 11:51:04 2025 -0700" }, "committer": { "name": "Josh Bleecher Snyder", "email": "josharian@gmail.com", "time": "Wed Jun 04 14:00:10 2025 -0700" }, "message": "loop: nudge agent towards less bouncy emoji babble" }, { "commit": "53ab24547cd684fc38254a6bd63759d7121ca7d6", "tree": "15122689ee81490ea8d3497b6baade986c6bad2c", "parents": [ "16098932295e067fb0a6b3ca2082b0d4b06027b4" ], "author": { "name": "Philip Zeyliger", "email": "philip@bold.dev", "time": "Wed Jun 04 17:49:33 2025 +0000" }, "committer": { "name": "Autoformatter", "email": "bot@sketch.dev", "time": "Wed Jun 04 18:10:57 2025 +0000" }, "message": "webui: implement DOMPurify sanitization for markdown security\n\nImplement comprehensive HTML sanitization using DOMPurify library to\nprevent XSS vulnerabilities in markdown rendering while preserving\nfull markdown functionality.\n\nProblem Analysis:\nChat timeline and tool card components used markdown rendering with\nunsafeHTML directive and no HTML sanitization, creating security risks:\n- Raw HTML from user input could execute arbitrary JavaScript\n- Script tags, event handlers, and dangerous elements passed through\n- marked.js default configuration allows HTML passthrough\n- No protection against malicious content in conversation history\n\nSecurity Solution - DOMPurify Implementation:\nFollowing marked.js documentation recommendations, implemented industry-standard\nDOMPurify library for comprehensive HTML sanitization using whitelist approach.\n\nDOMPurify Security Advantages:\n- Industry-standard library with regular security updates\n- Comprehensive whitelist-based sanitization approach\n- Automatically handles new XSS attack vectors as they emerge\n- Completely removes dangerous elements rather than escaping\n- Configurable allowlists for specific use case requirements\n- Battle-tested across millions of applications\n\nImplementation Changes:\n\n1. Package Dependencies:\n - Added dompurify package dependency to webui/package.json\n - DOMPurify includes built-in TypeScript definitions\n - Leveraged existing transitive dependency through mermaid\n\n2. Enhanced sketch-timeline-message.ts Security:\n - Integrated DOMPurify.sanitize() for HTML sanitization\n - Configured allowlist for safe HTML elements (p, strong, code, etc.)\n - Added support for mermaid diagram elements (svg, path, etc.)\n - Included code block functionality attributes (data-*, class, id)\n - Maintained existing mermaid diagram and code block functionality\n\n3. Enhanced sketch-tool-card.ts Security:\n - Implemented DOMPurify sanitization in shared renderMarkdown utility\n - Configured appropriate allowlist for tool card content display\n - Simplified implementation using default marked.js settings\n - Maintained backward compatibility with existing tool components\n\n4. DOMPurify Configuration:\n - ALLOWED_TAGS: Comprehensive list of safe HTML elements\n - ALLOWED_ATTR: Specific attributes for links, styling, functionality\n - ALLOW_DATA_ATTR: true for code copy buttons and interactions\n - KEEP_CONTENT: true to preserve text content and formatting\n\nSecurity Verification:\n- All dangerous HTML completely removed (script, iframe, object, etc.)\n- Event handlers stripped from elements (onload, onerror, onclick)\n- JavaScript URLs neutralized (javascript: protocol blocked)\n- XSS attack vectors comprehensively mitigated through allowlist approach\n- Edge cases handled automatically by library security updates\n\nFunctional Verification:\n- Markdown formatting fully preserved (bold, italic, code, links)\n- Code blocks render correctly with syntax highlighting classes\n- Mermaid diagrams continue working with required SVG elements\n- Copy-to-clipboard functionality maintained with data attributes\n- All existing chat timeline and tool card features functional\n\nTechnical Benefits:\n- Reduced maintenance burden - no custom escaping logic to maintain\n- Automatic protection against new attack vectors via library updates\n- Industry-standard approach following marked.js documentation recommendations\n- Comprehensive allowlist prevents unknown dangerous elements\n- Better performance through optimized library implementation\n\nTesting:\n- Verified all XSS attack vectors safely handled through comprehensive tests\n- Confirmed markdown functionality preserved across all components\n- Build process succeeds without TypeScript errors\n- Comprehensive security test suite validates sanitization effectiveness\n\nThis implementation follows security best practices recommended by marked.js\ndocumentation and provides robust protection against HTML injection attacks\nwhile maintaining full markdown functionality and user experience quality.\n\nCo-Authored-By: sketch \u003chello@sketch.dev\u003e\nChange-ID: s233c12c6daac5bb0k\n" }, { "commit": "16098932295e067fb0a6b3ca2082b0d4b06027b4", "tree": "60a47204f50aab38d803f4cc53594ff754cc0265", "parents": [ "e6c294dc139cf229ba790abc87a524016f98627f" ], "author": { "name": "Philip Zeyliger", "email": "philip@bold.dev", "time": "Wed Jun 04 11:02:55 2025 -0700" }, "committer": { "name": "Autoformatter", "email": "bot@sketch.dev", "time": "Wed Jun 04 18:03:43 2025 +0000" }, "message": "loop/webui: remove end session feedback survey functionality\n\nRemove end session feedback survey system that was previously implemented\nto collect user satisfaction ratings and comments when ending sessions.\n\nProblem Analysis:\nThe feedback survey system added complexity to the end session flow\nand included several components:\n- Modal dialog with thumbs up/down rating buttons\n- Optional text feedback collection\n- Backend storage and processing of feedback data\n- Complex synchronization logic with skaband clients\n- Extended State struct and API surface area\n\nThe feedback collection mechanism, while well-implemented, added\nunnecessary friction to session termination and required maintenance\nof additional state management infrastructure.\n\nImplementation Changes:\n\n1. Frontend Simplification (sketch-app-shell.ts):\n - Replace custom survey modal with simple window.confirm dialog\n - Remove showEndSessionSurvey() method and associated UI logic\n - Simplify end session request to basic reason-only payload\n - Remove complex button state management and form handling\n\n2. Type Definition Cleanup (types.ts):\n - Remove EndFeedback interface definition\n - Remove end field from State interface\n - Simplify TypeScript type definitions\n\n3. Backend Refactoring (agent.go):\n - Remove EndFeedback struct definition\n - Remove GetEndFeedback/SetEndFeedback methods from CodingAgent interface\n - Remove endFeedback field from Agent struct\n - Eliminate feedback-related state management\n\n4. HTTP Server Cleanup (loophttp.go):\n - Remove End field from State struct\n - Simplify /end endpoint request body parsing\n - Remove feedback storage and processing logic\n - Eliminate endWaitGroup synchronization mechanism\n - Remove wait_for_end query parameter handling\n - Simplify session termination to immediate exit with basic delay\n\n5. Test Cleanup (loophttp_test.go):\n - Remove TestEndFeedback test function\n - Remove endFeedback field from mockAgent\n - Remove GetEndFeedback/SetEndFeedback mock methods\n - Simplify test fixtures and expectations\n\nTechnical Details:\n- Session termination now uses simple confirmation dialog workflow\n- /end endpoint accepts only reason field in request body\n- Process exit occurs after 100ms delay without client coordination\n- All existing session management functionality preserved\n- TypeScript compilation verified with simplified type definitions\n\nBenefits:\n- Simplified end session user experience with standard confirmation\n- Reduced code complexity and maintenance burden\n- Eliminated complex state synchronization requirements\n- Cleaner API surface with fewer fields and methods\n- Faster session termination without feedback collection overhead\n- Standard web UI patterns for session ending confirmation\n\nTesting:\n- All existing tests pass without regression\n- TypeScript compilation succeeds with updated type definitions\n- End session functionality verified through manual testing\n- Build verification confirms no compilation errors\n\nThis change restores the end session flow to a simple, straightforward\nconfirmation-based approach while maintaining all core session management\nfunctionality and improving overall system simplicity.\n\nCo-Authored-By: sketch \u003chello@sketch.dev\u003e\nChange-ID: s9406002b5ac20a89k\n" }, { "commit": "e6c294dc139cf229ba790abc87a524016f98627f", "tree": "1a181005f78a908112288e814bd60205b060a436", "parents": [ "2f0eb6995fc1041d23b8224a099013e89bb03f67" ], "author": { "name": "Philip Zeyliger", "email": "philip@bold.dev", "time": "Wed Jun 04 16:55:21 2025 +0000" }, "committer": { "name": "Philip Zeyliger", "email": "philip@bold.dev", "time": "Wed Jun 04 09:57:17 2025 -0700" }, "message": "budget: remove num-iterations and wall clock time limits\n\nRemove iteration count and time-based budget limits from the agent budget system\nwhile preserving the budget concept for dollar-based limits only.\n\nProblem Analysis:\nThe budget system previously supported three types of limits:\n1. MaxResponses (iteration count limit)\n2. MaxWallTime (wall clock time limit)\n3. MaxDollars (cost limit)\n\nThis created complexity in both implementation and user experience, with\nmultiple overlapping budget mechanisms that could trigger independently.\nThe iteration and time limits added limited value compared to the more\npractical dollar-based budget control.\n\nImplementation Changes:\n\n1. Budget Structure Simplification:\n - Remove MaxResponses and MaxWallTime fields from Budget struct\n - Keep only MaxDollars field for cost-based budget control\n - Simplify Budget to single-field struct with clear purpose\n\n2. CLI Flag Removal:\n - Remove -max-iterations flag from command line interface\n - Remove -max-wall-time flag from command line interface\n - Keep -max-dollars flag with same functionality\n - Remove unused time import from cmd/sketch/main.go\n\n3. Budget Logic Streamlining:\n - Simplify ResetBudget() to only adjust MaxDollars based on usage\n - Simplify overBudget() to only check dollar limits\n - Remove iteration and time checking logic throughout\n\n4. Container Configuration Updates:\n - Remove MaxIterations and MaxWallTime from ContainerConfig struct\n - Remove corresponding docker command arguments\n - Maintain MaxDollars configuration and passing\n\n5. UI Cleanup:\n - Remove budget display of max responses and max wall time from termui\n - Keep dollar-based budget information display\n\n6. Test Updates:\n - Update test Budget initialization to use only MaxDollars\n - Verify all existing tests continue to pass\n\nTechnical Details:\n- Budget struct now contains only MaxDollars float64 field\n- ResetBudget adjusts budget by adding current TotalCostUSD to MaxDollars\n- overBudget checks only dollar spending against MaxDollars limit\n- CLI help shows only -max-dollars option, no iteration/time options\n- Docker container launch passes only max-dollars parameter\n\nBenefits:\n- Simplified budget system with single, clear cost control mechanism\n- Reduced complexity in budget logic and error handling\n- Cleaner CLI interface with fewer confusing options\n- More predictable budget behavior focused on practical cost limits\n- Easier to understand and configure for users\n\nTesting:\n- All existing tests pass with updated budget structure\n- CLI help verification shows only max-dollars option\n- Build verification confirms no compilation errors\n- Budget functionality preserved for dollar-based limits\n\nThis change streamlines the budget system to focus on practical cost control\nwhile maintaining all existing dollar-based budget functionality and removing\ncomplexity around iteration and time-based limits.\n\nCo-Authored-By: sketch \u003chello@sketch.dev\u003e\nChange-ID: sa7be127e12d43ee7k\n" }, { "commit": "2f0eb6995fc1041d23b8224a099013e89bb03f67", "tree": "9713c17be9deab35f9252836e0f48d0b12ee295d", "parents": [ "0df32aacd4c14c8db1ea2876378f4bc23a2744dc" ], "author": { "name": "Philip Zeyliger", "email": "philip@bold.dev", "time": "Wed Jun 04 09:53:42 2025 -0700" }, "committer": { "name": "Philip Zeyliger", "email": "philip@bold.dev", "time": "Wed Jun 04 09:53:42 2025 -0700" }, "message": "Capture git origin before replacing it.\n" }, { "commit": "0df32aacd4c14c8db1ea2876378f4bc23a2744dc", "tree": "78ce84dde10be6569f74b43148440afc8eaf83cb", "parents": [ "222bf413a2ab02a430d92961cb3eef05dcf5ff89" ], "author": { "name": "Philip Zeyliger", "email": "philip@bold.dev", "time": "Wed Jun 04 16:47:30 2025 +0000" }, "committer": { "name": "Philip Zeyliger", "email": "philip@bold.dev", "time": "Wed Jun 04 09:49:24 2025 -0700" }, "message": "loop: change state transition logging from INFO to DEBUG\n\nReduce verbosity of state transition logging by changing log level from\nslog.InfoContext to slog.DebugContext in StateMachine.TransitionWithEvent.\n\nThe state transition logs provide detailed internal state machine flow\ninformation that is primarily useful for debugging rather than general\noperation monitoring. Moving these to DEBUG level:\n\n- Reduces log noise during normal operations\n- Maintains debugging capability when DEBUG level is enabled\n- Preserves all existing log message content and structure\n- Only affects log level, no functional changes\n\nThis change specifically targets the log line:\n\u0027State transition from X to Y (event description) duration\u003dNs\u0027\n\nThe change applies to both regular transitions in TransitionWithEvent()\nwhile preserving the existing WARN level for forced transitions which\nremain important for operational visibility.\n\nCo-Authored-By: sketch \u003chello@sketch.dev\u003e\nChange-ID: s1079bacd87ecdb73k\n" }, { "commit": "222bf413a2ab02a430d92961cb3eef05dcf5ff89", "tree": "e5096166ffe7ed487def369ac9f2981e745d2edf", "parents": [ "c898abf9973147658cb90862c071759b0a82259e" ], "author": { "name": "Philip Zeyliger", "email": "philip@bold.dev", "time": "Wed Jun 04 16:42:58 2025 +0000" }, "committer": { "name": "Philip Zeyliger", "email": "philip@bold.dev", "time": "Wed Jun 04 16:46:40 2025 +0000" }, "message": "loop: replace sketch-host remote with origin remote in agent.Init()\n\nChange git remote handling in agent initialization to replace any existing\norigin remote with the provided git remote URL instead of creating a\nsketch-host remote.\n\nProblem Analysis:\nPreviously, when a git remote URL was provided to the agent, it would:\n1. Add a new remote called \u0027sketch-host\u0027 pointing to the provided URL\n2. Configure additional fetch refs for feature branches\n3. Use \u0027sketch-host\u0027 for all fetch operations\n\nThis created confusion and inconsistency since most git workflows expect\nto interact with \u0027origin\u0027 as the primary remote, not a custom \u0027sketch-host\u0027\nremote.\n\nImplementation Changes:\n\n1. Git Remote Setup Logic:\n - Remove existing \u0027origin\u0027 remote if it exists (ignoring errors if not present)\n - Add the provided remote URL as the new \u0027origin\u0027 remote\n - Update fetch operations to use \u0027origin\u0027 instead of \u0027sketch-host\u0027\n\n2. Branch Detection Logic:\n - Updated branchExists() function to remove \u0027refs/remotes/sketch-host/\u0027 reference\n - Now only checks \u0027refs/heads/\u0027 and \u0027refs/remotes/origin/\u0027 for branch existence\n\n3. Comment Updates:\n - Updated git debugging comment in dockerimg/githttp.go to reference \u0027origin\u0027 instead of \u0027sketch-host\u0027\n\nTechnical Details:\n- The \u0027git remote remove origin\u0027 command gracefully handles the case where\n origin doesn\u0027t exist by logging and continuing\n- All existing git operations (fetch, checkout, commit tracking) continue\n to work seamlessly with the origin remote\n- branchExists() function correctly identifies branches in origin remotes\n\nBenefits:\n- Consistent with standard git workflows that use \u0027origin\u0027 as primary remote\n- Eliminates confusion about which remote to use for git operations\n- Maintains all existing functionality while using standard git conventions\n- Simplifies git operations by using the expected \u0027origin\u0027 remote name\n- Better integration with external git tools and workflows\n\nTesting:\n- All existing loop package tests continue to pass\n- Verified git fetch, config, and branch detection work correctly\n- Integration testing confirms seamless operation with origin remote\n\nThis change provides a more intuitive and standard git remote configuration\nwhile preserving all agent functionality and improving compatibility with\nstandard git workflows.\n\nCo-Authored-By: sketch \u003chello@sketch.dev\u003e\nChange-ID: s9edcdfe5bae3ef4ek\n" }, { "commit": "c898abf9973147658cb90862c071759b0a82259e", "tree": "b6c8e1e076ee3ad8555995dd6e7898a276b327db", "parents": [ "a347b1750551dd2d95e478eb0cf2b27f8c547379" ], "author": { "name": "Philip Zeyliger", "email": "philip@bold.dev", "time": "Wed Jun 04 16:33:57 2025 +0000" }, "committer": { "name": "Philip Zeyliger", "email": "philip@bold.dev", "time": "Wed Jun 04 16:33:57 2025 +0000" }, "message": "dockerimg: restrict git fetch to upload-pack service requests only\n\nMake automatic git fetch origin more specific by only triggering on GET requests\nto .git/info/refs with service\u003dgit-upload-pack query parameter.\n\nPreviously, any request containing \u0027.git/info/refs\u0027 in the path would trigger\nan automatic git fetch origin operation. This was overly broad and could cause\nunnecessary fetch operations during git push or other git HTTP operations.\n\nThe change restricts the automatic fetch to occur only when:\n1. HTTP method is GET\n2. URL path contains \u0027.git/info/refs\u0027\n3. Query parameter \u0027service\u0027 equals \u0027git-upload-pack\u0027\n\nThis specifically targets git fetch operations (which use git-upload-pack service)\nwhile avoiding triggering during git push operations (which use git-receive-pack)\nor other git HTTP requests that don\u0027t need an automatic fetch.\n\nBenefits:\n- Reduces unnecessary git fetch operations during push and other operations\n- More precise triggering logic aligned with actual fetch behavior\n- Improved performance by avoiding redundant network operations\n- Better separation of fetch vs push operation handling\n\nCo-Authored-By: sketch \u003chello@sketch.dev\u003e\nChange-ID: s4c1aaa5cf80c7dc7k\n" }, { "commit": "a347b1750551dd2d95e478eb0cf2b27f8c547379", "tree": "6ab53e5d5550e8b049c4f3582bfb04acba369580", "parents": [ "7a852353fbfda90b45e0e0e774f1e6132dc7053c" ], "author": { "name": "Philip Zeyliger", "email": "philip@bold.dev", "time": "Wed Jun 04 16:18:57 2025 +0000" }, "committer": { "name": "Philip Zeyliger", "email": "philip@bold.dev", "time": "Wed Jun 04 16:20:26 2025 +0000" }, "message": "cmd/sketch: remove -initial-commit flag configuration option\n\nRemove the -initial-commit command-line flag to simplify the CLI interface\nwhile preserving all internal agent functionality for tracking the initial\ncommit baseline through the existing SketchGitBase system.\n\nProblem Analysis:\nThe -initial-commit flag allowed users to specify a different git commit\nreference as the starting point for Sketch operations. This added complexity\nto the command-line interface and created an incompatibility with the -unsafe\nflag. Analysis showed that most users would use the default HEAD value, making\nthe flag unnecessary complexity.\n\nImplementation Changes:\n\n1. Command Line Interface:\n - Removed -initial-commit flag definition from main.go\n - Removed CLI flag struct field and validation logic\n - Eliminated incompatibility check with -unsafe flag\n - Cleaned up flag parsing to remove unused initialCommit field\n\n2. Container Configuration:\n - Removed InitialCommit field from dockerimg.ContainerConfig struct\n - Updated git commit resolution to use \"HEAD\" directly instead of flag value\n - Simplified container launch process by removing flag passthrough\n\n3. Preserved Agent Functionality:\n - Maintained all SketchGitBase and SketchGitBaseRef methods unchanged\n - Preserved initial_commit field in server state and web UI for agent tracking\n - Kept all git diff, log, and baseline functionality intact\n - Agent continues to establish and track its own initial commit baseline\n\nTechnical Details:\n- The agent\u0027s internal initial commit tracking remains fully functional\n- Git operations continue to work with the sketch-base tag system\n- Agent initialization still establishes proper git baseline using HEAD\n- All existing git diff and log functionality preserved\n- Container and unsafe modes both default to current HEAD commit\n- Web UI continues to display the agent\u0027s tracked initial commit\n\nTesting:\n- All Go package tests pass (loop/server, dockerimg)\n- Command-line flag parsing works correctly without -initial-commit\n- Basic sketch startup functionality verified in both safe and unsafe modes\n- Agent git operations and baseline tracking remain intact\n\nBenefits:\n- Simplified command-line interface with fewer flags to understand\n- Removed artificial incompatibility between -initial-commit and -unsafe\n- Reduced cognitive load for new users learning sketch CLI options\n- Cleaner container configuration with less conditional logic\n- Maintained all essential agent functionality while removing user complexity\n\nThis change removes only the user-facing configurability while preserving\nall internal git tracking and baseline functionality that the agent relies on.\n\nCo-Authored-By: sketch \u003chello@sketch.dev\u003e\nChange-ID: s962b916b2d3b6582k\n" }, { "commit": "7a852353fbfda90b45e0e0e774f1e6132dc7053c", "tree": "87735d9cd3c4e14e8a7bdfcd847c7954375bcff8", "parents": [ "59e1c1694c0ea45893f344b98d7efaca072e5e87" ], "author": { "name": "Philip Zeyliger", "email": "philip@bold.dev", "time": "Tue Jun 03 02:21:21 2025 +0000" }, "committer": { "name": "Philip Zeyliger", "email": "philip@bold.dev", "time": "Tue Jun 03 10:44:03 2025 -0700" }, "message": "cmd/sketch: separate user-visible and internal flags using flagsets\n\nImplement comprehensive flag organization system that separates user-facing\nand internal/debugging flags into distinct flagsets for improved usability.\n\nCo-Authored-By: sketch \u003chello@sketch.dev\u003e\nChange-ID: s210c8ff84e6ed527k\n" }, { "commit": "59e1c1694c0ea45893f344b98d7efaca072e5e87", "tree": "ba24ce303cea4aac8e2a63ca0805c42e04f93efb", "parents": [ "138ec2436631f136dd2e8b4891211f896587ff00" ], "author": { "name": "Philip Zeyliger", "email": "philip@bold.dev", "time": "Mon Jun 02 12:54:34 2025 +0000" }, "committer": { "name": "Autoformatter", "email": "bot@sketch.dev", "time": "Tue Jun 03 17:27:32 2025 +0000" }, "message": "loop: fix branch naming increment and add user notification for conflicts\n\nFix the branch naming logic when git push encounters \u0027refusing to update\nchecked out branch\u0027 errors to properly increment numbers (foo1, foo2, foo3)\nrather than appending \u00271\u0027 characters, and add user notification explaining\nwhy the branch was renamed.\n\nImplementation improvements:\n\n1. Branch Naming Logic Verification:\n - Confirmed the existing logic already uses proper incremental numbering\n - Added comprehensive test case TestBranchNamingIncrement to verify behavior\n - Test validates that retries generate: foo, foo1, foo2, foo3, etc.\n - The reported issue of foo1, foo11, foo111 appears to be from an older version\n\n2. Enhanced User Communication:\n - Added automatic notification when branch is renamed due to checkout conflict\n - Uses AutoMessageType for consistent automated notification styling\n - Message format: \u0027Branch renamed from X to Y because the original branch is currently checked out on the remote\u0027\n - Provides clear explanation of why the system chose a different branch name\n\n3. Code Quality Improvements:\n - Added detailed comments explaining the incremental naming logic\n - Enhanced error handling context with user-friendly explanations\n - Maintained existing retry logic (up to 10 attempts) for robustness\n\nTechnical details:\n- The retry loop uses \u0027for retries :\u003d range 10\u0027 giving values 0, 1, 2, 3...\n- When retries \u003e 0, fmt.Sprintf(\u0027%s%d\u0027, originalBranch, retries) creates foo1, foo2, etc.\n- User notification is added to the messages array when branch !\u003d originalBranch\n- Notification timing ensures users understand automatic branch renaming\n\nThis resolves potential confusion when users see their branch published with\na different name than expected, providing transparency about the automatic\nconflict resolution process.\n\nCo-Authored-By: sketch \u003chello@sketch.dev\u003e\nChange-ID: s91efcab1b86b45dak\n\nloop: fix branch naming increment to properly handle existing numbers\n\nImplement proper branch naming logic that correctly parses and increments\nexisting numerical suffixes when git push encounters \u0027refusing to update\nchecked out branch\u0027 errors, ensuring foo1-\u003efoo2-\u003efoo3 instead of foo1-\u003efoo11-\u003efoo111.\n\nRoot cause analysis:\nThe previous logic used fmt.Sprintf(\"%s%d\", originalBranch, retries) which\nwould append numbers to whatever originalBranch contained. If originalBranch\nwas already \"foo1\", this created \"foo11\", \"foo12\", etc. instead of the\nintended incremental sequence.\n\nImplementation improvements:\n\n1. Added parseBranchNameAndNumber() function:\n - Extracts base branch name and existing numerical suffix\n - Handles branches like \"sketch/test-branch1\" -\u003e (\"sketch/test-branch\", 1)\n - Handles branches without numbers like \"sketch/test-branch\" -\u003e (\"sketch/test-branch\", 0)\n - Robust parsing that only considers trailing digits as suffixes\n\n2. Enhanced retry logic:\n - Uses parsed base name and starting number for proper incrementing\n - Formula: fmt.Sprintf(\"%s%d\", baseBranch, startNum+retries)\n - Ensures consistent incremental naming regardless of starting branch name\n - Maintains 10-retry limit for robustness\n\n3. Comprehensive test coverage:\n - TestBranchNamingIncrement covers multiple scenarios with table-driven tests\n - TestParseBranchNameAndNumber validates parsing logic with edge cases\n - Tests verify proper behavior for branches with and without existing numbers\n - Edge cases include numbers in middle vs end of branch names\n\nTechnical details:\n- parseBranchNameAndNumber() scans from end of string backward for consecutive digits\n- Only trailing digit sequences are treated as numerical suffixes\n- Error handling ensures malformed numbers default to treating branch as having no suffix\n- Maintains existing user notification when branch gets renamed\n\nExamples of corrected behavior:\n- \"foo\" -\u003e \"foo\", \"foo1\", \"foo2\", \"foo3\"\n- \"foo1\" -\u003e \"foo1\", \"foo2\", \"foo3\", \"foo4\"\n- \"foo42\" -\u003e \"foo42\", \"foo43\", \"foo44\", \"foo45\"\n\nThis resolves the reported issue where branches were getting names like\nfoo1, foo11, foo111 instead of proper incremental numbering.\n\nCo-Authored-By: sketch \u003chello@sketch.dev\u003e\nChange-ID: sfba5fdcdaf99fdcdk\n\nloop: simplify parseBranchNameAndNumber with regex\n\nReplace verbose manual parsing logic with a clean regular expression\napproach to extract trailing digits from branch names.\n\nChanges:\n- Replace 20+ lines of manual digit scanning with simple regex: ^(.+?)(\\d+)$\n- Add regexp import to support the regex functionality\n- Maintain exact same behavior and test coverage\n- Cleaner, more readable, and less error-prone implementation\n\nThe regex ^(.+?)(\\d+)$ captures:\n- Group 1: Everything up to the trailing digits (non-greedy match)\n- Group 2: The trailing digit sequence\n\nThis handles all the same cases but with much simpler code.\n\nCo-Authored-By: sketch \u003chello@sketch.dev\u003e\nChange-ID: sea27e90c492b83d8k\n" }, { "commit": "138ec2436631f136dd2e8b4891211f896587ff00", "tree": "80afc394ad900e6e7a0a7b524972a303ef90ef15", "parents": [ "457dfd12f281dbe9b1af8d1a7429f2977e234a6f" ], "author": { "name": "Sean McCullough", "email": "banksean@gmail.com", "time": "Mon Jun 02 22:42:06 2025 +0000" }, "committer": { "name": "Sean McCullough", "email": "banksean@gmail.com", "time": "Mon Jun 02 17:52:38 2025 -0700" }, "message": "loop: automatic host/container ssh port tunneling\n\nFix for #47\n\nAdd comprehensive port event monitoring and automatic SSH tunnel management\nsystem that enables real-time port forwarding for container services.\n\nContainer processes need automatic port forwarding when services start or stop\nlistening on ports during agent execution. Previously, users had to manually\ncreate SSH tunnels using commands like \u0027ssh -L8000:localhost:8888 container\u0027,\nwhich required manual intervention and knowledge of when ports become available.\n\n- Extended PortMonitor with thread-safe event storage using circular buffer\n- Added PortEvent struct with type (opened/closed), port info, and timestamps\n- Maintained backward compatibility with existing logging functionality\n- Events stored in 100-item circular buffer with efficient timestamp filtering\n\n- Added /port-events endpoint in loophttp.go for container-to-host communication\n- Supports optional \u0027since\u0027 query parameter for incremental event fetching\n- Returns JSON array of recent port events with proper error handling\n- Integrated with existing Agent interface via GetPortMonitor() method\n\n- Created TunnelManager component for host-side tunnel orchestration\n- Polls container /port-events endpoint every 10 seconds for new events\n- Automatically creates SSH tunnels when ports open using same port numbers\n- Properly cleans up tunnels when ports close or context cancels\n- Skips common system ports (SSH, HTTP, SMTP) to avoid conflicts\n\n- Integrated TunnelManager into dockerimg.LaunchContainer() workflow\n- Starts tunnel manager alongside existing container management goroutines\n- Only activates when SSH is available and configured properly\n- Uses existing SSH infrastructure and container naming conventions\n\n- Container PortMonitor detects port changes via ss -lntu command\n- Events stored with RFC3339 timestamps for precise filtering\n- Thread-safe access patterns with dedicated mutex protection\n- Circular buffer prevents unbounded memory growth\n\n- RESTful GET /port-events endpoint with time-based filtering\n- Proper JSON encoding/decoding with error handling\n- Integration with existing HTTP server infrastructure\n- Non-blocking polling pattern with configurable intervals\n\n- Uses existing SSH theater configuration and host keys\n- Creates tunnels with format: ssh -L hostPort:localhost:containerPort container\n- Background monitoring of tunnel processes with automatic cleanup\n- Proper context cancellation and resource management\n\n- Added comprehensive port event storage and filtering tests\n- HTTP endpoint testing with mock agents and proper status codes\n- Verified thread-safe access patterns and circular buffer behavior\n- All existing loop package tests continue to pass\n\n- Confirmed HTTP endpoint returns proper JSON responses\n- Validated tunnel manager integrates with container launch process\n- Verified SSH tunnel creation follows existing authentication patterns\n- Build verification confirms no regressions in existing functionality\n\n- Automatic port forwarding eliminates manual SSH tunnel management\n- Real-time port detection provides immediate service accessibility\n- Transparent integration with existing Sketch container workflow\n- Maintains all existing SSH functionality and manual override options\n\n- Clean separation between container monitoring and host tunnel management\n- Extensible event-based architecture for future port-related features\n- Minimal performance impact with efficient polling and filtering\n- Robust error handling and graceful degradation when SSH unavailable\n\nThis enhancement provides seamless port forwarding automation while maintaining\nthe reliability and security of the existing SSH infrastructure, significantly\nimproving the developer experience when working with containerized services.\n\nCo-Authored-By: sketch \u003chello@sketch.dev\u003e\nChange-ID: s6bc363ed64835e5dk\n" } ], "next": "457dfd12f281dbe9b1af8d1a7429f2977e234a6f" }