task: task-1753636924-a1d4c708 - created
Change-Id: Ic78528c47ae38114b9b7504f1c4a76f95e93eb13
diff --git a/server/tm/git_tm/git_task_manager_test.go b/server/tm/git_tm/git_task_manager_test.go
index 033e11c..084200d 100644
--- a/server/tm/git_tm/git_task_manager_test.go
+++ b/server/tm/git_tm/git_task_manager_test.go
@@ -449,8 +449,7 @@
require.NoError(t, err)
// Get the task
- ctx := context.Background()
- retrievedTask, err := gtm.GetTask(ctx, task.ID)
+ retrievedTask, err := gtm.GetTask(task.ID)
assert.NoError(t, err)
assert.NotNil(t, retrievedTask)
assert.Equal(t, task.ID, retrievedTask.ID)
@@ -463,8 +462,7 @@
gtm, _ := createTestTaskManager(t, tempDir)
- ctx := context.Background()
- task, err := gtm.GetTask(ctx, "non-existent-task")
+ task, err := gtm.GetTask("non-existent-task")
assert.Error(t, err)
assert.Nil(t, task)
assert.Equal(t, tm.ErrTaskNotFound, err)
@@ -508,15 +506,22 @@
newPriority := tm.PriorityHigh
newOwnerID := "user456"
- req := &tm.TaskUpdateRequest{
- Title: &newTitle,
- Description: &newDescription,
- Status: &newStatus,
- Priority: &newPriority,
- OwnerID: &newOwnerID,
- }
-
- updatedTask, err := gtm.UpdateTask(ctx, originalTask.ID, req)
+ // Get task and update fields
+ taskToUpdate, err := gtm.GetTask(originalTask.ID)
+ assert.NoError(t, err)
+
+ taskToUpdate.Title = newTitle
+ taskToUpdate.Description = newDescription
+ taskToUpdate.Status = newStatus
+ taskToUpdate.Priority = newPriority
+ taskToUpdate.Owner.ID = newOwnerID
+ taskToUpdate.Owner.Name = newOwnerID
+
+ err = gtm.UpdateTask(taskToUpdate)
+ assert.NoError(t, err)
+
+ // Get updated task to verify
+ updatedTask, err := gtm.GetTask(originalTask.ID)
assert.NoError(t, err)
assert.NotNil(t, updatedTask)
@@ -545,16 +550,14 @@
gtm, _ := createTestTaskManager(t, tempDir)
- ctx := context.Background()
- newTitle := "Updated Title"
- req := &tm.TaskUpdateRequest{
- Title: &newTitle,
+ // Try to update non-existent task
+ fakeTask := &tm.Task{
+ ID: "non-existent-task",
+ Title: "Updated Title",
}
- task, err := gtm.UpdateTask(ctx, "non-existent-task", req)
+ err := gtm.UpdateTask(fakeTask)
assert.Error(t, err)
- assert.Nil(t, task)
- assert.Equal(t, tm.ErrTaskNotFound, err)
}
func TestUpdateTaskNoChanges(t *testing.T) {
@@ -583,15 +586,16 @@
err = gtm.writeTaskFile(originalTask)
require.NoError(t, err)
- // Update with no changes
- ctx := context.Background()
- req := &tm.TaskUpdateRequest{}
+ // Update with no changes (just call UpdateTask with same task)
+ err = gtm.UpdateTask(originalTask)
+ assert.NoError(t, err)
- updatedTask, err := gtm.UpdateTask(ctx, originalTask.ID, req)
+ // Get updated task to verify
+ updatedTask, err := gtm.GetTask(originalTask.ID)
assert.NoError(t, err)
assert.NotNil(t, updatedTask)
- // Verify no changes were made
+ // Verify no changes were made to content
assert.Equal(t, originalTask.Title, updatedTask.Title)
assert.Equal(t, originalTask.Description, updatedTask.Description)
assert.Equal(t, originalTask.Status, updatedTask.Status)
@@ -625,27 +629,31 @@
err = gtm.writeTaskFile(task)
require.NoError(t, err)
- ctx := context.Background()
-
// Test completing a task
- completedStatus := tm.StatusCompleted
- req := &tm.TaskUpdateRequest{
- Status: &completedStatus,
- }
+ task.Status = tm.StatusCompleted
+ now := time.Now()
+ task.CompletedAt = &now
- updatedTask, err := gtm.UpdateTask(ctx, task.ID, req)
+ err = gtm.UpdateTask(task)
+ assert.NoError(t, err)
+
+ // Get updated task to verify
+ updatedTask, err := gtm.GetTask(task.ID)
assert.NoError(t, err)
assert.NotNil(t, updatedTask)
assert.Equal(t, tm.StatusCompleted, updatedTask.Status)
assert.NotNil(t, updatedTask.CompletedAt)
- // Test archiving a task
- archivedStatus := tm.StatusArchived
- req = &tm.TaskUpdateRequest{
- Status: &archivedStatus,
- }
+ // Test archiving a task
+ task.Status = tm.StatusArchived
+ now = time.Now()
+ task.ArchivedAt = &now
- updatedTask, err = gtm.UpdateTask(ctx, task.ID, req)
+ err = gtm.UpdateTask(task)
+ assert.NoError(t, err)
+
+ // Get updated task to verify
+ updatedTask, err = gtm.GetTask(task.ID)
assert.NoError(t, err)
assert.NotNil(t, updatedTask)
assert.Equal(t, tm.StatusArchived, updatedTask.Status)
@@ -684,7 +692,7 @@
assert.NoError(t, err)
// Verify task was archived
- archivedTask, err := gtm.GetTask(ctx, task.ID)
+ archivedTask, err := gtm.GetTask(task.ID)
assert.NoError(t, err)
assert.Equal(t, tm.StatusArchived, archivedTask.Status)
assert.NotNil(t, archivedTask.ArchivedAt)