| commit | c7c2cc1e9d2a90515e071527241e0ce680fe0738 | [log] [tgz] |
|---|---|---|
| author | Sean McCullough <banksean@gmail.com> | Fri Jun 13 03:21:18 2025 +0000 |
| committer | Autoformatter <bot@sketch.dev> | Fri Jun 13 03:48:18 2025 +0000 |
| tree | df1b7548a47fa1e4f219bcd8a27e5fadaa0acc3c | |
| parent | 83c5be6f73607c6add6d5c389f7894e1d7b5e06a [diff] |
webui: fix repository name parsing for names containing dots Fix GitHub repository URL parsing in sketch-container-status component to properly handle repository names containing dots, resolving broken GitHub links in the ongoing session log banner. Problem Analysis: The formatGitHubRepo function used regex patterns with [^/\s.]+ character classes that excluded dots from repository names. This caused repository names like 'boldsoftware/sketch.git' to be truncated to 'boldsoftware/sketch' when parsed, breaking GitHub links and repository display in the session banner. The issue occurred in three regex patterns for different GitHub URL formats: - HTTPS URLs: /https:\/\/github\.com\/([^/]+)\/([^/\s.]+)(?:\.git)?/ - SSH URLs: /git@github\.com:([^/]+)\/([^/\s.]+)(?:\.git)?/ - Git protocol: /git:\/\/github\.com\/([^/]+)\/([^/\s.]+)(?:\.git)?/ The [^/\s.]+ pattern specifically excluded dots (.) from matching, which was problematic for legitimate repository names containing dots. Implementation Changes: 1. Regex Pattern Updates: - Changed [^/\s.]+ to [^/\s]+? in all three URL patterns - Removed dot exclusion while maintaining whitespace and slash exclusion - Added non-greedy quantifier (?) to prevent over-matching - Added end-of-string anchor ($) for precise matching 2. Updated patterns: - HTTPS: /https:\/\/github\.com\/([^/]+)\/([^/\s]+?)(?:\.git)?$/ - SSH: /git@github\.com:([^/]+)\/([^/\s]+?)(?:\.git)?$/ - Git: /git:\/\/github\.com\/([^/]+)\/([^/\s]+?)(?:\.git)?$/ Technical Details: - Non-greedy matching (+?) ensures proper handling of .git suffix - End anchors ($) prevent partial matches and improve precision - Dots now allowed in repository names while preserving .git detection - Existing functionality preserved for repositories without dots Testing: Verified fix with comprehensive test cases: - git@github.com:boldsoftware/sketch.git → boldsoftware/sketch ✓ - https://github.com/user/repo.with.dots.git → user/repo.with.dots ✓ - git@github.com:org/project.name.git → org/project.name ✓ - https://github.com/test/normal-repo → test/normal-repo ✓ Benefits: - GitHub links now work correctly for repositories with dots in names - Session banner displays proper repository information - Maintains backward compatibility with existing repository names - Improves user experience for repository navigation This fix resolves the specific issue where repository names containing dots would have their GitHub links truncated, breaking navigation to the actual repository on GitHub. Co-Authored-By: sketch <hello@sketch.dev> Change-ID: sda0a251af3d756b6k webui: improve GitHub repo parsing tests Replace internal method testing with component behavior testing for better integration coverage and maintainability. - Test actual GitHub link rendering in DOM instead of calling private methods - Add separate test cases for repository names with dots - Verify href attributes, text content, and title attributes are correct - Cover both general dot-containing names and the specific boldsoftware/sketch case Co-Authored-By: sketch <hello@sketch.dev> Change-ID: s216977b6be91a2bak
Sketch is an agentic coding tool. It draws the 🦉
Sketch runs in your terminal, has a web UI, understands your code, and helps you get work done. To keep your environment pristine, sketch starts a docker container and outputs its work onto a branch in your host git repository.
Sketch helps with most programming environments, but Sketch has extra goodies for Go.
go install sketch.dev/cmd/sketch@latest sketch
Currently, Sketch runs on macOS and Linux. It uses Docker for containers.
| Platform | Installation |
|---|---|
| macOS | brew install colima (or Docker Desktop/Orbstack) |
| Linux | apt install docker.io (or equivalent for your distro) |
| WSL2 | Install Docker Desktop for Windows (docker entirely inside WSL2 is tricky) |
The sketch.dev service is used to provide access to an LLM service and give you a way to access the web UI from anywhere.
Start Sketch by running sketch in a Git repository. It will open your browser to the Sketch chat interface, but you can also use the CLI interface. Use -open=false if you want to use just the CLI interface.
Ask Sketch about your codebase or ask it to implement a feature. It may take a little while for Sketch to do its work, so hit the bell (🔔) icon to enable browser notifications. We won't spam you or anything; it will notify you when the Sketch agent's turn is done, and there's something to look at.
When you start Sketch, it:
This design lets you run multiple sketches in parallel since they each have their own sandbox. It also lets Sketch work without worry: it can trash its own container, but it can't trash your machine.
Sketch's agentic loop uses tool calls (mostly shell commands, but also a handful of other important tools) to allow the LLM to interact with your codebase.
Sketch is trained to make Git commits. When those happen, they are automatically pushed to the git repository where you started sketch with branch names sketch/*.
Finding Sketch branches:
git branch -a --sort=creatordate | grep sketch/ | tail
The UI keeps track of the latest branch it pushed and displays it prominently. You can use standard Git workflows to pull those branches into your workspace:
git cherry-pick $(git merge-base origin/main sketch/foo)
or merge the branch
git merge sketch/foo
or reset to the branch
git reset --hard sketch/foo
Ie use the same workflows you would if you were pulling in a friend's Pull Request.
Advanced: You can ask Sketch to git fetch sketch-host and rebase onto another commit. This will also fetch where you started Sketch, and we do a bit of "git fetch refspec configuration" to make origin/main work as a git reference.
Don't be afraid of asking Sketch to help you rebase, merge/squash commits, rewrite commit messages, and so forth; it's good at it!
The diff view shows you changes since Sketch started. Leaving comments on lines adds them to the chat box, and, when you hit Send (at the bottom of the page), Sketch goes to work addressing your comments.
You can interact directly with the container in three ways:
ssh sketch-ilik-eske-tcha-lott. We have automatically configured your SSH configuration to make these special hostnames work.Using SSH (and/or VSCode) allows you to forward ports from the container to your machine. For example, if you want to start your development webserver, you can do something like this:
# Forward container port 8888 to local port 8000 ssh -L8000:localhost:8888 sketch-ilik-epor-tfor-ward go run ./cmd/server
This makes http://localhost:8000/ on your machine point to localhost:8888 inside the container.
You can ask Sketch to browse a web page and take screenshots. There are tools both for taking screenshots and "reading images", the latter of which sends the image to the LLM. This functionality is handy if you're working on a web page and want to see what the in-progress change looks like.
Docker images, containers, and so forth tend to pile up. Ask Docker to prune unused images and containers:
docker system prune -a
See CONTRIBUTING.md for development guidelines.
Sketch is open source. It is right here in this repository! Have a look around and mod away.
If you want to run Sketch entirely without the sketch.dev service, you can set the flag -skaband-addr="" and then provide an ANTHROPIC_API_KEY environment variable. (More LLM services coming soon!)